From: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
To: Konstantin Khorenko <khorenko@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v11 09/10] dm-qcow2: retry R1/R2 writeback that failed with ENOSPC
Date: Tue, 10 Nov 2026 08:09:50 +0100 [thread overview]
Message-ID: <9de6e968-1c63-42a2-ba80-f114889a2db3@virtuozzo.com> (raw)
In-Reply-To: <179423895898.3398823.13849183598040694300.b4-review@b4>
>> + /* Retry R1/R2 writeback failed with ENOSPC once, then give up */
> Item 3 of the cover letter reply: say "up to two attempts", and that
> MD_DIRTY is dropped at submit.
>
> Why: a page that failed with ENOSPC before the flush is redirtied. Pass
> 0 fires the timer and writes it, and since md_wb_no_retry is still
> false there, a second failure redirties it again. Pass 1 writes it once
> more. MD_DIRTY is cleared in submit_metadata_writeback(), before the
> write, not by its failure.
>
> Item 4 of the cover letter reply: mention the leak per resubmission.
>
> Why: with this patch a request whose L2 write fails with ENOSPC ends
> with BLK_STS_NOSPC and is resubmitted after ENOSPC_TIMEOUT_JI. The L2
> entry was reverted to 0, so the resubmitted request allocates a new
> data cluster, and patch 8 keeps the old one. One sentence in the
> message is enough; it lasts only as long as the host is out of space.
Agreed, R1/R2 go out after L1/L2 here, so the v11 wording was wrong.
v12 patch 9 now says one cluster leaks per failed L1/L2 write of a
request.
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-11-10 7:11 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 14:01 [Devel] [PATCH hci-8.1 v11 00/10] dm-qcow2: truncate unused tail of image on suspend Alexander Ivanov
2026-11-09 14:01 ` [Devel] [PATCH hci-8.1 v11 01/10] dm-qcow2: add qcow2_md_page_read_sync() helper Alexander Ivanov
2026-11-09 14:06 ` no-reply
2026-11-09 14:01 ` [Devel] [PATCH hci-8.1 v11 02/10] dm-qcow2: drop duplicate prefix from QC_ERR/QC_INFO messages Alexander Ivanov
2026-11-09 14:05 ` no-reply
2026-11-09 14:01 ` [Devel] [PATCH hci-8.1 v11 03/10] dm-qcow2: extend the file for a new refblock in allocate_cluster() Alexander Ivanov
2026-11-09 14:06 ` no-reply
2026-11-09 14:01 ` [Devel] [PATCH hci-8.1 v11 04/10] dm-qcow2: complete wbd before ending the data qio Alexander Ivanov
2026-11-09 14:09 ` no-reply
2026-11-09 14:01 ` [Devel] [PATCH hci-8.1 v11 05/10] dm-qcow2: flush lower md before clearing dirty bit on merge failure Alexander Ivanov
2026-11-09 14:08 ` no-reply
2026-11-09 14:01 ` [Devel] [PATCH hci-8.1 v11 06/10] dm-qcow2: keep the dirty bit of an image that needs check Alexander Ivanov
2026-11-09 14:11 ` no-reply
2026-11-09 14:01 ` [Devel] [PATCH hci-8.1 v11 07/10] dm-qcow2: flag the image for check if reftable relocation fails late Alexander Ivanov
2026-11-09 14:11 ` no-reply
2026-11-09 15:42 ` Konstantin Khorenko
2026-11-09 14:01 ` [Devel] [PATCH hci-8.1 v11 08/10] dm-qcow2: leak clusters allocated for a failed L1/L2 writeback Alexander Ivanov
2026-11-09 14:14 ` no-reply
2026-11-09 14:36 ` Alexander Ivanov
2026-11-09 15:42 ` Konstantin Khorenko
2026-11-10 7:06 ` Alexander Ivanov
2026-11-09 14:01 ` [Devel] [PATCH hci-8.1 v11 09/10] dm-qcow2: retry R1/R2 writeback that failed with ENOSPC Alexander Ivanov
2026-11-09 14:16 ` no-reply
2026-11-09 14:39 ` Alexander Ivanov
2026-11-09 15:42 ` Konstantin Khorenko
2026-11-10 7:09 ` Alexander Ivanov [this message]
2026-11-09 14:01 ` [Devel] [PATCH hci-8.1 v11 10/10] dm-qcow2: truncate unused tail of image on suspend Alexander Ivanov
2026-11-09 14:18 ` no-reply
2026-11-09 14:47 ` Alexander Ivanov
2026-11-09 15:42 ` Konstantin Khorenko
2026-11-10 7:12 ` Alexander Ivanov
2026-11-09 15:42 ` [Devel] [PATCH hci-8.1 v11 00/10] " Konstantin Khorenko
2026-11-09 15:54 ` Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9de6e968-1c63-42a2-ba80-f114889a2db3@virtuozzo.com \
--to=alexander.ivanov@virtuozzo.com \
--cc=devel@openvz.org \
--cc=khorenko@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox