From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 98F3E8017D for ; Mon, 16 Nov 2026 08:44:30 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AG8h9Uo021459; Mon, 16 Nov 2026 11:43:10 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AG8h9Uo021459 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="0gS2LW1Z" Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AG8h7NA021455 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 16 Nov 2026 11:43:08 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AG8h7NA021455 Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-8a59717b0c0so2167658b3a.3 for ; Mon, 16 Nov 2026 00:43:08 -0800 (PST) X-Gm-Message-State: APuU4Z+dFaYyGpWn+fBdh3LkE/K61O4nDRuzbxCgGQZyypc+wOUgRSKl ybIv4yOEQFoscw1AE2EkI3M1SRmCYKXjMhzyfEZC/Pft1R70caGhv79z3t5xcbjc/Z0Mm3nPHj3 f4QSLZ0+c3+VTVDfuv62B1LZZfcKickr/993OrC4rw6gLprv+ZIfvyQ== X-Gm-Gg: AYBFou3EixI4j7+da0RrnzqxyFwcEFl/nV+N53CEESFxkQqMqTawk8W2E6q7+hBNlWX 8QZ/AqHofPkrB7xDkm/jNWkUIgM9zmFmVvIwj47YsuYE5MbDfrR3xyjGVwQbqskw0KevxLd7FtG 9lV/24/NCfs6ulraxc1eWidvclTqtux+Vw7vGw4x9GaY4rgEtKtZ0IxjWEPXryfhYwGZDCG11J0 8UsOKOYgPRcR4sxX1OfkiNGzFjcP2ApUgHP70Co0/ep8y0SNpjU5YEqG67m4yNQVle3b1hiz/rz U6BfyIklQeyfg0NN457wkwKa70tTfvkK89Hcvv+ZtmvjOZjyHKXYNohuIsQ7cbZm0T7rxhX8t8r uNrf4c+LMXLuwI75p91jlk/DwdIFmGj6f2/0osg787c5ZxPMatGg0GggrB+isNZF1Uxm0wm4Tuj tY3AXvagnpC8E6avwupAv3qatgb5alrmk= X-Received: by 2002:a05:6a00:4b53:b0:89f:4cd9:241a with SMTP id d2e1a72fcca58-8beb724ceb4mr8802972b3a.41.1794818587165; Mon, 16 Nov 2026 00:43:07 -0800 (PST) X-Received: by 2002:a05:6a00:4b53:b0:89f:4cd9:241a with SMTP id d2e1a72fcca58-8beb724ceb4mr8802954b3a.41.1794818586537; Mon, 16 Nov 2026 00:43:06 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1794818586; cv=pass; d=google.com; s=arc-20260327; b=W4uCoYCrKBnTXaKVIHJQhNuRbgPVVSB8hfesDpPqO++sMi3j7ft6deyy0+Li3bJnqg 7Yv5piypJiTAkd4f+wB+YhzvJ9Wxms1ZzjqqfP9Y+qlz8jqYVO047vOM/FTdvL6MtMG1 ABpD1Xi85pywIcntD3yeVJHQ4gO5PE44ZoC501fXH+Dls8exs8s6Q9KG6bSq8qOmoy4b MbTMr75npG2zvo3PjlZARpye6G+zb0OIko4pV4uYZan6srAtlhqt/uYJrs8CjDNQFKgd lHXY3UPQEX2xjcTzMytU7UIUayHse55790pyQXMFo2Db7UDnlR3Gnp85jkN/+TGsGc0J /d1A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=xrQVzGQnnJibpPKU6b/cRcaUszfiVPwhgJ2TZ9M0Iew=; fh=IlzoM7xapMIT9vjIu8V1YxnmOSGAT8hvLuDm+hjUGIo=; b=MBrtJgrZPab3BS0YzFcJmEtO+iDaXWER+OtluHZ1/9Oa+MxRoE9zsfprZhitXkvlEB O4v625xYVgmG4a2pRgqavFKvFd+UyxOqnoiqiMQyDioysHZ2cPZCqaxHDkjlVFMTKbQT OFzqyn+9c5We/Mq2fsMVAUjm5xxcEt/hQv2CgIiDBiHz0GHb8vw6PBllC8+HSck1NoH/ 9sny5GowMmHDX805+4VPmjTbCaKogniUV5ivdK9ke61080w+oFvbQ6jjY16y6p8P3TrG 8l/hhQFr4gJ6BCz7PQ0dYo0n3nKmsFqVnqBOtVCnJcxcyK3p69pG/9MqxawB5byC/PRj LSfw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=0gS2LW1Z; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c200::3 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazlp170110003.outbound.protection.outlook.com. [2a01:111:f403:c200::3]) by mx.google.com with ESMTPS id d2e1a72fcca58-8bed4d34aa7si19094204b3a.197.2026.11.16.00.43.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 00:43:06 -0800 (PST) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c200::3 as permitted sender) client-ip=2a01:111:f403:c200::3; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=0gS2LW1Z; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c200::3 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oZe30Iz9CQQMmEeX/taIfx8WIYW3bd1rFRh9smQGgHx3YX9x3wIop7BpEpGfVkrdFn4SPtM8Du5mQhFtm9h9QEMh8e+lhv1tS3c/vNmaoHydgDVh84ZnTW1xiZwSa0ccL4yevHudp/HfM6Q4GZ+gwfARpE+MzCTX8zMzC+MEqn80ju++F6bXwO9YPgPeJ5xPngFWaYjD29m+fQb1Ocdd8rNBfDUI/QPTBksJJYuoxtSBO3m0n5HK9MnMykU8zOvPIEdcBTlAXNTT+FxO3jAkAOYXLoCrB8EkquqYMM04VeT4M87Lw4rVawSjuto3WQQkJjt17fnIL5yCLqCMlql8ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xrQVzGQnnJibpPKU6b/cRcaUszfiVPwhgJ2TZ9M0Iew=; b=a3R6RQ/jNGIydFvwV/LZyP0fbksJy4iImE1aUPtu02JULBEZc0cBDyTIhM0UvJhfyS+RN6c5I+lKUBlL99lQxgfRSTKRnJfn8yV9e4wERA84IZB0UkY/1Zq3a8XAwDAqtWkfkultxgOixnpE/vORJpw90oNnW/HqMiMCFh4PHkCvm41eN28aButk/VQ8fvEcsgZciMq8PpbCFzGq2FOfHpI23jEs4qJtIYT77v0fGNo0BxpH2AGHv+eXT4j6SKq/7svK7W0ep6sfkBoZwbh++EPHdCxiWzMtYRMtdz8w1M7VH+XyfiJzmhrY9aD3+nzom4wfqvyqSZFsDUFly6RKQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xrQVzGQnnJibpPKU6b/cRcaUszfiVPwhgJ2TZ9M0Iew=; b=0gS2LW1ZzpOzf/YJWP+GB+ZfS2yLEAjCMKCrDu7ri4S3/6kxhv8gY4+ldtnXsEouk6kDXlQPax11ztZ8vTUDmac/mJmlWZaNRDGoYH+2TYFLjYi8RzzpzI0R6E+PgWJy4NMTdL/Xnlp68AiffqkzWa/qpGaE1OEIln0w9OKSXTVo1yiFHKpJnETGdHeDUY8nGrNTJaLOjuGZQrBugAA2Hlb4SWETN6QdhszZnDFFAq6h2RhoQ6tySbuGqIhRv47gQf9xLKhxYK2+3Cr2UmVaW4Ag/byfg8/Hup4PkyKhRVSo3G9WOMlI3q5zWXlhkM0wEdv1G+8X64gQyH4OlxrDLA== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) by AS2PR08MB9152.eurprd08.prod.outlook.com (2603:10a6:20b:578::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.615.14; Mon, 16 Nov 2026 08:43:01 +0000 Received: from VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a]) by VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a%6]) with mapi id 15.21.0592.009; Mon, 16 Nov 2026 08:43:01 +0000 Message-ID: Date: Mon, 16 Nov 2026 09:42:59 +0100 User-Agent: Mozilla Thunderbird To: no-reply@sashiko.virtuozzo.com, andrey.zhadchenko@virtuozzo.com References: <20261115133957.2803273-1-alexander.ivanov@virtuozzo.com> <20261115133957.2803273-2-alexander.ivanov@virtuozzo.com> <010701a1df7937e7-68dd8a02-a404-484e-bed1-7f2ddecfe8fd-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Alexander Ivanov In-Reply-To: <010701a1df7937e7-68dd8a02-a404-484e-bed1-7f2ddecfe8fd-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: FR4P281CA0242.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:f5::20) To VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10743:EE_|AS2PR08MB9152:EE_ X-MS-Office365-Filtering-Correlation-Id: 26217720-b496-49b2-32ed-08df43bd9f34 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|366016|23010399003|1800799024|22082099003|18002099003|6133799003|261009223027099003|4143699003|56012099006|261028144727099003|261102123227099003|261026121527099003|261026140227099003|261022105027099003|261021121427099003|10067099003; X-Microsoft-Antispam-Message-Info: dkQB6GRG7WdIBQAjJEz+K7KPWa5FfPrCCv8kuXSluoSuXQnLBcSchHhbY8au/G/ykg7DE/hDQFjOfrWWHJPjT+KU9qJ+Tqp9kK81mTPVVoKFXzCHkpQo8cSenUQj5ZrG3/ILEk/p1QgG7EUQSXCm3QsRQbkYijM/p8i+lSEk03Bsh0cfCnIeBSu3f7ro3POf8mwOUOp0zED7IOCE166dQ9z/cv81fKOwoa7Q+M03Yhp/d6pvPF8DLaf5AgxA9Qb6D4EJagHc+uR05ZHXvrAq3g+R03uPg7bri8EwWxkFdFqppoOy814kxMPaXPFVnJ1EYkUPa9GvR9pzG9gXG97YVfo9TmWvDa0PFOI+JzGuwz+7vkfCgSPFPCnpvl+IG+uU1Y52fQj+1fsapHdRNTzFLSMjhS/O5vi7LZkO6exVsrLccmQVysJ5CJKSfu+7GiS/rJCl485ts4dfYia+bHeDKSLNqMiy8L27hLMsrWjU4RZ9ZCf7zlSV9/RCgX/Tmns4zHRWUYMY+9JfWN7y3A3FGYa/yPUXW+2bivPX3HWD9FugIhy7rGdocY+0W+EhiuqtuVKPbuKY+328f+TI4nZwbc3g6CsnifMm1WJ327YXVg8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI0PR08MB10743.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(23010399003)(1800799024)(22082099003)(18002099003)(6133799003)(261009223027099003)(4143699003)(56012099006)(261028144727099003)(261102123227099003)(261026121527099003)(261026140227099003)(261022105027099003)(261021121427099003)(10067099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ck5GWHdBTC9Ca3FMSXlwSy9wNktPWDExb2h3dTdZMWFtNnpmOTd3RWN2ZWtG?= =?utf-8?B?RnNXWVQwNHUxRGhSUHUyb05WcEU2OEQ0U2Nxa254MThFb3djbGtKODBWWUtF?= =?utf-8?B?Z0Zpd3Mycng3Q2ZPOUJ1bWRmcElPYU13bDlybTl2RDRXaFl1UkJFdHRMVzYr?= =?utf-8?B?SWpoZkJlZDRFNnF2NDBGK2szZjdBdDBLSlRDSlVlMi9ZV2k1RHh6SEVEUDdr?= =?utf-8?B?ZWVhOWh4TnZCclNiUi9idkRWYmhEOXd5ZmRIL0hXOUlqQXdhR3FHTmozSEFI?= =?utf-8?B?YnNXak4xbFRVbyt0RTlPalB1cnhndk93eE5xRVZ1R0g4ZFM5NGFaRFZWSWdF?= =?utf-8?B?K2hmTUJsckFNSnFPdGNMMUc2N2Y0WDRKMkYzN21wNS80M2QweG94U0JPazdK?= =?utf-8?B?Q20yTmo4Y3V5RnJ1Z2ErUDZ4ZlFOQlo3ZktvdUdYckt6bE9oRGY4ZE8yemRv?= =?utf-8?B?Z2VDYmRqcCtmN0JaUmV5YWNjQU56R2tuTVhzcjlib3QzbFM2cUVLYnlJVGw5?= =?utf-8?B?b1ZDQzJ6OWVKK2FJa0crRW9LNzVQTHkwZVdzR0xuWHRCMm5LUFNQbzQrWG1v?= =?utf-8?B?dkoxMVdJMk44cGoxK0lHaXRVajRNaEwyQWlwWDRjVUJYQVBtZEhUNWtGYXgv?= =?utf-8?B?M2lkREU4MGpFMVlwQWN3WmRhNXlWakhwVjl2bXh6N3d2MjlBM1RoKzBpNUc2?= =?utf-8?B?ZUxQZ1pKSENmRXh2UWxZd05vNjdVMkVOMGNRRkhlVnBLQTJkQ3lvYnFBcDM3?= =?utf-8?B?ME9FZ1VSTnpGOVNwa3RSZitlaEdBbEx6UGFKNnA1akZOWTg1aFYyT0xPa0pM?= =?utf-8?B?cVE5RHcrOXVuVm5BTkJrVm1wb29ZaWVlUFVld04xckVOUEZrOHhPRm5xYmlv?= =?utf-8?B?U0tacS9nUGdpSWh6S3pKUkVBV0dCMTNSU0dhMU03Kzh0WjJCQS9PdXRYb3hQ?= =?utf-8?B?U2xmZ1VmMVYrZjBFUnBwWExTUjIvUlhOZ0RRSGFtY1loYkNzTmp3M3B4V05E?= =?utf-8?B?YmdQWFBoQWhpRFV6SC95ODl6cTJ0N3UzZGdJQXJhQkRGckFaTkRoM2FTMFlj?= =?utf-8?B?b01hMldpcXhaNndjWDZZQmZxejlRM3NKMUxOcjJCOHoxL0NEVTd4eEl6MVZY?= =?utf-8?B?ZTJBVUZURmQrSENvczZsemJZVy9jU2x6N2c2MUg0Qll1TTF3ams5K0lOblhw?= =?utf-8?B?TkE2MVdtQ1RHeEpTemJRalgyU2RQVTNrSUNYZGhodmlTd1piSzEwWVhGZnRq?= =?utf-8?B?VkZCZ3MrSk9SbUdZanJEdGk4VHJhbUo5YXpWRDkzWldRV2xJcU53RmsvSkpH?= =?utf-8?B?RERJdXFERmdDYWRXQlgwZGVYSlJkUVYyNVRDUXdLRDJ5OWJtMmpsZHlTVzFj?= =?utf-8?B?ZXdYWHo0aTkyeENWTEZwM0swcmgzV1lxZ3QwVkxwc1RNM3BLdEtZQk4xS2VM?= =?utf-8?B?RnkwNGtTaHJUdTFDTGVNTURhamRrQjVFM3NoZ2ZnZkF4UG93Z0tIL2x3d0tQ?= =?utf-8?B?VEhVTnhMRGZUdjB1My90M1RTb2ViSUp5TzhzaU9yTml3dGdwc0R5cW81QW8w?= =?utf-8?B?S0xMNHVHTVlpQlBMSkFaTHFEcmZHRjhIbVVOcGcvMzc0WUIrMCtJbU1NeDF6?= =?utf-8?B?d3RjWDhWYUtrQlVuTjZrYjRUR2xaWXc0NGFkbjZVNEsyY29QclRxUU1LM0FV?= =?utf-8?B?Z042UXZyYndoOTMxdFk2dS9DVzdJMzJvRzdBT2JIRXZMNWJzMk5pdTE5QWU2?= =?utf-8?B?MzhTeFBidXNvYUM0NDl4UktSR0Fod243dk9kZDFqUzA4MUExU0J2eDNRenhW?= =?utf-8?B?VVpFUWVhZ2VPcGlmbU9hdDcwa1ErSXd1aDliam14RVZRSnMvYkZWbFk2c0lD?= =?utf-8?B?anBCMEtLbVRqaGdWSTU0Z2RrWnhyODdKS2tUVnV6d21VWkR4U2loV1U1Yy9o?= =?utf-8?B?NCtCOWJhRTVZRWgyYXdpaXRQUENKSDhmWlc3V2lHY004d1piRUwrRVFGSnlu?= =?utf-8?B?NW1WSGY4dUxXakhFMU9VNHhDZFBIZzhGNGxKWXh3TTViTTFrS2p6SWVvSnVN?= =?utf-8?B?WnhTYTN3b3NhSzVpMnk0SzdoUE8xSTJucXU0L1Vpek5KQ0Jzc0VCNkwyMGMx?= =?utf-8?B?dXQrb2w0UHB4di9kN1lhRmhnZkVZMDBDS3FQK1N3bWZFZkNlakhvVVRxVHFU?= =?utf-8?B?OGR5VlhQZTQ0b3F5ckJuenF5bU5kOUpUOW5Kam1VbDV1M2lIMXJhZ3RURTlo?= =?utf-8?B?S2k1STUrZU50QlljbW54ZHBUQ3NuL09QTFpBUTJpdmVWbG81cFVza2pUdm9m?= =?utf-8?B?b3Q1Z2FoZ1RwUndnb2FyQlhKRjlFNm02OXBNRitvOXdzaFBEV2JUMkpUV1Zp?= =?utf-8?Q?nmS04XMC1f9qPlTE=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 26217720-b496-49b2-32ed-08df43bd9f34 X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10743.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2026 08:43:01.0619 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KR3kFNRowPrUgZ2LnuNx+kO2HlUVR3X3ILoehntOuLT+sJovB/KHndJ/D+fwkmvubycuJctI67unl6/3YRd+ABC3U2w3BgKOrDtTBy3bGh0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9152 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v3 1/2] drivers/vhost: fix a use-after-free of VHOST_SET_NWORKERS workers X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org >> drivers/vhost: fix a use-after-free of VHOST_SET_NWORKERS workers >> >> vhost_set_workers() and vhost_propagate_workers() store workers into >> vq->worker directly, bypassing __vhost_vq_attach_worker(). The workers >> they install keep attachment_cnt at 0, and the default worker keeps >> counting every vq. VHOST_FREE_WORKER then destroys a worker a virtqueue >> still points at, and the next vhost_vq_work_queue() on that vq is a >> use-after-free. VHOST_ATTACH_VRING_WORKER on such a vq drives >> attachment_cnt of its worker to -1. vhost-scsi already exposes both >> interfaces to the device owner. >> >> Attach the workers with __vhost_vq_attach_worker(), so VHOST_FREE_WORKER >> fails with -EBUSY while a vq uses the worker and both interfaces can >> coexist until userspace moves to the worker ioctls. Userspace issues >> VHOST_SET_NWORKERS before VHOST_SET_VRING_KICK, so the attach takes the >> path without synchronize_rcu() and VM startup is not slowed down. >> >> The attach dereferences the worker, so skip a source vq whose worker >> was killed, and reject VHOST_SET_NWORKERS on devices that do not use >> workers. On vhost-vdpa every vq->worker is NULL, and the workers >> vhost_set_workers() created there were never freed. >> >> https://virtuozzo.atlassian.net/browse/VSTOR-107537 >> Fixes: 1491588e71da ("drivers/vhost: add ioctl to increase the number of workers") >> Feature: vhost-blk: in-kernel accelerator for virtio-blk guests >> >> Signed-off-by: Alexander Ivanov > [Severity: Low] > Is the Fixes: tag pointing at the right commit? > > 1491588e71da is not an ancestor of this branch. The commit with the same > subject that is in this branch's history is 705a4b3eefde ("drivers/vhost: > add ioctl to increase the number of workers"). It added vhost_set_workers(), > vhost_propagate_workers() and the VHOST_SET_NWORKERS case, and it is where > the direct vq->worker stores came from. Should the tag name that commit > instead, so backport tooling can resolve it on this branch? After rebase we have new hashes. Fixed. _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel