From: Konstantin Khorenko <khorenko@virtuozzo.com>
To: Vasileios Almpanis <vasileios.almpanis@virtuozzo.com>,
OpenVZ devel list <devel@openvz.org>
Subject: Re: [Devel] [PATCH vz10] sched: enforce the 0..1 bound on sched_cpulimit_scale_cpufreq
Date: Wed, 26 Aug 2026 18:48:52 +0200 [thread overview]
Message-ID: <a1316698-6f7d-4fea-acb2-d025332d078f@virtuozzo.com> (raw)
In-Reply-To: <20260805134532.505482-1-khorenko@virtuozzo.com>
a kind ping
--
Best regards,
Konstantin Khorenko,
Virtuozzo Linux Kernel Team
On 8/5/26 15:45, Konstantin Khorenko wrote:
> The sched_cpulimit_scale_cpufreq sysctl was registered with
> .extra1 = SYSCTL_ZERO
> .extra2 = SYSCTL_ONE
> but with .proc_handler = proc_dointvec.
>
> proc_dointvec() ignores extra1/extra2, so the intended [0, 1] clamp was
> never applied. sysctl_sched_cpulimit_scale_cpufreq is also unsigned int,
> so proc_dointvec() is the wrong signedness for it in the first place.
>
> Use proc_douintvec_minmax() so the already-declared bounds are honoured
> and an out-of-range write is rejected.
>
> Fixes: 4e99efb641da0 ("sched: Port CONFIG_CFS_CPULIMIT feature")
> Feature: sched: ability to limit number of CPUs available to a CT
> https://virtuozzo.atlassian.net/browse/VSTOR-137234
> Signed-off-by: Konstantin Khorenko <khorenko@virtuozzo.com>
> ---
> kernel/sched/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index d5b4d8c97a0c7..7580067e7f44a 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -4753,7 +4753,7 @@ static struct ctl_table sched_core_sysctls[] = {
> .data = &sysctl_sched_cpulimit_scale_cpufreq,
> .maxlen = sizeof(unsigned int),
> .mode = 0644,
> - .proc_handler = proc_dointvec,
> + .proc_handler = proc_douintvec_minmax,
> .extra1 = SYSCTL_ZERO,
> .extra2 = SYSCTL_ONE,
> },
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
next prev parent reply other threads:[~2026-08-26 16:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 13:45 Konstantin Khorenko
2026-08-26 16:48 ` Konstantin Khorenko [this message]
2026-08-28 17:09 ` [Devel] [PATCH RHEL10 COMMIT] " Konstantin Khorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1316698-6f7d-4fea-acb2-d025332d078f@virtuozzo.com \
--to=khorenko@virtuozzo.com \
--cc=devel@openvz.org \
--cc=vasileios.almpanis@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox