From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id CB3208045D for ; Mon, 2 Nov 2026 15:18:49 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A2FHZd9026222; Mon, 2 Nov 2026 18:17:35 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A2FHZd9026222 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="XqrIqbuU" Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A2FHWPa026218 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Mon, 2 Nov 2026 18:17:33 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A2FHWPa026218 Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-cd6532dbd7bso1986644a12.2 for ; Mon, 02 Nov 2026 07:17:33 -0800 (PST) X-Gm-Message-State: AFq9FYKfor7jeF/a+wRyCavmfg9FemLjemFH8XMXtmSb0n+/ogA3vl5m 5xeUm7FREBpFq/gEcybGFM9jAfVaBrK5ukj56YF8ZglSHJEe3EGKZjfBZifBxX1ZyCHQt+uobk9 Gd0jDnaXyBe3/26Li7c9TPVuDCiq9BKuv/v12uit9WdVCZspFuWxAMg== X-Gm-Gg: AYBFou06KP0v+QoUEfDNPqXk4shrr5pXcw+9YmaRkkQouu8mcODFdB0QDGyJGi2xcBS kj4FOPPaR3Ynpz5uzXyFVz4chCNbWI2Ms0J1A38qj/26cLTvKH+gKVBQC4eJRQ4RHy7Q6q70Qzt GzPAJTnfAKRpMiSwtAGbgHuPIoptQBrY84T9lgaUyQK8bL0W1WNasymJbDREa683XoePuvg1f3D 2RTi9nacfAxk8KFlzwVlg9nnCpINb961h1PyG66Qhed1hXbsCfhBwYohHHbXIUPz19Lo/oSFZfJ gKiHtaMp+SbnUyai7QmUb36+ICcCfSvTfU45+hixVrAN36jOn3E2c8SwrCqEDwR1A2cx+zr/R5k B3Y5L7N00/W+gHque47rKfxrsgLsaZeBHlfEGGQq7e3QF1xUWNFa7LpSYssnIADa48afbHEJkgH 5RjYyap7o+pn2ZUFb7Jin+sg== X-Received: by 2002:a05:6a21:9189:b0:3e2:f025:d51b with SMTP id adf61e73a8af0-3e928df4d9bmr8535699637.11.1793632651725; Mon, 02 Nov 2026 07:17:31 -0800 (PST) X-Received: by 2002:a05:6a21:9189:b0:3e2:f025:d51b with SMTP id adf61e73a8af0-3e928df4d9bmr8535652637.11.1793632650709; Mon, 02 Nov 2026 07:17:30 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1793632650; cv=pass; d=google.com; s=arc-20260327; b=XhRIC4bHP3A7sG/M1YOtfzdI1JvQEc4xNRox0aoe7u7XvZelxT+MPtdO5kp3UYuT6C MYsDM5Qegzs2eDcGo6Ld79G0uOYma0G8dYCuR8SpcOU+ceCloRcUwq+iCTI1FLES4ieB twb4PUjnlHJUwt9xnwmCqF5LfP2u1IbwxRgYfX8PNjgwTwaIcdq+QZMdJcPYSNfflI+L /NRSM2FMczECaTgUH9ZJ0vjRbfkLLRZqMPdwDpf/Pyx6+oLnx0h/3OGS/fg4MChATpiy GYuL2EuAW+a5+Thsu521BqQoUfoMLbBziQ89SMsyvkEM2fX9tKQSg1g6pn+IDc2zQbqs Ym3A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=JlJLgDZ6N/JxEwhAXf8BM5P8M724jb00s4CwpKtDaVA=; fh=HiMMlmpSbSs0UGys/NetKQrFxFK7GSXxfdZg08B3GfY=; b=UVAtOj5UT9GSLTRpqd6OaYAtleuLSH0RXMkKSDU1WP94IFwg35eAwk5z9IJHVtgr7a DUVXwTEDR9KyaWqbeF5R01ffvZZlpy078251sx5/YO9HPI3wlTYNQ1PQFM03ObderNAn KoBumXFt69lf3wsU3WF1eZB7j+HEGLZOARxCe/RBrTwjWSYKeiKK0G/7guawIxsjT3f2 fRk1HsdjXm8spZ2N2Zay3ATzx2owDSXPypnFypovxlxhH9BzPx4qzhwBw00AlFzAS3hi Nf1I8E9jJtl1jjS7eE2bk+FB86rvlJysVHOSrG86hGY42lVrGx9WKPfmXS3WfZGnHQNk SPkg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=XqrIqbuU; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of khorenko@virtuozzo.com designates 2a01:111:f403:c200::3 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazlp170110003.outbound.protection.outlook.com. [2a01:111:f403:c200::3]) by mx.google.com with ESMTPS id 41be03b00d2f7-cdb3654aa36si9520a12.375.2026.11.02.07.17.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2026 07:17:30 -0800 (PST) Received-SPF: pass (google.com: domain of khorenko@virtuozzo.com designates 2a01:111:f403:c200::3 as permitted sender) client-ip=2a01:111:f403:c200::3; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=XqrIqbuU; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of khorenko@virtuozzo.com designates 2a01:111:f403:c200::3 as permitted sender) smtp.mailfrom=khorenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=o52Fc8uXqt3cRubwfFkgqsuxATouPoIriVQ74dzuUJM299lmXJvE/1ZQwTmNjmQvnbVaOjKvR0zGcFDVArfxnzzLRINO3nwSdOxPTncxm4VXvZtEZ/ziG0NZOxWRmpYS7yVB1RjQ0Y3fqKvRLImJ7k6tQvlthy4PQ4AZYMHCAlrso4dG+Fn+SKFtteNeYNMjsAzWbEZxYruxZThTf+s1vFmk5lB6Hj0ooVSVE28L5sRSr2aaUU8ag9YyIhVmHX8Qz17tsws5aO7N9nJM4c0YgIcA+NdFzZQyusO5E+3+bDWeazC9WjhG5ieKFGPNYyN/kx94MTuAzhAvB2uRIIovig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JlJLgDZ6N/JxEwhAXf8BM5P8M724jb00s4CwpKtDaVA=; b=EqeIH2L7QXlpQvcIz2IYWxdMKViUAAwBRa8u8K/UBIo+uDHQUOGtnmwzz1+k2HsDQyLaIi8Ys3SA8zkO0AJlKQJzOAJbtEvAV4pkUQZCgNm7dg/c4BL1LQ3R7ZM1VSooeY03P5B44zzciSY5N+coLedS52UBnoVApBUx5kubPx1O++L0GQUUyOSzHfhLNYKh+y+Ywl5GvHjimwO57dWOSJ1w6mzdbW5ICZiWWCtIcT3GOv7my2BK6aUKe0GCH5ZQwS64OMP7g75glGwzc5NqQwrMZgbn91PRXUNPq0djq0/Wfk5QbSiD0lBx7jMUvrsSPo9Enrpq0CX+5WKmCdCDgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JlJLgDZ6N/JxEwhAXf8BM5P8M724jb00s4CwpKtDaVA=; b=XqrIqbuUXnvE542I70lX9k0ecYzyhEhJGPir7htaZuXCDtfOXLbgrewnhwsXAeFzlKNoCRm52x+syifaFFAR+Ecvmrilx1uTiJZJqYyIcHBlVVemK4AWHmMHD3JWTkGwFM0g77HVyTc1EVTj6/s69YAls3EhtWKVvt83nZVDDcP3RgWe8piuND6CxE6lKzYivUw+jvW2DDJZU7m+k5LgSgSsoTo+OG4Vy3DDM5CpsZYJ3fssUvw+Y5JCv57lVUzIDDxrxQHw7S/VklwTUbaxUxuyRBPuveEamGmcZ6mDGPlrJFoAvwHVVp0Y/yVbPGnCqd6F2fsRMo9+4KV3Q3FWyw== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from AS2PR08MB9075.eurprd08.prod.outlook.com (2603:10a6:20b:5ff::9) by VI1PR08MB5342.eurprd08.prod.outlook.com (2603:10a6:803:132::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.12; Mon, 2 Nov 2026 15:17:26 +0000 Received: from AS2PR08MB9075.eurprd08.prod.outlook.com ([fe80::3f57:9ced:7a37:1bd8]) by AS2PR08MB9075.eurprd08.prod.outlook.com ([fe80::3f57:9ced:7a37:1bd8%4]) with mapi id 15.21.0569.011; Mon, 2 Nov 2026 15:17:26 +0000 Message-ID: Date: Mon, 2 Nov 2026 16:17:25 +0100 User-Agent: Mozilla Thunderbird To: "Denis V. Lunev" References: <20261029223502.1437160-1-den@openvz.org> Content-Language: en-US, ru, sr From: Konstantin Khorenko In-Reply-To: <20261029223502.1437160-1-den@openvz.org> X-ClientProxiedBy: AM9P192CA0030.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:21d::35) To AS2PR08MB9075.eurprd08.prod.outlook.com (2603:10a6:20b:5ff::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS2PR08MB9075:EE_|VI1PR08MB5342:EE_ X-MS-Office365-Filtering-Correlation-Id: 696dc302-3bfc-4849-d496-08df38f46732 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|23010399003|366016|261021121427099003|56012099006|5023799004|261028144727099003|261026121527099003|261022105027099003|261026140227099003|261022075727099003|10067099003|22082099003|18002099003|261102123227099003; X-Microsoft-Antispam-Message-Info: NjWAVAOKLxX/nZIAM8rlW9Dv7Dq42wXKrgzY7Xt0IuHg6TKL7rRyR/jw3jGNhbQkP09+oObuEOJcX4frintY50+l1cLmuD0w6W+ub/lkosCKVTIVFQVKkrL9tqaTKsHh8t5ZeCxxvGK5c9aUCnD/PzTxVVP08rWszvXsGwKe0TsvEmKdo3jIhTyowkbDrYdV1k/f0u3X3sIULv1Iqpxp2DC5ND0YEiEI88itVK8u8O1lpW6aZPOWv6oGvil1ATe8CeEPSsdKFVJWGr8etochYWtsBBWn8z2B3lj/v2lLLuLGuhNdo7Dsqd36a7tTI2cwhWYvh4f9ZKk0iNTdwyVUWEh77nbZCZCLy2r8ivd7wOf6NzqSr5EqW08oQygL2pIndRbQUqeqvnwa1MDdSVkio2yb3P5Zbq0A19pHUP8mQBLUYg3wbSrrqR0UbehOOErJZYMJxS0KLvI8ncFb6Xqz8IYFvIzcxZF9vFOmxZX1/a6HoolTMzb4wL+Y/jqLeq+WgiSBzMQINH99p9LzD+bqwjSJnFpgVlZQYRVAzPHqEX63SSRaqRoI4o6yApvPIJPqFx72MoUwKtBG00FVQ9K3tADKPLdePJa1AFtluJ98IJVPDn709NLqs1EP8rGqFSjyA/NNcP8scg/MpSdRFR0D5NjsncfyVTfHkWODi9FTwX8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS2PR08MB9075.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(23010399003)(366016)(261021121427099003)(56012099006)(5023799004)(261028144727099003)(261026121527099003)(261022105027099003)(261026140227099003)(261022075727099003)(10067099003)(22082099003)(18002099003)(261102123227099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MVlrbzhOb2grWnlFQlREMFcvaWkrWk15T0kydFo4V2VYRGVSTS9hSDZFVk9y?= =?utf-8?B?Q2YxNXA4dHJ6WWZlb042NWVla1dCZThiaURJaGNnUUh4QjBXOE1HWE5nZi9Y?= =?utf-8?B?VmFUYkx5eXFZVU5mTHcrSDlSMGsyQUsyK29wdklQRjByTGdMTC8xekhvWGx1?= =?utf-8?B?YVlmWlRqNWtYMks2VFpXS0VzcGN1TWNIWDhrRkdNb0xPSGpIL1haQWUzRmFV?= =?utf-8?B?T25FMjNNVDRBelpUOWtnRnpEbGx5U0NmVVppUlJTNVppK3BYL0RmN0IwOTcr?= =?utf-8?B?OFQwZ0VzQnZYRWdEdlhCUXlucU13YzZMZDBvTzkybzBuVUdIMUVFRTlGYzlI?= =?utf-8?B?d1hmT3VHZjUyQVFtTHVNSEJCZG9RRlVBSURIMkZTSWh2SnBWeEZsZFIxeUgx?= =?utf-8?B?Wk5QZGJRQzJrbm93aVZTcExkVEJpZ2hwRmVEUTRNVjZCaWVmRGtOYjU2clBr?= =?utf-8?B?dUhFczlxamdLaXVzRktydDdaY3VPcTRnMmdCVm9xRDg5b0lCOVlmNzVNemFY?= =?utf-8?B?K09xUjk1NGhlMFpXNkR1eVZHSVFsYUFqMGtGNTl4V2FSZEh2S0NSSTUwNWgv?= =?utf-8?B?U2NUZmczOVgvbjRPRWd1aFdoZlcyS2hrMGR1VGhxY3N3ZFdvTTlnVWZCaGxX?= =?utf-8?B?Q2lrMGYzOXl1Zis1SWJobGtnUGpNZHFnVDZIVFgvenYwalhJWjQ3N1ZNZHFS?= =?utf-8?B?c01HZ0ZmS3dDeVMyRWJGdS96ZFk0R3h4VGs1b3N3c25EcHVwNkxnYzM4eW11?= =?utf-8?B?WUlKMXlPcGxhQ21CcXkvem4vdURVWmdkZDFtemt3Vk1Kd0U1czVGUVpyZng3?= =?utf-8?B?R3FIcTlZRjVEekpwSk9zY2liUHNIa1ZpLzEzMHV0L01IQ1ZIRmk3d0pkMVl3?= =?utf-8?B?WkNSeEs3cjBkM3lDeExzU2h5YUJTU085NGlNZkdOUk5oSDJvTjlWSW5BSXRs?= =?utf-8?B?OFJGNzVBYlBRUlNZaW85THZSNDJEdHVqdVFrc3VNTkRGc2hteWErSmZkSGFn?= =?utf-8?B?cG0yc254cFdEUDFFald0WW1XZm1nUkRoMGJIMjBsRHh4UFM4U09LRGN5MnBv?= =?utf-8?B?L3BlRFdLQ3VSU2dDNEpNMFlkRGRhbklkUEVjZ0plcE1pdTNZQ0lMVkFtT1Ry?= =?utf-8?B?alRmMGRvVGxSQ25IOVFPTHFaZkxGVWVjTERuUjdlRDJjem84NHljblNNUjBm?= =?utf-8?B?WmFHL2dVTVh5aDdRS0g5eDVWSVVXazZQbS9sRFE1b3Y3VVFvQzh6TFI1S1h6?= =?utf-8?B?RFhyK3dzUFlITHpMTHZJaUNWc3RSZDlSV0ZzQ0I3VmtvZ3NlM1dzQ2ZpR1F3?= =?utf-8?B?djBnSEhBano0eXpmYU1ITjBySjUzbzhZU0RSczlpelNlaTA2UmpmL1hXVkJs?= =?utf-8?B?bjRVZ3BCaG52UjdvREdlUnNGR2N3eFBodDFlNkZUWEFvUHF3Z3doR2wxM085?= =?utf-8?B?UDVzdHBGVXNtZHdSMUdJTHBXOERMVENCZTlEVzRlaWFsREg3WGhyZzkrQUh4?= =?utf-8?B?VDdyWnc5S2dNK2c4L0JPb3I3Q05GakhWZHdyVEdQYTdpZEZ2SlpIN2pNMG9y?= =?utf-8?B?eVUyeW5VVVROWlFZcWFuWmJsZVJveHRWZlhjek1CSHZha1B6OUJCaGNlZGFL?= =?utf-8?B?Z1hDVmpJa0RWYnVncFBPOXhGK1MrUFR2Tmw3blN4bzFkUEd3OUdHczBVRzhD?= =?utf-8?B?aVlXMSs3VnZodU5YTTNEQnhkdEpOTG52Q1lYaEZmQVUxU3VPcXVvSG1SSU9o?= =?utf-8?B?MGs1NDlTU0g3dy9za2lBNDhtb3ZBcjNzbS9pTitPTTJKZDgrSm01Mml6VzYy?= =?utf-8?B?VGIrNkRMQXpWZG0rWmpZZ2M0bTNJSlNvblBGVTV6Qlc3YzVUbWhJKzA5cTZr?= =?utf-8?B?S2FwcHB4b1VVMjlQaTROdVBzNGZmZUc5dEVGbzU3clgzZlJnK2x4WlJVeC9w?= =?utf-8?B?U1R2Nzd0eGZLaGxRVm12TVpXdFJib2hLallTcC9qVHV5SDZOTXBacnZMNFhm?= =?utf-8?B?TmU0VFhDakxXM1VmTkpaalNFUzdIdlhqb1BhS01DWmNXbFg5WFNTZG96Vldu?= =?utf-8?B?aXR5S0NadnFOUmxpMy9JNjF3cXErTjc1R3ladmMxUGxIdlFERTFTeDY2L2kw?= =?utf-8?B?N0hGUzRYVjB2ODdNZlBhOVpGL1cveWRYbE1PeXpLLzhpU2YwUjdhWnREd1Js?= =?utf-8?B?UFo1M0VpYUJRNThGRlJUUU94eUgvWmM0M3lhNWxGZU5aSU9YM0FPWnIwY2Nt?= =?utf-8?B?eGpRSlpkUXRlcWFpNjV3bE9oRjBQZTRya3A4WUZpa3FzcEpIeSsyWkszOFNo?= =?utf-8?B?MWozaFFRcFZwL0Z2WDczM2lXeHZZM1duODE1VEpLQlVtV2FjM0lPZz09?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 696dc302-3bfc-4849-d496-08df38f46732 X-MS-Exchange-CrossTenant-AuthSource: AS2PR08MB9075.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2026 15:17:26.5555 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iEGeN2b/AraqPk/I+s241jBfkzhyxsS0ceD+uh46A37nqGHktAOCatQXDJQYNFuKFtJcx5KrIBgogFAMVdkLiA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5342 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1] ve/vtty: fix console attach failing with EBUSY while the CT closes the tty X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Hi Denis, > Return -EAGAIN for the dying pair. Nothing else on the > VE_CONFIGURE_OPEN_TTY path returns -EAGAIN, so it can only mean "try > again", which is what vzctl will do. Agreed, together with your vzctl change ("vzctl console: retry opening a CT tty the CT is still closing") the bug is fixed. But only for the new vzctl: every vzctl already installed tries the ioctl once and now fails with "Resource temporarily unavailable" instead of "Device or resource busy". > An in-CT open of such a pair gets > -EAGAIN from tty_reopen() and tty_open() retries it the same way. > Retrying inside vtty_open_master() instead would have to drop tty_mutex > for release_tty() to progress, and the global vtty context with it. We can fix it for old and new vzctl alike by doing what mainline did for the same window in 7f22f6c935cda ("tty: Retry failed reopen if tty teardown in-progress"), retry in the kernel: if (IS_ERR(tty)) { tty_free_file(filp); retval = PTR_ERR(tty); if (retval != -EAGAIN || signal_pending(current)) return retval; schedule(); goto retry_open; } Dropping tty_mutex and the vtty context is not a problem: err_unlock already does exactly that. So in vtty_open_master(): retry: mutex_lock(&tty_mutex); vtty_set_context(veid); ... if (!created && slave->count == 0) { tty_unlock(slave); vtty_drop_context(); mutex_unlock(&tty_mutex); if (signal_pending(current)) { ret = -EAGAIN; goto err_free_file; /* tty_free_file() onwards */ } schedule(); goto retry; } The fd and the file stay allocated across the loop, nothing else changes. The loop always ends: we get there only with master->count == 0 and slave->count == 0, i.e. tty_release() has decided on the final close, so the closer is already in tty_release_struct() on its way to release_tty() -> vtty_shutdown() -> vtty_map_clear(). Once we drop tty_mutex it gets through, and the next lookup misses and allocates a fresh pair. The BSD master pty that Peter excluded from the retry in mainline (its slave fds may stay open forever) is not our case: here both counts are already zero. What we get: - old vzctl works with the kernel update alone, the vzctl change becomes optional; - -EBUSY keeps meaning "console attached" only, -EAGAIN is left only for a pending signal; - it goes on top of what is committed, no revert needed. Could you send that as a follow-up on VSTOR-152365? -- Konstantin _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel