Re: [Devel] [PATCH vz10 1/3] selftests: net: Adapt ethtool mq tests to fix in qdisc graft

[Konstantin Khorenko <khorenko@virtuozzo.com>]

ack

--
Best regards,

Konstantin Khorenko,
Virtuozzo Linux Kernel Team

On 8/21/26 18:41, Eva Kurchatova wrote:
> From: Victor Nogueira <victor@mojatatu.com>
> 
> Because of patch[1] the graft behaviour changed
> 
> So the command:
> 
> tcq replace parent 100:1 handle 204:
> 
> Is no longer valid and will not delete 100:4 added by command:
> 
> tcq replace parent 100:4 handle 204: pfifo_fast
> 
> So to maintain the original behaviour, this patch manually deletes 100:4
> and grafts 100:1
> 
> Note: This change will also work fine without [1]
> 
> [1] https://lore.kernel.org/netdev/20250111151455.75480-1-jhs at mojatatu.com/T/#u
> 
> Signed-off-by: Victor Nogueira <victor@mojatatu.com>
> Reviewed-by: Jamal Hadi Salim <jhs@mojatatu.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> (cherry picked from commit 0a5b8fff01bde1b9908f00004c676f2e2459333b)
> 
> https://virtuozzo.atlassian.net/browse/VSTOR-139651
> Feature: fix selftests
> Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
> ---
>  .../selftests/drivers/net/netdevsim/tc-mq-visibility.sh  | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/testing/selftests/drivers/net/netdevsim/tc-mq-visibility.sh b/tools/testing/selftests/drivers/net/netdevsim/tc-mq-visibility.sh
> index fd13c8cfb7a8..b411fe66510f 100755
> --- a/tools/testing/selftests/drivers/net/netdevsim/tc-mq-visibility.sh
> +++ b/tools/testing/selftests/drivers/net/netdevsim/tc-mq-visibility.sh
> @@ -58,9 +58,12 @@ for root in mq mqprio; do
>      ethtool -L $NDEV combined 4
>      n_child_assert 4 "One real queue, rest default"
>  
> -    # Graft some
> -    tcq replace parent 100:1 handle 204:
> -    n_child_assert 3 "Grafted"
> +    # Remove real one
> +    tcq del parent 100:4 handle 204:
> +
> +    # Replace default with pfifo
> +    tcq replace parent 100:1 handle 205: pfifo limit 1000
> +    n_child_assert 3 "Deleting real one, replacing default one with pfifo"
>  
>      ethtool -L $NDEV combined 1
>      n_child_assert 1 "Grafted, one"