From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (unknown [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id CEA7C802A5 for ; Sat, 3 Oct 2026 13:51:13 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 693Dnr6i004699; Sat, 3 Oct 2026 16:49:54 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 693Dnr6i004699 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="M3KKbyHK" Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 693Dnoom004695 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Sat, 3 Oct 2026 16:49:51 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 693Dnoom004695 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2e305755a01so6483455ad.0 for ; Sat, 03 Oct 2026 06:49:51 -0700 (PDT) X-Gm-Message-State: AFq9FYIIaBv3yQtAtSkN90ZVR4MsUyyIHf+CBlY/Inqlbj0oomPrt8Kd UekXujfHTxG36IpbjhUYok2TJfvzYE4SlBeN1EI3sCY16zex36nAmF0b4LxVJ9T58Meu4T/megL unMybFRuZaYqRHGKvRjFoWtiBPveH2if4rNSsD2KR9Jip5vKzbm7OXg== X-Gm-Gg: AYBFou0HnY3sq/mJrYR+yDo7CQg23l8VIAj3WSthSR27QEPdwrNrsPCwkP2cbomMw3R +3VfLdKCNWF1XR7FklyTiQhFTDF7iQCzqN78GSksREV/BpS0nnb7RW06z0yeJ5tTOgQCdp3U/KL XDRP1haFo63/n/LegOioZkZqOR13M8PBdyE14YtoQE/5wiMSfCtV49iFci7OHGlE7A03m1f/yvt iXPmfa/7KL7q6CM3yesEKymJguyXRNq4pIQIXsobp2qnfjhs9GxM+twDGiy5YM/RLlTYK7+qwIP AWfoYDyw/5dVOX7M6+00fK/74OoxZntRILoQJb3/eelFRkSgBkgE2Oh3udjaun2LIBxd3OgJvm3 AzmqViX3929w2L0KRaOIiH7vXZKeZb9fXFwZ+/U/ACKzuMMOUGLxi0fXGAeqmrhF/yX3rWwyZFG 9GzqMLlzl0DuorNa3maY8871A4FCdfGZGMKQ== X-Received: by 2002:a17:903:987:b0:2e5:33a5:36ef with SMTP id d9443c01a7336-2e533a538f5mr17894225ad.14.1791035390071; Sat, 03 Oct 2026 06:49:50 -0700 (PDT) X-Received: by 2002:a17:903:987:b0:2e5:33a5:36ef with SMTP id d9443c01a7336-2e533a538f5mr17894125ad.14.1791035389556; Sat, 03 Oct 2026 06:49:49 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1791035389; cv=pass; d=google.com; s=arc-20260327; b=nA3NP3cCGN8p4SNXkUlhmwR3/Uj6r/zgXeJ00SVVa7+FS8oSwXYVNj/Y4GTkwe8I4v ekZ9zL5Yw752p1lqcqGwzvTWqB7a02ZMaEnj2agmGnKwIh8WKxY5O+URYhllk8qYR76r /WKDG7BPK/Ijq8L7qmhhdRMIOBM2wXXko0lfTSoIgKFRGr9EnL4ZyaF4B9jyNXVApUpA rJ9KP9xCCU1RcCgOdx85awF8jYBsiH7ipSJDzg9qb7WY58SmawLZLQIfNEFhygf4xMM6 UjrpISApNpp1MXAn5l3R+mq6fXWkT3Qd5Z8mS4jHdb85OCr1VwjM9Rg8s6W0o3BIxgn3 en3Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=ZGJzczXXKpU7PZhUPY2bKft25IE6ImRISV1nY1gL6mo=; fh=x+sEwlPrYjdnvyPJZgDx54RG2HGIpQh28bviCAKous0=; b=RAKcWEEGdFG20+oYUv9MBm5c6Dc0w53g+WC+y6GXVIZPx/JjH450cw6kvyEtVriern Eb7DojE1SbM9nrw5+rKElzNbDhBNd5vSZN5F+LoFhTOdwRtVlgxmZHk3puTUOSgTKHxR kYGAcagyHrn+BDa/X7ZfYmTGzBUkkg5+OTUSaw4u5CvAianJpvj90Xr7cL9/mr0IiypF fx/dMg/Ot2g4PMcFAbAVa2ALw/r07vv3Nx0ijPU0/qDUUXgbHyhNWhZxmEqr9t8z/d+l ITzcnRlvmpXAkqZtt9bVLxbHAumTi0PyLXYSggRVY1ktmiUVN0ZYOvYh5WECcfnGzolu y7bg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=M3KKbyHK; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c200::3 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazlp170110003.outbound.protection.outlook.com. [2a01:111:f403:c200::3]) by mx.google.com with ESMTPS id d9443c01a7336-2e535bb4656si47211065ad.47.2026.10.03.06.49.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Oct 2026 06:49:49 -0700 (PDT) Received-SPF: pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c200::3 as permitted sender) client-ip=2a01:111:f403:c200::3; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=M3KKbyHK; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c200::3 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xnAi48zC9wjaj9QqJ2orQx0xrkF+3cJiH4BNj6/JraITJBWDxJh0zyvcw1xxnLe/c/kPkYb0DVjpc9EnT3HQ1nAlsy//spde85m7+d8o3wNnh5HAsk2UV65sRm3BRHQKQUsVZcHYHIYMWrIXeTEyL3AoOQ5oRfVR0sP1UFkClNF69wR4crzedNR9jWFrI8/g3KEJIOHlbcb/8OBOP3usmMGWAmbx8K9olwFhJ02LcShL/Yu45gEoUPxBknnMl6HYH7eiP/swinKgSjLBAUNzkh83qKUxuF8vNaQsU+XnpmBbX4rryzCPi5HuftkdZTlqE8Jd/ZVAY3vyho0MO7mIIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZGJzczXXKpU7PZhUPY2bKft25IE6ImRISV1nY1gL6mo=; b=LQ4cDoAiPnLLa8p+Qfw4pcj/Lpb9j8l/hbipgI0q4/83xYRjDVoL3CXzs6tKlcb5OzoHCZ1+ll7bBzkbGdMUcdZJL7lMrGsx0jjeTbMFZkzDj0owuq9x948s/ih4pfdug4SeQ/hYoddhfLLKJfPP69XuHb939NJxJ4aKaceV7nAaN58mr3cgVnBzNhgzwoQBi5R3v0WjTUK3qqKUimZGW9toe6YHfkIIT03dtSNUpvKu0h3bWqOdDnhSMgJ2icdEbd6GQIQj44rWSaulZJ9+s19Uk9KOQceXXamYRUfJmp4WvBXREom21NweTUHkpqsVPmFiaDop7h476Tf/QdLXqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZGJzczXXKpU7PZhUPY2bKft25IE6ImRISV1nY1gL6mo=; b=M3KKbyHKwLHoyQUnA9MpekJcs4TKk0G1FkMx2ZWPuDoLySMDmZMOJorlLwArOr7WXwwlVp6UfTko3nXl7NlaVGEfZ1UJAWeFU63viIQlRZxJwkkgb4WCnSlIHzKIDG4BrgRlafa5LWP4ilNEpD+uI1e+dBstsPIRhJWXGfCZp419yiIPRl0IHTMkNRysBVhN9dLOLTdGdn0KKeFCsJ0+tP/uJNxCdbAYfKtTzcxdd0S1uDuRrFMBy/CwId0LBLxrYx3j09d6sCWhNzShFszD6fLTLfvEzqj7RIIhe/22EOjX+r+oEeJmprrf3UBBhfFBwzJggwYiOnMtC+vRJHXc/g== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from DB3PR08MB8962.eurprd08.prod.outlook.com (2603:10a6:10:43f::15) by PR3PR08MB5753.eurprd08.prod.outlook.com (2603:10a6:102:87::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.472.15; Sat, 3 Oct 2026 13:49:46 +0000 Received: from DB3PR08MB8962.eurprd08.prod.outlook.com ([fe80::da44:b0e3:f6ad:8f8c]) by DB3PR08MB8962.eurprd08.prod.outlook.com ([fe80::da44:b0e3:f6ad:8f8c%4]) with mapi id 15.21.0472.012; Sat, 3 Oct 2026 13:49:45 +0000 Message-ID: Date: Sat, 3 Oct 2026 15:49:44 +0200 User-Agent: Mozilla Thunderbird To: Konstantin Khorenko , vasileios.almpanis@virtuozzo.com References: <20261002-ve-printk-irq-v1-0-cb55896d455c@virtuozzo.com> <20261002-ve-printk-irq-v1-3-cb55896d455c@virtuozzo.com> <010701a0fe8bb014-8f314191-2690-436e-9abe-6b4b1c083e1d-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Vladimir Riabchun In-Reply-To: <010701a0fe8bb014-8f314191-2690-436e-9abe-6b4b1c083e1d-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: FR2P281CA0112.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::14) To DB3PR08MB8962.eurprd08.prod.outlook.com (2603:10a6:10:43f::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB3PR08MB8962:EE_|PR3PR08MB5753:EE_ X-MS-Office365-Filtering-Correlation-Id: e6639861-cfa9-4d5f-3703-08df21552f35 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|23010399003|366016|56012099006|6133799003|10067099003|4143699003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: Ll+tjXvCFK34E5aebi6/zfCL+j/5P93voDKkcpicETVF6s2oKWRAY0J8U6VwlBRj+VlkBS9jCQyMRpFKvIKKsnGZ8yGd7eWbpwpgGG+1hLctKaRPbeYvVodatK7ZDwIpLNlAc6CAg6dqHimTSPWDq9fwgWHUGYJOTJERH7hSUhwgCBhoEz8b3PQUQSfNiDCg25rh5tVjMel4pTlVYKuXQe3b9euWbdV7YJfJXqJsqG4YUdIxiKcoj0UeTpc/Hg+164DPPMDD14eFH7lfacfrN0uGEFr+434aMjfES0YojrLgIwzV6p0wOyutUbxrTcV4vw0xBLgz32gS/gjHI6mFPeo2+f+ivP6dIABw8EdBDKUKgsOaCvG5S0Je/GeVB2SCZu0SDdD5BCTd7Cm5SmPWFiFF+mvuxhGNJ8CSPgmZHdIgbOyrlZdJqO9w1XobiJxLEuKXllSwXcM1vj7xfG6FvvV1BtFxZFAnj74meSzAL6wo8fsDkhReWBqt0k1N91jk3jFwn5I6GoDXKIePW6IunfzDGOqcw1EExf8VTJjv4IclABwohRRlq1zb1CHt1uvRo2hSttZ+RtcjquA0HM7I+An/GY6guc+ZdjIFkD/zSquNbm1hk87AVdBWwd0UZYoRnLs9/r54lm80zLASJ19/x/EA0yuzHslZ9qsG52pKd9Q= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB3PR08MB8962.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(23010399003)(366016)(56012099006)(6133799003)(10067099003)(4143699003)(22082099003)(18002099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SU1SbCtseUJWK3JSNDFXR1hEZ2lSREtPbkNyS0pkOVo5UmtvKzJvYjFpNnR4?= =?utf-8?B?WmRIbFYvVUswQjBHMnh1d3dsa2NqTmt0YzVuVUVhZU0yeTdsUkVXRFp5SlJs?= =?utf-8?B?aUozMlpVeWlWZ2cramtSSHBxd2xtdVcwUEVkdS9CZ3pOZ2NhL1FmZEFoeG9w?= =?utf-8?B?NFErTzYwb3plZmNLbE5Oa0tpVUJXNmdUWnZ0UlpnWk5vakNCaXBLQmg3dHUy?= =?utf-8?B?T2REbWpXYjRMdGxIVEsrbWdkdXpsWmZyU1M0LzFBQUt3eWd1MDRHbjhnSFJy?= =?utf-8?B?OFBtUHEwbjBQUW5DUzI2T0lmUExnZlg1WFJNdElvUnZtS1hDYnR6QlU2ZjB5?= =?utf-8?B?V3BJZVVtVWMwdERaVS9wNEZNMTkzT29ROVE3RFgvS0d0L1VDZ2lyOHdpTEtw?= =?utf-8?B?VjNQRzM3aytsbFpmSXRlVncrY2FOR1NEcjVaMG9qRDQ0dFlIUnUzRCtoTURM?= =?utf-8?B?UnlpY0VwYVozd3pKSkxxZFJnWlVCM2RVZHJERnk3aTdMdlpFYmo4NTF3QThz?= =?utf-8?B?aFRBcXhRZkhkSFhsb3ZMNWo2ampPN21oZEFaNy9SM3M5M2Q1bUd6YWcrU1Iy?= =?utf-8?B?VWVuc3dFMVJHNDR1QnpLVkRsTUg5VUhRUGprV2NrWjJMWjNqRTE4WjVuQzJz?= =?utf-8?B?SHYvSU5WakwxTTFYa3VrYnBaY2tGTUdqZnEvVVhtc2MrMkJtSzRkYmZHTnlH?= =?utf-8?B?QmxIQkpJNHNFMFQ4RHpPYjNTMDZqOWNLM1ZNRHRDNUQ0d2syYkgvakFUSXAr?= =?utf-8?B?QzFLK1F4aVI4QUUzbFF2eUNwYVFDbHY1aG5rb0gxWTY4dmRwTXB4NlU1V0pU?= =?utf-8?B?WlR4cWQvT3hpVC9EYUY4R3VYRTBJdHNQS1N1cE8wbVFUUnlEem1jU2tTNU1X?= =?utf-8?B?bWNaNDc0MHdRam1RTWhTWUFXOWZ6OHR2RjNEWmpYc3BBeEE0UldoNU1vZzBC?= =?utf-8?B?OUR3N0RRTVk1YWNXT2R6VVd1aVVKVmtYSUdTdCttaFRNTkIvOXVKbFNoZ0xU?= =?utf-8?B?RGxzT3drRW8xYTUzejNTRDRZS1VqeGxTMm40UkpqbkJjZklqSUhXSE9Ib0p0?= =?utf-8?B?Sy9Qc3F0bHluNHJSUG54VUZkdUUvQmhUaTFybWM3UEg3ZlJoMlhRZVIwV1Jh?= =?utf-8?B?SWc1Nmhnd25BeWtBWFNNU3ErZnp5ektmMlQwaDFIdUZ3dVBJVDFsL2xRdU53?= =?utf-8?B?OW5ueDh5T2pwOWQyZjVkckJHelRwN3ArY3ZldVFMUDFPS2ZzNzlveURjWklL?= =?utf-8?B?cTRWSUZrZEZ5NlN1dGJObks2OEhkNlg5OXl5R1VlZXdrNVN6NTlTN0hxTkpu?= =?utf-8?B?U1ozMGtjUE9heHZsbkFVdk5JdG40U0JtUUVxd0FJVmxWTnVLalUwKytGbVpI?= =?utf-8?B?UTRoaWFsRWRQT01HaTAzWUdFZVUvdDRmRzIzUzJJYXNkQ3ROQ2dyN1RPNlBC?= =?utf-8?B?TisyZ1hTVDh4RTd4ZzMrUlJ4SGNxWnpJRkRQZ1I3NEVteFN0V0VURjVsMUJM?= =?utf-8?B?U2RocmVUZ3VhRzhqb0Z6Z2p2VGF1ZnBCSGY0eTEyT05vVVJwTGExY1J2M1E3?= =?utf-8?B?QVJDTG5Bc0xYSUhUOTJOU2x1S2NZYllpdmpKWnkzcWs0T0VUeXBpYSszWVhi?= =?utf-8?B?MUZZQVZ3WVVOMFgwZG5LNm4wVjdaaTZMY2h5UTdmNXlWcWJBc0Y0SXBKUGdL?= =?utf-8?B?MFhtYTh6UkN4bHFKSklRYm9wRkRoR1NGL05GWmxFWFRUTTVQUzdYYU1VZ2t0?= =?utf-8?B?TkxnbWpYcU94L0MvTUI0NEtZN2ZRSnFJN3Z2YTZsU0p1enpOcDg1ZVlxZm1v?= =?utf-8?B?VHVHV203eWVRQUNyZmoyMkdiMmdvSWVwTnRmTUtPelZ5Q0Z6dW51bzRYdTVO?= =?utf-8?B?aW1zUnZPTmtEOFRXeGc2S3djMFR0ZElqZTJ4WVh1dDcveVVieFliUEtPWWxq?= =?utf-8?B?ZWtiMURRMDhvczl5a2RCWmZwR053dXhaTERYWFAvd2ZDa0RHSWVaYXIveW45?= =?utf-8?B?RWJrcGc0Zk5aVzVoVjl6YS85OHY3bzd2aDliNkJkZ01KRjJ6MlliSHFDWkdx?= =?utf-8?B?WEtPczNHSnRTRmQ5V0dZNUI3RjUyYko4WklIWHc2ZW9ITy9MdHlxc2dhY3V3?= =?utf-8?B?OFlsNmJiRzJNeEk2THg5QWc3TXdlL3JhWjRZdHU3bFoxVWdjSUc4WHp1T0h2?= =?utf-8?B?Y2RRaDFjUDVnNzhJNXlBYXNEWE16VzBVSDU3TUs4Y0pCUStyenQ5R1AxZUFI?= =?utf-8?B?UUdsZFpDRXFha1gyMmFSaHVLVUVTYVFYd24wR3RBMU44eWpXQVRKQ3R2dDNO?= =?utf-8?B?MzZJQTJRT0dUQlZLSm82d1ZNenpzdUk0Z1c2cGN6NExkLzh6L1QrMTU5OGUv?= =?utf-8?Q?YdRtIAP0VAuA6vkY=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: e6639861-cfa9-4d5f-3703-08df21552f35 X-MS-Exchange-CrossTenant-AuthSource: DB3PR08MB8962.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2026 13:49:45.8937 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AO80rqmuHAcJUoZlXt0tyUOCfo6p/iyn/g1qmQNvNRTn40HmqS6AM2hXEf6F74RKN1x0qxni4s1UxYO0ojJAdAh4AkE8xPaG30JYzNp7Vv4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5753 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 3/6] ve/printk: Specify ve in printks X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 10/2/26 23:36, no-reply@sashiko.virtuozzo.com wrote: > Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider: > - [Medium] printk: host-log decision in ve_vprintk() uses get_exec_env() instead of the explicit ve > - [Low] printk: ve_printk_ratelimited() passes get_exec_env() as explicit ve, bypassing in_task() guard > - [Low] printk: !CONFIG_PRINTK stub ve_printk_deferred() keeps stale __printf(2, 3) attribute > -- > > commit 59948e2d94e2f343f89f9252383a061f24bb4a33 > Author: Vladimir Riabchun > > ve/printk: Specify ve in printks > > This commit adds ve_printk helpers that take an explicit VE, so callers > where get_exec_env() is unreliable can name the VE to log to. The > ve_ratelimit() and ve_net_ratelimit() helpers now require a VE argument, > and the netfilter callers pass net->owner_ve. > > Link: https://virtuozzo.atlassian.net/browse/VSTOR-146839 > >> diff --git a/include/linux/printk.h b/include/linux/printk.h >> --- a/include/linux/printk.h >> +++ b/include/linux/printk.h > > [ ... ] > >> static inline __printf(3, 4) __cold >> +int __ve_printk(int dst, struct ve_struct *ve, const char *s, ...) >> +{ >> + return 0; >> +} >> static inline __printf(2, 3) __cold >> -int ve_printk_deferred(int dst, const char *s, ...) >> +int ve_printk_deferred(int dst, struct ve_struct *ve, const char *s, ...) >> { >> return 0; >> } > > [Severity: Low] > The stub ve_printk_deferred() gained the struct ve_struct *ve parameter, > so the format string is now argument 3. It still carries > __printf(2, 3), while the real prototype was updated to __printf(3, 4). > > With the old attribute, GCC treats the ve pointer as the format string. > Could this produce a -Wformat warning (an error under -Werror) at call > sites such as __ve_ratelimit() in lib/ratelimit.c when building with > CONFIG_PRINTK=n? > > Should the stub use __printf(3, 4) to match? Yes, correct. Will fix in v2. > > [ ... ] > >> @@ -747,7 +761,8 @@ struct pi_entry { >> DEFAULT_RATELIMIT_BURST); \ >> \ >> - if (ve_ratelimit(dst, &_rs)) \ >> + WARN_ON_ONCE((dst & VE_LOG) && !in_task()); \ >> + if (ve_ratelimit(dst, get_exec_env(), &_rs)) \ >> ve_printk(dst, fmt, ##__VA_ARGS__); \ >> }) > > [Severity: Low] > Here get_exec_env() is passed as an explicit VE. When > ve_printk_ratelimited(VE_LOG, ...) runs from softirq, the interval-reset > path in __ve_ratelimit() calls: > > __ve_ratelimit() > ve_printk_deferred(dst, ve, KERN_WARNING "%s: %d callbacks suppressed\n", ...) > > With a non-NULL ve, ve_vprintk_deferred() computes ve_provided as true, > so this check is skipped: > > if (!ve_provided && WARN_ON_ONCE(!in_task())) > goto done; > > Can the "callbacks suppressed" message then be written to the log of > whichever VE belongs to the interrupted task? The in_task() guard no > longer protects this path. True. Will fix in v2 by passing ve0 value here in IRQ case. > > Would it be better to keep passing NULL here, or to use a variant that > keeps the guard? > >> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c >> --- a/kernel/printk/printk.c >> +++ b/kernel/printk/printk.c > > [ ... ] > >> -static asmlinkage int ve_vprintk(int dst, const char *fmt, va_list args) >> +static asmlinkage int ve_vprintk(int dst, struct ve_struct *ve, >> + const char *fmt, va_list args) >> { >> va_list args2; >> - int r = 0; >> + int r = 0, ve_provided = (ve != NULL); >> >> WARN_ON_ONCE(!dst || (dst & ~VE_LOG_BOTH)); >> >> + if (!ve) >> + ve = get_exec_env(); >> + >> va_copy(args2, args); >> if (ve_is_super(get_exec_env()) || (dst & VE0_LOG)) >> r = vprintk(fmt, args); > > [Severity: Medium] > The host-log decision here still uses ve_is_super(get_exec_env()), while > the per-VE branch below uses ve_is_super(ve). When an explicit ve is > passed, can the two destinations disagree? > > Take net_velog_ratelimited(net->owner_ve, ...) called from a netfilter > softirq path such as xt_TCPMSS or nf_conntrack allocation: > > - If a container-owned VE_LOG-only message is emitted while the softirq > interrupted a VE0 task, ve_is_super(get_exec_env()) is true. The > message is then also printed to the host log. > > - If a VE0-owned message is emitted while the softirq interrupted a > container task, ve_is_super(get_exec_env()) is false. If dst has no > VE0_LOG, the host branch is skipped. The per-VE branch is skipped too, > since ve_is_super(ve) is true. The message is lost. > > Should this test use ve_is_super(ve) instead of get_exec_env()? True, missed it. Will fix in v2. Next one as well. > > [ ... ] > >> +static asmlinkage int ve_vprintk_deferred(int dst, struct ve_struct *ve, >> + const char *fmt, va_list args) >> { >> va_list args2; >> - int r = 0; >> + int r = 0, ve_provided = (ve != NULL); >> >> WARN_ON_ONCE(!dst || (dst & ~VE_LOG_BOTH)); >> >> + if (!ve) >> + ve = get_exec_env(); >> + >> va_copy(args2, args); >> if (ve_is_super(get_exec_env()) || (dst & VE0_LOG)) >> r = vprintk_emit(0, LOGLEVEL_SCHED, NULL, fmt, args); > > [Severity: Medium] > The deferred variant has the same issue. __ve_ratelimit() calls > ve_printk_deferred() from arbitrary contexts with an explicit ve, but the > host-log condition still looks at get_exec_env(). > > Can the "callbacks suppressed" message go to the host log, or be dropped, > based on the interrupted task's VE rather than the ve passed in? > > Should this use ve_is_super(ve) as well? > -- Best regards, Riabchun Vladimir Linux Kernel Developer, Virtuozzo _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel