From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 47850803BB for ; Tue, 17 Nov 2026 10:30:48 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHATUg8008151; Tue, 17 Nov 2026 13:29:30 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHATUg8008151 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="eVogDRTX" Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6AHATSml008147 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 17 Nov 2026 13:29:28 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6AHATSml008147 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-6b57627bacaso855099a12.0 for ; Tue, 17 Nov 2026 02:29:28 -0800 (PST) X-Gm-Message-State: APuU4Z/QnF2cuSZZ2+3tFm2kNtCXlK8lJniMhdnm7BuPTXCErJ6+qvPX 74anESKWJL35n21MxTQbKWmxnkQtZrgK373hfsps8AwdesGd+TqgE9C933P40Ei0uvO0dReHWwV smx5gRJG/Y7KN6VTrEE7h20xE9axxvK3Un6plq0z1vlXirnSMCOJD3w== X-Gm-Gg: AYBFou1ABSSwSEwr6Nbx1a5OFsf8ULFhNv/N97ntjwI9GijUwchisXObACdCS27DsCU CRYz78KJoFENfK4P/XlN2y50Q0m3vig+w+iTNthRqcDDqWgbf2J65QIXhkIODiVP2btYMtFl1dS yoF4+17h38diSqbLtqR2FSCko51ZTlJ1XoLpBzRc7Kt1mpvvIldmCmzgmDBTOjM/tJGwmvg/w29 QdPNxxDnjIrLVfv/ysYlZEgntQDwC9hD/w6u9PWMyh+n68uwEREyB/Fo2qRst6uaOrk9oyFrKup rpZXMYGBsTtanPSRY/EJh1u0aQqT5RHjox4/aGxlHzPjmYoH45OyyInDoFLh37khyNz2jQ2jHYN C9luorDlzuRRgMFIpkYrcsowHQovLRWm8O9Q6V8D/O31LzQKANLR7t0AUrmz+tyRoVbsiyWN2CN wIU2aKBvMLdegDgGbtwUoTkm7HwPvNd6ih X-Received: by 2002:a05:6402:a581:20b0:6b7:834c:ebaf with SMTP id 4fb4d7f45d1cf-6b859b361bdmr1328713a12.12.1794911368183; Tue, 17 Nov 2026 02:29:28 -0800 (PST) X-Received: by 2002:a05:6402:a581:20b0:6b7:834c:ebaf with SMTP id 4fb4d7f45d1cf-6b859b361bdmr1328695a12.12.1794911367689; Tue, 17 Nov 2026 02:29:27 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1794911367; cv=pass; d=google.com; s=arc-20260327; b=NPjIRU6K/GMVgvNaNfTN/Ez4zlNdMPJnEfeAMpqIv7TJtLPd258/uK3R9wY7iJXkyG oOaZJvRpuBKlZRDm1hTQEQjSq8KbCqVvphb8PZT2B7j1+an1pcdXdFPYLwV1DWHBlYLJ n0rfW08ORdqbgI9O/b5SjSy/X7DEaoFT+yVWQmKwp+qs9lF2UV6BxnHxIm98fPIejvQH oqzWkMHnvNNZfvvtrAUinRoeaxHWiqMtA/cGkuV/+pzCuwEn1kle3gVyC3uZr92DtEs4 wi1dx1QKkPZVf1EX9zaloqAyf3XaHw7cOAgca327onQrSWP3X3wha+qDcnO9hZVPUxGT 29Cg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=JMAvsin8sd/pHKw7MeDk4ubEcHBB85WtXDInkEAJ3KE=; fh=wZwd5yRbW8HRNLtAnbjmPgrqfPdwPW1GvOQXIFYLV2Y=; b=OFbirhE/uuY/urGubV8OpfLJPvnKr4XGDySjFaCwjFr3VavI5L+isswYrJRkuZbr68 RjucUYJsZEjdyysBMZwyCxLXslGNfeP05UDasWveOb/s9lxWmx3rVZrQ26AW9AgjgDBc F8i96fHikJziMGCTBwPIqbI/6qrA21SknE5dyjSwuZrYIVbGNKF41VTscd+JFODMcxPB zx9sMEHCZr+SH3uTNwetohUBbGvIDhrSwG9IEUU12GAVoefIodWQFZNFS59IMSO6UP1c Ta4X1NMhKyoM6CzhJDS1l256Z0cWdb2+V7T5NpcTBpsK/1w3FZUjnqrMs8mYsyZF+DEx JVUw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=eVogDRTX; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 2a01:111:f403:c201::6 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazlp170130006.outbound.protection.outlook.com. [2a01:111:f403:c201::6]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-6b863e99e2csi1483296a12.148.2026.11.17.02.29.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 02:29:27 -0800 (PST) Received-SPF: pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 2a01:111:f403:c201::6 as permitted sender) client-ip=2a01:111:f403:c201::6; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=eVogDRTX; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 2a01:111:f403:c201::6 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qb0JC/d7Zl17RX46Fx8dAAltP5aKmUC7sxhdNNjw1rVjbByZlPlBQHgykf796pQQjNxOdm0wP8UJuh2rwqyP6IoUzsj1R7ISuPRi3EYAfQ3iOr3Co7HmQ/Ye65LWrJhI/5WF2l5SMPxWCaBbw84spowmFvL4NFYDpitvMdXZPpbMGmhNBPEj2dzhg5mu92FxGqJSHZMsg2a/fdIl5CLRcsh3hYW0L0wArG3DeAXAiCubTtcrDxDy1XSod3qv91OKh9MA+k2ozqhtoO+VLx1lvLVI+Db///MhvREZUXSoRQfNoyxQzMHdOhU9DR2Rcst1JX3Kn3/wf0xrexXkXVk0lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JMAvsin8sd/pHKw7MeDk4ubEcHBB85WtXDInkEAJ3KE=; b=dpjPf2kzP7IfjzWQWhzTj4HWHM/U2awdMp6lpuKMsJiEIQu9y52cuBHQwOIjKNJcxT9QY/Ad2+2FTFtJ52Q6AeDkyVkP3qew9l6ZXLEmG6fFxlcCa9q0XYTR28iUpQs2OVkzF68AivzYyleU6SbDC/AygkXa+poFKcayjVdgBYjK0R4TuO4EzF/C0qd98S5MajcA51DozHD+8LoL0eNpgGFFO1LujEN//lHJj9ChQwLI0416sGWuJ67bCqOeS8UcpLNULTCQcxbx5PU3BDLt42d0Rr6kKt3RJeAgtx5E9leGnOCnFROHsBFHZI8KFLcenAqvZSpJHN9+oOqdfa37tQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JMAvsin8sd/pHKw7MeDk4ubEcHBB85WtXDInkEAJ3KE=; b=eVogDRTXeSDmnZn0VptYgpnWGPzn/AQKCrwgLhFZp2lSQqPOSWEgpSrO/G0Ye1nBNIp8u+IyGFe8H9GwVnDCDL/gpxbk+SgcWnVHROHSKZKFcPzzpL4B/WAT49IC91UER0JfBLsXNoNNMuib0SRQ3i7rkSWjaP3wlGpXlrmdPNpQeWKCxL2t573HZfnP2p63JlHNplLrTBI0l2yOMGHtvWex5BnCR8OWaULT5oH06JifNOu0h7tJUwEekT7gpWzOUlQ0iP2VSfxuql4KHncwUx+w1S9oPtLNbDSE7nDwyPCNOyCANUv3CDDV6gwAD/vLDNtLxpRx9KMcYPvdHrhEKw== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from PA4PR08MB6061.eurprd08.prod.outlook.com (2603:10a6:102:e9::13) by AM5PR08MB201416.eurprd08.prod.outlook.com (2603:10a6:20b:7d3::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.615.14; Tue, 17 Nov 2026 10:29:25 +0000 Received: from PA4PR08MB6061.eurprd08.prod.outlook.com ([fe80::c3bf:e107:b1d2:6a00]) by PA4PR08MB6061.eurprd08.prod.outlook.com ([fe80::c3bf:e107:b1d2:6a00%4]) with mapi id 15.21.0615.013; Tue, 17 Nov 2026 10:29:25 +0000 Message-ID: Date: Tue, 17 Nov 2026 11:29:24 +0100 User-Agent: Mozilla Thunderbird To: Konstantin Khorenko , Pavel Tikhomirov References: <20261105-b4-prep-khorenko-vstor-153709-dm-ploop-drop-the-lock-of-local-md-pages-v1-1-82fed22d5591@virtuozzo.com> Content-Language: en-US From: Andrey Zhadchenko In-Reply-To: <20261105-b4-prep-khorenko-vstor-153709-dm-ploop-drop-the-lock-of-local-md-pages-v1-1-82fed22d5591@virtuozzo.com> X-ClientProxiedBy: FR2P281CA0001.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::11) To PA4PR08MB6061.eurprd08.prod.outlook.com (2603:10a6:102:e9::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR08MB6061:EE_|AM5PR08MB201416:EE_ X-MS-Office365-Filtering-Correlation-Id: b1ab363d-05c2-4a0f-051c-08df4495a720 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|23010399003|1800799024|366016|376014|261102123227099003|261021123027099003|261021121427099003|261022075727099003|5023799004|56012099006|10067099003|18002099003|22082099003|261009223027099003; X-Microsoft-Antispam-Message-Info: 8BzMY392NmG+HkGK1f0VGbAPl4XQfqYN4Y33OfV70wihBfsIJSFj6u58pq/qIzzbCdqV7m8MyOSkWqBNsausmBqikc+CYrcIJrVRb0eS/TNqjEZ9iVneevHGUCzMalFinD1eIsOm1f6cR7NTr99w/QPeSDQ7P23LxnYS96KMn4Hr/RiODXCnak67rb+fBoEl/ucRHud26zTc2/0XM9Nybe5Psr3QYjVklkU9L7e7YqGivGf/D2lr9Y/EN+BnBgcddRBKzWUF8akU0GP6Jo4PHQw828uyE/qGI2C9NVVKKauWswKL1wJbUTpuwLk9/7jElDVZoZJGmK9BQd/MRdRAf6crQf8TtDtDrvcrA1rVHFyqiyN4H91EMJV9E2rxKeVxNFi0VVVoHW20kQTeuFcF0h21WoqvcsFb/uvmeR7ldxuSlzTpeSVtoaS/k/EQoVpwCjrOnKYABjYqioC17+/Xob4dh+lAcP+qX703+Pkt+cA1xk+ODYpN3RI+2mE7G/2+KGzpdN+raCcstwyH/pJW5oNtbDxscrYDcZ6yUwuKGtkmVAM7UHqMMwdmVPjCEMPUSqD/YhNd6VuxhOPJuHqzBSzBfI8QZzThr8l9e9dieIxHV5FVAcML14LrpX2ky5JB X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA4PR08MB6061.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(1800799024)(366016)(376014)(261102123227099003)(261021123027099003)(261021121427099003)(261022075727099003)(5023799004)(56012099006)(10067099003)(18002099003)(22082099003)(261009223027099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TW1mamIwYVlzUlE4OGRmbWZVLys1cXdQT2xNL0txQ2NiSVlsNExwbTJsWUFO?= =?utf-8?B?TVlGbG9aM0N3ZXA4SzY2YjRvVk1vaHRYMkRWQ3JiM05hWVBuQVFKZ1RWTWcz?= =?utf-8?B?MmcxMDBTbTBnbGsvTTF1OVp2dk1sL2tpSUVVLzYrazM1eVFQRCtBb1hKRktH?= =?utf-8?B?V2UyaWRaWWdTN0FUYTNlblQwQkljTWExdU1zemdrTUh2L253UTcyZk1RU2xs?= =?utf-8?B?QU14THczWjdFWjhacGo1dmxjYzNxK2d1MTRyMmk3SmhsRWM0RE9uci9CV2o1?= =?utf-8?B?UjBUOWJDK25RSytoMERKNno0ZFZEOG8xZHQ3LzBUR2dmWXVWdi9RdE5LVzVK?= =?utf-8?B?Z3BIOGpOaDlSSWtJK3Ird290UHg0MWx0Z3k1V1R3ZVFMcGNXbTJUSld0bVVK?= =?utf-8?B?VW5qdnhwNkpyd0lsK05mTEJkNy8rbEhLQTkrdXI1aTlmeVZDRURvL2VXTVBR?= =?utf-8?B?QXdNV3h0WTJoUURaSFlUa2RwT0xyaU9LSXFORzFKUHdBZUdXcXRPRVNnejc3?= =?utf-8?B?SDQ5dy9IdWN0aEREWUZBenhUWUdKRmk3QlVjTTVlT3J0QVhDUHNZa2ZRU2px?= =?utf-8?B?QVM2SkdkQ2tPazhmaUhnTVBnSkh0bFBoN0Uzb1E0czFMWS83QzFzTXBMNVEx?= =?utf-8?B?QWdHSmdtT1M2d0lBdW52dXBEVVowOUhsSERJWmswMXZhN0tkazRMKzdRekJn?= =?utf-8?B?YldJSnZrNFNHSlZqejFNQURlcFlvbURPOWpJMUJZRlJMMEJWdHJkeHp5dC9M?= =?utf-8?B?RGpjUCtyNkVaTE5kcEJrQjBRZC9XT2pLNUpiTmJZSkJYb2xVcFp0RXpKM0lE?= =?utf-8?B?bVZNZFJzaFAyVzQwMWpZU2FzdW0zbXU4dG1EYmVlT2VsbzMzMy9VdzBjbFdh?= =?utf-8?B?MFZqSVNwV0ZIT2ZoRFFZK1pUd3pybXFVck1hbDc4UXRSVzlDUmFJeE02V1F1?= =?utf-8?B?cFJFdmlINGs1RWoxbXdXNWY1V2tnVGRGZWRKb3ZkWmhxYjllL1JkTDZyVUJs?= =?utf-8?B?aUh2ekRtbmRHc0Y4bXB5Y0w2dllXVS9lT3BxQVd6WWN2RjR5QUcxNXpMTXRq?= =?utf-8?B?WWtaMVMxSHFLb01YOFZzV2czSTNLaG5NUjlWVTJKYVU5RFdQOWsremUrWHJz?= =?utf-8?B?WnM5TmRKT2ZEL0Z3WGJaUmJzQjNCTGYxWjlsYlp3V0ZpamhWUWRxbCtRdEtZ?= =?utf-8?B?NHhWS1J4ZkFDQ2I3TFdiOUNYZjlvd0hsTU5TbDdvZXF1QWRJZUx6dFc4TkVo?= =?utf-8?B?Wnk2Znh3V21mVldBUzFwcDNHK1ZzYWNVQXdURnhUSlNmU1FIUUVGdXdkYlVw?= =?utf-8?B?aVB4U0NKQktLbkFHQXdoTXZBVW01UWNwU0VmUXU2NllseFZST05EQzNzQlBh?= =?utf-8?B?NklONGFQWkVoM3hobDdvYzRuYXptQmNrV040dktiTmFMVld1bCtySzhYUmVx?= =?utf-8?B?NWx5YmhPbStSWDlJczZvME13UW1lMjcxcGpzYVladkZlQlFHU0dURCtWdVY1?= =?utf-8?B?ZE96dWtVUGFuZVA2RGpITUlKMHNCUWhTVUxTcUNFQ29ZVnYvRVRRQUdGemhK?= =?utf-8?B?cDBWUnR4dk5Ja083YkpwOGtHSDMvYm40SEtUV2d5Q2RUUkI4SENVVGxuckZl?= =?utf-8?B?NTdTUkpNdlJ3cVhqYjZGRXJIbG5ONHlPcXhEUVoyTEJkY2FJclBsS0daTnkw?= =?utf-8?B?ai9rZ1NKMWRxR29xd1MwamRHMXRpcmFTeEdIOFBDWWxXUWYxd0JoQ21GYlc1?= =?utf-8?B?ZnE3K2phdjNIWU5vdHVZTSt1MnZtUkcxVnZld2s5aStBc0pCc29RRThmT29z?= =?utf-8?B?WjJ0S3F5Qkx4N01ndE1YalFJVGdPVkExNXA4NE9tLzZ2eHNncTVnbGw3NTVl?= =?utf-8?B?QURqVlpEUFpaaWtrMVNWenFZS3JiWlFmWDJCSTlIMlVNSmFoeTNDRFhWdVZZ?= =?utf-8?B?NmNBSDFlektTQVVqSlZzaG9VYzg5dTFsK293R29ycVB1SGcyYTNvKzFqUFc4?= =?utf-8?B?NHh5YkRwdWR3c2JIbVdoYmpaM1ZTQWhHWW9FSGI5elhvaHhVWUkwbmZkZ3d4?= =?utf-8?B?NDlpTlloazBpN1FTMEU1R0Exak5IdCsyMzkvSnl0Yy9Ub0pUai9MQTZYT3NM?= =?utf-8?B?cm1vKzQrVy84YmowTXJwZGpLa3pndnZXbGMrQTdVbHpnKzkxek1qS1JscUtZ?= =?utf-8?B?c0xheTNDa1A2ZDF6NzJERjcwcFdBMjRUeUNwS01TQnYxVktLSU5ZckdQN1Uz?= =?utf-8?B?ZjFseVdXeTJtY1NZcUQxUnphR0ROR1QwS1ZKV2tIZXVWaE8yb3JjTzhsTHU5?= =?utf-8?B?RzNWUHB1cml1NXpvakhuNmQrY0txTFE5a0RKM2V3ZklFUUpraWxJNC9CbmNC?= =?utf-8?Q?MJo62yYtH5i6adQI=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1ab363d-05c2-4a0f-051c-08df4495a720 X-MS-Exchange-CrossTenant-AuthSource: PA4PR08MB6061.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2026 10:29:25.6681 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xqyHnC4JqfxrnQbhZBx9NmZr7537py4meYzi0R3ySZQqzFTfdjVDJZLmDcYuvlLZYXBWMXJS1rc57uGtKQWjxzU2+2mqGAm8dh1uF6/SWX8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR08MB201416 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1] dm-ploop: do not lock the md pages of a delta read for a BAT walk X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Reviewed-by: Andrey Zhadchenko On 11/5/26 20:17, Konstantin Khorenko wrote: > notify_delta_merged() and ploop_check_delta_before_flip() walk the live > BAT together with the BAT of a delta that ploop_read_delta_metadata() > read into a local md tree. For each page they take the md_lock of the > live page and then the md_lock of the local one. > > Every md_lock is initialized in ploop_alloc_md_page(), so both locks > share one lockdep class. With CONFIG_PROVE_LOCKING the first walk > reports "possible recursive locking detected", and lockdep turns itself > off for the rest of the boot. > > Only the cmd that read the local tree can reach it, and it frees the > tree after the walk, so its md_lock protects nothing. Stop taking it. > > https://virtuozzo.atlassian.net/browse/VSTOR-153709 > > Fixes: 0d4b4d0a20a9 ("dm-ploop: introduce per-md page locking") > Feature: dm-ploop: ploop target driver > Signed-off-by: Konstantin Khorenko > --- > This obsoletes "[PATCH vz10 10/24] dm-ploop: annotate nested md_lock in > ploop_check_delta_before_flip()" of the VSTOR-137234 selftests series. > Pavel pointed out that the SINGLE_DEPTH_NESTING annotation works around > a lock that is not needed at all, and that notify_delta_merged() has > the same problem. This patch stops taking that lock in both walks. > > Assisted-by: LLM > --- > drivers/md/dm-ploop-cmd.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/md/dm-ploop-cmd.c b/drivers/md/dm-ploop-cmd.c > index 2d1fa449b052d..f6135e07c2737 100644 > --- a/drivers/md/dm-ploop-cmd.c > +++ b/drivers/md/dm-ploop-cmd.c > @@ -812,7 +812,6 @@ static void notify_delta_merged(struct ploop *ploop, u8 level, > d_bat_entries = d_md->kmpage; > > spin_lock_irqsave(&md->md_lock, flags); /* write */ > - spin_lock(&d_md->md_lock); /* write */ > for (; i <= end; i++) { > clu = ploop_page_clu_idx_to_bat_clu(md->id, i); > if (clu == nr_be - 1) > @@ -846,7 +845,6 @@ static void notify_delta_merged(struct ploop *ploop, u8 level, > WRITE_ONCE(md->bat_levels[i], level); > } > > - spin_unlock(&d_md->md_lock); > spin_unlock_irqrestore(&md->md_lock, flags); > > if (stop) > @@ -1147,7 +1145,6 @@ static int ploop_check_delta_before_flip(struct ploop *ploop, struct file *file) > d_bat_entries = d_md->kmpage; > > spin_lock_irq(&md->md_lock); /* read */ > - spin_lock(&d_md->md_lock); > for (; i <= end; i++) { > if (ploop_md_page_cluster_is_in_top_delta(ploop, md, i) && > d_bat_entries[i] != BAT_ENTRY_NONE) { > @@ -1156,7 +1153,6 @@ static int ploop_check_delta_before_flip(struct ploop *ploop, struct file *file) > break; > } > } > - spin_unlock(&d_md->md_lock); > spin_unlock_irq(&md->md_lock); > if (stop) > break; > > --- > base-commit: f0cff9cebdb0d481d05b02bdb7bdafe864adca1c > change-id: 20261105-b4-prep-khorenko-vstor-153709-dm-ploop-drop-the-lock-of-local-md-pages-4f25ac778924 > > Best regards, > -- > Konstantin Khorenko, > Virtuozzo Linux Kernel Team > _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel