From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 06AEB80BB3 for ; Thu, 22 Oct 2026 20:28:43 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69MKRMNr016672; Thu, 22 Oct 2026 23:27:24 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69MKRMNr016672 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=default; t=1792700846; bh=oQHXrU/ajzibmr9fjns/0DOC2eJh5X2o33lAYsnvsZg=; h=From:To:Date:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe; b=DlXBGPutGqR00BI2gJI0si8bcVTIOVXdVaPvPcOH/lZ7DLTRAyAMYCVXW/mbpeBbE 3SOMxGxMaa9UvaFJFOGwPjDrNIdEkSeUQEJQBPsSolE5ymkFo+he4XW7mZ9PAn4Il7 63XP7rMGWnCO+QocYi9JcBOlbcz/xiUPamTotOfrGJQPasjysBQMJZ22Vz3pmgMV+s 5TlI09cZzYKGYhsg10fClbUS5w1kTOp48V80DfkFpuufhX5EuVa7ALoxaFbWIlQfKO AsH9yv+JzBBO/kspQ1DxrOpp4xMx3J0QucHy99+htBUJgVfeYjqvSMWIK5l74f+Jle sEzY5pXqcvhqA== Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69MKRKlJ016662 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 22 Oct 2026 23:27:20 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69MKRKlJ016662 Authentication-Results: mail.openvz.org; dkim=pass (2048-bit key) header.d=openvz.org header.i=@openvz.org header.b="LebMozuC" Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4a028616bebso1186025e9.1 for ; Thu, 22 Oct 2026 13:27:20 -0700 (PDT) X-Gm-Message-State: AFq9FYKFibXtDQ13AxMYnNLfhisujE2ml98RaqleHu8Szus7OigcGnTH c8QemuX4Ei4JxiqCBZqXIqH6aD4I65jGAkf2tq8sczhjzJ0MZPWOH+Ng3jlGxIMEkg5qSIvQ08X luPFmp55R4+ePFqxuk95/HDF/SS03my1Y3mwpGA2ryhDqsaV1tWichg== X-Gm-Gg: AYBFou3Y7CRl0OpGq6S8t5sr9pwoQvVKRuectrooRPXowtGN5WJpFzcIMK9mmI5S4uy 0kgzXLKBbYJGQYAYOfmR9idvprJIDqYbzDEawXVa6JlN2iV2pziL6/ntS0LGk4tZduSU3W6Y4C5 UhR4UCZQGamM9oorOB7UjOQ8fiq1hJBOnCoYtM7RvGghxgqlQeLFhq+jXMLTLPZzmAjcgF5syWa oWLvEvWImibtRXuwIL7HkopC7Blav++SVX92fLBNKltnbcCURH5MEnEPKJqVIBza4vBtvGhh/eE WASg6r8QEg== X-Received: by 2002:a05:600d:82f1:b0:4a2:803:a3c4 with SMTP id 5b1f17b1804b1-4a211ce3d43mr2981285e9.13.1792700840269; Thu, 22 Oct 2026 13:27:20 -0700 (PDT) X-Received: by 2002:a05:600d:82f1:b0:4a2:803:a3c4 with SMTP id 5b1f17b1804b1-4a211ce3d43mr2980985e9.13.1792700839703; Thu, 22 Oct 2026 13:27:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1792700839; cv=none; d=google.com; s=arc-20260327; b=Yy4hyX+3RdEk+oqIrV7miXvdZ+QK/QSPJj9P1zUBS6+rMsRIWFGMblbtWP1oNIbgqv RvjTiWYz6Qowyi+8fKaasQPMR30nNWotYJfln8X6IxUxH5N6myQEm77gRHkZGu2RyxGX Fg3Eial7qu9b0q6hNaKYlyWuoPg3lAfQiKoBcU4RBUrOEOgx1h671velwI28Q1OZgEJA unVMw34p+mt56qd5NM0aytOq1i2L1SIaupoCHAEbMDWF9nkpSXwTawsXFmh75jt7+2QB KlfebIlHjgFYc51P0tRr2iJugE4a8e97sbJaA+vEC+O9oohutBIcEgnG22994aHkWTQF QkEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=YsMmhKv4n4gasj6OiMbXLToPQ/YKWpaVJ2W+lb08hfU=; fh=9uh4XaPpgi4eEAsqC4+SeZyHNzLz7ufStPU27zuFNdo=; b=lGGV/WArH9s978pTVoePn354j49tOT5h39sx5zp465dnAm9HjHT1ZWXoIHziuFwdKE LUYkNR/KGbJUYvfFSCyu5SYeylmdG4gE5aX7S8brmhjdhcru8J0ra7AG4LLDmwS2ENFb TyjWov6x669CCjuf6Cplm3XDXP+mSHCfi/YOK3eFzUsJcUQuS/mIh853eMWvBhLK/JTp 15jvkohK/4GuLwNb7j3DV7YFHivX/EoogcJBpd23lNCqD2KBdnCNqv4vF6aDzhG2lFRY uIyer57KXDXqYYYTMq6zwNFTKtiiZ6SfB5cnFxTY4TId1iO+yprEgfdy7GrEiVaPsHUS 8wgA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=LebMozuC; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:3c49:8d18:710e:ef45 as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id 5b1f17b1804b1-4a211be42e4sor430305e9.11.2026.10.22.13.27.19 for (Google Transport Security); Thu, 22 Oct 2026 13:27:19 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:3c49:8d18:710e:ef45 as permitted sender) client-ip=2a06:5b06:b600:300:3c49:8d18:710e:ef45; Authentication-Results: mx.google.com; dkim=pass header.i=@openvz.org header.s=google header.b=LebMozuC; spf=softfail (google.com: domain of transitioning den@openvz.org does not designate 2a06:5b06:b600:300:3c49:8d18:710e:ef45 as permitted sender) smtp.mailfrom=den@openvz.org; dara=neutral header.i=@openvz.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz.org; s=google; t=1792700839; x=1793305639; darn=openvz.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=YsMmhKv4n4gasj6OiMbXLToPQ/YKWpaVJ2W+lb08hfU=; b=LebMozuCXtOmmIn/2K3POba+lfURlFQpLTSSDlVR6/QhVvm6UZWocZsd6dR+vk9fRm OK7lu/rhA9SHKtEeG2rGIjTcWr9OPiErk9jMw4vRxIaLG2Yx3S/QRWP6DQU34MXyy3yk K666o0oLWpoGJpz2znZ20ui+3GOz1Y4Zp0tL/5ezvAy5ZkDBsrOR830r1sSMOvtkmK5p xpFZjqqol14OjS4S14kycp2SIUjZk3Go5XiCIqsZ5/B0NrbHXqLOkJfqgfxgvykMGbZf ZnEoRpev4ce3+ZSrgkhciWNGRA/Sb3yKQrTrQoGcODqukjqn0NlbARHlhOS0fob/93LZ wC/A== X-Received: by 2002:a05:600c:1c1b:b0:4a1:dda8:eb73 with SMTP id 5b1f17b1804b1-4a211ee94b4mr2571015e9.27.1792700839183; Thu, 22 Oct 2026 13:27:19 -0700 (PDT) Received: from athena.sw.ru ([2a06:5b06:b600:300:3c49:8d18:710e:ef45]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a21047b524sm21261065e9.14.2026.10.22.13.27.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Oct 2026 13:27:18 -0700 (PDT) From: "Denis V. Lunev" To: devel@openvz.org Date: Thu, 22 Oct 2026 22:27:14 +0200 Message-ID: X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 X-OZ-Fwd: true Subject: [Devel] [PATCH RK hci-7.4 0/2] fix node crash on RK replace: pcs RDMA handlers left in the unloaded RK X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org Replacing RK v8.51..v8.53 on 5.14.0-427.106.1.vz9.90.3 crashes nodes with live pcs RDMA connections on the next CM event of a connection opened under the replaced RK (ASUP-3835): BUG: unable to handle page fault for address: ffffffffc170ef30 #PF: supervisor instruction fetch in kernel mode RIP: 0010:0xffffffffc170ef30 cma_cm_event_handler+0x1e/0xd0 [rdma_cm] [last unloaded: kpatch_cumulative_8_51_r1] TRACE() embeds __LINE__, so the VSTOR-141673 hunk ("fix RPC response drop for large messages sent over RDMA") drags every TRACE() user below rio_handle_tx() into the RK, pcs_rdma_create() and the RDMA event handlers among them. The patched pcs_rdma_create() then stores the addresses of the RK copies of the handlers in rio->id, the CQ and the QP, and the RK's KBUILD_MODNAME as restrack name of the PD and CQ, which the MRs inherit. "kpatch replace" unloads the old RK right after the new one is enabled and all of these dangle. Patch 1 keeps the line numbers stable, so these functions drop out of the RK and new connections get the fuse_kio_pcs originals. Patch 2 repairs connections opened under an older RK from a post-patch callback. Afterwards nothing points into any RK, so a later replace, an unload or a downgrade is safe whatever the next RK contains. Both are needed: without patch 1 the callback would resolve the handlers to the RK's own copies. The series goes on top of kpatch-patch.vzs 5.14.0-427.106.1.vz9.90.3-v8.53, after 0002-fs-fuse-kio-fix-RPC-response-drop-for-large-messages.patch; the #line values are computed for that state. Patch 2 has to stay in all later 90.3 RKs, since nodes may jump straight from v8.51..v8.53 to any of them. It is idempotent where there is nothing to repair. Tested on a 90.3 node without RDMA, built with kpatch-build 0.9.9 from the kernel SRPM and the RK config: - pcs_rdma_io.o contributes only rio_handle_tx() and rio_handle_rx() plus the fixup; the handlers reach the module only as klp relocations against fuse_kio_pcs; - no code in the module stores or hands out an address of the module itself, apart from the TRACE() format strings below; - atomic replace over the shipped v8.53 leaves rio_handle_tx() and rio_handle_rx() as the only redirected pcs_rdma_io.c functions, removing v8.53 and then unloading the new RK are clean. Repair of live RDMA connections is not tested here. https://virtuozzo.atlassian.net/browse/VSTOR-151314 Cc: Vladimir Riabchun Cc: Konstantin Khorenko Signed-off-by: Denis V. Lunev Denis V. Lunev (2): fs/fuse kio: keep pcs_rdma_io.c line numbers stable in the RK fs/fuse kio: repoint RDMA handlers and restrack names on RK load fs/fuse/kio/pcs/pcs_fuse_kdirect.c | 88 ++++++++++++++++++++++++++++++ fs/fuse/kio/pcs/pcs_rdma_io.c | 46 ++++++++++++++++ 2 files changed, 134 insertions(+) -- 2.53.0 _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel