OpenVZ / Virtuozzo kernel development (devel@openvz.org)
 help / color / mirror / Atom feed
From: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
To: no-reply@sashiko.virtuozzo.com, andrey.zhadchenko@virtuozzo.com
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 v12 09/12] dm-qcow2: leak clusters allocated for a failed L1/L2 writeback
Date: Tue, 10 Nov 2026 09:25:36 +0100	[thread overview]
Message-ID: <d241fb3c-6756-4359-bd65-2738c7448962@virtuozzo.com> (raw)
In-Reply-To: <010701a1c47c8dca-09b0fc20-e2e2-4379-83d0-009e1c0d80d2-000000@eu-central-1.amazonses.com>

>> +		list_for_each_entry(qio, &end_list, link) {
>> +			if (qio->ext)
>> +				qio->ext->cleanup_mask &= ~FREE_ALLOCATED_CLU;
>> +		}
>>   		qcow2_dispatch_qios(qcow2, NULL, &wait_list);
>>   		end_qios(&end_list, errno_to_blk_status(wbd->ret));
> [Severity: Medium]
> The commit message says "Check frees them, so the image needs no check and
> resume needs no refusal." Is that accurate?
>
> Once revert_l_entries_update() no longer calls mark_cluster_unused(), the
> L2-table cluster (for an L1 write) or the data cluster (for an L2 write)
> allocated in prepare_l_entry_update() keeps its refcount. The same applies
> to COW clusters, because complete_wbd() clears FREE_ALLOCATED_CLU, which
> bypasses handle_cleanup_mask()->mark_cluster_unused().
>
> Nothing seems to report this leak. clear_writeback_status() sets
> MD_WRITEBACK_ERROR only when !md->wbd, which is not the case on this path.
> There is also no QC_ERR message and no counter, so wants_check and the
> status output do not tell the operator that a check is needed to reclaim
> the space.
>
> With persistent write failures and guest retries, each failed request
> leaks one more cluster. Leaked clusters also stay counted as used, so the
> used-end tail truncation added later in the series cannot shrink past
> them.
>
> Would it make sense to log the leak, or to flag the image so that a check
> is requested, and to reword the commit message accordingly?
A leaked cluster does not corrupt the image: nothing on disk points to a 
free
cluster, and no two offsets share a cluster. It is the same harmless 
leak that
qemu-img check reclaims during any check. Setting wants_check would bring
back the resume refusal that this commit removes. The message already says
that each failed request leaks one cluster. A separate log message adds 
nothing,
since the guest already gets the write error.
>> diff --git a/drivers/md/dm-qcow2-target.c b/drivers/md/dm-qcow2-target.c
>> --- a/drivers/md/dm-qcow2-target.c
>> +++ b/drivers/md/dm-qcow2-target.c
>> @@ -173,10 +173,6 @@ void qcow2_flush_deferred_activity(struct qcow2_target *tgt, struct qcow2 *qcow2
>>   	struct md_page *md;
>>   	int i;
>>   
>> -	/*
>> -	 * We need second iteration, since revert_l_entries_update() may start timer again after failed wb.
>> -	 */
>>   	for (i = 0; i < 2; i++) {
> [Severity: Low]
> This isn't a bug, but the comment explaining why the loop runs twice is
> deleted while the loop itself stays.
>
> mark_cluster_unused() is still reached from handle_cleanup_mask() with
> FREE_ALLOCATED_CLU, and process_indexes_end() still dirties R2 pages. Both
> can re-arm slow_wb_timer after the first pass.
>
> Could the comment be rewritten to state the remaining reason for the second
> iteration, rather than removed?
The loop itself explains why it runs twice.

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

  reply	other threads:[~2026-11-10  8:27 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10  7:51 [Devel] [PATCH hci-8.1 v12 00/12] dm-qcow2: truncate unused tail of image on suspend Alexander Ivanov
2026-11-10  7:51 ` [Devel] [PATCH hci-8.1 v12 01/12] dm-qcow2: add qcow2_md_page_read_sync() helper Alexander Ivanov
2026-11-10  7:55   ` no-reply
2026-11-10  7:51 ` [Devel] [PATCH hci-8.1 v12 02/12] dm-qcow2: drop duplicate prefix from QC_ERR/QC_INFO messages Alexander Ivanov
2026-11-10  7:55   ` no-reply
2026-11-10  7:51 ` [Devel] [PATCH hci-8.1 v12 03/12] dm-qcow2: extend the file for a new refblock in allocate_cluster() Alexander Ivanov
2026-11-10  7:56   ` no-reply
2026-11-10  7:51 ` [Devel] [PATCH hci-8.1 v12 04/12] dm-qcow2: complete wbd before ending the data qio Alexander Ivanov
2026-11-10  7:58   ` no-reply
2026-11-10  7:51 ` [Devel] [PATCH hci-8.1 v12 05/12] dm-qcow2: flush lower md before clearing dirty bit on merge failure Alexander Ivanov
2026-11-10  7:58   ` no-reply
2026-11-10  7:51 ` [Devel] [PATCH hci-8.1 v12 06/12] dm-qcow2: keep the dirty bit of an image that needs check Alexander Ivanov
2026-11-10  7:59   ` no-reply
2026-11-10  7:51 ` [Devel] [PATCH hci-8.1 v12 07/12] dm-qcow2: flag the image for check if reftable relocation fails late Alexander Ivanov
2026-11-10  8:00   ` no-reply
2026-11-10  7:51 ` [Devel] [PATCH hci-8.1 v12 08/12] dm-qcow2: fail the L2 table allocation request on L1 writeback error Alexander Ivanov
2026-11-10  8:01   ` no-reply
2026-11-10  7:51 ` [Devel] [PATCH hci-8.1 v12 09/12] dm-qcow2: leak clusters allocated for a failed L1/L2 writeback Alexander Ivanov
2026-11-10  8:04   ` no-reply
2026-11-10  8:25     ` Alexander Ivanov [this message]
2026-11-10  7:51 ` [Devel] [PATCH hci-8.1 v12 10/12] dm-qcow2: retry R1/R2 writeback that failed with ENOSPC Alexander Ivanov
2026-11-10  8:06   ` no-reply
2026-11-10  8:31     ` Alexander Ivanov
2026-11-10  7:51 ` [Devel] [PATCH hci-8.1 v12 11/12] dm-qcow2: truncate unused tail of image on suspend Alexander Ivanov
2026-11-10  8:07   ` no-reply
2026-11-10  7:51 ` [Devel] [PATCH hci-8.1 v12 12/12] dm-qcow2: fix WARN in qrq_endio() on flush failing with ENOSPC Alexander Ivanov
2026-11-10  8:07   ` no-reply
2026-11-10  8:35     ` Alexander Ivanov
2026-11-10 11:42 ` [Devel] [PATCH hci-8.1 v12 00/12] dm-qcow2: truncate unused tail of image on suspend Konstantin Khorenko
2026-11-10 11:43 ` Konstantin Khorenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d241fb3c-6756-4359-bd65-2738c7448962@virtuozzo.com \
    --to=alexander.ivanov@virtuozzo.com \
    --cc=andrey.zhadchenko@virtuozzo.com \
    --cc=devel@openvz.org \
    --cc=no-reply@sashiko.virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox