From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id E6B778017D for ; Fri, 23 Oct 2026 14:00:18 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69NDwtZR025197; Fri, 23 Oct 2026 16:58:56 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69NDwtZR025197 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="bHSGNOoI" Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69NDwq7Z025193 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Fri, 23 Oct 2026 16:58:53 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69NDwq7Z025193 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-8b0d978e4faso15191547b3.0 for ; Fri, 23 Oct 2026 06:58:53 -0700 (PDT) X-Gm-Message-State: AFq9FYJmAfhRnca9ZB07f1TFGcBINtYeOKkvDNkHqGaAiUoEj6DgLSCK 0xlEX+Weqorhxd9NOfBz44yb0JAH5fGmRatcUnrHuy7+m33q8LaohFJJ8tCO9pfQghaNdNs7wGx duBV7GKhsR1eSAeRrawmV46ihQ6MMS4zbS8oblDtIikNAjyUFAVgIuA== X-Gm-Gg: AYBFou1LWXbk17dXXU74kz6Ktm0abkIHg1CWLKrllsJ+kAXTulD4btLUfVu8YPW4O85 vYEbvOxoK4W+pM5uKrYzJgZ/8Cta2BkCbBNOlAdRiXjM6mhBKeL8d+Tu6/dElroQ8dv4bhT7Fot r10fXDflKN+1ZCUATznlWyMOrXv8LAF/hETAHdv26atwiu7lHgFFOS5S4uwblq0N3zhKoP6lCU1 ABfGNBJgVCtmkZJbcdlQB8pAzQmvpH1DskvqZFJ9w52LHeORNkW1BWcy/k2ZlMLCPjPqQJLdUME g3oSklRRhxvXEcsFOcB6jzFLTDl4H9u7L2f5EaPfp6Q7HztsHsZTGmU4iQaZq19ZwDCQRK+p+Xe flBivJ2jv9OtKYNbV8/faWH262AqlP5Yp8Ok9Y2KnUSXL9pR2cLbmOeC/Dd2t+5jE/7YAtpP+gI s17ItmLWigIQwB7ASaKsJjNXvBBsEHyCU= X-Received: by 2002:a05:690c:60c5:b0:8ab:485b:9bc8 with SMTP id 00721157ae682-8b157d1fd6fmr17579897b3.24.1792763932146; Fri, 23 Oct 2026 06:58:52 -0700 (PDT) X-Received: by 2002:a05:690c:60c5:b0:8ab:485b:9bc8 with SMTP id 00721157ae682-8b157d1fd6fmr17579817b3.24.1792763931573; Fri, 23 Oct 2026 06:58:51 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1792763931; cv=pass; d=google.com; s=arc-20260327; b=PGJJjAdHI73vFm50kC5f4Y2RBpf5a97bz5zUxiMzfka9gIffTxFHNbi8mnNViI4aKv 6t3iSegnlBsu8qDpTe97Q45IYSmk1ME3SdXX4b98aC2ok79v5bLeIaiUzW858PRH8z7M HdIyneWW3S+uR1YP19Gq8lBgaznhXFfOLaJ6RI36dedDbQYslBzzKPPR3mDvAkwNRnuD VfgAhN9mGZz/aZoeDvPPSmF9M4bqtTHayLNLp6pQLqam420gCzSOLQA1Gsofer1CWyws LVPwjfJiqWLYVCRDwfnt8reCAci81fWc8aapKRl1K/jrGwy7phxhQrhMmFH7cdREmymN 16kw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=p/5mptXMDXIE3gmmoqNPCwggGFHW67PAcqEE4uESJ8Q=; fh=IlzoM7xapMIT9vjIu8V1YxnmOSGAT8hvLuDm+hjUGIo=; b=mK1XcyhVR8yOiodh6wKCgkPG0BeObYjb96gUK6DiUPjgrurItmDJG9Pb79Pz/TgRYs u5vrEHEAt9ZFhmmcAFYO6p+6Ugg3Ag17DBcC1FDm77Qn8hKBk6/tQyEVOiKtV8LAPf6v 8NI6P7yXlkZlO26fPLVyxAE8LE7Q4sOPkT8ZQ5fZmtsxj+zUfoO6oPJGD6RGrFCHMqDl zVIAIOxCPt0o97tbaBe6na6+agGkBPtVl4WV8EpTfh0Hl2RQ00uwrDoFL7Jx4cTcts0v 7/bx3cdTjRcGYtgK7HoDdh37R3xVD172dqIgSHwGXlklyq/xIZ+PyURPz0D2KG74ip0/ /LgA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=bHSGNOoI; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c20f::7 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazlp170130007.outbound.protection.outlook.com. [2a01:111:f403:c20f::7]) by mx.google.com with ESMTPS id 00721157ae682-8b163d47cc2si160717b3.33.2026.10.23.06.58.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Oct 2026 06:58:51 -0700 (PDT) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c20f::7 as permitted sender) client-ip=2a01:111:f403:c20f::7; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=bHSGNOoI; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c20f::7 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fd1oxaVcQas1qXIgIoVNrR6xwfsvFqtGIMyBdYbgp0Sm9OjsDBmRQnCAMNpwsQRSxbZO3w8KTiNIU/4rrudAVldd973HDqhaul+3CVNfXlABYXkWu0/IBmfBr7f+16YrtZgyYyEYKLaGgKiY8vMojd2FpVAOqwq/LHhY9yN1pxaU59QDsWgXzIAlIxNcMGcVR7typ0NxmeIK55odwezdi+hurSCcjgyYjX9YguwTi5nIdD8ZAynluU3HkYhqNBHi+LLrJmhmhpAgSaoosUvEWHsl0uC17o0NEhETaFJTNbJomuzOpRS2KRli3GbzCgVwR1sRdoTmXxU8BO7p/Tdg5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p/5mptXMDXIE3gmmoqNPCwggGFHW67PAcqEE4uESJ8Q=; b=vCUS0jK6vODG3Cvqf7DTktFU9VlG39co/IFY70TAJUeXJgeykP4MtsUHfdExEeXmrBbrwC6buPJIyn248zAtuWC+9ZC7TwDknXe051QigjHvWjR99QmkGpfDdsaAdcvYfKR5a8QcH6FV0vScfBzlFGXt8kxedDBJNrzKDCO+E1fToKYj0x1c08dovaGYPQrmfqHGqrNQrIjmhU5d685BCuzglb5PtqSnfdn/UoeuvLbj2KpdUwmoMBbfHFacyULEqTYLAzwCUEoVKTiVERo/mnJITZ0cFOsrRZ+dMVlIp8VhSk3f2+aqXBQ1CcsGeOjjr0NRTyUvO8ZrX49KxUxNeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p/5mptXMDXIE3gmmoqNPCwggGFHW67PAcqEE4uESJ8Q=; b=bHSGNOoItY5qzSCeOe/9FgpHjKYbz4ZyQ3cpIndZNQ4ahCeHxMUxkAMbfbnpcBk2o7iWIyAmFbdq+gLJhlJTakV/IO7KZFhCk7MTBHG8teCLeRqV5Jf4l1wYVkaxiypUX9zXUzN18biV2vIqDNzTDZJPXO7ym2C2QloCLUWktPh0qMfFNi4bOuf8tP00OjYwxZq/f/R0/1yo2LfVqX/U0ql5JtzEKj2mv6qRbJaWhU2aE2Fc53AJcFGv6+LAlT4OGbxHiwD+oA5CJfEJjgdYpM/T0e9Cdz+L4yPwYJst98210EtTp5cj2+6jOZ4n8zGE4Lnn/AQ93gZXSk17orY/vQ== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) by DU2PR08MB10231.eurprd08.prod.outlook.com (2603:10a6:10:491::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.15; Fri, 23 Oct 2026 13:58:48 +0000 Received: from VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a]) by VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a%6]) with mapi id 15.21.0546.017; Fri, 23 Oct 2026 13:58:48 +0000 Message-ID: Date: Fri, 23 Oct 2026 15:58:47 +0200 User-Agent: Mozilla Thunderbird To: no-reply@sashiko.virtuozzo.com, andrey.zhadchenko@virtuozzo.com References: <20261023132008.2304901-1-alexander.ivanov@virtuozzo.com> <20261023132008.2304901-4-alexander.ivanov@virtuozzo.com> <010701a168f0113e-a206ddd3-c75b-46e7-9392-a425636a8df8-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Alexander Ivanov In-Reply-To: <010701a168f0113e-a206ddd3-c75b-46e7-9392-a425636a8df8-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: FR2P281CA0086.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9b::14) To VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10743:EE_|DU2PR08MB10231:EE_ X-MS-Office365-Filtering-Correlation-Id: 89494e6b-13ff-4849-9f01-08df310dc29b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|366016|23010399003|261021121427099003|18002099003|10067099003|22082099003|261022115727099003|4143699003|261009223027099003|56012099006|261022105027099003|261022075727099003; X-Microsoft-Antispam-Message-Info: 6H66PhqSMDzE7PZJxwB+8LLtS8iG49JHhhqw4IzKmH5BZdIPEyoYYS/73THEi2LngFqKyEPryfJ+lRQr4142V/lO2rpfGNHLPGQHh0e0X0JZsfTBNq+AftKqNXCJA3GJZeH7HLHVwCtvEg0qjR/yul7exnlwEZar0oaGq+F9ttuaCVmylnaIp+aCH6nox75y7tZftOh4W+4xlhoL6zzlmddkcmacIZAzHy2bjhfT9hYlTOwrRiCF6E3SkUGJBrAeeJHJevo8aaAvXHUn3jKaVXrostXyAZujNOQnROPpK9jhsa3nagd4A4+5Dgfkt0r5ZCx6++ZOssYrygjOg56gIbw5LUyacNAd0VYBwTMGdZgFIdyTHjHdEQ+vscWfvkKjp+Of/mk7yDoNsKokNa9RsGSZce0Mqmww91wAVxxxj9Z1UTzPXN1/fRO+KW9kpCQDPb8VwQbuNNv98qVL7izKoIDvuSBSFNlFrPYOTTGtruVioRB0ROK/BnydRraF0ElsTdof328KCB0uic3lrXFTqycr0qYP1xhab7FS+pk0KjamKgKW8BLC5xZYwyZdtXFk19lLFk5B67atdm5nfZlw0iKvcQUG9Zcw1xfX0gCInE1P86UvUpIji5YAb/ApnKtLdjLSlwb+qBkxeKUiH2eGY5N7U0/oq19YhMfVip4ReIA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI0PR08MB10743.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(23010399003)(261021121427099003)(18002099003)(10067099003)(22082099003)(261022115727099003)(4143699003)(261009223027099003)(56012099006)(261022105027099003)(261022075727099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZW9oVUNvVkJ4MFVYUDN6T0xGSlIrblR2UmRDanVaeHRiWXdKK2JEMkFNVEdM?= =?utf-8?B?clFkdEs4RTZZUjc1dFFjY1R3UWxpWm5WcmZjQlNIbWR6NTBWS2JVZlpXUXA3?= =?utf-8?B?b21hWXJTVUNiaTBuTVRRKzR4UTdRV25NL1o4RUVVVTl3dGJQMWpqcHVWYmVy?= =?utf-8?B?bUdEWXlyTHNOWWx3Nm95TEJ0RHNSOFkzTkwvZGd2OFEza3BJQ0FPbEdjWHVj?= =?utf-8?B?aGFxT2RESVgyVGFvTzJyUE10bW13TEQ3UW85U1M4SEFBVGEyMzM4eDJJb2py?= =?utf-8?B?Mk1oSU1VVzVITnFOaWxBeFhIM3Qrb1BuSitSaTRpQzhwRUFkUzUrby9yRDZy?= =?utf-8?B?NkRyUUg3SjZ1SXMyNHZzc05WSUJRK0JOVzFiZDkxUGZ2N0szbjN3dDhXcCtE?= =?utf-8?B?ZktIZCtzZ1NGSlA2RkMyOW12SjY1dGRaV3I1NjltWTNUSlNPNjhwZXJLOHQ1?= =?utf-8?B?ZHlkRmJtSVFXU0dCcExLVGtSMnpkZzlnWUhwdW8wVHpQUFVQMFlzdUxxdXFY?= =?utf-8?B?ekEwNVA0WFprajFJOWJINEFBWk1HbUgwVDdNRXc4RU9iWDN0RVJ2bDhCYU92?= =?utf-8?B?VkpXUXpBRWhRSzE0K3F2TTNmNkZrcGs0Q0lwSWpnSXNZOEV6TjBmbTY2NDZG?= =?utf-8?B?QXdrZmM3Skw1SmlLNXAxYVB0aG1qVW8relIwMVlLYkJkZUxTNnN4UXFQbEV6?= =?utf-8?B?eWp4VjB2Y1BGdUxyUEh1NTNtelVjQ3lVMnlhYWtJSDUwMHM3QnY0M0FlM0th?= =?utf-8?B?TmwrSW96YUZYenVxOHRNNUpPRHFzV0xZaEJDYkpuNkV6S090WmtCUlhSL1h2?= =?utf-8?B?WlR6Zmo0SDg4QmYwVUpvTHZEdmNPakJydnZVRzJ5Y2VRSTIxWXRpVW5CNlBE?= =?utf-8?B?MWdJUDhYRlRHT25pK2pDUGRCZXh3cjNLdDl3L2xpTmJEVWFOZHRYSitDbzhS?= =?utf-8?B?WThPSjVOSStZbnU0eUNYWUtJS1J6Y25oTEpHZWJqSGZyVFBweFZlU0V6c0FS?= =?utf-8?B?ajN2RSszNUZLR0xMNEFQeDRMOGk5SXJlYmhHT01lTFYrVUNJbCtnVGJTMGpL?= =?utf-8?B?SElGR3ZoNHhYU2JvM0F2azZ6d2dqZVpPSXVXLzlWSXZVRU8zSjAwN0VyK2pW?= =?utf-8?B?WmM4TitycGVBbFhSNTdnQ2NDb3FqMGRGeEtrTTVzcFhOSG9BdzNVZ25NSU02?= =?utf-8?B?V1daVml4QTlBQVpjajI1eWdiSXI3TkI5dEtqSy85WHJMYlc2Q2hTcEphZ0pB?= =?utf-8?B?MjhXbkovSDRzdU1LakZEeHpob1Y0YnQ1OTE4OEZTclE4VlZ4RnFnT3h1NC81?= =?utf-8?B?UkxNTm9HTHB4OWJtNVhRcnhoSmhINGFmTU4zM3lUeklUSGs3OWI0bU5jYXJ2?= =?utf-8?B?K3p3VUpqeS8wYVIzd1FRS3B6TmNJejlvSnIvdXU5djV2L1A1RHdZT0pER3FY?= =?utf-8?B?VU1pdWRIOEl1MlhTSkM0S3dIRVJSazA4S0loSHlsVit2cnpQS2tMQTl6aU0w?= =?utf-8?B?Yksxc3BZcVZZNm5uMkhQTnNyYWJjTnNWdFVId0pQUmxYNDN0MnpVQ29BV3FE?= =?utf-8?B?U1g3M3FiWGRxOFNCaGU2V1Z3a1lKOWhEbWdKeUFlZnRjdUxEQWVrckRlTXZx?= =?utf-8?B?M2l4RHdKQnB5QXRTVGsxWUVpL3FTUWdlUWlKelVCcTQzNHB2SlAvWkJIVjBt?= =?utf-8?B?REJFTld5MXlVUGdUVS8rcVVXaFVIbC82cXZCNGRoYzF2UGVCbkFUNHYyUEha?= =?utf-8?B?bzRBZWRyM0E0a3lkL0pXS3VqSGdVMVQ2UHNkdWxDTUxNWUhVa0k1WnVXa3Rw?= =?utf-8?B?NDZRRU5ub2xXYUM1cFdPZFNTNkNWVEtsaXcyMTNnbXUyZ1d2VmQ1a0RLZFAy?= =?utf-8?B?bHpSVHFXUjRKSW5wL2NIOGRKTTcvNURRN0pubEFhUzlHVHFxeFdGS3Q1aS9x?= =?utf-8?B?K1p6eGN0UCtPZmg2RHI2Nkl0UzlVZGo0Qy9ZU0tCNjRTd0owNDd0UENRNTlo?= =?utf-8?B?S0NiK2hYSG1meU5VQzBYLzliRmJkLytaeFR1U0RuY254dXVuZ3diM1dqVTR4?= =?utf-8?B?cWZEQmdvMDRuUVFWTjFpMEtUdkI4RkhPb0ROMVRpQXIyT3FBaExmOEZaeHNm?= =?utf-8?B?ZExVUnJ4NEgvcE1KSVVDdWJCVlNpbkRUbmFGZzlaWmx5c05UR2tLQi9wQUVL?= =?utf-8?B?UWwvS2hqSEMwajg5MzJrSERubTRpY1BaVWJsbFdUckdGYVhQbVdCdTBVY0M5?= =?utf-8?B?V0lJQ3BtY1ZqYnlSTEtjUHBCNElyVW5JN2srUGpITVpuanQzTS9YQ3c0OWNv?= =?utf-8?B?UGI3MVJHV3ZVNEl0SFRTRDUzelQ1d25obnNST3o1bjljN05pb1FwMStHU2VD?= =?utf-8?Q?KFpe1o2EOocV1kdA=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 89494e6b-13ff-4849-9f01-08df310dc29b X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10743.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2026 13:58:48.1621 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wBdz5/ucuvS0nDIE2QKtUs0428/iCVUVIOVeVo1IMmardDd6SHI0fsMNeviP+hlwUrQLrjrHFXasi/y8g2z9sNmo1BD8kMwHxKXH4Iv0rUY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB10231 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 3/3] drivers/md/dm-qcow2: do not revalidate inconsistent persistent bitmaps X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org >> @@ -865,6 +866,7 @@ static int qcow2_parse_header(struct dm_target *ti, struct qcow2 *qcow2, >> max_len = upper->hdr.size; >> } >> ret = qcow2_check_convert_hdr(ti, raw_hdr, hdr, min_len, max_len); >> + raw_autoclear = be64_to_cpu(raw_hdr->autoclear_features); >> kunmap(md->page); >> if (ret < 0) >> goto out; > [Severity: Low] > Is it correct to read autoclear_features from raw_hdr unconditionally here? > > qcow2_check_convert_hdr() returns early for version 2 images: > > if (hdr->version == 2) > return 0; > > so it never parses or zeroes autoclear_features for them. For a v2 image, > the field is not part of the header, and the bytes at that offset belong to > the extension area or padding. The new code then treats those bytes as > autoclear feature flags. > > The v3 case looks similar. header_length is only checked against > sizeof(struct QCowHeader) on the compression path. A v3 image with a short > header_length would also have the bytes at that offset read as autoclear > flags. > > The new code can only clear QCOW2_AUTOCLEAR_BITMAPS, never set it, and the > read stays inside the mapped page. The effect is therefore small. > > Would it be better to do the read and the mask only when hdr->version >= 3? > That could go inside qcow2_check_convert_hdr(), next to the existing > hdr->autoclear_features = 0. No change needed: for v2 the value is never written back to disk, and a v3 header shorter than 104 bytes is invalid per the spec. The code can only clear the bitmaps bit, never set it, so in the worst case bitmaps are treated as inconsistent, which is safe. > > [ ... ] > >> @@ -914,6 +916,9 @@ static int qcow2_parse_header(struct dm_target *ti, struct qcow2 *qcow2, >> goto out; >> } >> } >> + /* Bitmaps invalidated before must not become consistent again */ >> + if (!(raw_autoclear & QCOW2_AUTOCLEAR_BITMAPS)) >> + hdr->autoclear_features &= ~QCOW2_AUTOCLEAR_BITMAPS; >> ret = 0; >> out: >> return ret; > [Severity: Low] > For a v2 image, does this decision depend on a meaningless raw_autoclear > value? > > The mask is applied based on whatever bytes sit at offset 88 of the header > page, rather than on a real autoclear_features field. It should be > conditional on hdr->version >= 3, as noted above. For v2 the value is never used: hdr.autoclear_features is consumed only by qcow2_set_image_file_features(), which returns early for v2, so whatever bytes sit at offset 88 have no effect. _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel