From: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
To: Konstantin Khorenko <khorenko@virtuozzo.com>
Cc: devel@openvz.org
Subject: Re: [Devel] [PATCH hci-8.1 0/9] dm-qcow2: support the werror/rerror policies for vhost-blk disks
Date: Tue, 17 Nov 2026 10:03:47 +0100 [thread overview]
Message-ID: <dd2d1c8b-ba4f-4426-ae03-d7c04c468d45@virtuozzo.com> (raw)
In-Reply-To: <179484986789.861498.9914296104181809603.b4-review@b4>
I've addressed the review comments in v3 of the series.
Feel free to skip v2, since I missed some of the comments there.
On 11/16/26 18:24, Konstantin Khorenko wrote:
> I won't apply this version, please send v2 with the changes below.
>
> On Mon, 16 Nov 2026 16:41:10 +0100, Alexander Ivanov <alexander.ivanov@virtuozzo.com> wrote:
>> Patch 8 requeues held requests to the dm queue on a noflush suspend,
>> so a table reload or a snapshot of a paused VM does not deliver the
>> error to the guest.
> The kernel side holds up: the locking, the timer and suspend
> handling, and the vhost-blk release fix all trace correctly. What is
> missing is the part that makes the series usable from userspace:
>
> 1. Series: QEMU's pause cannot work with held requests. On PAUSED and
> FINISH_MIGRATE vhost_blk_vm_state() calls vhost_blk_stop(), which
> detaches the backend; in the kernel that is
> vhost_blk_drop_backend() -> vhost_blk_flush(), which waits for
> every in-flight request, held ones included, with the BQL held. So
> the pause the IO_ERROR uevent is meant to trigger, virsh suspend
> and a migration all hang until resubmit or fail_held, and a timer
> retry that fails again holds the request again. Say how QEMU is to
> pause such a VM, and link the QEMU and libvirt series.
> 2. Cover letter and patch 8: ploop suspends with a flush suspend for
> a snapshot and for grow (ploop_suspend_device(), cmd(..., 0)), so
> with today's ploop a snapshot of a paused VM still delivers the
> error. Also dm_reload_imglist() does not pass error_policy, so any
> ploop reload resets the policy to the default. Name the ploop
> changes this needs, or drop the snapshot claim.
> 3. Patch 5, message: at this patch ENOSPC reads are still held (patch
> 3 keeps them), so "Only ENOSPC writes and flushes are held" and
> "reads are not held" are wrong until patch 7.
> 4. Patch 5, message: say that every dm-qcow2 device, CT disks
> included, now sends the uevent and gets a udev probe every 20
> seconds while it stays full.
> 5. Patch 7, message: under the enospc policy only ENOSPC is held, so
> drop "whatever the error" (Sashiko).
> 6. Fixes tags: patch 1 and patch 4 6e2ec304689f ("dm-qcow2: Pause IO
> and notify about ENOSPC events"), patch 2 2f9926b51be7 ("dm-qcow2:
> Rename MERGE_QIOS_MAX"), patch 9 c57a98d65796 ("drivers/vhost:
> vhost-blk accelerator for virtio-blk guests").
>
_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel
prev parent reply other threads:[~2026-11-17 9:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 15:41 Alexander Ivanov
2026-11-16 15:41 ` [Devel] [PATCH hci-8.1 1/9] drivers/md/dm-qcow2: cancel the event work and ENOSPC timer in the destructor Alexander Ivanov
2026-11-16 15:46 ` no-reply
2026-11-16 17:24 ` Konstantin Khorenko
2026-11-16 15:41 ` [Devel] [PATCH hci-8.1 2/9] drivers/md/dm-qcow2: always resubmit delayed ENOSPC requests in presuspend Alexander Ivanov
2026-11-16 15:45 ` no-reply
2026-11-16 17:24 ` Konstantin Khorenko
2026-11-16 15:41 ` [Devel] [PATCH hci-8.1 3/9] drivers/md/dm-qcow2: rename the ENOSPC delay list to a held request list Alexander Ivanov
2026-11-16 15:45 ` no-reply
2026-11-16 15:41 ` [Devel] [PATCH hci-8.1 4/9] drivers/md/dm-qcow2: arm the hold timer only for the first held request Alexander Ivanov
2026-11-16 15:46 ` no-reply
2026-11-16 17:24 ` Konstantin Khorenko
2026-11-16 15:41 ` [Devel] [PATCH hci-8.1 5/9] drivers/md/dm-qcow2: report held requests with an IO_ERROR uevent Alexander Ivanov
2026-11-16 15:49 ` no-reply
2026-11-16 17:24 ` Konstantin Khorenko
2026-11-16 15:41 ` [Devel] [PATCH hci-8.1 6/9] drivers/md/dm-qcow2: add the resubmit and fail_held messages Alexander Ivanov
2026-11-16 15:48 ` no-reply
2026-11-16 15:41 ` [Devel] [PATCH hci-8.1 7/9] drivers/md/dm-qcow2: add the error_policy table argument Alexander Ivanov
2026-11-16 15:52 ` no-reply
2026-11-16 17:24 ` Konstantin Khorenko
2026-11-16 15:41 ` [Devel] [PATCH hci-8.1 8/9] drivers/md/dm-qcow2: requeue held requests on a noflush suspend Alexander Ivanov
2026-11-16 15:51 ` no-reply
2026-11-16 17:24 ` Konstantin Khorenko
2026-11-16 15:41 ` [Devel] [PATCH hci-8.1 9/9] drivers/vhost/blk: fix a hang on release after the vhost worker is killed Alexander Ivanov
2026-11-16 15:56 ` no-reply
2026-11-16 17:24 ` Konstantin Khorenko
2026-11-16 17:24 ` [Devel] [PATCH hci-8.1 0/9] dm-qcow2: support the werror/rerror policies for vhost-blk disks Konstantin Khorenko
2026-11-17 9:03 ` Alexander Ivanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd2d1c8b-ba4f-4426-ae03-d7c04c468d45@virtuozzo.com \
--to=alexander.ivanov@virtuozzo.com \
--cc=devel@openvz.org \
--cc=khorenko@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox