From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 976738045D for ; Thu, 22 Oct 2026 15:30:21 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69MFT0t7010402; Thu, 22 Oct 2026 18:29:01 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69MFT0t7010402 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="C2LgqKJY" Received: from mail-yw1-f197.google.com (mail-yw1-f197.google.com [209.85.128.197]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69MFSwah010398 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 22 Oct 2026 18:28:59 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69MFSwah010398 Received: by mail-yw1-f197.google.com with SMTP id 00721157ae682-8b150adb80cso7174097b3.0 for ; Thu, 22 Oct 2026 08:28:59 -0700 (PDT) X-Gm-Message-State: AFq9FYJbBMkvSyJsq1FI7E+g7Yq1cwAL6tB/ma+NvmI+Fgf3mcTDX8Yy ih8mAXtRgCWbfEMoh4NiZ956HWXfD1CS90Jxe0SQhfetXaINV7nn4g7w8JUnD9+2Yj2rBSzxB0J S2LjWh1R779H8oitGuoToKNBUL983QuWuo4S/KK2SiQxTZ9fOQUorsw== X-Gm-Gg: AYBFou3omFt6WuaDFbdR3Mb7MTmzNELrGNxhCFH7GsecXQp2daFPkuNKj9nB24CLTIj Lpfy5Q/BPWgW2Y2tJzG8UAbRlJxpfejwAGhg20lHp5YQFpfsIn6nYvf4HO3gKh8IyLE/tQcfIUG zdFRhShO9Tsawh3BkjJkReCFY9p0vqDcGeAfhOAeVSXxg7ZinaQbT3WxSm6iWO61Qgrn22xbPJ1 VQTDOunkuHyRwKYPgGrLYC+RKawnOzSF5EoBsDE3D1okr3VhI5bx1YDA2OxgLTweq2kgHMuBDqV tJxfa3KTKdsXT9jUSH/X2IoQkb9fHgc7AfYe2io3wuscVOPmQ8BohPaatrZLzZESaxrn0Mp71WU ivYGwrn1vgh3WQXYevpEnhf9cWU3wcFi8PjoMCDT4dJZV8khww+NKin5xhlhYuWOpH7QbYB5L5Y lapdW1Scs7ACy7swOYy1fpg0JWGaDIeyGZfN36 X-Received: by 2002:a05:690c:dd6:b0:873:5c6b:a321 with SMTP id 00721157ae682-8b14565ce22mr16326257b3.27.1792682938183; Thu, 22 Oct 2026 08:28:58 -0700 (PDT) X-Received: by 2002:a05:690c:dd6:b0:873:5c6b:a321 with SMTP id 00721157ae682-8b14565ce22mr16326127b3.27.1792682937617; Thu, 22 Oct 2026 08:28:57 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1792682937; cv=pass; d=google.com; s=arc-20260327; b=mdPi8Cc+fMzzVrnsRqQoGRTa+iKXYgvAWEX6/Qp83hjoEyZyuj37U9zUJI5PGz06hj ccV++TSAO1O+jFFB8u/hZYTtwRTbZpVSqMxKO49mq9+60RjonimQBLmVUZhrHAg8H6xz pxLErN9zixdnRR4DUaJcnOYAuVMnKtXpKpj703426VcEgwRewjCyPyP6gcTYbQqnmqPi FqaAI02z1r9bZHKAju74Am0ErlzADw1a+ENy8TXLfD4fwTyoHvO7TfwLNqlIwpeUslPS dsLPmCBBF/8asogHVxH8tDgPF5Q8Z765V4x/IQVUnohW1/NZ0s2ONDBUTd/d82M4TwiO vB+Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=SBxwX97JJdH6bi1y6J3qdxozYMVI9Y/P2rrpUTI4JUY=; fh=XnEMhXvwlyplB1GF6KxaLPN91MF1UgjoUy1OKzQIfKQ=; b=q3wWo9faSZh+BwOyhuc11GIV42TXdE5Gq+fnW5Ey9bwL3Z88fm8m856pz2N/M3e1i2 BrtS6RydldNjNR6FlMn+0pmJlCXKiGiFm5BBRsfZgMAjizBPsM4roswWevXYjnSUZ2r7 6/AEuiF2O8PJwgJ4/1TUSZuB44/2JSAqSfPpCrNQXYNV5iY70rm/4SVEm8w2K2RjNd0T C//7wZc+vfAKk1XY7jk6u1LPbDBT3pHHtry+p8X+NEhjWSVkaqaWqOUTgP6jgP/gll5/ I0kHGfaq6UB8rVhu0yqiTeM9J/eWZWnWVbqfxZ82/CP/2rF86YWj2uOvj/NOv4bPucNV H8Jw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=C2LgqKJY; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c20a::7 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazlp170130007.outbound.protection.outlook.com. [2a01:111:f403:c20a::7]) by mx.google.com with ESMTPS id 00721157ae682-8b155f08d58si15957b3.11.2026.10.22.08.28.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Oct 2026 08:28:57 -0700 (PDT) Received-SPF: pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c20a::7 as permitted sender) client-ip=2a01:111:f403:c20a::7; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=C2LgqKJY; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of vladimir.riabchun@virtuozzo.com designates 2a01:111:f403:c20a::7 as permitted sender) smtp.mailfrom=vladimir.riabchun@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UyKsEhvw1AAGRMDrmE+GA3To/YbeTSec0q8p1BmAm6VXuQsRIJtFXKs8oiD8U2+Q7MCz1WlhKd6YanVxYPYE5U3FvDV4qOP9F4beLlJNNboti8pUw2reswF3kyqJuqjvJs2pX+uzR3Fvdbx0euQK1j1YULT4anfgVYyOcQf65/0QFtVElPr9rNdG+N3Uu0Ree/ifujW/5oB1uFBay7ixloxUoVIsdW39OY2InFEjcwoT3xGLnV07nHW2hjNTs5lxaK2BujaT0hoZ+3t/4TfXM1L2CKeBEsn4Y9k+PjyuCG4xvBSl4+Zbs4ZRUyJOp0reIWPSmThqKnQx9dtMaQa0Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SBxwX97JJdH6bi1y6J3qdxozYMVI9Y/P2rrpUTI4JUY=; b=CJ2BoA5hgIcjJbQGPY+IctVvn9LGYk6teFl7cv7SGZtacuuK7DSxOyUV4M6tN5GadxYEUJ4i9pmEFMv4B9+Gl0MXriIed4AacKoGUZIaKMfFExQ4T3f5XMXUHr8gmsWRhrTGNlvL7B3g6DZWYKACfu3iAc+XPO/3UdaKab5X39KAucyOSnWMc4bXJSa3dNk1NVQ5GHjGyidXW14bzUNTaHcQqstaw7e4NclZXqujasDTM4b6NVVKy8QRNP3yxUqrbvfAi/PQuooUlKm9PIZJZFwZF0PA4NVF29CsiB5BwVLb2Wrfyl5TVjsXXMEc1Q2NwYTBEcPEM4NtoHr1Q58XKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SBxwX97JJdH6bi1y6J3qdxozYMVI9Y/P2rrpUTI4JUY=; b=C2LgqKJYNEKyGY8G0RGSxrSI/RGMeqqemGerRVnhuA2vyKh8W8ZHzkxQG4oimAFtz4zhz0Qud0ehzus4KkL3xSgc8bY4v0O/YUAou0RgpP+7kjGSgpPF+o8jWiw3VCgD7s/q9L04yG+pCHsLcEXkeHILzoeQUJsjX7YwIirF5CYedeIU7HU/KOd9qrd2Sk7vSMNX/04JOnG5C8trfGQou+h4MdwxwRKLHfD3gdJSkoUyvgkbGXmo4aSnh8++qHFbekTT/TD/k/9GjQ9Ju+CfEXTf4eom65UQgE9qqZ14Jf1JJMMi2AQONZNa/jgavW0qlJPBhe5Y8KsYro9xsEAgaQ== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from MI7PR08MB201474.eurprd08.prod.outlook.com (2603:10a6:290:112::17) by DU0PR08MB8254.eurprd08.prod.outlook.com (2603:10a6:10:412::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.15; Thu, 22 Oct 2026 15:28:54 +0000 Received: from MI7PR08MB201474.eurprd08.prod.outlook.com ([fe80::f35b:af88:bd82:6dfa]) by MI7PR08MB201474.eurprd08.prod.outlook.com ([fe80::f35b:af88:bd82:6dfa%3]) with mapi id 15.21.0546.012; Thu, 22 Oct 2026 15:28:53 +0000 Message-ID: Date: Thu, 22 Oct 2026 17:28:52 +0200 User-Agent: Mozilla Thunderbird To: no-reply@sashiko.virtuozzo.com, vasileios.almpanis@virtuozzo.com, Konstantin Khorenko , ptikhomirov@virtuozzo.com References: <20261022-ovl-use-orig-ve-v1-0-da84c00c8065@virtuozzo.com> <20261022-ovl-use-orig-ve-v1-1-da84c00c8065@virtuozzo.com> <010701a1642a92b7-37a13b94-dfda-460d-87f9-893f3c969e82-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Vladimir Riabchun In-Reply-To: <010701a1642a92b7-37a13b94-dfda-460d-87f9-893f3c969e82-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: ZR1PEPF000077D6.CHEP278.PROD.OUTLOOK.COM (2603:10a6:918::417) To MI7PR08MB201474.eurprd08.prod.outlook.com (2603:10a6:290:112::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI7PR08MB201474:EE_|DU0PR08MB8254:EE_ X-MS-Office365-Filtering-Correlation-Id: 2c40e5cc-95ef-44df-33d2-08df30512e57 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|366016|23010399003|376014|56012099006|261021121427099003|261009223027099003|4143699003|10067099003|18002099003|261021123027099003|22082099003|3023799007; X-Microsoft-Antispam-Message-Info: OuJ1PSuPYsqXybGKVrw8GNtgfL0WcDVFPmpOttbJnGxUSMt7uWAx/SzIsF9ONSz80tivMrR81mWGK+PFcr24Iff0qR1Upv5BhJMMNZZoFCj6ZqSz/RhcereZLa6QzmPsluzrTu3GRbRUlSCnrP7LxJtNswQSenjpIdMieXFl3MXFBFtFm3W7Aayeu4TTUes4eqlbrE1UT83GjVWMTpQ2kcoaU+AtVjW/7P9Q1p1AGD0+aYazQXBBLA7avPSkWD6L6VBaCOZkvVkpI8lxM069rctLhovnljHQnNwpYz7mIbJ023TGC15tusmJMjwImoOyfAB4u0M6YUG063YgMi94ddiUkZa7fgZH9burKuWJS8imQwtTy9Bc8+x+6FG+K4l/TKL9zTSaaCLVuqeS82UmnE6lqLqf995O8RSWMHcIAhOw27d9hhDbCvDFTAdNl9Wjo/ndyIUowxvkEpMCPMomhTtZJsjrPdWkPILcgvmTYCOF++Eubyvtwe5Ab8IPpTPENFy5qVA5Sfu/dkDEw9yjSBHAlyJU2EA1fXovXLdRsW/l6or9UaN7dhVwLm7Y+boM9f7frWKjj/Bf9394AQ2wQS1xj8zt2rnshrYNvMcEpGHs52HyCxjAoYpuDHg493zm X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MI7PR08MB201474.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(23010399003)(376014)(56012099006)(261021121427099003)(261009223027099003)(4143699003)(10067099003)(18002099003)(261021123027099003)(22082099003)(3023799007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a1JZVGJ3N3NvVG9IMVMzVXdUODRkQStTcTlRRHIxVjZQbDhXSFNxUVllenJN?= =?utf-8?B?bzBobXpmc3lwRTRhcGZYaGNGQmpDSGxWdEpQS1RtVFNsREh1cE5odTVkV0NC?= =?utf-8?B?TllsSnNMMUh2clNsemZvNld4QTN2T2U2MDR3cWZoSk12TElLV3ZHSzJsekFC?= =?utf-8?B?cE5OVmNoaE10MnRFaE45T2t4VmZrQmc5amJnRUNBVjNuU2ZZVGMzR1VmZ25L?= =?utf-8?B?ZU5nS1k2Smt2VUxyVThQM3hhajBXMGwxaUNSSG1Ba0Y3MTFjZmVNalhrSi82?= =?utf-8?B?emM4Nyt5cG9QcE9MN0FmTzFLeitzS3B3bGNFNDRzak9FaGI0WGNRL0tRWS9p?= =?utf-8?B?cHFVd2VRVVJWTEQ1T28rdG9GR2JLTk9idi9vcVZXNWRGNjNsNzAvaHhicGJI?= =?utf-8?B?SkhLLzNNMGFOV0pvMnY5L0E4Mytac2srMHZiNjBZSWZKWUE2QnFodlFaTVFK?= =?utf-8?B?OFVldEJPKzZob3NRa0lRZVBVUS95TVdzeURBaXc2Rjh6UlRNYVlKMG5PbU1L?= =?utf-8?B?K1BCUEhHYytDcnl1SFpPTXR4WUtZeTRKSUpMODg1c1o5Zlhkd293ZmFxVkNJ?= =?utf-8?B?ejIrNHp5d2lzVmYvUjNodTd1a3lCQTUzbXZCZHlHLzExUjh2VVBpeTdQRCti?= =?utf-8?B?OFdEZitUYVZSTWJFaWxnZ1VleGtId1BXM3lTdG5zT21wMmloWjdONUhGTHB5?= =?utf-8?B?cnJwNWJGV3h0VFR4SCszUUQ1czVwbi95Qk9ManI1eHo0eVZNQlgyWGFYa0FH?= =?utf-8?B?WDdFZ0lFMjB4MU41TlVBb2ZPYVdxb0I1SmJDWitjL3c4anpMd2RZUkNLRk5X?= =?utf-8?B?QTlpWmZBbVBiL0I0UDRqa1Q3VDRSRnBJNHNSazBLYSszVHdzZTVCY20rNGlU?= =?utf-8?B?TlZ3allzaHA4dmMrbUxWQVA4NDNiaTRKZ1FFS25ZZXA5V0lnRFluQ2V6cmxo?= =?utf-8?B?TWtTYk1NcTBKNmtBSTFkVmJScnNjMGJWM0R4aUlxM1VJNEhyZlZneEJ2amlF?= =?utf-8?B?cHpya0FIUzc0c1NzcG15dWRCUUtqUVUxL3RNSDhEUjRJM2NXNG9ZWlVmSUJh?= =?utf-8?B?YnBaek11dHl4T3JZUXplelFmT0dCMVcyTUZtZ1p3Rml2WVMwQWdEQXAzNTgr?= =?utf-8?B?UDl5Z1pkM3NVY3J4ZE5aaVNKSzJ1WU92UUxLbzh3S0Z5TmZwaGxVdnlaSUVW?= =?utf-8?B?VEFWdkZOWmlqQkoyMndjSGJ4L0VmSFoxVENVN3dzTDJVVGNpMkdSU2l0L1NH?= =?utf-8?B?VHBXaG0wZS9kSkpnbmxmLzBxT1BWbTZkQkZUREw5RUZDVk5LZFVMSlJKdTdS?= =?utf-8?B?ZEt4WHhRYU90dWk3bFZzQ280UzhwUlJWN0U4SHVrbUxXZFNSdm1SRm4xK2VE?= =?utf-8?B?cnB3ODJJNHVab3dMdmxFaWt4YXRKSkRTaXVvclNEUStiT1FsWGtubGVCZE9D?= =?utf-8?B?c2pjWnUwSEtvY0xwUWJUeWRqaklONVRBa2JJVk9wVmd3VFAxTm1odmx4VUVO?= =?utf-8?B?Z0NIYXd0cS9LNGZhWTAzaWtKdHMyaWhGRU95YVpqWGxWVHRvSjNGNmhhcWYx?= =?utf-8?B?NWYwNnhrTkljTjMrNGdaY05RR2dHdkhaZllrcHR2MCsxamJlVEhLaDhhanNa?= =?utf-8?B?WTl2ei9rY01xeDhKTURjVUd4cUhOYlBkNWlyOEkxT0xJTmhobWVXR3NhekU2?= =?utf-8?B?dkdkS0pnVHhocEdkb0VuUmpsbEtNanRLZ1VqbEVsQldWTmhUYUtCNDd3VDdI?= =?utf-8?B?Ni9SN3B2ZXYyQWtZUmxDSmJzanNoKzA3ZFJVYmdTQTU4aHNyRC9SdXU1VHlI?= =?utf-8?B?a0s1ZUxVaFJ4K3NVbFJzNm9jbDdRdm9OdU9DNzMvWUVtcThtNzl3YmNNVDVa?= =?utf-8?B?VkQvMTJSQWhUNVJ6VityNVFzMk1jTS8vWjF1dWU3THUwR2xvRGhFeC9SaU9V?= =?utf-8?B?dG9HaXp4RlF3Nlc5eW90WE5XY2EwOExhcm0yRC9zbXJ4aThHRzJmdEZtQmc5?= =?utf-8?B?Q0NXc0dZMDBoWGczYUxUSlpOK1grUUJ3U09oYk1jdEl1RE1GK3Q4NmF5cGJm?= =?utf-8?B?d2s3SDdNN2JZdHh2S09raWx0MXArYnBqclRCellYT2YxaWtoeFpxNWQvNmli?= =?utf-8?B?WWhDZ3FpcDgzdXVWemhCZnBTMjlUMGtIUTFGdlk2dDZKekdTTmVMMmdDbTd5?= =?utf-8?B?VHR4dTVUdTNweW1ELy9POE5sdGdWaEQ0NGt5WVJiZjY2Y3JzYUlwaVN3WFFy?= =?utf-8?B?dHY4YjJmT1haSkx3cTdobjdqd1pkU1B3ZWpxN3p6MSsycnBvcEdRTHd0dEIx?= =?utf-8?B?N3FwcEtwaU50R085MEZtalE5RTI1YnphbkNzVXBBUUQyZkhNUjRRMlhnc0Fy?= =?utf-8?Q?d7RpE94tQuNa+Prc=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c40e5cc-95ef-44df-33d2-08df30512e57 X-MS-Exchange-CrossTenant-AuthSource: MI7PR08MB201474.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2026 15:28:53.8357 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2pPClTAW7eaVe6HsXz/+kLeB6chS2efMgzWrMXHVOsyDjMpXLKwbsuDFY2zdWhWktFA9K2B4CMbOtd+ZOENDMahZg1bVYMwX957jZJXgpKs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8254 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 1/4] ve: Remove STOPPED state X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 10/22/26 17:11, no-reply@sashiko.virtuozzo.com wrote: > Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: > - [Low] ve: renumbering VE_STATE_DEAD from 4 to 3 changes the state value logged by setns > - [Low] ve: commit message claims STOPPED removal blocks VE reuse, but it is only a cleanup > -- > > commit afa07824d11d984ebc29eb501787f9b9b4ecea47 > Author: Vladimir Riabchun > > ve: Remove STOPPED state > > This patch merges VE_STATE_STOPPED into VE_STATE_DEAD. The stop path in > ve_exit_ns() and the error path in ve_start_container() now set DEAD > directly. It also drops the ve_set_state(DEAD) call in ve_destroy() and > renumbers VE_STATE_DEAD from 4 to 3. > > Link: https://virtuozzo.atlassian.net/browse/VSTOR-142405 > >> diff --git a/include/linux/ve.h b/include/linux/ve.h >> --- a/include/linux/ve.h >> +++ b/include/linux/ve.h >> @@ -40,8 +40,7 @@ struct vfsmount; >> #define VE_STATE_STARTING 0 >> #define VE_STATE_RUNNING 1 >> #define VE_STATE_STOPPING 2 >> -#define VE_STATE_STOPPED 3 >> -#define VE_STATE_DEAD 4 >> +#define VE_STATE_DEAD 3 > > [Severity: Low] > Is the renumbering of VE_STATE_DEAD from 4 to 3 intended to be visible in > logs? > > The raw state integer is printed in the setns check in > kernel/ve/ve_namespace.c: > > ve_name(ve_ns->ve), ve_ns->ve->state, > > and in the ve_set_state() WARN_ONCE messages. Anything that parses the > integer in the "setns to the VE namespace of a non-running CT (state %d)" > message now sees 3 for a stopped CT, where it could previously see 3 or 4. > > The cgroup state file is unaffected, since ve_state_show() still prints > "STOPPED" for VE_STATE_DEAD. > STOPPED left intentionally, vzctl checks it. Numbers in warns - don't care, these are debug messages. > [ ... ] > >> @@ -680,7 +680,7 @@ void ve_exit_ns(struct pid_namespace *pid_ns) >> ve_hook_iterate_fini(VE_SS_CHAIN, ve); >> ve_list_del(ve); >> ve_drop_context(ve); >> - ve_set_state(ve, VE_STATE_STOPPED); >> + ve_set_state(ve, VE_STATE_DEAD); >> up_write(&ve->op_sem); > > [Severity: Low] > This isn't a bug, but the commit message doesn't seem to match what the > patch does. It says: > > We really don't want to reuse VE after its stop. > Some resources from the old run can reference this CT, so new > start may see leftovers. > > Fix this by transitioning from STOPPING to DEAD directly. > > Is that description accurate? > > ve_start_container() already rejected a restart for any state other than > STARTING: > > if (ve->state != VE_STATE_STARTING || ve_nsproxy) > return -EBUSY; > > STARTING is only assigned in ve_create(). A VE in STOPPED could therefore > not be restarted before this patch, and a VE in DEAD cannot be restarted > now. > > The ve_set_state(DEAD) call removed from ve_destroy() wrote to an object > that kmem_cache_free() releases immediately afterwards: > > ve_set_state(ve, VE_STATE_DEAD); > kmem_cache_free(ve_cachep, ve); > > So DEAD was never observable there. > > The later patches in the series (override_ve/revert_ve and the overlayfs > creator VE changes) don't check VE_STATE_DEAD or VE_IS_RUNNING. They take > and drop references with get_ve() and put_ve(). It looks like the > "leftovers" problem is addressed by those reference changes and not by > this patch. > > Could the commit message be reworded to say that this is a state machine > cleanup that merges STOPPED into DEAD and removes a dead store in > ve_destroy()? Huh, true. So it just drops useless state. I'll change commit message in v2. > > [ ... ] > -- Best regards, Riabchun Vladimir Linux Kernel Developer, Virtuozzo _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel