From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id 65F8F8017D for ; Thu, 29 Oct 2026 12:17:45 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69TCGQqn032450; Thu, 29 Oct 2026 15:16:28 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69TCGQqn032450 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="ln7YTBpP" Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 69TCGOjU032446 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Thu, 29 Oct 2026 15:16:25 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 69TCGOjU032446 Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-89fb6a45c48so2620773b3a.1 for ; Thu, 29 Oct 2026 05:16:25 -0700 (PDT) X-Gm-Message-State: AFq9FYI/kiMqD4zM/rsl2OtKgYJWS5Q+J2SuD0ZIHbSYOcC6XiQY4PTR Pt+XKkICaiXjMhxo+7FwDXLH/+fXZodMUA8iq5BKyCcccJaof1up03UG6bf7p7hWQhqnrlL2NuQ tR5FO1zN593xr06HVuhzIB66wclOVQ0YzAOFVL6/hc8jZB+vrPt7IHw== X-Gm-Gg: AYBFou0aGfU+T1ZbDt5m0u7cBLIx/CaDcRhRrRP9Jk9Xs/uKZc1bOge2lgurdvAQRQW RbDsUKpC4uMYyD4kB19L2xLsZIHtYLR+/dzCXYR9KM2FuHxxJhuD5p9VGEVtk/nHYQpOVlrNyFy dSNXkUOtXjr/y6x7TC/wLpN26cTnXzenPtpycu4cG1pxzH7mFNyB9m857qyGUfrBYN3vxIOlXff rwl5ueXJn4uMwfVkmcVQPOBqfxFtBv3TWe6SHzfTfqgHTi8oudD5QVBjequtPNEOnKCzCYe+dal 53PApnr7Z7VyPmckMHKPdtTLUdmga7gMI+XyNEBAeWizH50SGnElEGyMY2ymD+RDCr6RoPbdrAt iSl4JLF4tCyF1DKCwmtU4Xq2xemcsikVCMdpajbhpef2KNrEXbZkkhNP5kFN5ERfD4Io8kpZoM9 SqgsuoOjTWaE6gMCW3mUZskKuQEDWXugg= X-Received: by 2002:a05:6a00:1ca5:b0:874:708d:b620 with SMTP id d2e1a72fcca58-8a6e78cfef3mr4224175b3a.30.1793276183403; Thu, 29 Oct 2026 05:16:23 -0700 (PDT) X-Received: by 2002:a05:6a00:1ca5:b0:874:708d:b620 with SMTP id d2e1a72fcca58-8a6e78cfef3mr4224133b3a.30.1793276182552; Thu, 29 Oct 2026 05:16:22 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1793276182; cv=pass; d=google.com; s=arc-20260327; b=fg+0yD2Bw6js9GoqRi8INcmg+CB45YfxMM/7eznfPWN1O3ierVNgtRYeJkhE0/WyPv KNpD0T7PDq5LIbNShP5tAcs7hbHLm25Z9uLNiTw5YQB8kdHuOsPGih59s2xsu/yNr0bs Di4mkONEPveRCV5xK5VjOFCB6NKuKyFTW/Gn5PKHRCJX9p8QjcEuF9+MpLxgoQfqRfi+ JqbgSKK1RhqizArtTaIzFRi9RJklYOqYYxz+RCVA7tA75AxCxo/KJPZ/x45H4oyGtTJh 4R3Sm5Xq96pqj+JQPIGIydLi10lUXQurt0M9m8MmhGlJpo81LK3lkWiN/kw4Xm996k07 qgnw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=yumTPAmalKrhZnbW4gs7Db582QoGDuXCB9gS0IuEgok=; fh=IlzoM7xapMIT9vjIu8V1YxnmOSGAT8hvLuDm+hjUGIo=; b=UEfg/iboRtfe/VQdcu7bJH9aYKVrU+I5xhnVuiqk+uDNzSzAt+FpPF00RGy/6CI7vn Uulj7q62pxSyKUdUa5+YkIAl/IfAyQaW+PpWrDluXuGwFIkdPhgtD3MbanM+kZl7Sozo MAlyPCSd4a5vOLB3g9H1kQW6fzR37zEnjpCVhhaEJ95nytqmOg6H2jaeAovNaWteUuno LlTc3ibSI5OQGaBxsMFJUQw5faOYfoOc9wxDD27ywRVrCl9XmiPsfqhbL1Fea3PMwHkg 6lb5X6KCLTZN/52mnVBJClfAJgCLHH+CFFIA0iydL1VZunzkwn2SkWkRijj8l90TA2/m mz0w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=ln7YTBpP; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c20f::7 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazlp170130007.outbound.protection.outlook.com. [2a01:111:f403:c20f::7]) by mx.google.com with ESMTPS id d2e1a72fcca58-8a6a3972580si11533918b3a.43.2026.10.29.05.16.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2026 05:16:22 -0700 (PDT) Received-SPF: pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c20f::7 as permitted sender) client-ip=2a01:111:f403:c20f::7; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=ln7YTBpP; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of alexander.ivanov@virtuozzo.com designates 2a01:111:f403:c20f::7 as permitted sender) smtp.mailfrom=alexander.ivanov@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NU00KodbjCBRvBM2N7IHfNSDVcsfNiZf2TGySrQGRYv5oO2bVgw/uWc6F2KdU//p7GGW0ysKIKJ/vpS6ObteFKSf5qpevRRpKoo1GtaRqmrLI0XrsWXaC6FSnXP6bnOa0An9EHFOyuZoaDTPBw8WLsfg58TWWzKhYgO84m/uy6nreLjK5S11RzR/2JhSce1w2f1/XEWzqDYH4AJzZXZBxdF3YVqwBeHQRpAbh8WE2PEC3kfYQnl0TMxFVcLOPMkLWLwIR0L0qso2y3S4v0QC0B432+NEuSvwXouoCVxIF4nzk/3LgVeWuOEd0qEWPAOGbMg3MgJAUH5/jVEl8kKzmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yumTPAmalKrhZnbW4gs7Db582QoGDuXCB9gS0IuEgok=; b=yWaooHHKxMG3utEXxT0J1tDGyHrlx/MFEs0FTBPzV2riUPYZYmJucQdWDn1070sX6NzKTBgbSHigQepeboHRlnwnWbOx1e000uE+JvOdHDZ5cNUSAFmYB85LALqbkUs/0vHBbzJs604i/QUTHPVrn+uBvahjsDdyvVeRivZaddjw5XLvIFme0gNstCvIUb1B8ENlmVK0LzkQoQoF082u4TuCmOK4rAGk+UHkCs7tBByDo5k8EvB8mPLRgfpPs8zTSu3kfYBanRuJS2RKzWqzuX/4W+/aOwMf36ZgXh6X3x0LkkVmUmUoDgwQmn22fqqPMGMn07NNeiHzjwF9U8OWaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yumTPAmalKrhZnbW4gs7Db582QoGDuXCB9gS0IuEgok=; b=ln7YTBpPpZ0vF7is3H5yGHeNlcg+5R2m/WEDvK5xgr7J5qzN2C2OvivDqlAf3VpTHYxnuL8a/t4qYUQa1yn1QG7q7egcArBe7+iaHi4R2v9g3B7QNYkCHsnWBrq8LLlej992ST4t0RSpfuPGMSw0EXmfCxsxL9V1CgmclSkusA2E9uVOAmWbAJ0i/FTWpDZYgalsy6YHM7mZ0zSbvgh9Qj9DO/Y42hPtMCItejMCYW/Cxrxad3jqQkoSD4CYC0JaObBTB4loFqg70CYQ3oVZm0YyvMnDkKDAhvzL4llPWAhnXYjCOldsaOs9qeuP5dq+MM7pbafjDGMyQahHtFH9xA== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) by WA4PR08MB707242.eurprd08.prod.outlook.com (2603:10a6:1d0:2e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.8; Thu, 29 Oct 2026 12:16:17 +0000 Received: from VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a]) by VI0PR08MB10743.eurprd08.prod.outlook.com ([fe80::7a7c:d078:f125:f16a%6]) with mapi id 15.21.0546.017; Thu, 29 Oct 2026 12:16:17 +0000 Message-ID: Date: Thu, 29 Oct 2026 13:16:15 +0100 User-Agent: Mozilla Thunderbird To: no-reply@sashiko.virtuozzo.com, andrey.zhadchenko@virtuozzo.com References: <20261029110554.3315693-1-alexander.ivanov@virtuozzo.com> <010701a1875ad41d-a0c5e689-8264-466d-af13-8b992708dfec-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Alexander Ivanov In-Reply-To: <010701a1875ad41d-a0c5e689-8264-466d-af13-8b992708dfec-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: ZR0P278CA0081.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:22::14) To VI0PR08MB10743.eurprd08.prod.outlook.com (2603:10a6:800:205::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10743:EE_|WA4PR08MB707242:EE_ X-MS-Office365-Filtering-Correlation-Id: c0fc01c7-0bcb-43bd-618c-08df35b66f08 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|1800799024|23010399003|376014|261028144727099003|4143699003|56012099006|5023799004|261009223027099003|261026140227099003|261026121527099003|261021121427099003|261022105027099003|10067099003|261022075727099003|22082099003|18002099003|6133799003; X-Microsoft-Antispam-Message-Info: RrXpFAKWowDKmM8HaGNdA2aNqWkGESiGG88VHpxEnLVsDXn3u6ml9OT76pRtAL6iZJMcq+uzVV/kubG+gIk/jGkE+1F4WHiXMmxY/FA4NLkHoItJ3/0wfhXzS2zsurkHoKR9QBmnelKICJC2S3je521gOVo+KMP5h9fYUASEbMkpbTpqLzKJayxaNsUMVYFMyueuulICrVbMhRVnaJ1S8z/07pYH5ZhdcINQ/SYHj/jM0vauivNIK3Jm3aosl9FwkuL9iBM+fG6YyBY13fGSFEbg1xc5y5TWNE8YUT99TW2mbVBo3OdoxekbnHZ3Xsp1hp5rUh+Rk9Yvttulzuiuoh/qVh3Sg8NvI64V35pYZNLsETvQnR2k7ENbx75XfUuiBO9TOQ3UO6OiDrssMIqNb/Ms6wQZQmg1kNXbzALcUMmpmHJIdVAPfE9Z+YdsGpg88U8HRqM4DOHVtRgVHS8HATKjOlVrOOtvTQZbMlv14HlktwOYU7M1klvtFMskbsDp2YFbYmbmNUqQNITH2X7x33CFBCKnrDXRZc0jRaJ7601Sd/9SwYz+p87Qh5sHV7zmOptKkEpZnD0CQ1VnSFPymnvckL9RBNOocFgDhZ+Lbf4d9QRJZsF3NH8Oo9N5eDozX86SVTE5oTBK42PVcECLg0T5IVKMaYuH52nC9s2hAsc= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI0PR08MB10743.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(23010399003)(376014)(261028144727099003)(4143699003)(56012099006)(5023799004)(261009223027099003)(261026140227099003)(261026121527099003)(261021121427099003)(261022105027099003)(10067099003)(261022075727099003)(22082099003)(18002099003)(6133799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TFhoR0dwTzVrODBzWGRCTnBRUGVyaFFON2x6QVZGSWtJVUdHajRyd283SlpB?= =?utf-8?B?d3FLNkx1dCtNeTV3SkVEQkl0NGtvVkJ2dnF1bTBGaTl5WW8ycHpIMWRxUDU5?= =?utf-8?B?ZVQ3d2dQMlBVZjlWV3FqUk5Eem9vVU8zdDdid1hvTllPTEJqMVkvZm9WQ2kx?= =?utf-8?B?cG1rY29rWmJCb2xvbjA1MTloeXFlUXA0azF1a2FMY0grTGo2dm9NT01MMklJ?= =?utf-8?B?UlN3RzZzUExSQk5nbDNjQ0JLY2cyYjNlZ1RlZU5xajNyOVI0akxZZm1VbDZF?= =?utf-8?B?R09LMEsyaTFFRGZneVYvQ2ZaK2FReTR6eUMwYVNPQXREcGI4QVM2KzdoSlNI?= =?utf-8?B?VVlZOHBEbGt4emZTdCtWSGpVeVVZUnhXQlRVVTFtMnFlWkNKZFA0RmEreFhX?= =?utf-8?B?WmQxN3JWMmtQR281cFVFVFdkT3Q1QjBTNnNtZWFCRVF6ZE1BVjBPVGFDc3pB?= =?utf-8?B?K0J4NE9lK0VDY2ZONXRnRUtlV3p5TzQzZkZYays5TFJpM0lhdXZXZER0cWZ1?= =?utf-8?B?OG1mb1VzSUZhQ0hmR3JuZ0FrcEUwSFdIbWh1QVc0eFFmZXpsbENlZEY3eDIv?= =?utf-8?B?Nyt0bmtFQTdMMXdXeHRaUGpZd2pwd2tKOHoyR2diRmpQNkRvTWg1bFU0UlNN?= =?utf-8?B?bWVjajRNNVowL2puaGMyREZ1Z3JzZk11cklleC9DTjBuMG1UMHB0YnkrekNU?= =?utf-8?B?THZKbjNneUtQbCttdlFocnRhMld4RUlIL0VJYlB2b2RHSXZNK3E5QXdRS0tG?= =?utf-8?B?cGsweTF1TFJYVDc5K2UrRTRoMzFKWllWMXJacUlmS3poSFRkWEtBeDM4V3ZU?= =?utf-8?B?akJxODVOZklBelJTNldPZ2VualIxdmE3NmJScnNkZUxSbWwvTU9vVGR6Nngy?= =?utf-8?B?Z0FEZW4ycDk4V05xekR3cVZPRmQxeTZJZ1cvRHJSOFlFekJ4YUdURm9VOTR1?= =?utf-8?B?YmlQS2pzWmhBMXFnTGRFY2NtYWVJd25qWDIyeXA0WHViYy9GeTM1RUFNazR6?= =?utf-8?B?UmY4SElFWWkxL3lCNDVIT3pYckVCcU93cVFaclVkU2s4NysyZzNxc2FKQVhI?= =?utf-8?B?S0ZVUXlqVkJraFBiT3ZwZVEzU2drQzA4Z3B1YTQrODhsWXkrS3cwcWk1RFNj?= =?utf-8?B?RndveWRYK0h3enRIbzVUTjZvM2QwQmlsSjBzYTN6ZmF0MkRPVmtid29oaEJ3?= =?utf-8?B?RFRIb0tEMEo5djNYblZpNWhzT09VZjdpcmNtWG1FTU1CRTJ6SGtqdVpvNlMw?= =?utf-8?B?Z2VnZGpQNXp3dnJteXhPanczcHhqZDgxdnlLZ1hCMDFock0vMGxuaGFId3Rw?= =?utf-8?B?Sm5DLzFqRU1jeWM4V3p1OGNPd3FVd3RoRGxoVU1sV1Y3NkFkYUlRbllRbFNU?= =?utf-8?B?U1VsRDNqRDF1K2w2c3Q2ZXNPbld1VS9rblBlbWZiZTJjVk8zbElxRndSenRz?= =?utf-8?B?MDlpOFJKYnNjUzRWUzNNY1RmVHFWdmhMTmxmSkpSWWowWW4xaExYNkg5ZFVO?= =?utf-8?B?bWpwTlhaTjJhK2hTbDh6eGNnRSsrZnE2ak9SdmFMOXd4UGpYVm5Hakprdkcx?= =?utf-8?B?Ymc5VUNna1BwUGY1dVUxNGxqT1F0QUxkR0l2SWxURDM5SWcxOXhjM3hmbUxU?= =?utf-8?B?aXVwS2lNdkY2KzYwVWtLdVVtdWdzLzF0SlJZMVM0MFVQQVRoUmNEZVRYNnJ1?= =?utf-8?B?Umt1bEIzeGhEdzArUVN2SXQrZUR5a1RXQUovcTNlTVRRMVlZaGdYRlowSEw4?= =?utf-8?B?SDExWGpvbXlDUHo1a0Z0TEpteTNKM2dRbnNnOURXdFphZmYzbGZ4NEtia0JX?= =?utf-8?B?ZVJrSGIxejEvTjU1bEc3RlJNNFl2amh5MFRteU9BWG9UWTdyT0ZGV3ZPUFU5?= =?utf-8?B?RGpGa1F5SC9tdkhlVndlbHpTT2IveWF4YnZNVC9PVDVZa05jZlJKZDlhVVM0?= =?utf-8?B?STJrZEhMZHdIaXZTVlFRRWxia3Z1SFYyZ2dRY0tGWnRBOGpMY2VFYUxWcmxR?= =?utf-8?B?SkVzTUZOeUNiWCtqeEdjVy9vaEYzVm95WHBaSkRNdlFDUUhibjBKSVJqQXk5?= =?utf-8?B?T0NwUE9tbXZsMis2RTM5NnZWb0wyWG1zN3QraG1EQWM0TUNLWGw0WHpselNx?= =?utf-8?B?N1VvWk8vN25zNm9xbS9nRW5UbHNUUlFkL1ZEUy9aUHFBZmhhSDMyWGU4YTVr?= =?utf-8?B?M0NPeGFyc2Vtcmt4aHpzSEE0cVdmRmdlc0dOUnNmeVRTR3R3S0RwTEVDL3N0?= =?utf-8?B?YkFwZC9ZYThOUXFyVExvMzVhSmhEZ0Njd1RQSm1Sa3JFSXhXYlBCdzBKbS9B?= =?utf-8?B?NUdaQ29XRk9ndkY5R3p5VWNMNnh1Y3hUZVRNNVlLZU8rVkZFNEd1VzdsQjgx?= =?utf-8?Q?TbmwAt9yuaqz6eDc=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: c0fc01c7-0bcb-43bd-618c-08df35b66f08 X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10743.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2026 12:16:17.4932 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZZ8oaZEQy+MTGopmfx7BrZJfJpZb8SMVRmhbniM9ycU10EDCW7BJRVebW3CBDsQ/SqJ362HROG17W8/nU17BGxjdQInOJvrDZdAvtRlV+Dg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: WA4PR08MB707242 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1] drivers/vhost/blk: add support for worker ioctls X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org >> @@ -909,6 +909,14 @@ static long vhost_blk_ioctl(struct file *f, unsigned int ioctl, >> return vhost_blk_set_features(blk, features); >> case VHOST_RESET_OWNER: >> return vhost_blk_reset_owner(blk); >> + case VHOST_NEW_WORKER: >> + case VHOST_FREE_WORKER: >> + case VHOST_ATTACH_VRING_WORKER: >> + case VHOST_GET_VRING_WORKER: >> + mutex_lock(&blk->dev.mutex); >> + ret = vhost_worker_ioctl(&blk->dev, ioctl, argp); >> + mutex_unlock(&blk->dev.mutex); >> + return ret; > [Severity: Medium] > Can a completed request be stranded here, hanging vhost_blk_flush()? > > Once user-created workers can be attached to vhost-blk virtqueues, a vq > can lose its worker. When a worker dies, vhost_worker_killed() does: > > rcu_assign_pointer(vq->worker, NULL); > > After that, a bio that completes goes through vhost_blk_req_done(): > > if (atomic_dec_and_test(&req->bio_nr)) { > llist_add(&req->llnode, &req->blk_vq->llhead); > vhost_vq_work_queue(&req->blk_vq->vq, &req->blk_vq->work); > } > > vhost_vq_work_queue() finds rcu_dereference(vq->worker) == NULL, queues > nothing and returns false. vhost_blk_req_done() ignores that return value. > > Only vhost_blk_handle_host_kick() calls vhost_blk_req_cleanup() and > forget_request(), and that work will never run. The request therefore > stays on llhead. Its bio, iov and bounce buffer are not freed, and > req_inflight[] is never decremented. > > vhost_blk_flush() then does an untimed wait: > > wait_event(blk->flush_wait, > !atomic_read(&blk->req_inflight[flush_bin])); > > vhost_dev_flush() skips killed workers, because __vhost_worker_flush() > returns early when worker->killed is set, so nothing wakes this wait. > > This wait is reachable from several paths: > > vhost_blk_release()->vhost_blk_drop_backend()->vhost_blk_flush() > vhost_blk_reset_owner()->vhost_blk_drop_backend()->vhost_blk_flush() > vhost_blk_set_features()->vhost_blk_flush() > > The release path can hang, so the backend file reference is not dropped > and the vhost_blk is not freed. > > The hang can already occur for the default worker in vhost_task mode. > This patch also exposes it to user-created workers, through > VHOST_NEW_WORKER and VHOST_ATTACH_VRING_WORKER. > > Should vhost_blk_req_done() handle a false return from > vhost_vq_work_queue(), for example by cleaning up the request directly? This hang is pre-existing and not introduced by this patch, since the default worker can already hit it in vhost_task mode, so we will fix it later in a separate patch. _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel