From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.openvz.org (mail.openvz.org [69.168.225.77]) by lore.virtuozzo.com (Postfix) with ESMTPS id DA5DB8045D for ; Tue, 3 Nov 2026 06:42:49 +0000 (UTC) Received: from mail.openvz.org (localhost [127.0.0.1]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A36fVsE001396; Tue, 3 Nov 2026 09:41:32 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A36fVsE001396 Authentication-Results: mail.openvz.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="Z1Jyw1lw" Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mail.openvz.org (8.14.4/8.14.4) with ESMTP id 6A36fSHD001391 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=FAIL) for ; Tue, 3 Nov 2026 09:41:29 +0300 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.openvz.org 6A36fSHD001391 Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-3ab926c236aso2987360a91.0 for ; Mon, 02 Nov 2026 22:41:29 -0800 (PST) X-Gm-Message-State: APuU4Z/FPsGC2LBJX0qzUWD5Qk6v2TzNTwChGQEkfX3VDHqBchKMOXTU vdDC87uq4ma2n9khPpj9dDcXo6WLqIiUr1f80rqjj4cMWE7s334G3kspiXzA5DTVur8u/lw1g43 h1JmUt+vDx9KP1k+CfLmD1KZR56FkDG+bhBASPELSNP2Z8Xk0CWLZew== X-Gm-Gg: AYBFou2WQawgLf3LTq5UJ0YCjS8GusqTZV9jL0XvmdfQQEFVkNcbQFMD+hyH2oucwVq TxCU77ioFHllaems2kdA5LQLw8hJSUitT7E9kG41Iyj6blozCmYnVWjxpg4L3CO8IyVPT0QTgJj /Wg2UVHcOK+PzqLrzagOsOkhpnRXSMQ5xAgI5A1xK0CAwt/NdX2gnQprDZYfThec6VVwDOW2Tam ymw2Qs6E4PQnFEpiwX8+3y8x6Li6sNtJn7nWWMRBaGC3SCodyWESUeAyQzD3rtzZ8Gt6og4Z16t z6PPo9bvsgylQ5ioqcdAHA/wo+FHxa66Mbu+qVOpnVs+D3tbT3Js+8HD+52JsDlrB3CCmOWw2H6 BobJGAG78yCiUxDjwiGmHFlF2Uwr3CF9DTh3FzV98QGDgELaq7s6DBhlMJRBBl/CDojef9CZwXw IjCujff6zN+jAj74yNT9vlcAUT7ClcD5Ia X-Received: by 2002:a17:90b:2b4f:b0:3ac:8897:7b98 with SMTP id 98e67ed59e1d1-3ae89741d7amr9681306a91.32.1793688087787; Mon, 02 Nov 2026 22:41:27 -0800 (PST) X-Received: by 2002:a17:90b:2b4f:b0:3ac:8897:7b98 with SMTP id 98e67ed59e1d1-3ae89741d7amr9681295a91.32.1793688087230; Mon, 02 Nov 2026 22:41:27 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1793688087; cv=pass; d=google.com; s=arc-20260327; b=s8pu9f0HUP1gRU4E0Eys1fa3PJuuvcI8SU+HghC/aPP55f22wqH2DvPB76Qtq+Cagj V7Z7Uo0b718Hgx5mIt0CVbTe2q5i/oe1cZsadHiPX8kWvbW/oO5p2XYjblLDMO+n5/Dd ZSnhtH+G7/b9zG8sCqGuypzqS9zqyABTTQkkLPZcy7m8/GginHRKWKZr7Irx1oq2GTa7 /CG9IPyj+AAY682T0YMX+u3pyw/Edf5mM/wfhaVHwRzqFsEG9M4Q3roLQVKnzLfvQEbg IB1Fch2OX5RDzLGWcWrufnd2v1zD9LPXqN4P2L0se+mvrCJepkJeCaE98F09yQjx8r1P i/9w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=mime-version:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:date :message-id:dkim-signature; bh=wknkuTQoBEwCDau5PSDoU70/HcwLxgdKBG4bzu1fwSY=; fh=K/aF4mylbRspO5jRtw/PQx/jWAuPfOe+jQNgz/MCECM=; b=UVK7GhqyJOR2+ZcehtslYZ1iOPkY5zIQzWQkBmKh/0fsFV/rW+Mq4fZLQ/VHVdPbyE iABFp380bCUH8NI9dxQ/5+b6TiWSmIQUBb3r4bzSZoXot2/eME63zjAHgL38wwUJZy0Y AYnKun4/lEdjZYbkreAIIU/8ImGQXhmhgVPa5wkYDW+H1UViFHTp4mNTvJyetmZNeNK7 wOv3emQtgIwUNyAGQNzFJLSJa/nqjikNro+HKlyvfQ5LHGEElCRETQ3wZPmxVEqpjeTP 1mAfFnDmKayt7KCpw0RthCRNAM+g32HzIqjxrQ6mYPA/fRXiVQgj0wqhaIXgPkK8othJ 60Zg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=Z1Jyw1lw; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 2a01:111:f403:c20f::7 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazlp170130007.outbound.protection.outlook.com. [2a01:111:f403:c20f::7]) by mx.google.com with ESMTPS id 98e67ed59e1d1-3b07c7a3d18si3451919a91.4.2026.11.02.22.41.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2026 22:41:27 -0800 (PST) Received-SPF: pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 2a01:111:f403:c20f::7 as permitted sender) client-ip=2a01:111:f403:c20f::7; Authentication-Results: mx.google.com; dkim=pass header.i=@virtuozzo.com header.s=selector2 header.b=Z1Jyw1lw; arc=pass (i=1 spf=pass spfdomain=virtuozzo.com dkim=pass dkdomain=virtuozzo.com dmarc=pass fromdomain=virtuozzo.com); spf=pass (google.com: domain of andrey.zhadchenko@virtuozzo.com designates 2a01:111:f403:c20f::7 as permitted sender) smtp.mailfrom=andrey.zhadchenko@virtuozzo.com; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iq7noI/yFlaw1OHz0tBBqhpXfY+3P6vEEAvPoOAqaubuaKAuHpEW4RDTnMPDRc8CCYDt+/Aa/85kCGVoypDYbXgaG5HlSB+7YBgoXtZ8GoPQe9c9Zkfb3+DXOl3O6xClV/UJHVnrHUGHv4TdKvwkTQ/urzgF1lkqOeVH3MYRwJAczWFSRFmnu5BRfWda8orqfPGcYj54PfYFc4/b8+S3apenWp4nzVxkZepbsa82um3a99TyKEtTRbXBoxvPPG3ilWq0X+71EBf1tlyyUFgJ0OJGjZnkAFz5d+IJAVQdzJYk3PeQA9BuIaQ2tztTzXpPDjanFLW5F56pu88aYoK06Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wknkuTQoBEwCDau5PSDoU70/HcwLxgdKBG4bzu1fwSY=; b=AApjOSrj4WbicAmmG8Sb7KtklFllFzn3yHQEjYvg0/r79fWi3WrWJ05GNVRf/SMpGxpDwndLfOoGXN93S/KF/DaTDE/BTnPgGFF+e9WHkCGkFOl5brYrJIRGG81HEyJxdh48KT33h5db5EXqQN4JV7IM91PLDnpdngHJUq1RAqTxkwcNflHm9W9ZLQulKdfpFcecE3IZ+C6IhnUDPAovIcoqEt3hTenBIMMY6RxLMfsGSGj4LvCuPiwvLsyy9dCg0k0+PXr6z+oyLz0suMq801/S58iZ8Wrl/7NEVryVDlQWRlH4SRv9YMSQ08uIXjydJtGcqJ5mu5dRtwaUMOndWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wknkuTQoBEwCDau5PSDoU70/HcwLxgdKBG4bzu1fwSY=; b=Z1Jyw1lwvxfSZSPG10+s7Y2N4blAtGTEOPHC2RIQzRr61FPtSCejMe045IxRbOL8fyuL3M1KNGrm0X0gln9peW8BNOhSbFtJz2OPmQpnw1GpJJpM4M9FDBVbIWyJbSzp/yQzwhclO7AInJ37FC2nxHzPHWBHjWhGAVTxYcGYBwTZGrzk1XXdlc43aNOqsV26SLOLD3qpuem2VKNTT1xTkzEKYctwxYlPel+zq073kQwnDCCDTbkpYKlV3RMktxk7VWyKzZOjH1Mdo/pKC4VubxiACJMz8Xtin9q5PwxkGImw0PCbu65HtkFudiLmSg/8KeKY5bcz+F6HQibWmKNmTg== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; Received: from PA4PR08MB6061.eurprd08.prod.outlook.com (2603:10a6:102:e9::13) by DU0PR08MB9533.eurprd08.prod.outlook.com (2603:10a6:10:44f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.12; Tue, 3 Nov 2026 06:41:22 +0000 Received: from PA4PR08MB6061.eurprd08.prod.outlook.com ([fe80::c3bf:e107:b1d2:6a00]) by PA4PR08MB6061.eurprd08.prod.outlook.com ([fe80::c3bf:e107:b1d2:6a00%4]) with mapi id 15.21.0592.007; Tue, 3 Nov 2026 06:41:22 +0000 Message-ID: Date: Tue, 3 Nov 2026 07:41:21 +0100 User-Agent: Mozilla Thunderbird To: no-reply@sashiko.virtuozzo.com, alexander.ivanov@virtuozzo.com References: <20261103061752.720813-1-andrey.zhadchenko@virtuozzo.com> <20261103061752.720813-7-andrey.zhadchenko@virtuozzo.com> <010701a1a01b42a2-9130a6ec-9fa6-4df6-86ff-367560989509-000000@eu-central-1.amazonses.com> Content-Language: en-US From: Andrey Zhadchenko In-Reply-To: <010701a1a01b42a2-9130a6ec-9fa6-4df6-86ff-367560989509-000000@eu-central-1.amazonses.com> X-ClientProxiedBy: FR4P281CA0419.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:d0::18) To PA4PR08MB6061.eurprd08.prod.outlook.com (2603:10a6:102:e9::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA4PR08MB6061:EE_|DU0PR08MB9533:EE_ X-MS-Office365-Filtering-Correlation-Id: e4297466-7ef8-44e6-0597-08df39757979 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|23010399003|366016|10067099003|18002099003|22082099003|56012099006|4143699003|261026121527099003|261022105027099003|261022075727099003|261026140227099003|261009223027099003|261028144727099003; X-Microsoft-Antispam-Message-Info: BmcMiKGiO5p/vNWalarWQ8PgUjPZ2T0fTgDbG2IqyuBCudXQaYI1VzaF9rNvSLk0/M8iz9xcODLcQXrY7h4Yqsvu8sIqM2K854jZ6ovgbqVEbp9vhWePeXkoHGX/VmqVuNKPj2ncFbhuqIzoM5yxCjTSDENdyJTiGjpa4dUTpfODWK/mVRVyEy23InysVLgfSAgVYZCyrX0JFykO18ipgZiELLIin+d3XhxIwSQgLIvHSMcK8z2SOYuRK7JOJNvBHJ4y0XhpML3+9W64qIUpC7sooXPazm1+2iEkFbW5Sd8ODBlnRja4ev8pFb4VQFPohtFKXtVjlDpEUW38MkGqn6Cf61OcRQmikfjbLgb0+nwuQl8cnWSZ6OOuAEjnAzhWgKuQZpU7ZKsz/SsbbZOcl5zT20bsr89H+aopH4U8ZT83L7htjqFvsv8m419+W+DR6GQJ9mvNAWTNzyrNjUy92Kf/kkV09GwbCuw9uIr/HSGZq9/cxHC/aJSFXWBZR+jlnGI526Ip9BUIuTns0Rc6mtYg1DVobmljCRJKRbdprLr15t9ZTdjVjEsxkls9XSnHxHngTZylmjcoRsemnnC5UcsvOclv9ZQLLQR41uG3VP/AIcdWwK0O5AxQt2Ft5ekQ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA4PR08MB6061.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(23010399003)(366016)(10067099003)(18002099003)(22082099003)(56012099006)(4143699003)(261026121527099003)(261022105027099003)(261022075727099003)(261026140227099003)(261009223027099003)(261028144727099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cmhrK3Juc2xVck53aFhEOXBLU05oN2ZlSzUxakd6d3g4SU11ZnJyVDNmV1pz?= =?utf-8?B?WVA5anJIbVJRMXVOMzVtakl0RmFZWXVGc1ZKaFJFT3JwS2R1WENKaGJIVUd0?= =?utf-8?B?VzJSRmRsbGdPOVZVOTVYUlJzTXVSMG1GMlFsRGhlMHpqZFl5eVNJelR1amlR?= =?utf-8?B?Um9JYmlCeWhGa043ZDNMV2F1THBjbWFEUzUycHh2UzhNVUlOemQxTUN6dHdw?= =?utf-8?B?OWpWaUlTVHRoV2Rlb3dQNGZNME9zYkFnZWY5WjQyMU9mdVZPMFZ2RkRLd1VB?= =?utf-8?B?YThCNUNqOWZpeUpLOFUxOXNsWGFmUmM0dWFZOTRtN2p5cWIrQitURmdaamw1?= =?utf-8?B?OHE2aWtneGJDWVM4NlZINmpzdmZhVEtkcGZIOGovMVJTTG5FTGtjWW9mMHc4?= =?utf-8?B?M1VFNFZSMmlseUt5OFhFckpGWVNMZzFPYnZmeWhEVkN2OHB4SmQ2ZHJTVHd2?= =?utf-8?B?L0RYNy9DMFlNSEJQRG1jTHZGTWZkMmFQcFFyWGJRT05BUGJIR2FGUU9VeFc5?= =?utf-8?B?dTRIdWF2b2xzQlhYTnpjZ2tIUG9BU3hTWkhjV055V3lYL0tTM0JKa2NFQklL?= =?utf-8?B?cmFQQlphbXA5WGpycDZ4dG1JTGd1b1duNDdhVzc1a0tuV1JhanBqYU1jZGJI?= =?utf-8?B?dGFYenljQ2pRQlRiejVXNE1BVWFzeVM2ZTkvZHBkalpRajFoZnBLbVVpUm45?= =?utf-8?B?RkRwNEdYbkN0TDJqdW5XMkgwc2Q4cE15Z2ZWRGNGRDRybE5zVWlLemtJcVBy?= =?utf-8?B?dDJ4bUtUQ09uQ0JGOENVUUFXTHJCRmsxYkl3OVJYNUJQaUFhMkkxU3d1QjNr?= =?utf-8?B?cGgxcjdsK3pMOEpGOVRzNXU1aUk4WlhxQllSZGIwMlFCTDIzMzMvamErV0Jq?= =?utf-8?B?aURHRDV4Tks4TmJMQllrTHJ2NFpmemdPOVBmaUp0N1Y1dXFYaEZQdS9EMnlM?= =?utf-8?B?dm9ZUldpbGlnWjFBSkdDWXcrUE80QmJrelZ2ZmR6c2NLWCtXdStDYmRtdDZ3?= =?utf-8?B?SDRzSHZadWV2c2NzcXpYZFdFeVRRVW4rM0JkZWcwWVNwTnRFeDhaNjZYdXM3?= =?utf-8?B?Tm5VL21tRUREcUFaQ3c4VkFObjduUFJ5ejVzQTN1c3JxQXJ6R1J6MTBTSTl2?= =?utf-8?B?dVdHL0xoTnBheGpiOWVZb3lIa2tQYm9MMHhvczhTS3VWU2dvWkJqTnZQcjZy?= =?utf-8?B?N2xuV2lOQW94bzEwK01VcVcvQ3BldTNLb2crVjJMSEhmWENJTWNkaGpsN1pZ?= =?utf-8?B?TlZ3MWdqNzJKVkZ2eEtFVnd0MElmUnhQMzB0TnFZMkxvQzE2VkNDQXB2c1NU?= =?utf-8?B?N0ZaaGVpQ0YremI4OUx1RXByYUNKWnZBL3V0U082dW5HNDVVSVNYT0cxUnJM?= =?utf-8?B?My9HWFU2UjlnRDYwekpwL1hnSVZGcXN0RnBMTXc2djhuWE5ZRVN5eHorMjIr?= =?utf-8?B?NXdvWCtXdDNLdUo5dmIzY1lkclBIc0NFNm1BRCtCbFQ1RWtkV2E1aTJTTzhD?= =?utf-8?B?WVpESktUZ1hLZTBwMHY3cUpPcGRDSHRJekdQNFJTVFozd1poQjlPVGxqekUw?= =?utf-8?B?Zyt0b21XQi9yd2hMT3pvV3BiYlV3QmZUSVJPSzF3RjVwNzJDbFRBWjV0NzN0?= =?utf-8?B?T3FQdU9sbmYxdlEyYjF4ZkJqZ2NSRmFvbnEwQXBmUUxPdmhKWWNZSGhQN3lt?= =?utf-8?B?cGh6RlNhT0pWVWR1RzYwcU9Xb0UzYUtZZ1VYdnI5Szg2QWNmMXZ3dDFOV0tX?= =?utf-8?B?WUtNY0pjS2NZUm1rRUdub1RSb2JjSTB2Y0RMTTNHNGpYWGk2OXI3NVF3VnJ3?= =?utf-8?B?QjZ0K0U3blhTcnRXMVBPdjFGZDFJOTVKejFCOVZOWEFVNDhINUxMN09yb0tt?= =?utf-8?B?RVpmM0x1NmxFbVFETjhSdUZRTTMzd2NBNzcxQXkwWTl3b2dBUjBOeFFkSGc5?= =?utf-8?B?cFI4SG05b25aR1F2S1BQT0ZQUHByMDA3WnVNaHQ0NzlLd1kyT1lFb1VucnNO?= =?utf-8?B?d283elZtM29DMEpSRXBXd0ZuZ3RuSGsrV0lxZE9uSmRCYjM0bE5OV2NBZDYv?= =?utf-8?B?dExzbWpCUmdaKzcyY05IenBMQzJ6cDFxbHFWS1VJeG51V1A2Z3dVajRvajhS?= =?utf-8?B?QWxycWZURE1BVVl3VjBFQTdHTGRUVlljU2hON1VGQ2J3b1RjcWdVdG5sSGpG?= =?utf-8?B?R2h0QXd6NlBXZ3MrR1hBWEFmb2pIa2V2TXc4MWxtYjM2M0pFd2pkY00rbUJ0?= =?utf-8?B?OEYrN3g1bGxEK1RNelJBczhUQ1B3OTAvNytRVGREUlNJK2lTcitVYTFuNWFq?= =?utf-8?B?WjlRTGgrTTFRdGlTYStieFVLaVBYNThOY2ZuVkQ0TFBneVlOaVIzVFU4K2JM?= =?utf-8?Q?VjzOatMbR95kg4C0=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4297466-7ef8-44e6-0597-08df39757979 X-MS-Exchange-CrossTenant-AuthSource: PA4PR08MB6061.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2026 06:41:22.3627 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KErJov86YWXzN8QVD2j7KIc/wNtTUFzRTejcbKjUmma4R7MzlpjaOrqkqAfF9AiS9pfdhs/TDIzCe79y7Y2yVOrkfO6HnFsbT9B6+jPGyj4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9533 X-OZ-Fwd: true Cc: devel@openvz.org Subject: Re: [Devel] [PATCH hci-8.1 v3 6/6] drivers/md/push_backup: add event file descriptor interface X-BeenThere: devel@openvz.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: OpenVZ development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: devel-bounces@openvz.org Errors-To: devel-bounces@openvz.org On 11/3/26 07:31, no-reply@sashiko.virtuozzo.com wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > - [Medium] dm-push-backup: event fd pb_fops has no .poll, so epoll/poll always report ready We are not planning to use it in non-blocking mode, so this is fine. If we really need that we will add this later > -- > > commit b2845f9ea4dfb915a0897be5e674c310ca9217b3 > Author: Andrey Zhadchenko > > drivers/md/push_backup: add event file descriptor interface > > This adds a "push_backup_get_fd" target message that returns an anon inode > fd. The backup tool can read() that fd to get the next cluster range and > write() it to acknowledge the range. This avoids sleeping inside a dm > message with md->io_barrier held. The patch also adds a kref on struct > push_backup to tie its lifetime to the open fds. > > Link: https://virtuozzo.atlassian.net/browse/VSTOR-152912 > >> diff --git a/drivers/md/dm-push-backup.c b/drivers/md/dm-push-backup.c >> --- a/drivers/md/dm-push-backup.c >> +++ b/drivers/md/dm-push-backup.c > > [ ... ] > >> +static bool pb_has_event(struct push_backup *pb) >> +{ >> + return READ_ONCE(pb->destroyed) || !READ_ONCE(pb->map) || >> + !READ_ONCE(pb->alive) || !READ_ONCE(pb->map_bits) || >> + !list_empty_careful(&pb->pending); >> +} > > [ ... ] > >> +static const struct file_operations pb_fops = { >> + .owner = THIS_MODULE, >> + .read = pb_fd_read, >> + .write = pb_fd_write, >> + .release = pb_fd_release, >> +}; > > [Severity: Medium] > Is the lack of a .poll method in pb_fops intentional? > > Without a ->poll handler, poll/select/epoll always report this file as > readable and writable. A tool that adds the fd to an epoll set would get an > immediate EPOLLIN. Its O_NONBLOCK read() would then return -EAGAIN, which > the UAPI header documents: > > * -EAGAIN - O_NONBLOCK is set and no writes are pending. > > Polling again would return immediately, so the tool would spin. The only > usable way to wait is a blocking read() in a dedicated thread. > > pb_has_event() already defines the readiness condition, and pb->waitq is > already woken on the relevant state changes. Would it make sense to add a > .poll method built on pb_has_event() and pb->waitq? Adding it later would > change how this fd behaves for userspace that already uses it. > > Also, pb_fops has no .llseek = no_llseek, and the file is not opened with > stream_open() or nonseekable_open() semantics. Should this stream-like fd > be marked non-seekable? > _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel