From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a0fd865042-b26931bf-69dc-45bd-977e-5749c8df2256-000000@eu-central-1.amazonses.com> Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11023074.outbound.protection.outlook.com [52.101.72.74]) by lore.virtuozzo.com (Postfix) with ESMTPS id 797028017D for ; Fri, 2 Oct 2026 16:50:38 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BZE4ITZuiPgBUiDW0puUrHb1UOd+/QWgvTUGBkTH03aIOzSXAL98aErliYosRiZ/Z91XbvIyRdOzuCe0GfJ6IIavC8QAub92+g7AXWw0rs8/RxNyhyuZzQnh4O8olwTJzE9qUq3RYfeOWD8G+3o4/PAm1ghMkAv5Z0nHbIhOEdOXXWLKq+Wx22TPnf/1oO9ogWxW9SbENxKIBHcTNh5t8+M+Bek17PxyjDZPB82A6UPKQRadqxnHHdvh4EpB1ged24mAk69sIa9vP1Am9fE4Y0k/Y1/aKcfSCWtzZA7dZTh9X1H9FQ43IM1oqET++oGU99u4QCtpNhYd5hpBS8cvSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+4LKD31MJV/Uaoe+54zaZsrJfM2LkkHj1onKTt4HqzM=; b=Rcva7S2WGd+eUGw/VD9bL9blD3LmHA/8N+4JH+HQCM8OgdhBst4fzgaaDUoNL7DTlCrkNncbYNeB+mftXxNAc+Yzct7N4XIzsTUyAc/LgFkB+RF8pY86ecfEt9hxNDWAicT2P7EsL3thmBH9nriA/F9HGZ4Qx6vIwxgwk+c3ci5AEJqgJVhlsdvo3TOp9VZdKccb/1IlPE/cTWGkCVO4u3z5g4sdC0bOauUjwGQoOi/a9fSpp5+YRPE44RHZtmZOf7VWt8SiVWOJ6k9W0NeP3ngUqn0feRXRvaAnqby0b6AuZvDyI32hV7SerGleEPR4DeaKcpuKbXOc2MifaaRJjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.6) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+4LKD31MJV/Uaoe+54zaZsrJfM2LkkHj1onKTt4HqzM=; b=WEzE6+16DjV81d+J6pSZ7FYO/P+eTZUes74bAoIVBcCyqxC9SpUNkDxRxZ+pGGYQ92kY9ONvtzzzlrzee+wYteraXLYkFcOznmYpswOGi33pyppbrlNImPIolmehN4iJKMAglLPrbOdOHUwTDYbSubWyihqqJAu3sj8NGwDjM/k= Received: from ZR2P278CA0047.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:53::12) by MA9PR08MB399289.eurprd08.prod.outlook.com (2603:10a6:250:107::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.12; Fri, 2 Oct 2026 16:50:34 +0000 Received: from ZR1PEPF0000E462.eurprd04.prod.outlook.com (2603:10a6:910:53:cafe::78) by ZR2P278CA0047.outlook.office365.com (2603:10a6:910:53::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.472.19 via Frontend Transport; Fri, 2 Oct 2026 16:50:34 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.6) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.6 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.6; helo=b224-6.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-6.smtp-out.eu-central-1.amazonses.com (69.169.224.6) by ZR1PEPF0000E462.mail.protection.outlook.com (10.167.241.52) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.472.14 via Frontend Transport; Fri, 2 Oct 2026 16:50:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1790959833; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Message-ID; bh=+4LKD31MJV/Uaoe+54zaZsrJfM2LkkHj1onKTt4HqzM=; b=ALyDseGBwAjIcWp2ld5Nltiw38QDRFg46UQl8A95sNNb72dKkhF8WDD0l2wnUFXk vcX/7vZky7JdqEU3Z9nvoL4XFae+n7aTfRb3b6CUc+FJ/NfIkqn/K/XW4bVPdae8b2O vPMqPRUXp+igNV2Txwcx7I82URZf9+n9XyUeQYJl7cwMwRjY2Wn0b19tVB8+xiUe6BS Scn4bUvP/XASDGLUg4V31VXMOcARM3UxdsAzv3PuWa9s/20yS1g/WTXlIx1ybfwCQPx JJmQqLJPFsaISUg4H4xiwhaFDS9YxvNXWnEOgfs4fZllnW4vUpqvtUnv5ia9Fi1Mw4L 9ZE2vRAZCg== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=sokbgaaqhfgd6qjht2wmdajpuuanpimv; d=amazonses.com; t=1790959833; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Message-ID:Feedback-ID; bh=+4LKD31MJV/Uaoe+54zaZsrJfM2LkkHj1onKTt4HqzM=; b=N2YSGBf1ASn3ehbqLPu8660TKuO5hUkgQ9ZhqD6TTBmhgzelO/L3W+tZiU+XFP/n bu54QfZ5nNr9eJ1q7yQLXgytNeFOcM/KLfITzw3VbWXcDMAx9cMLM2WvZcrLqy3pXQ1 WQE3RglykMqwbsrBkTcg83xdFYepqPpb2/V5mCjw= From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH 1/3] chardev: implement cpr_claim_fds() in the base class #VSTOR-148304 To: svt-core@virtuozzo.com, "Denis V. Lunev" Cc: den@virtuozzo.com, andrey.drobyshev@virtuozzo.com In-Reply-To: <20261002164853.2130337-2-den@openvz.org> References: <20261002164853.2130337-1-den@openvz.org> <20261002164853.2130337-2-den@openvz.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 2 Oct 2026 16:50:33 +0000 Message-ID: <010701a0fd865042-b26931bf-69dc-45bd-977e-5749c8df2256-000000@eu-central-1.amazonses.com> Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.02-69.169.224.6 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: ZR1PEPF0000E462:EE_|MA9PR08MB399289:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: f756c6d6-91c2-46a0-98b5-08df20a546af X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|61400799027|376014|48200799018|9140799003|32142699015|10067099003|56012099006|5063699009|4143699003|5113699003|4113699003|22082099003|16102099003|13003099007|55112099003|18002099003; X-Microsoft-Antispam-Message-Info: tnoBQzjOTQTXSsZDZVWdcsfBsw3garJkEHTRcdkky1aJOobDts8VeHy5OkNsZ7dwpZ/q/7bZ1EuYfWreqF7gm73H+8hFVgsKrqMIQOUTGOjlYC5XUQAdt5aXdi3meNFn2PXWpHhnyhimVrRUTWSpcKSMWdjq4AWbDUoyTyhVMla/HxMidSvlhFMEEQDa4giMve4MynzwuBScYynuLc2LTw2AJvk2klOIJ17iox+Q+aVypoHra2sgmGULPt1YcpSvent3vVxrroBnXLg9mK9HqKn/6+FCweyLN4QNRk1+tq2FsNmVqPT1edwa9OXuyKKKDXe5JC7bBHNlY3L8nZcPP7WqmchYVrBC1/y1bT7V0Khvr4jdGwV4Db9AzfT+9sp0HBrGhTRJ4HwbM6JrKSWTnArO2mrIlyE1ucJa2YAnWBB0y++pTK4Fv+NFXZbmjZuVSsbUfrxBvlBVTc5Je2bGfwgn0+LRjHQIxnHrsPurwMVOvvjUbnUxhxHbo6uulvURFcgnN40qKnj9eh76lj6/B1UvmR2poX5Afqdo8PcLpw/j5+HEoYeNZwlqVA/ISB51/tfEo42QASYRw0ivR4t/BmfGvNzeIcxlMhnxKgKf6DIfqhrQHf0nsCgxOC068v4WirNNDQ3rybuVdi9MbxY7zfDI2WEFbBhkiW6T8zPUkB1uHem6o2xCy73wUGON0OQ9AGRw3sRSmG5jPh7ZLxdgYycF2I5HomuV6diVJEpGsMS2Zn+KQYv5fDy/5c7zLjkwkqjFIFDjUGSOGvipHMIIcAZPWDXjL182wy9FLDCmRTra+RrohM0/1J+tZbQp3sJtRn5hdy2klyB+izdE76ckibIrKtcvLQQcW+3dLWDS/ovsuvHaPXBswKKdYAKkhnIpQTWBx7zMtRj/VMlHVshPxA== X-Forefront-Antispam-Report: CIP:69.169.224.6;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-6.smtp-out.eu-central-1.amazonses.com;PTR:b224-6.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(61400799027)(376014)(48200799018)(9140799003)(32142699015)(10067099003)(56012099006)(5063699009)(4143699003)(5113699003)(4113699003)(22082099003)(16102099003)(13003099007)(55112099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 0VSPdUmzU7MKiFlm3FuhznJW/U7WybaEqa9prjcv0/JNnvwrsAT06ZiU7VO63clsjyX3HoAOf63T9ZNxs5XUMdrx/1y8B8rSueRheGj9FtE0MconTeejsJBAPTfjLo0VcYN8Qnhtl1agtWi/+pHj0WF9jcTLgYd+/8549k7euqcLbRLnADshXTXpaZgHR4DaYpPJRujQ7feY+7RgR1Q5YFqv0ckNR7BfDKFLV+llg7qWJCap03xyIpOrFgHKd57FsmKTBEnbBAb1GQPnkMbgg/0FZW6KwQw84Q4O1JeQ5YqfEiM7NVrH6trtDcv7gSHUjX7XvKu/hYbiFU3zrYQxr+PuYPKX6gdZUCZ4QmAvGzsmySsNsu6qws5dYpdoh+v/Sc/pOvrPGypbsvPKW25A3wkCt1IIL5oPxgQKOQOh16x/JwI2zk3dt8aeceLc2uaM X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2026 16:50:33.6910 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f756c6d6-91c2-46a0-98b5-08df20a546af X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: ZR1PEPF0000E462.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: MA9PR08MB399289 > From: Denis V. Lunev >=20 > Give TYPE_CHARDEV an empty cpr_claim_fds() and make the file, pty and > socket backends chain to their parent's. Every chardev class then has > the hook, so qmp_chardev_change() calls it without a NULL check, and > state owned by the base class can be re-claimed there as well. >=20 > No functional change. >=20 > Signed-off-by: Denis V. Lunev Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/2026100216485= 3.2130337-1-den@openvz.org?part=3D1