From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a1213677f5-cf439a3d-cab9-40ed-bd89-4cbc95c93ad3-000000@eu-central-1.amazonses.com> Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11021115.outbound.protection.outlook.com [52.101.65.115]) by lore.virtuozzo.com (Postfix) with ESMTPS id 43FB28017D for ; Fri, 9 Oct 2026 15:09:45 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gjLv+xf9+Dd3uTGhm+B3ti6iGwjYajh6g+09SL6kOufxeaY3SGugeu/qI22dlpP2vPcZ9HT6RFIo4qFvwTk0R15u7GaPbqQpDRxh5JUEL4u9b0Odiyrp1vB2Zqir8eDpVrdvD+pmVraaN+It3dOausbl4Fq025vjVseLTwcogQYLRIu82upbwhNwd+ImOOkws51bhdxLl9G2cUtlBHnCT9BNMJjYI9U1RwJVhvbprdecwpEJqiPjXy4KZuRrGld/hgiaeSHUSvEwSAImaRbT14xoFu5uegw6XNgtujwaxLseAg6zz6vN+zIVhZcMwpUtdhn3IWWNmwDzuZ+5o1ZEAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HS8hgpmNy33IVZHCS7fPjOY8oB6YrcM2cYzA/1YVsJY=; b=VSGrKPk8hUN5eX2JNVZTTDHdcrxJktrmHg8O1QddNVeotq+jt+X1dQJyOUk+snOI36I4KrcRbfUy6MdGcYrBgfsjLjuFYb7FNjuVZxilcvUX33HmOFAWjKs4R5cFiLODCmThtuVnY6gmChW/aNoOSVp6IuCDmW2otMSmalBbNwn+FvPlSGTWJgzBdGDt/wVh/ImHnQxL4n3x6LjRgGsevxmq7kKuO8ujE5vjx/fo/1kAgYGTCnH8SUyQXBcChosiX27Gtsa0w5rPid7Cgsp1j5WR0k9+qcPswO9i4GAcdo1Gvlr+AbgVZctAiLrH57v8M3NsjVXQbza03xglM8fTrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.1) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HS8hgpmNy33IVZHCS7fPjOY8oB6YrcM2cYzA/1YVsJY=; b=TBNZ/Z/Rise0duBBVKSQ1KRlVMBVnnOXcfh9LiYuyAR/aFf9Q+eRMTg2gJVLES2LoUgdC/AwabMEWUV0lR6HLZnmtgsp+celc+GG7Kny2rTLJMvu4sa7w3hJNhhUwN/+NlQ09i0lwdR8g5PyQFwqlgI9DvOc3keVsQMBIadquF8= Received: from PR1P264CA0036.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:19f::23) by DU0PR08MB9800.eurprd08.prod.outlook.com (2603:10a6:10:443::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.15; Fri, 9 Oct 2026 15:09:41 +0000 Received: from MAD0EPF000008C1.eurprd05.prod.outlook.com (2603:10a6:102:19f::4) by PR1P264CA0036.outlook.office365.com (2603:10a6:102:19f::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.496.5 via Frontend Transport; Fri, 9 Oct 2026 15:09:41 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.1) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.1 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.1; helo=b224-1.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-1.smtp-out.eu-central-1.amazonses.com (69.169.224.1) by MAD0EPF000008C1.mail.protection.outlook.com (10.167.241.197) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.6 via Frontend Transport; Fri, 9 Oct 2026 15:09:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1791558580; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=23rubvVH0KWImOkLcedtgP4LfH24dvNsVJybBGmYjgA=; b=fDHs1zYsCuBNFZJ9xa788DBgdLCoF+ukt1g3hEs4N2dDB/6FY3PjLLQvHKKEHs9l AhzbV2AMJxQt4ff5j7nTczcxz2sh1NTknvdQtQ6z9OClBw+xhMzVnAfgKfM49INq8jE Rj63Zk4xrC0+OPpYuyYc1G8Qh9Vcj5A+iQv6d6bNcXLTuwOt7YD+0tGru5ljaHl/ugx s+r8/0dhIktT8fsJ+vzcmKXPsVSAziUsWJujsZA8ZpJlWVk2TstsgnahPi3Vip5EZfl lB4YQd3q77E3UOkB6iCwlKTB3z25xWNVY98Pl4f6xhTfFmJuQToQuFPQA+Fan3Abc5f pPyFM/FCwQ== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1791558580; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=23rubvVH0KWImOkLcedtgP4LfH24dvNsVJybBGmYjgA=; b=DPrZ+O1VOrYewU1VCgMFRte+HS1GDivKUB0N9sshaKrGQshs1HJpMpDPPe3I4UVA LLd8Ovg0H53v1culi6AfAEJbMJU0WirjGdyShg9KU+lpZtw9U71Z1z6NiqgYSUVWzxu KauMDAIRDZOP7pxQDAD069ZEcKQeJGvidyLVcZxc= Message-ID: <010701a1213677f5-cf439a3d-cab9-40ed-bd89-4cbc95c93ad3-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 02/21] hw/vfio: Fix liveness check in vfio_connect_kvm_msi_virq() To: svt-core@virtuozzo.com, Andrey Drobyshev In-Reply-To: <20261009-vfio_v1-v1-2-2ae91d5b8048@virtuozzo.com> References: <20261009-vfio_v1-v1-0-2ae91d5b8048@virtuozzo.com> <20261009-vfio_v1-v1-2-2ae91d5b8048@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 9 Oct 2026 15:09:40 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.09-69.169.224.1 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MAD0EPF000008C1:EE_|DU0PR08MB9800:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 4cec4777-94b9-4940-3efc-08df261757d1 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|9140799003|32142699015|61400799027|48200799018|376014|5063699009|56012099006|4143699003|260925022911599003|260925021311599003|18002099003|10067099003|22082099003|16102099003|55112099003|4113699003|5113699003|260925021911599003|13003099007; X-Microsoft-Antispam-Message-Info: 3jJPDqREXDsmu4XQuwFh9mZIS7jiJt3mKFHg5yavDk2v4/e1FYoqEvoH/Mfy8u5O15Gwe3KiVs3s/xc6hmYWMPmw95xWQJjACYTGG1+r1LqikQUqzBFuxhB/TTGNAeX7CFoeK4HbRsoegIQZzE3zQ1TxZ/4BlN4+HOA6z7UEKRKqjZ8WC4nTuRJ8sAdDivs53CvsyHEn7i3i/AOT5RORdjm55fnAKmeoZuPYXv+WIc34b9S1kGFDG2K01OxW61ZpBTwhOczbqzJnGjCUC/Xs8YwQDrJtRgSUISHsQsDfEw/xyftbCWHH79xemoEJUa5Auk86ncMd00TEzk70aJIX3KAudQ2CDuiPO3fSENRxwPR/KrYt9UHr9yCIsXiZOhsfZ/eSse3y2ODfDN1FdbWAUNiIo2QNE0zVYAlXjiiQZKuDMJ0eg+ehW6aeKZ3aZmI3fWZIPRksKWVVrUYPeoIir11rveXLQlsjaDGLNxse/yu6/iNlfxGNNlUhhMOwZ69HAa3CnY+0cjE3V1WlbavvmgqBgGrO4n6QHytBybkiaNsbolemVpffjLieu64i8Tdj0RfQBIpDJ0rdOV3fD5GmmDJZCuxeEibGNOYfTUVuGKHwn5Iqg3sF/42BWmEilTETrRgD7gP0LEzHzjXMDzANCbPb5aS8Dt3UMHo4Pi8/mKKv7Lx+HXFF1PjmOyN1z4EmDJYPCKGKA+Caj9k8cn5JWUvMA1KQTobMWAYQy1jMwwzjzb6OeorzkqNboiDqCkq3POElxHOIlvvl30OaNGFvofNyw0tGK6NjrBxnW7mGAuDV6/DcOzY1o9xhZV/pwd2z2thUx/5jbwJPBBftxpzk9ox55AY63hBE5s94XcDHtih+Fa0JtEs5uYy/2gMS3V+Rr6I7K2hbBw9vCbFumTNbZPF+/smkW81j1kO17lKM/4U= X-Forefront-Antispam-Report: CIP:69.169.224.1;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-1.smtp-out.eu-central-1.amazonses.com;PTR:b224-1.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(9140799003)(32142699015)(61400799027)(48200799018)(376014)(5063699009)(56012099006)(4143699003)(260925022911599003)(260925021311599003)(18002099003)(10067099003)(22082099003)(16102099003)(55112099003)(4113699003)(5113699003)(260925021911599003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Dq47bwc9z2GS8futmEseOTpAEYE4MqbovcdFwDVh6/BKeZPxtHxgLz+Gn4L/IZzT5alz9kJ1g28fMaCVFofwvWMOfAixU14BNlewa66FUXeRu34V7380wjLuleuPiu79e11E1aw/a8Y/VSPcCEappqWqi2TbOl5HmjyR9EuCYAAMn5Df/xf5lJX656IwLyfk7YFCVzT3c+fqtJCqrR7ToFJ2XisJlWJpSA43CB4YNbsPSwuXkYQYAnmuDgKc2v34h+J54zhUxaPe4kt2aGsvmx6UU3eR3s7yq0r/3ciP0ATnyDAtLhPIE0M2qSxZSZR12Kmufdq8NBxbwArCB0AKDk4PbCGi4Rp/IwKut35dp8hmIFix0IKJqqsLr32TLIYeGLmG04w2odxx26rdAO6Gnix5J4AXkSIetHjUL+2Hqk77zqsuCawpw8dq/riZY73d X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2026 15:09:40.8153 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4cec4777-94b9-4940-3efc-08df261757d1 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: MAD0EPF000008C1.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9800 > From: "Tycho Andersen (AMD)" >=20 > While working on savevm/loadvm for a new vfio device, I encountered the > crash below. Since vfio_connect_kvm_msi_virq() didn't check the ->use flag > for the vector, it would pass an unused vector down to > vfio_cpr_load_vector_fd() which would crash. >=20 > Fix this by checking the ->use flag along with the virq number to detect > whether a vector is valid or not. >=20 > Thread 1 "qemu-system-x86" received signal SIGSEGV, Segmentation fault. > 0x0000555555a891ef in vfio_cpr_load_vector_fd (vdev=3Dvdev@entry=3D0x0, > name=3Dname@entry=3D0x555555eeb27e "kvm_interrupt", nr=3Dnr@entry=3D1= ) at ../hw/vfio/cpr.c:44 > 44 g_autofree char *fdname =3D STRDUP_VECTOR_FD_NAME(vdev, name); > (gdb) bt > [ ... ] > Fixes: 30edcb4d4e7a ("vfio-pci: preserve MSI") > Signed-off-by: Tycho Andersen (AMD) > Reviewed-by: C=C3=A9dric Le Goater > Link: https://lore.kernel.org/qemu-devel/20260727150038.2684512-1-tycho@k= ernel.org > Signed-off-by: C=C3=A9dric Le Goater Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261009-vfio= _v1-v1-0-2ae91d5b8048@virtuozzo.com?part=3D2