From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a1213719ff-82f34a66-f75d-463b-86e6-68240d093128-000000@eu-central-1.amazonses.com> Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11023122.outbound.protection.outlook.com [52.101.72.122]) by lore.virtuozzo.com (Postfix) with ESMTPS id 6BB4E802A5 for ; Fri, 9 Oct 2026 15:10:29 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WKK5Dbv3LR5NAzfigXfRnAxdY/wiIPgfrCs1XLDe7tgooR0ZwxycNzFpLEBYm8XklxsdOoigwxPdk+290TaVh/Dq9+YUcVdm2T5gmVvA3KRon2cTY4wWoV1X7eV5GTZXM3WlQerlmHcnVb8wwzAAaWGWkQZzQ+s6Hs6LuLhYI68q9oeN6ud2h8gohW7G+QpEN6cFigrgyZY49p6CUd9+2zxnOkhQkgUPxoqeZgh2GY6tW6/R+kNqsb5pN84lWA4EPbJwxoweGoVpQNm6mHBlIm95xXREtvgnN0V307c/l8Gq4jJRSFH3Onv07t+bfMyyPAYweReegDVtQjucrJumEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jZA5gjJdeO4TGbXDuG7QYGquOAULWslisAdi3Ql3PCo=; b=gVb6vKhBExhPDcube8WhUL/v6HHSCOqKCIVNSlTH+SFYYwWMJoRTTXU3io6zs6RvceCMVFZdcVbO1fZ9X66HG/y1qNWet4NL/gVjOhp1aGEKAGsQzMODE4yAQ0fqFhC/kI79t0JFYItbrLWwXreghd2EBrYtHP+6RD8r0yFptnTayP088PvF4NiVQwDmGluM7u4cMLEE8eEY0Sahh1j98IsMkc/09GzKIVltrbpXKMSFfLNuQtjXdlvsLSejAm/VCE52Zz/msvKW7D3ndmRzzmpvPZAS43OjL7hfa8PPTwMUAvJLMgTiaw8I/oAkAGxFh4w9F5TgxEYN6e1JY7LI3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.2) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jZA5gjJdeO4TGbXDuG7QYGquOAULWslisAdi3Ql3PCo=; b=iiFGQrIIGPa0mGSg9VEwKhpeS2laCY++nQA8dK9HjEvJDkhKuvauj/uzfx2YwTVk1+59fQN47LHYnDNjsHTob5ZVwj4xWWGQxWjKl96Y0UnxQcAiw83AF+sSo48xuSsrdMVB8GK9ET0WM7fGeV7KuvZ3uQ2KUDVRvQZMGyv7DN4= Received: from AM9P195CA0015.EURP195.PROD.OUTLOOK.COM (2603:10a6:20b:21f::20) by PAVPR08MB8848.eurprd08.prod.outlook.com (2603:10a6:102:321::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.472.15; Fri, 9 Oct 2026 15:10:22 +0000 Received: from AM1PEPF000C1ADA.eurprd02.prod.outlook.com (2603:10a6:20b:21f:cafe::8e) by AM9P195CA0015.outlook.office365.com (2603:10a6:20b:21f::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.472.20 via Frontend Transport; Fri, 9 Oct 2026 15:10:22 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.2) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.2 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.2; helo=b224-2.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-2.smtp-out.eu-central-1.amazonses.com (69.169.224.2) by AM1PEPF000C1ADA.mail.protection.outlook.com (10.167.242.105) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.6 via Frontend Transport; Fri, 9 Oct 2026 15:10:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1791558621; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=ZYQIOWJJg+Z17vtK9+d8NO41jFMOPrufYG5qGbslgZ4=; b=mvi8TjuHUGA9mzy3oJXzNH4/qR1rqjxPw2EoBNCxoj/4uaqh3n/f7j7SLuqv3g1k ITIu99XLgCe3xZ0YbxUYm+CCff+5p4m6d+euLY/0s3lH6xxJFu/o7qq+YfBZjqp5d6L 6hcWDKdcywOjYdCr0/6NDhsBbdk/1egA7fyxARtH7tB/+GHBt48rm0dWcXAMkW6sfST KyuevBn4V1L8pp+SSTkc0oT9Z9xz/+PDFGCm1cZGIh9zbhe5KGkldQ9BcpTIkDcpzV8 ynasthauELJ0hCGC/TIeac1EKEV8Kjz2WyyYf61Cp1bS8NW6mhm/RT4zXmepajiZHHE cC0Db5vviw== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1791558621; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=ZYQIOWJJg+Z17vtK9+d8NO41jFMOPrufYG5qGbslgZ4=; b=CjcnIl6a5Bk1jYQ7p2c5ogNmDc6E9BQPjYSQhFyXOavd32LYXk1qfpW0XtC/KwK8 iP6y1M63l257AhcjfthSEtwE7AdTxwpIuMLtuGg3emKwp9dywVvRVhHD4R6tlIiVIA0 ANvcUHpnoQM0OFaG6WtnxuYOqUtXXvNLJKEFyAos= Message-ID: <010701a1213719ff-82f34a66-f75d-463b-86e6-68240d093128-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 04/21] vfio/pci: Fix information leak in vfio_rom_read() To: Andrey Drobyshev , svt-core@virtuozzo.com In-Reply-To: <20261009-vfio_v1-v1-4-2ae91d5b8048@virtuozzo.com> References: <20261009-vfio_v1-v1-0-2ae91d5b8048@virtuozzo.com> <20261009-vfio_v1-v1-4-2ae91d5b8048@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 9 Oct 2026 15:10:21 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.09-69.169.224.2 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM1PEPF000C1ADA:EE_|PAVPR08MB8848:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 7416249f-5846-4250-3c17-08df26177063 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|704161411799003|704162011799003|704162111799003|9140799003|376014|32142699015|61400799027|48200799018|6133799003|5113699003|4113699003|55112099003|22082099003|18002099003|16102099003|13003099007|10067099003|4143699003|5063699009|56012099006; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bkVBd242cVNuVm1KRnRTQkVPa3Fqc1kxYXdZVVNSQTN6cGZPK2dRaE1iZi9X?= =?utf-8?B?UTFWaXZ5M3NYbnJtd29tdkZlZEF6WTRQMGRrMWVPRmV4UDFhcWpGU2JlZGtp?= =?utf-8?B?V2JYQ0VuRFgzdlhvSk4vSkhQYnBtdUdQRGY0d0Y3NGkyejVRa0ltT1pYbHRN?= =?utf-8?B?TWFTWGJtQmozaUMxcUgvNnpEZ3VtK29PbVNkUzEyclFWbE1qSjBLTlB5bUhC?= =?utf-8?B?bVJ1cjJpb2JEWTFNcWFaK0JGSkswMkJ5Z0FpN0tMQjJvK0VwaU5zbStEN0lY?= =?utf-8?B?OVB0NWZjd1RlQ1NVZEpac3dqSFAvUzVVdUxaQmpxek5jZXNVeCtBUWQ5Mk5J?= =?utf-8?B?V0pmYUtOQ3JOWkVMYjgrbVcwb0ZhenMzZy9BWUJLZkhyTWpMSkxHR0d1NWpJ?= =?utf-8?B?ZngzSDdSSitUblBJVzQ0dHg2ZFcrTXppOTlualBoY3lYeVQ3SU1tTWdJSjRa?= =?utf-8?B?SlV3eVovUkFydHo2am1SOWNkcktwUFlWL3k0SUpacXZITXJRZTZCZWdjM0FQ?= =?utf-8?B?RC9yYVNFTmk3ejQ5QVJYcW5WTUJSWXNqUjV6ZGpMdzYwcEI4VjBZSGo4ckd3?= =?utf-8?B?QjNOY0o5S1h6cUsycUxvMTNJRmRINS9iL3VqODVGaFlYbG0zRlF4clA2K3Fz?= =?utf-8?B?aUtmRDlneVFGMVI2K3NLT0lqR05Bd0NmTUhKdW55MGRvZ2FyNWY4aFlSUlJs?= =?utf-8?B?MTNHRkRQd3ZmWUY4MmZYRTZ0bjZnT0NOb3pPOStxRnhQWmlOV2xqUmlET3Jm?= =?utf-8?B?QkpNV09pNGMrR1B0MTMrQ2ZuWlFQbVNLd1ZTeG9GZ0s3eGpsdm9sQmpEQzJr?= =?utf-8?B?L2wrL214cmNSTDIva0JlYkVWUDRydTBSUTlHU0xwK0l2UXRyUS9KVzAxdGQ2?= =?utf-8?B?Sm5lQlVGSVZ1Tk5qS2dJZUc1bEVIRXJYZWdEMVVHbkZ2WlBUa21rOUxtQlVY?= =?utf-8?B?alBSNmFnOWM0b3lKNmR2RFFnSzJRaDVtZE5OOHYxUHBicVUyK1VtUi8yVGV6?= =?utf-8?B?MmNxNkczajlpZG1qcHh5Z3ExdzdhdWVtSTh2ZzFUZjNWMjNjcEd6cUlYOVpH?= =?utf-8?B?VWdEUGZkUlQ3ODA4Tm1JcjBPZjFuZ0tlT3AyUCtpNk8vQXdHVkhmWitPWG9j?= =?utf-8?B?S2JoYldSUWxUQi9oUlZyUEdHM05XOFFTcEhPTVY5b3YxbDRHZEk2YWs1MUl4?= =?utf-8?B?d1UwYnZnUWR0MUNtT21zOCs3U2tFb1VZWlJMUnpPdUkzTTJHT09yeWpEOVYz?= =?utf-8?B?dzZ3a0dJQ3NyKzNoTmI1dFF1RGlFbzF3OG9WQTFlUEN3VEFWNC9NMVpqVzNi?= =?utf-8?B?bVZiN29KZThvYnJZVnNCRE9mV3Q5THhKMENOWGRYQkRwdlA3ZVpKYjM1eHor?= =?utf-8?B?S2IwTHQwb0VtbUNSUnRWNWdza1FITnFRWXRuT2lFc0Zqc0FwMlZoRUZLdmJH?= =?utf-8?B?SmkrYVQ4cEdsOCtBN0NTNXkrbHVQeHpucFhEakVRPT0=?= X-Forefront-Antispam-Report: CIP:69.169.224.2;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-2.smtp-out.eu-central-1.amazonses.com;PTR:b224-2.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(704161411799003)(704162011799003)(704162111799003)(9140799003)(376014)(32142699015)(61400799027)(48200799018)(6133799003)(5113699003)(4113699003)(55112099003)(22082099003)(18002099003)(16102099003)(13003099007)(10067099003)(4143699003)(5063699009)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: oVJ7jJvvPNWyvgOj234RNbuGSSlM57x2iw+E7DngqhHAAP9XN6qSxCPAGTOJ4CbF/keTNmiKt+QaIiaBvUjVUkhe7mEqN4v57YRJm1GrMhKpxxr2JFO3QT6xbJprecQ+L7rjS8YKBD0f37gYmjgvOYCnDSLXyy6aV8yAMFJdLPqeW2nA7KcYn5EzDSRnksVWgVLo8r9oWnmUknAnOZXqAWidHkBNCBCYLFX74x/JA6NVwSaeN2IH0pquxh1mTFVbT4GvRk0kFPur1r1Q2wJPKMH8oq0YReONv3WX4J/ZNKo1xsb1q6ed+gQNaM9OCS0k3L46IIw0nNuvDjRomZ3JOQqKkFESv5iMwt7+bw+ZkAIgdd+fdEUf2XoMaa+jJxrRqcGg6vcSR+bSTNFr7xiymx5WzK/38+S9vr6z+XXWLApQ86T9y15MbZ7JLtQvczCi X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2026 15:10:22.0903 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7416249f-5846-4250-3c17-08df26177063 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: AM1PEPF000C1ADA.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB8848 > From: C=C3=A9dric Le Goater >=20 > vfio_rom_read() can leak uninitialized stack data to the guest when a > read occurs at the end boundary of the ROM BAR. >=20 > Fix this by initializing the val union to 0xff, matching the ROM > initialization pattern used in vfio_pci_load_rom(). >=20 > andrey.drobyshev: > This commit is cherry-picked as-is, with no modifications, from the > upstream commit 402fd5a75659. >=20 > Reviewed-by: Philippe Mathieu-Daud=C3=A9 > Reviewed-by: Mario Casquero > Link: https://lore.kernel.org/qemu-devel/20260602074446.1206892-1-clg@red= hat.com > Signed-off-by: C=C3=A9dric Le Goater Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261009-vfio= _v1-v1-0-2ae91d5b8048@virtuozzo.com?part=3D4