From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a135e36676-f514f661-3d03-4a60-a614-91520f574c0f-000000@eu-central-1.amazonses.com> Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11023074.outbound.protection.outlook.com [40.107.159.74]) by lore.virtuozzo.com (Postfix) with ESMTPS id C2C7380726 for ; Tue, 13 Oct 2026 15:31:03 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hc5nOkv0Q2IpbI+ZvoWY7ZCzqozHuIhC85G6nCOn6Fh0yFgpS1qCDXKq5bKdNThF1EmMBKZ2+Rg39JEcjERfa9H3ix9HjUwpZKUp+6jqh+v8+mNy7nruLANPebYUDcC9K1k2QDdlw+x3g17XcGgmReqstUdoTydJQvudvMIYGykvbiExBNvZOWF2B01DjZyvtha8KOfzI1LdjN4CPppU9SGyNZ4a1OznmwY0Knn4/1UY1OyDfk6Nv6wg71wO0F4ZPnD4MvjMMls7Mtb7PNNIm+wPHiQ+qkXXSD/v4+orEpObycyKWhOs5l/v8njh3qwd9vKW3K0PNw8iPh5ebv8pPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fmu+ZphGBoSQuiBRKUqKpOrkqxS4JHddNzhXHTrjV8E=; b=GigceQvOiOJFZY8+05vUaA+3I6oiTLSAlf0J9DVyeVBlpHr9AFvgRuflUJlXMwyN2Pldb3u4uDs/T99odnU9EjHROzycwl91xnigm6mK3IJNJL71y0omjC/i/00wqBWJGQ9BMParEfSEsbMup13+NCuAUPox2W2xBEHjuTY7al5Ltj/WGJ+RhZxDTPoT6FysjtbTChhS/iLtoOn3g2g5TF4cOO7nbG3bXpLEDGFFWSwY2f3WAA8abjrCFSbJSrlIIMIKLCuJSzgtZkWTVPtNN9dQplS2SLmtraU/1Uz4yOotUro9kgKv3MnyLSq3pfMRQo2yEmsPup3luxVmSHmCvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.1) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fmu+ZphGBoSQuiBRKUqKpOrkqxS4JHddNzhXHTrjV8E=; b=YwuqO8GpzG0rjdA9F2L2Z8YZ89RNy39u5Q7zc03ohqybHygQjukR7F0NBtbqRC2MgjinGR9NAS184hZnIsFL2sD22T7UPlJ3/PYinCMPGQpAMLeBVY9N+/BxKPnbUdMrHeYSbMvgaAW7viGG1g9OijS1k5Tyt5DSPYllFNi54sA= Received: from WA2PEPF000008A9.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d8::649) by DB4PR08MB8005.eurprd08.prod.outlook.com (2603:10a6:10:38f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.522.12; Tue, 13 Oct 2026 15:30:59 +0000 Received: from WA1PEPF00009B37.eurprd05.prod.outlook.com (2603:10a6:1d8::114) by WA2PEPF000008A9.outlook.office365.com (2603:10a6:1d8::649) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.382.12 via Frontend Transport; Tue, 13 Oct 2026 15:30:58 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.1) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.1 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.1; helo=b224-1.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-1.smtp-out.eu-central-1.amazonses.com (69.169.224.1) by WA1PEPF00009B37.mail.protection.outlook.com (10.167.242.36) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.6 via Frontend Transport; Tue, 13 Oct 2026 15:30:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1791905457; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=olwbmEzXgpfUjepa75r/yKvJszSmBs26HkI2UC04apc=; b=CNP/EUVCCoCMXXP2uLsZPq5c37eT4LF+ik0b4HbaksAIxIQmzfY/+w5G1NHVR+Ws 2isP6uaBWo92Px52AvZ23qBGjVIrUJAJmAdf8eK1V04G2feRZ99Fui38EAO5bhLiGje 0sx5JWMcraaNSmRPhYzHM94MF3yjWxZ+nlDmWTyI6U6eVgeoXcTGKy1I7dXAkomqZX9 sgJRDilnQFrOfufRF/7ygKYv//yD8jmnTYz7qrhlWK3lARXoOSTXXOuzqTuir46a92i P8JJBVIVm1ckbG4gcet2EMssBhkLBiI7aQdf6tqwxrz0TofRVzEn6WFDc9JHwin/vB7 aGsnF/nUqA== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1791905457; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=olwbmEzXgpfUjepa75r/yKvJszSmBs26HkI2UC04apc=; b=H7V5LNaMXmmJXIok0yHIM/R+mibMAsBwj3FamVeB6vin+sKbo86jQTVhYEwZbo+j vk2AAoJidYh29L9V7pDYAu5H3nsfaWRLJCs4cNuWShYtq9zSpKe0JqMLe9Yk1O//KPD 8uWKywru2ExOh4IgPJ9B02m+WoKHZlIa1xyh2Sfs= Message-ID: <010701a135e36676-f514f661-3d03-4a60-a614-91520f574c0f-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v2 01/24] migration: Plug memory leaks after migrate_set_error() To: svt-core@virtuozzo.com, Andrey Drobyshev Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261013-vfio_v1-v2-1-433455c0a294@virtuozzo.com> References: <20261013-vfio_v1-v2-0-433455c0a294@virtuozzo.com> <20261013-vfio_v1-v2-1-433455c0a294@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 13 Oct 2026 15:30:57 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.13-69.169.224.1 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: WA1PEPF00009B37:EE_|DB4PR08MB8005:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 8bf0dd87-cc63-4a4b-43c9-08df293efae4 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|704161411799003|61400799027|32142699015|48200799018|376014|9140799003|261009223027099003|56012099006|5063699009|4143699003|10067099003|22082099003|16102099003|18002099003|4113699003|5113699003|55112099003|13003099007; X-Microsoft-Antispam-Message-Info: QpbBqlYgK/FEolkBwuoagC0BxWiKMvczzTPv5tTsg+97p5I7seA1WK5jKhFlU8wZW68ix2eM2jCGv1TBuFH1BhqQnQLUR1ADiagDrv1r4r8g4rJwMOw200dkGJ3jRga5/AuBozt08ihueHg8xwPlj7si0kBRKZ3y4NIfABGNmnp6MaOpuQFYYyX9XLuWwvabB4kcKIAaHAHbcfwNXcXKZvCmYUtI//P1FNejgGFGyQYiu0Wweblk6L+VBYtajNR8V9oIZdA102zpsSFbWNT6leQhhza2htPFB2otTB/VodTjQMgp7osbxEvLvyYvQVhvyIVEfufFQRHg6tdPCwNh1KPsLkxJsdzhhyNexdlWvad2D4XhiftcOZ4Su7ORVCgE8OhRUMomzPqCLbbBcVNFskOmpj28a18LWDtoaUgUzYMYDhWJP96GN8mVBOH4fG46gSphsS0F7V/yIsduvSbzMyMT/3aFeamBfL59UxKdOC+pTnIWklGvwk8DLWHDuxPXKIcg1jkE04Veh72zL7ZZUM8Ie+EzDa79idZlbIDaf6iCUbNTurOTZMpsphodn0Hpde5VIQfgJtc1ZjpY9QMLxdS3WLc4KHq7kvmLEm/WKIhAVqZQGVm/K9Dm61DEdwc47gxDtHVcD9/lIAN2yOf9TZWpzguR5Dgbh8cejt9+FJBtwKSYTZGVCKUeDCTge7RafTSmWilLoba3acfKvqpAA1e2Stx3xu8svmPTUtI7M7ZatxxesWQ0fQUm3reY08VjwoLr4rZ2lSduprcVL/ojCohK9cs0K663osePhPZDynXGfEUjdhN97rmi6VBeSj/xUVeYSTcBoFmmMw9l6fyz8yxxcUrKnfLHtpveqpJY9PvJOqQrs+0MaS7JK31b9kXltt8YWE5TKsh2H2eIrlyLFBFhyrRXH9VAn4EUA7OQq6EH3Lo371OCPTRDduHY9t99 X-Forefront-Antispam-Report: CIP:69.169.224.1;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-1.smtp-out.eu-central-1.amazonses.com;PTR:b224-1.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(704161411799003)(61400799027)(32142699015)(48200799018)(376014)(9140799003)(261009223027099003)(56012099006)(5063699009)(4143699003)(10067099003)(22082099003)(16102099003)(18002099003)(4113699003)(5113699003)(55112099003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: cGnUVfGCLjApy87qAGGdAKfWDZBoNZACFE9bonL1PFDpnl3cX7LSkl02Zjiy8DEBNLr2dYqFyZ+yrCLZUPjkN/+F4WIUoVCDLwGY+C+bGrAsdUXGcEZQpi3yB24ooTueX2d8axKBBas0Hv/8rqjodB3vi98lfHCPeVcVOliLyUFJRK9Q26vHRjdJn23oEiyEzCplBRiSNBv3Xam3tJL9eZXQRhljQZB0WfpdEVH/+uOnEYw+BUz9E9Vlui+Sl3OMIWx8Al/QAG725BHvNi7RckkRbmUBAvg2fAK6UXvzVFggYO0nCE0g66BsNuYlsXok78kSn3LjNTUXuweV02wJhOy6gSSPHuqOPL9WAnpMhtNKplL2YWckxM7G5WYtNaGXai2SyfRrrzeEQklVQaAjl1CcKdGhGI9pnlgY+ONdrSclZ9fV4QzvwOfPzQXtSrUV X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2026 15:30:58.2552 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8bf0dd87-cc63-4a4b-43c9-08df293efae4 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: WA1PEPF00009B37.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB8005 > From: Markus Armbruster >=20 > migrate_set_error(s, err) stores a copy of @err in @s. The original > @err is not freed. Most callers free it immediately. Some callers > free it later, or pass it on. And some leak it. Fix those. >=20 > Perhaps migrate_set_error(s, err) should take ownership of @err. The > callers that free it immediately would become simpler, and avoid a > copy and a deallocation. The others would have to pass > error_copy(err). >=20 > andrey.drobyshev: > This commit is cherry-picked as-is, with no modifications, from the > upstream commit 93817ec39656. >=20 > Signed-off-by: Markus Armbruster > Link: https://lore.kernel.org/r/20251115083500.2753895-2-armbru@redhat.com > Signed-off-by: Peter Xu Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261013-vfio= _v1-v2-0-433455c0a294@virtuozzo.com?part=3D1