From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a135e431c5-3c5d7713-533d-41ec-be8f-0b49d9ea7b37-000000@eu-central-1.amazonses.com> Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11020112.outbound.protection.outlook.com [52.101.84.112]) by lore.virtuozzo.com (Postfix) with ESMTPS id 01B5D8017D for ; Tue, 13 Oct 2026 15:31:55 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EGmDtCIiOGZfZ7Yq8G2FYCvtUEYeda+bGElQgqJXNLIFVXP9HJVq6HEBQwT/FbxvAtc+ugvs4fCCxpzthKUIKi3nXUbGEkUkvVO3mStRMzWBWrDkCZOAu2K1CynkTOprKLS3mFXvWcyJSXuZAfiSE31bVE64Z+3c1cKAsEHZnk8x00kvwzBaJzLppTTNi0nkSSEHO1+d5CTd+xNsDkkWhgNa9BRhI17GymkMwMt077Y4VuflS8V3Y7otzZpwZTVatrRaGj/n5nciDhkN+LVy5Dmi/L95xQEZnEhkLoND9+bbB3vNbrDJT4gRUUnfebSkb/0hi/+nuA/ulM9NMYRFfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=41Z32Hf4gFaCcuL5tHYIf78hzbZvvFK0HEwYH0Los9k=; b=cUTOw0puZUUhVJid/Tm5bqKK2OjyT32Jr+uTxpOjwhSUSXfsrj7PWmgyOLtJ/FWqv4dWK9MvY8JeXMG29AW1gCsLrOfekItO4gOVfAIx8gM5CJOT8FmqQvIrRKcUP1cAbKwNxmd7WVq27ergYVfQjqnPwLqpkQFQoq6at298swLjRQmZFJxP9iBuYRee1cdKuqRoHeucrSV89L0dDhpcJiraCHTi4Ahuj9cd0nTL6Yyh4GOLYueTvtI7WrhtlXKcslWXwrxApREnkx9PreoUUlT0kUmNfBOEL/SGWmYzxtxDtGmT2AA3GG6pHEnz29ER9u5rw/I8L3VjNtpfz5xxIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.5) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=41Z32Hf4gFaCcuL5tHYIf78hzbZvvFK0HEwYH0Los9k=; b=FOGGiF1R/qWLlXpBqWW6t2ZkT/MveZHyZvMJZwtOSSwJqW01xxXleV1lll5ipcYizkjZu8L7/gqJDZjgp4dR15TfxWMpXBcyp0ihtEhNzlH+402c5dKClz2Hmpwr8A9fLkwGZS5as+V3ZYs06NSkIcshDvAqgLd/bnWUcRqzVpE= Received: from DUZP191CA0042.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:4f8::6) by VI0PR08MB11501.eurprd08.prod.outlook.com (2603:10a6:800:2ff::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.522.11; Tue, 13 Oct 2026 15:31:50 +0000 Received: from DB3PEPF0000885A.eurprd02.prod.outlook.com (2603:10a6:10:4f8:cafe::1) by DUZP191CA0042.outlook.office365.com (2603:10a6:10:4f8::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.4 via Frontend Transport; Tue, 13 Oct 2026 15:31:50 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.5) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.5 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.5; helo=b224-5.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-5.smtp-out.eu-central-1.amazonses.com (69.169.224.5) by DB3PEPF0000885A.mail.protection.outlook.com (10.167.242.5) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.6 via Frontend Transport; Tue, 13 Oct 2026 15:31:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1791905509; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=9i/U4cQUKugA0hKYqVXdTRuq9cMbwtbdIktjs88MnFY=; b=axl4wCIzFZdJpv3fJl9aZBBcIR6ZznmM65K5fnsNiioyz0CDZlUlZXgtv7zVzpzP FhIt5UvbSr5f5J2v05O5+zLTKj0qkvoXW3w23A0IqlytYai9yjUAMLlV1pVrNtdOSuH k3su/YtHYOtRW3g165jP4M/kYaNUv3VOBpwOF4WhTWP6N/Zo6hIMEk1I57k+1BtJtxo RXQJrCx8iZ0CYD+wcA/9o04/6dKS23DZgN3Zwgacb7VgFlfxf+LerBipDh3p3/7w2dB 0AOqzibuUQTLxm4oCGTSps1sOz6KSyj8FuMrMxIeXd5ADAs787/9407X1z5/My8cvLc 6T/o/HCDjA== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1791905509; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=9i/U4cQUKugA0hKYqVXdTRuq9cMbwtbdIktjs88MnFY=; b=fttHFP+xI8oPw+3FqkwAWQ1ra/upkSnGC9mEuOThUlPUZ4YFTmebKmMDs53HeuXz N7EDhdAAcuBxKhQdiL6Cipf6LYEnfeOGxqJC7PeeS4UzU4bUF9qQeS4VEIFwuCWRDVK DqCxjhoe7a72WCVkS5B/+6sG6SxT+Cyj8NVtiuWY= Message-ID: <010701a135e431c5-3c5d7713-533d-41ec-be8f-0b49d9ea7b37-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v2 04/24] vfio/pci: Fix information leak in vfio_rom_read() To: Andrey Drobyshev , svt-core@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261013-vfio_v1-v2-4-433455c0a294@virtuozzo.com> References: <20261013-vfio_v1-v2-0-433455c0a294@virtuozzo.com> <20261013-vfio_v1-v2-4-433455c0a294@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 13 Oct 2026 15:31:49 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.13-69.169.224.5 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB3PEPF0000885A:EE_|VI0PR08MB11501:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 84467968-4c7b-41ed-73c2-08df293f19e4 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|704161411799003|704162011799003|704162111799003|32142699015|61400799027|9140799003|376014|48200799018|56012099006|5063699009|4143699003|261009223027099003|10067099003|55112099003|18002099003|16102099003|22082099003|6133799003|4113699003|5113699003|13003099007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?T0g0THIvUWRyd21Ea3p1SFJUSVE0bWxaeGp3OGhxbXUxaGZrUFh5LzNTVVhr?= =?utf-8?B?QnU3cHIvWVZDVW5DYU82dmtRK05sOXdEVy82VVNFMkhjbzEzQVYzVXUyb1RS?= =?utf-8?B?TTJxcUJUS01PemlYcEcwK3dqWlh5SGxpOXNsS1RSc3ZOU0E2Q3Q5aHhRbGIy?= =?utf-8?B?SFphTDBvcmt1Y21neFhGSktWWGE0cERKMWsreUFhRjJ4ZENrc2lud0NOVUxu?= =?utf-8?B?bGdNYWR2SmhRVXUyeFhiNmNTZ2d3YWlXSmE3cEVhODRXYmFCbW9qRUhRQW1h?= =?utf-8?B?WnNLdUpFb1ZpeWVhc241MVZxZExUZy9KTlNPMnduVFZoWUJoRFRacTFMY2ZZ?= =?utf-8?B?cllzL2JTaXVMeWxHb1JtVWhBeEdXTUJyN3RPbUxMNytwQ0l6ODQrVDhkekVi?= =?utf-8?B?UVkvOVJnN05Eb0JwcGNwcTg4Uk5oclR1ZkNURlk2TkIwVm45eUUrVm04ZTBy?= =?utf-8?B?anNBZEIvMDVrM2tGUnV2MnVSdldyc0lQY2xVczZQa0o5eUlTUHhhMURBNC9r?= =?utf-8?B?T2d0ci9jNUlZWHl3MVZUNzB0eDRZZ0xYaUhndXJMdXgyYVU4VE5WM0FCYVoz?= =?utf-8?B?RXpTbDBVR1Q5MENuWlRVc2s0R3V1d0REcHp6V255NTVHdEM0a3hsVUJ3WGM5?= =?utf-8?B?YmRtQ254dHVOcElhL1o0eEh3VTB0RCtkd1IyZHNqVlNxMlhpN2lyQlh5czly?= =?utf-8?B?MGRKTmRGREhhbFNJTE0wWCt4UlhyRVZsN0dpZ3N1TE1NY2M1VHhrcmxsOVdN?= =?utf-8?B?VGlndDN5c1k4RjZrSHdqNG40cGljTktadmZuaDdVR2JwZFNBUGpvY0dBck5F?= =?utf-8?B?cGtvbWlXNlZ0dW94d3JJdmliSGVJc2s1ZzJONlA0VzNQY1VqZ01tR05udWNN?= =?utf-8?B?Q0EwUFJpRGcvbDE1Nm5LMTE4SkRTSHBxRytZblA0QmRGTDlNc1huSjNiMW5C?= =?utf-8?B?SlRtSDRNV1lyQzNNWkczcmZWdkJFaCtVZkRZODhhY2tVVVl5VDBPeDJuMEF0?= =?utf-8?B?bmkyUm8rc2xNN0tOSWxPelNPQ1QrU21GMy8xYjJUSmd5a2Q2NlAyUHY2Z2dI?= =?utf-8?B?Zzd5emZpZWNHSllrcmNkdTZjU2VmTjRsOFZ6SnJRS3l0VHRTbW9IQm5JRjZ0?= =?utf-8?B?b28rN3NNazkvc2FsZmhsREdiSjZTaWJlZGc0M3dmUXpBZ1FyaHUvODRDRWF1?= =?utf-8?B?UkM0LzJTOXdRVm5KZUM1d0o5ck5TMCtRQjh3QndqV2hEa2ZiV1I3S2JiRmwv?= =?utf-8?B?ak1EdDNrTnJZd1pGcnl6WGRwS0t3Vmg1OEtVV2E4Mi9BdFNkS2ZyT1pTU1ZY?= =?utf-8?B?ekNoRVhGelh1cmQvaDV1WjJCQ25ncEVGRmtzcUNPK2VLQWdDTFBGQXJwVUFF?= =?utf-8?B?NUdkTjNZYjJTbDJqditvaGhDc3ZhVVZlK01vbldsVXBtSVhQeXh3Q2xtTE16?= =?utf-8?B?S1dRVkM1YnVmMEp0RzkxNFpzYkJGNXl6SmJtY01RPT0=?= X-Forefront-Antispam-Report: CIP:69.169.224.5;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-5.smtp-out.eu-central-1.amazonses.com;PTR:b224-5.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(704161411799003)(704162011799003)(704162111799003)(32142699015)(61400799027)(9140799003)(376014)(48200799018)(56012099006)(5063699009)(4143699003)(261009223027099003)(10067099003)(55112099003)(18002099003)(16102099003)(22082099003)(6133799003)(4113699003)(5113699003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: RH6XFe+yAhPV5T7ufbNwD7aUANFUmvwH2Opm42NwHEPO1RPgnfd05ISJLMqclvnAjD/aKoklEX1JtfzBscKqcpoT3vD4K6160kpoT0o13n+POG2yFUnt1avPmRz8PW9LaYUdI1WMX1GUXvF+5howcR8zbvbcF2/VqOyBzTmsutJn0DanA8yACWRxWhH48yezBzXRf1Ioqk2hOAJmveVaqpSQFGbsRWI5hauNHPOoS+xEvmBEDwYBBaB36vuq1BwJ5Fe64HQgFzUs513LVar7ZJqR4ZJ08Skdkb29/MaolTJWIuy2v87HzhmoBLdsZ0u+A/5Edwa8E7bbSkb+QJpzBqQMScxsbz9SHZ/cgse1t5fBfPyMz4ReY0UOdw71gJeB110rTHrYbB9MdKUImJSS1rvx9ACZ37ZC13ccb0K24AMHriVSZP4C6gNQGS/DQ4Wu X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2026 15:31:50.3116 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 84467968-4c7b-41ed-73c2-08df293f19e4 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: DB3PEPF0000885A.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR08MB11501 > From: C=C3=A9dric Le Goater >=20 > vfio_rom_read() can leak uninitialized stack data to the guest when a > read occurs at the end boundary of the ROM BAR. >=20 > Fix this by initializing the val union to 0xff, matching the ROM > initialization pattern used in vfio_pci_load_rom(). >=20 > andrey.drobyshev: > This commit is cherry-picked as-is, with no modifications, from the > upstream commit 402fd5a75659. >=20 > Reviewed-by: Philippe Mathieu-Daud=C3=A9 > Reviewed-by: Mario Casquero > Link: https://lore.kernel.org/qemu-devel/20260602074446.1206892-1-clg@red= hat.com > Signed-off-by: C=C3=A9dric Le Goater Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261013-vfio= _v1-v2-0-433455c0a294@virtuozzo.com?part=3D4