From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020106.outbound.protection.outlook.com [52.101.69.106]) by lore.virtuozzo.com (Postfix) with ESMTPS id 059C5808A3 for ; Tue, 13 Oct 2026 15:33:05 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BrLzuV8emyl4T4jWbsNOksiuV+CAwA523eA69Tu6Qp4/J6emkBmLUEz4pJHxBCzPGwYUWO6pBMWeahvJnrN8G+/GZTLJgiKmM6cWQfef0vog4qQxCbukxmq9Sn+2I2AGKyUc4D2dGHzHIE7ChpUvfiYy8uW/LmScfitkmXz9Q76tzfdUEgfzwfZ7kerKn/pEQx4V43mvN6Ww1wR4IzkRpPkv+E6R3sue3cf10eT5zjWXiKv3WNoXUhTS0iiDU59zcQyXIAr69UVWkPzgq2AIbbiPLVER/ScsN3ancQ8wEi7h1kPSeQyDng0BzbuNdC+Zpxw2MQggTicq1AqAM75sEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bWM7LYM2ODtCXB56JJ8WSoXDb3IAlY/xjk3um5r2z7c=; b=m5qPbn7YyRTLiaxCrRgyFwPBh6FI5bnTBa/Zp+9TR0MgU3iFYKYClZTpwI4z1yaU+qm6bXX3Jpy2igSeIGmXWmkzfc1XpFQ50AVj4aQ3CZXYSzDUA6hWl+y8Gt9xh+YiaErzmZZgHZdIoT2p8rMZ9WYQsQhPwfnd2XlNhowt3oHGMrz2bPbWMzWTu5WWCv+YqQSGOgoZjvJM8ZuvwXJeo1+M+7Z5nzVR1m/LVRefc+4K2zX+p3oB6Jet4KhvSCus5KihP+0YUQqV+pdda+wI60djb3oN+hWGXSXZWlE97PIUOsjBXECQSmAWX+Bryyoty+Ni94w0oCRyRX+F0JA6fQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.1) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bWM7LYM2ODtCXB56JJ8WSoXDb3IAlY/xjk3um5r2z7c=; b=ZHN0hcBKsyDx/6tEzwucoBhE1rIKi7/4wDxsZAFQHdutF0vhe9Wbbn22vfXmm/vWuwLAqF+To91eXQRMRkF3HQLh+RqfmWr4HRH1z8aumGzzQDur3kY7DbodKpwO5a8w+KLruFLbEPDzyL2H66MJ35cPPY7Gp+ifNzSKSvyNNfA= Received: from AS4P191CA0009.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:5d5::16) by AMDPR08MB786969.eurprd08.prod.outlook.com (2603:10a6:20b:74a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.522.12; Tue, 13 Oct 2026 15:33:02 +0000 Received: from DB1PEPF000509F7.eurprd02.prod.outlook.com (2603:10a6:20b:5d5:cafe::59) by AS4P191CA0009.outlook.office365.com (2603:10a6:20b:5d5::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.4 via Frontend Transport; Tue, 13 Oct 2026 15:33:01 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.1) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.1 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.1; helo=b224-1.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-1.smtp-out.eu-central-1.amazonses.com (69.169.224.1) by DB1PEPF000509F7.mail.protection.outlook.com (10.167.242.153) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.6 via Frontend Transport; Tue, 13 Oct 2026 15:33:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1791905581; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=ZUHm6XrmF9usFzmsJrMNyJ3TGAJ9JCaqoNGL0jCClDw=; b=xb7Y5oPO0Iu1PFSaoYPd2yImREcdL3fg6Id7CREK1eNFQDMMiOP1doMtswD7pFrN aVsHns3MqaKmR/0S6YuQjF/X8zruWK6/fjbdYQrAc5dyPjbXr3vtgnJiLpIj7DdYy90 6B7aWjSQ82K9QUGnvWfN/I54UuhtfmcQYn4eBP4LhuDzuGkX9148bri2VzeUdcIqxvA SY0W/ZRBCGhhbcy3DMxwgWNO16JFXH2neI6xrpDvfWhZ17mxmEfQ7IWVY6GjH45+QjL bd2MksykKWuiJSRJaT3IAp4AEgqkbRXQt0tBhgMWhrweZ9DUzd+ENg9irHwXeTf8rrT 1Ubr4hHKyw== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1791905581; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=ZUHm6XrmF9usFzmsJrMNyJ3TGAJ9JCaqoNGL0jCClDw=; b=BRPkqIkwLp9FzWG/Beq8FNNx4H70GS1L50/IN5mjHelkqR9iVuhz8QaY++3oq3DY 7vDFjG04Punj54/ByrjIUvjMmFcZq6Pj2zqnHvC0CcH9KvxiPDaqlX0E5R116rycmFl s0bvy6qTnyJIPufVRyKFzAFQJTIzwMsL5P2fneI0= Message-ID: <010701a135e547cd-f3c73af2-2b31-4dce-8572-f186d5252af8-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v2 05/24] vfio/pci: Initialize rom_read_failed in vfio_pci_load_rom() To: Andrey Drobyshev , svt-core@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261013-vfio_v1-v2-5-433455c0a294@virtuozzo.com> References: <20261013-vfio_v1-v2-0-433455c0a294@virtuozzo.com> <20261013-vfio_v1-v2-5-433455c0a294@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 13 Oct 2026 15:33:01 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.13-69.169.224.1 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB1PEPF000509F7:EE_|AMDPR08MB786969:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 07cef828-2f24-4dcc-cd45-08df293f4465 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|704162311799003|9140799003|376014|48200799018|61400799027|32142699015|4113699003|5113699003|10067099003|22082099003|55112099003|18002099003|16102099003|13003099007|4143699003|261009223027099003|5063699009|56012099006; X-Microsoft-Antispam-Message-Info: aiAqI9Ut+/PKirx6LBWt1XvYEkoY2XKjlBNL8nnnbuX+AWNzFQXV4mQ7/uxXAprM/0QmKOVsujKqpu4IkMRlNV3+bB/GVj6InLqz4ibc8fzOXuwP1NT9pmhLbHgdPjLVtHLJcJqatw+YPFFoMklzi2HDOIg7Ax3yX1msX86Jt/2fSBf05VIBSGp1Mvu7V+HniVH8DEW13BATPX9iuvthmU4D0Z972v8MJ4LYsWSXcBxDEBQj0axUR7lsjTNflqIk7PkZXEIdO3rZb5jk7aqolKSPlktBOyC9VuGv3tV0loir+c6HdiWFbuHDySlXTKc19RHec+/S3f8Rg00u53vdDzG7wHIXMLx2GnA3ZQd16DnHwJvb4b0NLJMLXs+aXh58qbQVCn2H12aFXfPwLXmI1ZVQ19WrkI2xoYuo1PLwGN/MV19Bo7K+6cjN3oaMal2QDErfmNtRGoKbeaN31Qs6Tf08JehBmK2BUZ4xUsVmHu2SgnUoX+0YWoZmQo8udlJhXJOh8YESCuFI21Hz/CW8HTUZVCw+E2NRJKVR1EoweZJ98DJ4AhOr8ooE12+KonTmLo/AUfyUzviJKaPa/ijwDr0Vtffu2XuXGb7JrdnZS39dutTCtAq5SmSum08Y7Qis9nWHXxWQCdkEWtlhgHI4t65rTpYUuSkMZP8IpmMDP3r9GkrCoTDZvFDUzfRRCpt0N/WZPFYLYv18LFj5g2PT9RpMWmc/wEuY6qX+CBeE3h2rHKraVwLqrzzbjGniTZvm0pch7x1yIpVodW70A7UHgm6yWEuQAh42Tn3/MLij7cWHCdMncIHMtq5Cd84T1Qdy X-Forefront-Antispam-Report: CIP:69.169.224.1;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-1.smtp-out.eu-central-1.amazonses.com;PTR:b224-1.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(704162311799003)(9140799003)(376014)(48200799018)(61400799027)(32142699015)(4113699003)(5113699003)(10067099003)(22082099003)(55112099003)(18002099003)(16102099003)(13003099007)(4143699003)(261009223027099003)(5063699009)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: q9JsI4hJoEhDUzMPnMEnyBMhNz2nkMZk8VxyC6ILWsid1ynlBhnGxSpNub2yuPBDVcs5iKiyeR40ZfHJzxhVRx/HJ1Xki31MvUkvzK78S3DebqIBF6zFK2C7uaeP9W69GVByOSNRuv4T0hSyIss1wrMXu+tbcPRe38Mue86x30awzwaUq4zdwiR72w6Zy2r/TEjWLUuCLmZXORWVCHN4whhmU88lXB4AdvBUguoEPi9fEZSf8boFLGwYuITsjn0xhdIg257cz/lXT8rA0r7nigvtWRJ5/QBSHyfgORPgbv+f9mRH7yJ9mfU3KeKrNcDoDPntTAa0dH37OCFpV/pmfoWA3GtP6JoLH/Kvrz/JDHFWnaSJLQYvGlJCZcyvzC0UysCsr2NAx4FAvjjOV+Ag6jBdqe4oAE7/xvnBfEAbMeWBW7mGsVUljGuY0rbNXZab X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2026 15:33:01.5892 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 07cef828-2f24-4dcc-cd45-08df293f4465 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF000509F7.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMDPR08MB786969 > From: Mario Casquero >=20 > When vfio_device_get_region_info() fails in vfio_pci_load_rom(), > the function returns without setting vdev->rom_read_failed to true, > and without allocating vdev->rom. This leaves vdev->rom as NULL. >=20 > andrey.drobyshev: > This commit is cherry-picked as-is, with no modifications, from the > upstream commit c822ecd80661. >=20 > Signed-off-by: Mario Casquero > Reviewed-by: C=C3=A9dric Le Goater > Link: https://lore.kernel.org/qemu-devel/20260602070857.356526-1-mcasquer= @redhat.com > Signed-off-by: C=C3=A9dric Le Goater Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261013-vfio= _v1-v2-0-433455c0a294@virtuozzo.com?part=3D5