From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11023097.outbound.protection.outlook.com [40.107.159.97]) by lore.virtuozzo.com (Postfix) with ESMTPS id 2A868802A5 for ; Tue, 13 Oct 2026 15:40:46 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jjNPdxhe9Qlcmt5XqzbZTaS8T40Hh5oaWajeVdirxjyYE/xkjrR9ImDH6usrSqLKPYvManUFdntvm4CNs5ROInTSNWLU9Y0stSRH4WzGFJvO1X3BM5X4GnwE7YlIcu0dNHCE6ZE/JwKKn4LnCQexcnkgx998lx0Td5Acc6VfF04pbWCTW9bENReXFxF2dsrXCbPgt/dk//0v6GVFWsyQXGEuYcnOVXawNVHzu7v8ypMv/0AMxdyrwJllX29tjMNlaIoG5hnWcvMEHJyn6uclDvt+O11QOue90XwsSQ+jgtaBODCgH9oF0Xljs7tg76rrqJ8HT/Krg5qyr03Y8T1x7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0OiSaafjTIPOFGfmp3h3TbiSbVbnrnxMHHoDKfmSZmU=; b=PeAXQi4iWpXQ2w1A85tkJc8+r6zQvuUlkWgH78xHSFCKMB9OPDhla5iWsEuXqeOrdnuNAVKXqPlQ47C5Up69nnh8ysLc2nrgNiWEXvt21oHfA7JqQ7DEOuUTr6I0p8A6aHsoh+8uvn41URL+58ZoHZMxPb/LcVTTEdI9DvT2zrCVdk+X6tShRM2ROOyCuLnV8w1aEqfpXGa68fgn6L9OzyyVzwDyXkTYSV8x4NOZ++ySCzp6lqlCnQEo37vaVVL6csS3kF4n8c3xrR0tFmalLnoUPRNVFk7hfBWi5VU3ShuRhreNksUny30PYGpjpFXcRE43IxV7D1SnUYUVKpMfeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.5) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0OiSaafjTIPOFGfmp3h3TbiSbVbnrnxMHHoDKfmSZmU=; b=mR3TUBcxJHPrIkJb84ryew9tD4GzWJ4GWA89u+iv7DjgeaumDp0QqoDCHKk2cZl52ZpaPUWdVq2aqHWQhtu3jzukFtSTDgNGDoTw13xaIgKR6RiVHCSOlrC7zNNDOUz6s5yjM+/MAk+tm47aaLgMF1yfs1Ew9yc2PQbrM2UUB58= Received: from PAZP264CA0076.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:1fa::23) by GV2PR08MB11371.eurprd08.prod.outlook.com (2603:10a6:150:2a5::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.522.12; Tue, 13 Oct 2026 15:40:40 +0000 Received: from ZR1PEPF0000E6B9.eurprd07.prod.outlook.com (2603:10a6:102:1fa:cafe::57) by PAZP264CA0076.outlook.office365.com (2603:10a6:102:1fa::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.4 via Frontend Transport; Tue, 13 Oct 2026 15:40:40 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.5) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.5 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.5; helo=b224-5.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-5.smtp-out.eu-central-1.amazonses.com (69.169.224.5) by ZR1PEPF0000E6B9.mail.protection.outlook.com (10.167.241.72) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.6 via Frontend Transport; Tue, 13 Oct 2026 15:40:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1791906040; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=pkgBwabc5lndfLq9XS84wr1243HQNbQnfz18FCN+3y0=; b=grgXbP5Mpymh+577mf9pV8pAoA413qlGm7EWsTE5N8N8IBSCpRqP6Sbg0ZcIqxEV Jdtx/760Hlv0XiRQ1Ir1K4vmvpibvE79kPoa2eJYs9AiIdR6LVNveC0pHzl5qUlSVvy zMq85flWiubtqfDVCmUhNo7Zk8/my9LxIL1l/R1PCxExBZivDKjcle9FpH8GYd2ku3m /rKntVK+KoRUrq6gOpsVcJpugN4zvbEHcyG7PVku3h9v+09PmQhL//Y66GVlaj2Jk2I 8tFGRxYk+uJm5hUEPgEzT45R1J/1afQImiLVJvLJmSG2XutTeo12SgPuWq7JiAAHKWt jCkN7fr7wQ== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1791906040; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=pkgBwabc5lndfLq9XS84wr1243HQNbQnfz18FCN+3y0=; b=KrUeUvMRctj0lL1iuGaQ+LSAgV8adiB06yDz52UTAGZ5hoSFoa/yMtLOnEbvSnlo wTYIKJ6tzxBRZWmqwZBtZAiVW+xz09yxtCMK30jN5oK7PmVLLuTUUOtxUJUFriLs/QL 0an8GjKwyxU9LGChzlbdNyfCNCFGrmT7PH8HN0a4= Message-ID: <010701a135ec496b-dbf52559-f751-4469-ad5c-cbc3db6fc5e3-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v2 13/24] migration: Move CPR HUP watch to cpr-transfer.c To: Andrey Drobyshev , svt-core@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261013-vfio_v1-v2-13-433455c0a294@virtuozzo.com> References: <20261013-vfio_v1-v2-0-433455c0a294@virtuozzo.com> <20261013-vfio_v1-v2-13-433455c0a294@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 13 Oct 2026 15:40:40 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.13-69.169.224.5 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: ZR1PEPF0000E6B9:EE_|GV2PR08MB11371:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 61a956cf-e4d6-4bc0-a078-08df294055f1 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|704162111799003|32142699015|376014|61400799027|48200799018|9140799003|10067099003|13003099007|261009223027099003|4143699003|4113699003|6133799003|5113699003|22082099003|56012099006|18002099003|55112099003|5063699009|16102099003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?N3pXYjRQdVRENnhxaG5ZUTJSM3luUDZzYWl4aE5kK0l2SUd0a3pTUllGUlZH?= =?utf-8?B?TnF3ZWgvbU9od2cxOURzdGNqb24zTGlQNlRrVVRGSHVyaFZqdGFLRDI1Vi90?= =?utf-8?B?QnlGVU55bElHZllnd0w0cEg3ZmY4TDZIRzJzVlczdy9EQ3NNVGxrWXJrNk1T?= =?utf-8?B?eHBTRTlDZWFkc21ENnhsRDUyZm9aNXJYbFphUGQ1aUp5c215STJiNE1qRDlm?= =?utf-8?B?RGxXaUEyMmtMb1I1aGR3UTVFeDJyaE5Ja1ZCWjk4YVVpMGlIb2NMR0dVekhG?= =?utf-8?B?U1dYYnZONEdqYkRpcStHb2NPaXBMaEZ6Qnp2emNWZmFOYS94SFpCeHpjMS9R?= =?utf-8?B?a1dIVFFwbGtoSzNab3gvRXhPbUZyMmxCQXFEcG05OGVMUHVxSitHeU9KWnpS?= =?utf-8?B?MjFBZFpaUVh0d3IvN2dDZkFGQzQ0enBrbnBXcDRFejdPeWprVXJZV1AxQWw2?= =?utf-8?B?ZkkwVHI0RHdBendhcUhjQmdKcnFETGFlS3hic3FRNytCOVErekc0N1RrcXht?= =?utf-8?B?bE11Umk0cmZyL3F6RWhFYkR3VGRDTVgxd0RkY1pMZU4zbWQvS0kzcDVadmZY?= =?utf-8?B?MlhzcTR3aFlzOWNvRTJQV3FCZGtBd1NPcTNZMGZRbmU3bVZOUjB2Z1ZtUDRY?= =?utf-8?B?bmFGUjJ3YzU4Nng4ekVvemI5MkVIUE1VZ0RBZDJyL1h2bzAzVDlCWlpRRzZs?= =?utf-8?B?bDFtS0ZyK0poZGd5L1Y1UFJERE9VQ054K0hNeDhmTkRsR09oU2p6VjQvTDFK?= =?utf-8?B?cUd5NUZ4dWN3RTJQZkp1VlVCc3k0M2tqQ0tyOTU5cWJSUWlwazZKVDd1bU8x?= =?utf-8?B?K1lNRG1kbnBtUkFVNUF4ckMrVHQvbW1YamdxZ0kwOFZWdXJDeTA2aE5DVzBj?= =?utf-8?B?dTVCQzZ2OHR6NkhsRzVJazhWT2k0cHRwcXdDdlBodk1iQ3dHRUVZNzRZWGN2?= =?utf-8?B?UUNRbFhBcEFMUDA3Y1pxMDRkaGhDREY1L3dYdVozMFYzR0pMM0FIUWUvSldp?= =?utf-8?B?VlFiaU9ETEFsTnJJSGpQTDFVQUk3QThxc0s3QU93bndLN1V0MDNyRWNkMXU1?= =?utf-8?B?ZkpKWGJQb2lHZG1hUk12SzBBRmM3V0lPUkVpYmhwckJ2QjlZdUFyL1BuVmxs?= =?utf-8?B?c1FiZ2xPcnE5UEJra3htanNwd3RZUmVPdXlmc1pmTU41VUpPaFV1NmpUZXJh?= =?utf-8?B?dGUzNmx0VmJZRG1UWkF1bWtWNVRmNmMyd1hsd2t0MGUvdXRhQThIUVd1NHhP?= =?utf-8?B?dmhZUk8xWWszamJ4ZjJaOGZiTjdoQ28xcjNOek5VZTZYeUMrS2IwTjFDNGFu?= =?utf-8?B?TVFDbmpmSkxKWFBEdmlnTEw1VGZnYTZXd3lFRThtWW1Sb3VFOUY4UUNzMWpy?= =?utf-8?B?MVNsTnphcW1MT2xyajh1ZFUybHdoK1EwNzg4aGpPeDZyZ3NBaU9CZTZlaUl0?= =?utf-8?B?Wk9IdG80bFAzMDRSRlZrQ01QMnZZc0tNeDh5V1VnPT0=?= X-Forefront-Antispam-Report: CIP:69.169.224.5;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-5.smtp-out.eu-central-1.amazonses.com;PTR:b224-5.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(704162111799003)(32142699015)(376014)(61400799027)(48200799018)(9140799003)(10067099003)(13003099007)(261009223027099003)(4143699003)(4113699003)(6133799003)(5113699003)(22082099003)(56012099006)(18002099003)(55112099003)(5063699009)(16102099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: VCZ3fFBU0YKQPNz41HJ8loEdNw5te5dLFfgHiyVCbONyDPq7kogW7HNHjHIzET59Lbcm06X6oJVyhw7xD6xiwxbG6mKZo8n3rzNZ5C9xO7B1D1Mct1IXYBrW0LIKTEfuE2r3y8KQF0qbOd7fKZvFkTiGvOYnzCCfCu8sfooO/J18/eTYtJTyVKEAZZX5+BT9FQQ5nRzzEtfRiblGAdP7u0kE3FgOyqtYH8uzl5amT44hvVTQIVV9ueY/WsWgPaM4DGLN+R/4A9WaZQoUJxxOufJwGPnhAZot5gsjYcDNKUShc5b/dv92eznF+O4Cz9ZOpYfjYZHQ38+UcW24UOdp53k5j31tx3EYMytVmP+Te5u1+vp0z9lJFi6pmZbA4RfRQR6fgwpErUPY0FHvn00Rw+bWOe+T2ba0LLxD4g8J38rtcnw7OQpPqIN+YwoNwOzI X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2026 15:40:40.5738 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 61a956cf-e4d6-4bc0-a078-08df294055f1 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: ZR1PEPF0000E6B9.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB11371 > From: Fabiano Rosas >=20 > Move this CPR-specific code into a cpr file. While here, give the > functions more significant names. >=20 > This makes the new idea (after cpr-transfer) of having two parts to > qmp_migrate slightly more obvious: either wait for the hangup or > continue directly. >=20 > andrey.drobyshev: > This commit was cherry-picked from the upstream commit f523e5aa5f56, > adapted for the hci-dev base, which predates the upstream qmp_migrate= () > rework around MigrationChannel: the watch is still armed with the > plain MigrationAddress from qmp_migrate() rather than main_ch->addr, > and qmp_migrate_finish_cb() keeps closing the cpr state and destroying > the HUP source itself. >=20 > Reviewed-by: Peter Xu > Reviewed-by: Prasad Pandit > Link: https://lore.kernel.org/qemu-devel/20260123141656.6765-24-farosas@s= use.de > Signed-off-by: Fabiano Rosas Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261013-vfio= _v1-v2-0-433455c0a294@virtuozzo.com?part=3D13