From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11023119.outbound.protection.outlook.com [40.107.162.119]) by lore.virtuozzo.com (Postfix) with ESMTPS id B18408017D for ; Fri, 16 Oct 2026 15:29:19 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nfQdq8wQVddNnKiYG9MH46PlFILWHf2lI4AtnIVTQDpQTS/Vc1qatWckLI0lBdUNcEMYUVtqcGvXFTtTTdcJyFooTbjdUPcMVWHYF7YD+XuUWbyHB/OjEzZ/xIuhA/Iu7oDQDo6qHoYlOVc7klSUd2VEBm/8f4gHLfKX5wC5N8LDxZGWSAf2tae4/AwMjghpN4YMjtwkvCNe9lsBP1MIb9sMqKkNxXbuRlnpF9ZAltDzt2QpPoTsik0aUf053h2bK8UoyLO5H+e4K/KqkW5L8GmOgxlWtCKjCuai3WknDluyTa1VwwF12jz1p+jzVURKgp1EnbaCGHaQlZBeDlddjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dTAUYw1p3H4CzNPsNtsYFUbF3LYvSbvX7H+tvCDUbvs=; b=lGAo/+7ydJY0nGalbX4N3cuTWYo01p5rG+kBMab6HwN54TpC3txbhmM3PI22nuc5QWN/uEp2haW02q52T2Q6ILuTimkgER+Jc2VeN3+GU3zGYCHrseHi0WelMypLzWcer0gYUx9C6EatrPCmV2zq7y3ACIFyaFbhVq/Fe5sFxS2zyub0zS2I4nPaPsQtVD0fpk/BTViJHEhxB6rEndf24LukWzuMYaBx6aqTYmGDB5wnD5ZOUpxbvMCAc2f6v9m4p1IgbbwCNfMpod6dOsYbPE/a7+QTGumU8F1gSy9RGSmku9xRYekGbitzZVFSSTi7Zakp81EUZWsu+JQFXkH5Bg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.6) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dTAUYw1p3H4CzNPsNtsYFUbF3LYvSbvX7H+tvCDUbvs=; b=dzu/3jlQxCFn+Dwkru6bNBPBv6sAxftbSyX68zWgXZSiBjEnFScBWJBHApKd1bkVoOFREJJEoee8nsxgLpwoZXSwE4ianLq78YFHl8Smc2rRE0ZC94Wln2cyZWdLjy2arl0c8az1pOtboJiwqmbz84nbXdm6ANmMf4PNefAjLko= Received: from VI1P191CA0014.EURP191.PROD.OUTLOOK.COM (2603:10a6:800:1ba::14) by PAWPR08MB11331.eurprd08.prod.outlook.com (2603:10a6:102:50b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.9; Fri, 16 Oct 2026 15:29:16 +0000 Received: from MI3PEPF00008480.eurprd02.prod.outlook.com (2603:10a6:800:1ba:cafe::50) by VI1P191CA0014.outlook.office365.com (2603:10a6:800:1ba::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.4 via Frontend Transport; Fri, 16 Oct 2026 15:29:16 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.6) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.6 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.6; helo=b224-6.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-6.smtp-out.eu-central-1.amazonses.com (69.169.224.6) by MI3PEPF00008480.mail.protection.outlook.com (10.167.240.167) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.6 via Frontend Transport; Fri, 16 Oct 2026 15:29:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792164555; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=T+/Kry9rrxg6n9MdCIOhg3VCaPn9IJVNnlJ7GUjGZTM=; b=PXcX29RhFArg+f2ojrWmltsMQCto7XAkzemzmUJyoV2V3wF3TeE2+GuXxDLlht5B yGRAzTT5Yf+wdEKoRMOnufaVkneo0k94Ga1oEp2mZawjbEzXZy5C89L75CFPKu08STL /9lyD2r8tHIFA/8UKc31MOLUbxNpxHG/85OoX9+yytV9DZnMsMw+QW1PpSXuzUJeBfS SYnSIi4ggIY3hYiQN963XyOfi4ZpjmjQUwD2WEahmBYl08amgtYpGZYz1CYP9l5t+y5 aWfvUvesvy9xUnzzQtywJuqdKsbfNf6TAkhRJhDPBy3kTOLdxJhGekVFv/UrNGxfMO+ xNiogrgTPA== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792164555; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=T+/Kry9rrxg6n9MdCIOhg3VCaPn9IJVNnlJ7GUjGZTM=; b=aWItRcQt3Qv65X1iqfsCqx+vs22jSW6be2jkcjQxoDwHIxANxXfXPIZnM39cTfec XcP07ePby1Z9SdNKtdtmxfi1DDrbv7FTQ1NZ6C4nHFloYj07HlkQiQIZj4TxbzGsJki BoBosHKkphnreFskP+BmV94m2hXEQjS5wdPtIn4w= Message-ID: <010701a14554ec3a-25bb7432-1662-437b-8601-39dd23c3010b-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v3 04/28] migration: Plug memory leaks after migrate_set_error() To: svt-core@virtuozzo.com, Andrey Drobyshev Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261016-vfio_v1-v3-4-47487cb5a8e5@virtuozzo.com> References: <20261016-vfio_v1-v3-0-47487cb5a8e5@virtuozzo.com> <20261016-vfio_v1-v3-4-47487cb5a8e5@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 16 Oct 2026 15:29:15 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.16-69.169.224.6 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI3PEPF00008480:EE_|PAWPR08MB11331:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: ffef8406-5913-4844-620a-08df2b9a3d53 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|61400799027|9140799003|48200799018|32142699015|4113699003|55112099003|5113699003|10067099003|18002099003|22082099003|16102099003|13003099007|261009223027099003|4143699003|56012099006|5063699009; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MWd5cnp0YVVyWHZFU3MxdTZiOVg5a016N3RkVGk3cmFLbDhFN01vWW5XQTF2?= =?utf-8?B?dE1SdE1Rc29CZUdBcFlIS0pyOGxwUktsUlhHV0tDS3hKNWMyY1FRc2h1QW1x?= =?utf-8?B?TEFVaTJ6ekRwWmdYOXpGWVlZSU50bmFxTVU3OTkzTGM4RUdDZlA5YitqcWFu?= =?utf-8?B?Y3BUZEwvZVVSdzVNd3VZczNvZWVYUjhKRHNORWx2N1VYOTNyY2hkZTBJUFk0?= =?utf-8?B?azc5ZGJSMjhOQTVNRVN3Vkc5Nkw1ci9TM0d4TXh1aWVjT0NpczJReDNrVFFY?= =?utf-8?B?dWI1MTlKZkVmYXprb3ViMTM1aFdnK3I5YTN6eHczdUREK2thZGxrY2ZoMUNk?= =?utf-8?B?L3U5Um03SjZ2dnA1dHNmT0h4ckZ0d0Z4Yy9YN1pSandTdXNmUnRXWkdaSUFk?= =?utf-8?B?K0VXNkthdnFSZjVUOGJnOU5EZFdZSm1tRzU1L2VGanJzUWNWSHlud01kVU5i?= =?utf-8?B?Ni9zeE53cmVkRGJhclhIbW4xeDIxWlR6a2pBQytiQ0xHcmhkQnkyckEyblZ3?= =?utf-8?B?MVJBT1ZibkpVRXpMNHc4SlYrWm9lWG1xQ1c0dEZYUkJ6WmdadU05SnAzOG5W?= =?utf-8?B?M2ZaVWxKQmFvTzl5Um9iTnllK3htYmV4Mmg0ZUNRdVVIeVJaa0JzVVFDbGI4?= =?utf-8?B?aC9kM2ovNWpvLzh2MXZ5R3N0bU8zRlRDZlZMQ2xFRFRXYnNqU1BRRjVNQjhG?= =?utf-8?B?TnBUd3Q1NnNnSU9FU2srVUdzSm01QnJxZ2pKSUUzOHBPaU43VTE5WEtkdEpU?= =?utf-8?B?NXVXSUNwYkU1eVlUWEpkYk1NWmN1V2krZWlZU3NQUy9VdjA0dmY4U25jMnBH?= =?utf-8?B?ZVlIeGgwYjJhZklwR2NieWMrc3Q2VDBQZE5EUkZHazcxZlFPSmpzRENsSzlW?= =?utf-8?B?ejBTckhtSFRWTmNMWGZmUW1BSzgzbzBCVzZIdkxmdUQyTjlYcC95Wk1ycFBL?= =?utf-8?B?K1doRHdPaGY5d2IybUhRZktlZXZFSjRySktBT3pxWGRCMzZtM0RvTnNDWHp2?= =?utf-8?B?MlVUMStqQUcwUVA3aHFHZlpoNStpbjBJUGdPb1AyRTFteDBKZGpBM3VqQThF?= =?utf-8?B?blh3alh5QjdZYkh4dTJZV21TYlNHZ2tJeUYyaTMxMTdDOUNILzZhbHFvSEl0?= =?utf-8?B?bjNKcnlIT3Npa0wwNWhkNE02RkhrK296ZVFtcmQ0QU02azUzOXF4c1lUdnRV?= =?utf-8?B?cGt6TkpYS1YxM1RNczZxcXR5akc0N3poTjVqTmpUUTE2NDZOZTRrWHU1Ky9a?= =?utf-8?B?czBuVXdseXJkaklWdzd1aWM3TEY5THZSd244WFpLTERmWUUrKzZjcnJ1TUN0?= =?utf-8?Q?QpbrJyps1zr7qria/gMQogVfbGYQKSmrjh?= X-Forefront-Antispam-Report: CIP:69.169.224.6;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-6.smtp-out.eu-central-1.amazonses.com;PTR:b224-6.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(376014)(61400799027)(9140799003)(48200799018)(32142699015)(4113699003)(55112099003)(5113699003)(10067099003)(18002099003)(22082099003)(16102099003)(13003099007)(261009223027099003)(4143699003)(56012099006)(5063699009);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: lko6fikSlJ8XDsHVWobzk81JwrrhD6natYPFnj/Vt8so9vVBiqJv6b2RJf3NfCULUzxBNX+8CQtlB+m1LSCS5rPmNl/9tcKrsV+2x1NJlv0j8KeTfg2LBe+rSOXlR2DGhX6utz6yPYHKPLnenM9Z7yARXnLf7tsisTSp1037HZqh4Jst3cY8DoA7Qk++efKz2bbZWi+e4jfnF4/fDcNbSvsU/rlDQt5q8DZpxf0Kd76Swp88smE8bIDU4vSQQ92mSaXfrOUJONOU1RA6BRFwEleZ4lIZb4oXg8maEjEqXLa+rkZcroF1VeaTHHVNiiPgZMhRaWLdEVe1HTXkaaA0LTwWJtvgqu+WKSVYf+FGKHuFnpZ9MlPSYHQV4pAbZ6Gi2MxlsuFwr515VmnMvo8szoJQ/KBKSmE+d08E5+PmlIMLzTrIzorX8k/ZDK9AD+Eq X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 15:29:16.2959 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ffef8406-5913-4844-620a-08df2b9a3d53 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: MI3PEPF00008480.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB11331 > From: Markus Armbruster >=20 > migrate_set_error(s, err) stores a copy of @err in @s. The original > @err is not freed. Most callers free it immediately. Some callers > free it later, or pass it on. And some leak it. Fix those. >=20 > Perhaps migrate_set_error(s, err) should take ownership of @err. The > callers that free it immediately would become simpler, and avoid a > copy and a deallocation. The others would have to pass > error_copy(err). >=20 > andrey.drobyshev: > This commit is cherry-picked as-is, with no modifications, from the > upstream commit 93817ec39656. >=20 > Signed-off-by: Markus Armbruster > Link: https://lore.kernel.org/r/20251115083500.2753895-2-armbru@redhat.com > Signed-off-by: Peter Xu Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261016-vfio= _v1-v3-0-47487cb5a8e5@virtuozzo.com?part=3D4