From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a1455653d1-7ccd772f-b08f-4144-9b9c-8da3ccd9cfab-000000@eu-central-1.amazonses.com> Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11023101.outbound.protection.outlook.com [40.107.159.101]) by lore.virtuozzo.com (Postfix) with ESMTPS id 9DD518017D for ; Fri, 16 Oct 2026 15:30:58 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=F3aBicshAFuyY7+vCs+vdYxxKzn+S5EmsBFQV9fkyXGqn/BlgjNnVyZKT/tlMyEH1sGdu4Q0sgYn67mAgFyRxIPasTjwjvnaXcEwMOUY0mjQjmTHSEZYRa1NKKbot95/M+pwpFhr8bIUHGDfp4rA+hBa6IdXR17U/Fu2m4D1ZKgr3gc5GvaDiEtcqse4Q3yYWFYRQaJneR+pDIeJpacDaFZ9BOrIFDaWt+0QfVfGSZ2Oa6FYPdxUuvvLJyBz+LvfAyMV4I1EpbpQwCJ/1Jcsao/OTBFXD7fGdaFZXqhvplL3dcNSGMRafca+DYhCn824mm3L2HGl61zwzSC7a0YOVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9oU2R6n4pRJ7Qej2TP+/8SoZeV/s8mrFYjJ+oHQsu9w=; b=kegCS8brGkBAn3LgBDzd8IHvNLNavmoY/WyHMh/q+8IstuRfCmcO0KKIbO1ziwEPU08uM6EgkrnZvLElpApJOi4JHjc5hBDRav/+3RSwxA4STyLkSvy4aqN14aMC+HD9HLceHPXjymLJWhxiP9Gb1M8qV2l69teFGAoZza6poahbqXx5Z66mRT5yltygFtRyJISVG/YnM9znRMVoLEQeIknwHty88h2AXytdAO9PeCtZqg8j7Bfgmo+DuMphowp8nhLgmBxMcR3v5e5ShMQH2Kwd86r7rkuwCVdoxpkqQMBajIEP5y9i2zb6MrSaTObgIeZ/UkTyIKIjyu6iemfTVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.5) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9oU2R6n4pRJ7Qej2TP+/8SoZeV/s8mrFYjJ+oHQsu9w=; b=k5eKGwXrzrKD/uXn00uk4dy0xdoykvnx6yzbV8arQzAh2qzGDzUvNs2nYYFn8fcO9gTXGwx8nMcn+pQ+ERkUoOjRCwDqyyp60pleveiUAaxV1n8jSfnKKhiARCZTEP9YYAZXOfpHO2X62EQiVn8ce14H1BCc4brQptn/cEeoZfw= Received: from ZR1PEPF000077FE.CHEP278.PROD.OUTLOOK.COM (2603:10a6:918::452) by GV2PR08MB9255.eurprd08.prod.outlook.com (2603:10a6:150:e3::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.9; Fri, 16 Oct 2026 15:30:48 +0000 Received: from MI3PEPF00008494.eurprd03.prod.outlook.com (2603:10a6:298:1::5b) by ZR1PEPF000077FE.outlook.office365.com (2603:10a6:918::452) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.382.15 via Frontend Transport; Fri, 16 Oct 2026 15:30:48 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.5) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.5 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.5; helo=b224-5.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-5.smtp-out.eu-central-1.amazonses.com (69.169.224.5) by MI3PEPF00008494.mail.protection.outlook.com (10.167.240.155) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.6 via Frontend Transport; Fri, 16 Oct 2026 15:30:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792164648; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=GN1MuUiTMHp/oTqH8mKWvl3W9/QxUfOF28CvciHU3vQ=; b=gwsDJbdGgwNEgqnvpRuoZF2dQBy2O2GnDi6J+2gdL9HlRKc6iREJ/b+vWqnF7wJ4 MKYTGAFwKUkPMcmqHf9GQlziic6r95mp1j8B13ycR6iaZn4Mu2pq1eA35N863O3Hc0C gsvjEZyLiwX8V9ixUvtvRq1g81zgQLCJnBB6t5WOV2LIPfUb4d9PtB87tPR+q07Fsgt hAcJvsCga6DBxnIgRtw1RqfaWSrPLWb4mu+tDYb/UE1yZqA8kclN33TE5O2vJZ0nB5Z pNy/Ga+hu4W78KYgzz3uEcBknUjjc8w7IMWGXhVXDJWORoOrJHmB5wyfAcLNrjBWOxk h+WLN0HUYA== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792164648; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=GN1MuUiTMHp/oTqH8mKWvl3W9/QxUfOF28CvciHU3vQ=; b=m7B4qlriaf5E/MhSr40T/sXIE2PL7VBIQJexdWw9P5RFMzsJ3l7GaibH8eMVV4yD s2JfU3Q4oPj5CLeBujmzOIqcTmcXsYk8Pp/vCuE+oQAcXmKJnlh0rDCBMLP/gsk1n6e /3kniVYXUQyHJTEcfS+SNXR4y23/SfrGZB1fAhf4= Message-ID: <010701a1455653d1-7ccd772f-b08f-4144-9b9c-8da3ccd9cfab-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v3 05/28] hw/vfio: Fix liveness check in vfio_connect_kvm_msi_virq() To: svt-core@virtuozzo.com, Andrey Drobyshev Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261016-vfio_v1-v3-5-47487cb5a8e5@virtuozzo.com> References: <20261016-vfio_v1-v3-0-47487cb5a8e5@virtuozzo.com> <20261016-vfio_v1-v3-5-47487cb5a8e5@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 16 Oct 2026 15:30:47 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.16-69.169.224.5 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI3PEPF00008494:EE_|GV2PR08MB9255:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 55154e6a-cbe7-417c-0005-08df2b9a7443 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|9140799003|376014|48200799018|61400799027|32142699015|55112099003|4113699003|5113699003|10067099003|22082099003|18002099003|16102099003|13003099007|260925021911599003|260925021311599003|260925022911599003|261009223027099003|4143699003|56012099006|5063699009; X-Microsoft-Antispam-Message-Info: rZY5NfS15MwNoDD8jPHuWgQJ00XJoBB5+2HVzj5BIIz0Qa7dPARexJfyKBsVq+9aic68N4KNmBP6vkind+AqmHS9enHhkuNy8TQ0HbAjIy/b4eUegFqB0eNeh5MYG2jHty6f18xrAX9S0PlROC+cp4OB3n/OCPN9rGt52OShgvMm71SjO7X+Fe+mBDFkBQtSanYGAiJUA3g//J2HNywzYMcGKPWPaGVC1efwcbW9VCvhabYOPkamNqRBqFoL2u5MFXvK9wMk/9y+mqmchlRrKu+HZfXp32TwI6lwnzbhph1dAYm72VSNepcMk7C2+eDUCiGwo4CGwA/WrMj76yK661nlPGD6nV1EGSd6gZDWvekREoDk96J3alf6MAfMLL+pCaLj47wvrCRiH6fMTm8NLVw4wiKgy5RNMfTB/tDNOx9CnOG78+sRI92wECBGnmnNRQfQ/o6jq5oVpU/SWn+zSN1uU18IhA11mA3o6J+WCSKy4dP5OuFupXqjp1Krry9q17SbBNUYVZs4plpe/5m2IUw16Cx8zFa4vjrGR/OBoMAYYYfz8AedWOe5yapFb3EPSB0SIBKKHBynscVnagsHL33CqLBi9Rf8tqUw33c8MUy1c5WvbjESLYezQuUBE9IIDr9Uk4PiNnMY1SwY3An7bqmlGiZ5vd2/+mICT5nYmYB5cTGNyOqnCFrMsnUs7hOjuwkVG+eCY8TzGXUEBhN6ICI9DxHQXnurMS5nPJMZQkGrtjqhJBDuXuAgfnp2/bvTMKcGmmeYDOYopmUb8UNERsZfhBWByIcDcU32oTk3k4ceUWS/0n1zk4UL6940QoUMX2Ai/ZE9NCzv8mONUUo/3DikbwjLIjcY9XoCHvdd68roiwptwpXkfbE36JyXw+Ax0as5Y7gMDSMySzjR8+vfmMECJoqbIi0py4WZCM25ScA= X-Forefront-Antispam-Report: CIP:69.169.224.5;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-5.smtp-out.eu-central-1.amazonses.com;PTR:b224-5.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(9140799003)(376014)(48200799018)(61400799027)(32142699015)(55112099003)(4113699003)(5113699003)(10067099003)(22082099003)(18002099003)(16102099003)(13003099007)(260925021911599003)(260925021311599003)(260925022911599003)(261009223027099003)(4143699003)(56012099006)(5063699009);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 0CDWMb3Ir1qXL6mivsmOxiixLk2Jd8tyuv+JP4Ux0bAqd+OF1PsBZBAO0vXLYFDoVjR8ZnARwyRy4rjGWHoMKidRQL/PlHyz9PqBTGQOI/l4P0xunmoYZVdK5YvTpf7WbX0EoYoXdbB78fndWU8tG6fWZUK5XyWyhcUVsI8MvVHNSOMII7tjrFBxDjCbilDM4+b6NlM/vXM+AOQJXdD/p9m0wa3YYwJe1TliQr4JGNLTGOBOi/nAAMXF34IO0pDwX9wZaJyAn7lxSqboqxEJbw2PEfTmmpzUZ9xDvOJJ+AvLUiupxoHBsCutzFXTdiYsVpOQvSSItvOVcOrpAO2oDkxq3012Ty9yyFum1oYBnndkzbefc/gUuNrDuR8JvB2iJe5dsAtEBbaGujkm9RGEuYUuRoqJKsxIwlplZ41gvNbnNR6DrwSBWW9Xea6/iwS8 X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 15:30:48.4601 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 55154e6a-cbe7-417c-0005-08df2b9a7443 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: MI3PEPF00008494.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9255 > From: "Tycho Andersen (AMD)" >=20 > While working on savevm/loadvm for a new vfio device, I encountered the > crash below. Since vfio_connect_kvm_msi_virq() didn't check the ->use flag > for the vector, it would pass an unused vector down to > vfio_cpr_load_vector_fd() which would crash. >=20 > Fix this by checking the ->use flag along with the virq number to detect > whether a vector is valid or not. >=20 > Thread 1 "qemu-system-x86" received signal SIGSEGV, Segmentation fault. > 0x0000555555a891ef in vfio_cpr_load_vector_fd (vdev=3Dvdev@entry=3D0x0, > name=3Dname@entry=3D0x555555eeb27e "kvm_interrupt", nr=3Dnr@entry=3D1= ) at ../hw/vfio/cpr.c:44 > 44 g_autofree char *fdname =3D STRDUP_VECTOR_FD_NAME(vdev, name); > (gdb) bt > [ ... ] > Fixes: 30edcb4d4e7a ("vfio-pci: preserve MSI") > Signed-off-by: Tycho Andersen (AMD) > Reviewed-by: C=C3=A9dric Le Goater > Link: https://lore.kernel.org/qemu-devel/20260727150038.2684512-1-tycho@k= ernel.org > Signed-off-by: C=C3=A9dric Le Goater Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261016-vfio= _v1-v3-0-47487cb5a8e5@virtuozzo.com?part=3D5