From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from GVXPR05CU001.outbound.protection.outlook.com (mail-swedencentralazon11023130.outbound.protection.outlook.com [52.101.83.130]) by lore.virtuozzo.com (Postfix) with ESMTPS id 0C8B280461 for ; Fri, 16 Oct 2026 15:31:13 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZRSVejPrUOr0VOOmoY5+qsvDhbxXr7Yd3V2tMgZ4t3oV+5glUIvMRYFpJnXF92cNG+MjD5wImMf53za4qubvSlc7k3I4cYsY8EofafujWxwr4rLwT6LaZaSKGQLwyI6sJL99OQH3iuBySRcH53NKSoZgsAWieDNp1fRC7gLToGZp21FTi2J7JNu9O7fkXSwqmoj7g/uQbnNZ/T1tyXAwb+rygd+0RODWnS/1b4iw6AAo4/EGZUPm+sQhd5j7FZPnpBXbI65b1+NL6BkQy9kQzXaaD9BlFWpxkEzQXRq/BKDo3VXvofjxFhDJ3rbTOmwYQUt0iWL6gVN7qVxOu2rF8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BZffxbQLPDBM2peOpJ4d6jcXiCcR09UqguQvbCkZkv8=; b=dcTWRXzFCGP5VJF8OiJUXgsF8Y7bFS0BwxzbBRZes/Cd8qx4Dy5aSUTkCGI0N8dd9m5asVX4cgA5Cl5X4FXLhPk5Zg4uNR0/Gz+lha7wyQSGb0IQPN5ZhjHy+8fWqpBUJmmhcheQNMomXxO+6p9kX5R9luj9rOGCudkBOnif3pxxnFVIKO+4FJ5R+1vc+qGykHrYA/TDTP0xUZmlfIBrMoE4am55ElM+eu+Lsr5K1y65MUS2lI7wmmV6Jsjgo31HY5LUcV+83tM7jh83siY2x9TNC+ACRVWV7QboYmi4kVroSfg2KmMMycHghWqlcv3tEwgzUkS8EKgfrR6OIHhoIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.5) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BZffxbQLPDBM2peOpJ4d6jcXiCcR09UqguQvbCkZkv8=; b=lwRAE+/lWyewrzEvtf+QDRdNlu2rtrbsWPrmVzszWMhP4nbJE71xxyUO9HfAqd8rEiDL/cfIr0zIv0DNdmr7wPFUd0x6rHHZUcfbszvTg65qUAWkBcD0KipTBB+38RgFAJT1LVGAWC8VSLkfA8Tat+r1LdGCvOlhs0z4/GcPt0c= Received: from DUZPR01CA0059.eurprd01.prod.exchangelabs.com (2603:10a6:10:469::13) by MI9PR08MB781463.eurprd08.prod.outlook.com (2603:10a6:290:87::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.7; Fri, 16 Oct 2026 15:31:09 +0000 Received: from DU2PEPF00028D07.eurprd03.prod.outlook.com (2603:10a6:10:469:cafe::81) by DUZPR01CA0059.outlook.office365.com (2603:10a6:10:469::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.472.21 via Frontend Transport; Fri, 16 Oct 2026 15:31:09 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.5) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.5 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.5; helo=b224-5.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-5.smtp-out.eu-central-1.amazonses.com (69.169.224.5) by DU2PEPF00028D07.mail.protection.outlook.com (10.167.242.167) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.6 via Frontend Transport; Fri, 16 Oct 2026 15:31:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792164668; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=y1l4vQlhHaHsVtrZLQLlpLV+w/RviVnQboOmTF1Aal8=; b=T4+7JLPWARFLhytaaAGV5nHH5kTvrUVFa3BXRZOTHg8/l0LVvP5zwuVVGgARAHSo YwU4YKCCdistMnIeED+v67UwyzcRX9YYbp0hyiOvpHdhHNJCWudsDvVEI8BdvmRMR1B QQHVHyvsaiQOsiza44KaEMZ411CKuPu4JIjFVQTTQVekFfSgFDNxxW3xAWu4f3kXLY0 fsveJIE8uH6hYcJ+ytKdRSHwDzRR+LpM5+H8b3jf6FYuthZuUEJpf8LISglSRViMeJO gSIYyDYtrYHDQz65ic5BMwbJk0JUG667jU/SQ6BbZCxbcQ69nAIAcarhbTWpva9ZRyv i2NvmUhhuQ== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792164668; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=y1l4vQlhHaHsVtrZLQLlpLV+w/RviVnQboOmTF1Aal8=; b=A/nEB39ALmoR6903x534F8JAWp2rkoabU7Dk7vUdeI3de1ccuCWkDooOYBr5GcF6 iI580517VpcvWy/apJomNvWQ8e7OwHQGOFxUsMCcfbxvSdmp+c+ljicHcbHdW9Rtmtc vVBDc60MRsiwnpYCrAHKYTsxxCu6J6RUyrcVGZXM= Message-ID: <010701a14556a48e-1ff60259-44a5-4526-b806-af150e688b4f-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v3 07/28] vfio/pci: Fix information leak in vfio_rom_read() To: Andrey Drobyshev , svt-core@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261016-vfio_v1-v3-7-47487cb5a8e5@virtuozzo.com> References: <20261016-vfio_v1-v3-0-47487cb5a8e5@virtuozzo.com> <20261016-vfio_v1-v3-7-47487cb5a8e5@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 16 Oct 2026 15:31:08 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.16-69.169.224.5 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PEPF00028D07:EE_|MI9PR08MB781463:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: d1416b3e-8d97-456d-9e01-08df2b9a808d X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|704160211799003|48200799018|376014|61400799027|32142699015|9140799003|5063699009|56012099006|4143699003|261009223027099003|10067099003|18002099003|16102099003|22082099003|4113699003|55112099003|6133799003|5113699003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MzdDVkpYZFRKcmRwalZDMnNodnp2VEJiQ0k5YjBLa2hieERnYStqV0VlUm92?= =?utf-8?B?UTVOMFV2QkVDWUZ3ZnkwRExZNjZwNFJVa2NzNCsvK1VyRUd1SE5QZytKN3Ay?= =?utf-8?B?NGw1cnZMNzFnVXJONktUZ1ZzUzg4M3ZxMTVxeFcwL3JaVkw4TEtic1lhQXg2?= =?utf-8?B?M3VZNTJmZzhkelFGd3NCc0hhWStoT0FjTW5CVWQyQTl2amoyVUQxdzZrQmZB?= =?utf-8?B?YUhtQWMwbDdOemg2Ukx2cHZ0UU5SSmJ0TlBDbmVXVHdmM1pQeW5TMlI2bDF2?= =?utf-8?B?SU5MVHZMT2xSSnlwbTdPN1dOQVJHYlQ2MUJsODdhVkMxNklQSUZiaWRNSTJW?= =?utf-8?B?Rm9DQWxFdktDMTRpeDhlb2xLenNZRjhzTHZYc1pldWI3UVZlTjJVZm52SUtL?= =?utf-8?B?SVRFK0J3SmhOUGNFbzZxV2dkVkgzbkdNYVZBdGFvMTU2d1Evc1NlSk1ldjJN?= =?utf-8?B?K3UrN3NUU3ZrTG1YL1B0SDRsOUhpZkRZNXBBSE9sVmp0dURSbTRUb2R3NUd2?= =?utf-8?B?SmN4MFhaY1hKaGJCOVFEdnZaSmJjU0tjQnlqY0VyWW16Um5DSWtTQVpDa0FZ?= =?utf-8?B?MDFGTGVCSURwY2hrVHdqWFdtVkU2bmZxV2YrRUplSStWRk1PajgzZ1pwNVVG?= =?utf-8?B?bnhqZDBRbVJCck11MXc0YzV1YldqaEdWb2xLL3paQThseit5aXBFOE1BeFpy?= =?utf-8?B?bkdENnlRNDZaMFBieGsrMmdMVTErRktlWEUyNWdUVitrTy85cG1memw2R3Nk?= =?utf-8?B?RExnTHd1TnFJd0pqK04rUEdIUmd6MGFsQTFtc1cxQ09HQVNDYVdzOWwxNHpS?= =?utf-8?B?STFoUTg1eVhDSkZKckhwWnlFUzFYLzlDdHpsZWtaUmZFVGxKUWtyVUdiL0Zx?= =?utf-8?B?Wk5NQmVMMGl0YzJObWpjV2F2MkljZ3JsbW5zdEFkYlR3YWRsbWs0NWxkV2Jz?= =?utf-8?B?S2tnNE9sejR5dU02YklCQ1haemp4TVFPUmxDUVdoaHNQYVQ2N3ovS2ZGUHRC?= =?utf-8?B?c0NQemNra0NVU0RoRVI2OExwVzZQbm9zSlc1WGx6UlY5MVlQd1Y5bEtmcmtx?= =?utf-8?B?cG0wczVETndhWUExd0tRVk9HYmVLemxMRjhjTmZTaTQ2WThLZUhnSjQ1YzNQ?= =?utf-8?B?UmpqN0NscEFjaVY3UmxDUGlYMkpHVjVUb1Y2YXgwTmM3MmRaMTdVVzUwaXBW?= =?utf-8?B?ams1bVk4aG1XQitPTHFBWDFyUTRGNXBKRDAyYkNXQTd5cDRWcWlPaW84YlN3?= =?utf-8?B?a1JhRFQ3cld1ZldyTDJ2SzdCS0xtV2g5c2YwWG9IcURvSEI2WjBnd3ViblV0?= =?utf-8?Q?kGc28ook1mRcE=3D?= X-Forefront-Antispam-Report: CIP:69.169.224.5;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-5.smtp-out.eu-central-1.amazonses.com;PTR:b224-5.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(704160211799003)(48200799018)(376014)(61400799027)(32142699015)(9140799003)(5063699009)(56012099006)(4143699003)(261009223027099003)(10067099003)(18002099003)(16102099003)(22082099003)(4113699003)(55112099003)(6133799003)(5113699003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 65PvkJ8l2ULR6O1TFlBMzHFrhxR8yI1t/xUJeqLteMSwjGC7g/pDIUd5RCTPd9dT61X2D+svvxA9X8ZQ9mYcmsljf4UiDMFQ6iKeH/n7f/pAdmASI/i+Pi8lO7XVQ8StPx+ohtgWDyvFTj1/IM1WiRXCKzByrTgt/XTXiKGdKDNHVetFnIT95swvSQVOfIlvRWGIIJcwlLvPW5UNbxn213dGKFXv8P88kpEkUShX+U8YWw9N0VyMItavZ/8Dycld3ALvLaeVqo9w1Q36nM2No6gs9xo+MlAULJ0QaropMrWHaWfRsR1PmZCqvyXreGxV+fmQ5HhdQMVpJUjSxuCeiKriOqzOK+Bpgd7SllfB2n1sLsxQWApAwNVRkWqiomRCF6TZhg57f1zDBilWaLjZpIcAEiPA1uFpkRRLCkptRNKuEjOXGskKXOzY+f9PukYj X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 15:31:09.0741 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d1416b3e-8d97-456d-9e01-08df2b9a808d X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: DU2PEPF00028D07.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: MI9PR08MB781463 > From: C=C3=A9dric Le Goater >=20 > vfio_rom_read() can leak uninitialized stack data to the guest when a > read occurs at the end boundary of the ROM BAR. >=20 > Fix this by initializing the val union to 0xff, matching the ROM > initialization pattern used in vfio_pci_load_rom(). >=20 > andrey.drobyshev: > This commit is cherry-picked as-is, with no modifications, from the > upstream commit 402fd5a75659. >=20 > Reviewed-by: Philippe Mathieu-Daud=C3=A9 > Reviewed-by: Mario Casquero > Link: https://lore.kernel.org/qemu-devel/20260602074446.1206892-1-clg@red= hat.com > Signed-off-by: C=C3=A9dric Le Goater Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261016-vfio= _v1-v3-0-47487cb5a8e5@virtuozzo.com?part=3D7