From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11023127.outbound.protection.outlook.com [52.101.72.127]) by lore.virtuozzo.com (Postfix) with ESMTPS id D9DB4802A5 for ; Fri, 16 Oct 2026 15:33:38 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OWBP0cBRujd0XY7tN0xFNQZoRjimD7r/aDvS2DN2dgOoJSj+zNfgR3mrEIXmXFJvELf3NK1LvlUOlXPKELRcB9/xbyQD+E07wmyRqwLEOlf5qlTVaWhY/J/xv2wvJwvtaDJ3rcAVWODhoo585wQYe7/t+ZvJfz1Hm2MKK8W50b8QULEbrGlNrfbT4tbcfdstJ2IFJDy4T32G1IVi6/ee11rbQPntulsUCHIkQYJJgWKXJJOiEzlwgMohb76q4QrOqyAxz8flpDT1+zqZtg5atvouKq1WswD66ObC+JIBpTdN5bthQXDCL0ZtRTpvmhjwjWntr1UHmBw+MY/xk5+h2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aHSoKvU5QAOQwTFHLaWsmbFk9gibUVzaEev6DQKyk6Y=; b=L2XGI0pC/wHDBVCyp7lxowZ+hl/ZwSqIVw/o1jvuj9hzmtrpSaYGm1iOahUy20wrCbuZBbV3HIua85WnVYH2jDjAywhyC0ZqrCBZHzHd2LyRvMA2uMlmMmrzlesnP+PrEsNLrvT/UWbfpDzN9noUbmd2IgmKqII+mk9GLxcEMzRQCaxNSEJ14iXETDrwTBveYHJCUQhoIAg4AmLn5plN2uW7J/25N7zQgaCkrGWp25W/CQXgr5uSW5LzFcln7bmapZ1U936LEWzINdN9e746odoEyYGhLKhonT45xV8OncQ8s0LZNzRj7HC9TVVArevmDjVyF/uNr9LavZQQLwuWtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.1) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aHSoKvU5QAOQwTFHLaWsmbFk9gibUVzaEev6DQKyk6Y=; b=pb1kIiCaPDt8K6SsGsQEd/Cb0igQOd4XIkoenNNH3Z4EXNHGfRcgqsebtDZSDyJ/fZhqto/QLN8TOL6Sm1xVqKnZrjExtIXTPFELaUjfRLCMQLcyQ/P2n0bqvjhbd3uJMmOFKLYp0Wnr9PH6Y8f/E6U9SyWM2jZIiqL1fgH0txY= Received: from VIUP296CA0020.AUTP296.PROD.OUTLOOK.COM (2603:10a6:800:34e::9) by PAWPR08MB10308.eurprd08.prod.outlook.com (2603:10a6:102:369::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.6; Fri, 16 Oct 2026 15:33:32 +0000 Received: from MI3PEPF00008487.eurprd02.prod.outlook.com (2603:10a6:800:34e:cafe::a6) by VIUP296CA0020.outlook.office365.com (2603:10a6:800:34e::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.17 via Frontend Transport; Fri, 16 Oct 2026 15:33:32 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.1) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.1 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.1; helo=b224-1.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-1.smtp-out.eu-central-1.amazonses.com (69.169.224.1) by MI3PEPF00008487.mail.protection.outlook.com (10.167.240.134) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.6 via Frontend Transport; Fri, 16 Oct 2026 15:33:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792164811; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=JtJQBJv/wy0O9miTyCPnapdI4BMhGmdR2lm4q6LsKvo=; b=brt9hyfFctfp3YI8FZQrsSuGJCJEId2/zHWT6F23TE2R6Z8TbgSt+1RULUV7kmB4 r1u59PVxSsfBoCKA5OmP+LlSEyCQz+fSx+/J1hs9JxtmAPepQTN7xRDwxVyvaT1raud pV+/4uwD4uAaROSwt2yl4kZF7U5wX6Ss7/dP+eeK3VGduQgXxU9zG0wm84NoCToATXj IiZ+vGW+tiQOt7TZ1XhtGa89zS9rROlERh8uFzg43jUQnlWt04lalkDWw+Zm3f3Y77k S87/ufesqhPI/209zSnz0Z/IEvXFDdQgtmZTiRxbp+FTAuOr2tSdhVGIn5elO0yiW5L bDwsXwdU6w== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792164811; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=JtJQBJv/wy0O9miTyCPnapdI4BMhGmdR2lm4q6LsKvo=; b=eH/0sbccdfVUz0EJMEToB2OJz1i/q0t+g4feSOsbSyCcPWDe7azBi0MWGY0ER2vF vKr0qSRppW97c8hevXfUITiYu8ok+MMOj9Eg/s75rWgeZioqPKO1muimSWtGue4x+wp LKch5FnteGChkD5X2LvTm+EU4iW1L3dA9wp1ZreU= Message-ID: <010701a14558d260-2b3d050e-01fe-4bde-8790-113ae36218b3-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v3 10/28] q35: Fix migration of SMRAM state To: Andrey Drobyshev , svt-core@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261016-vfio_v1-v3-10-47487cb5a8e5@virtuozzo.com> References: <20261016-vfio_v1-v3-0-47487cb5a8e5@virtuozzo.com> <20261016-vfio_v1-v3-10-47487cb5a8e5@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 16 Oct 2026 15:33:31 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.16-69.169.224.1 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI3PEPF00008487:EE_|PAWPR08MB10308:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: fc7f1da3-f6f1-4bc4-47a0-08df2b9ad5ad X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|9140799003|376014|61400799027|32142699015|48200799018|4113699003|5113699003|55112099003|22082099003|10067099003|16102099003|18002099003|13003099007|4143699003|261009223027099003|5063699009|56012099006; X-Microsoft-Antispam-Message-Info: 1W/12PHlUrvUcV5kAHiOU+/XhewGLAY3jjq5jxlyoMlrkJXQtcbSklsZmubvvmlhiisxix8YCxPML47/KjkoT4dUkji3DZ0meKSFhH+Wv7z/wIMYSQr2GWRkVwcelpZqqAShnIgZwZr6qDIEKs4QKW+otK2c0lAjupjI8Zcpea63TbxsErlpBEdqgX2eRirQgUt9/JZf4M/Ik1TzbfTBSi11OXsttq026pQFYBcRyGFS8J7ylU++ahp+VUxtY7Jrd4d2q0xm5MnfSLMp8DPQ4CyM4EKUx5ohIAZyeuFOige8AXSoKPqlalwRgZrF0/zq39QsN6L0BX4AZOW4BYAdjbcJgQVOmuIPMVRvzEaeFCL2JMhbxyC7sc4rLfkFE40RZcNVurIbf/NGyye+5yJpT6irQBvjdk/jzR97rGiTwuHcfQNAXGBxBQOpZPU4gCR51uWSQEUiBFatQbXBg5a6P/p3Yv5iuPdMwMmLXgkgG0ZucZxH9Mfo4baZbInp7LznSADzzPyBOfirN8pQDAkCBSI5w+cvEwDogpjFFglb7Wi38xADC0mEECncJLUpgjpRFFVd1aPhWce9xcTnFfnpUMYXy0n1zt4c2gvro13lFvWPYC2W8rEkxfSj4S5rSbVmKXL0DUWES5iiDpbRoW+PK4BwbYeD2LJLrLA9GyEkd8CClOsea+VAcLkfg3RSwlkik5K32zYJSOEV22w53E6ZhtkE9ejDzzSTniRwpB+LoQS4oJqQ6wxZtwD1lxdOUMg8qsgWX1ipqEtvCAFwFwonl+hSoB4iU4aToxfzv7/zu4so68nAhB/MlILXb9ElB3brn1nwpmlkw+wPc+X3mvrwo+8bS53Em3ngQemImNNPiYkTZH0a9ay7ceM62syVm0/NUqBqCViygyW39yb7peDKYw== X-Forefront-Antispam-Report: CIP:69.169.224.1;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-1.smtp-out.eu-central-1.amazonses.com;PTR:b224-1.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(9140799003)(376014)(61400799027)(32142699015)(48200799018)(4113699003)(5113699003)(55112099003)(22082099003)(10067099003)(16102099003)(18002099003)(13003099007)(4143699003)(261009223027099003)(5063699009)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ylSbWpbC3x3t4KbaAmjSNvmR4f2ge2uG2umrsCi0TpGOJUumxxeUwojrV8OablKDkisuAsS0O6UrMChnvBsYLxWU1JhiicvIId1zXMONNn8NhwNQJu5YXEbkblyVIf9lm/0KkojsBBjxe/qFT+xOV1USM7qu1uieeF0+8dvR00kJDlitQFuzHswRYv1lmLUUqBDa6jUk3OEjXHQvONUbsxcukNXjievUv9i93Gdr3ixpwdodf+f6z16vxzfh3PvCKKvJ2ak27L2F7EiinEBP1wX/RplqGgpD4Yudqjdh+JqESUQwsI36l/kQPVRMCc3NPVk+MeP83e5fdFNRi7dYF3nEVh8+om/Z46kOWHbxNLomt3xGLHGYMbOoXrQ1rcI+85NKqRVMKA9ut36ptxzySMpef1wBQ5Ur+qOEqZYLLV2wVjyv23yUzsDs2z1ptgq1 X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 15:33:31.9079 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fc7f1da3-f6f1-4bc4-47a0-08df2b9ad5ad X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: MI3PEPF00008487.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB10308 > From: Igor Mammedov >=20 > When migrating, dst QEMU by default has SMRAM unlocked, > and since wmask is not migrated, the migrated value of > MCH_HOST_BRIDGE_F_SMBASE in config space fall to prey of >=20 > mch_update_smbase_smram() > ... > if (pd->wmask[MCH_HOST_BRIDGE_F_SMBASE] =3D=3D 0xff) { > *reg =3D 0x00; >=20 > and is getting cleared and leads to unlocked smram > on dst even if on source it's been locked. >=20 > As Andrey has pointed out [1], we should derive wmask > [ ... ] > Reported-by: Andrey Ryabinin > Signed-off-by: Igor Mammedov > Reviewed-by: Andrey Ryabinin > Reviewed-by: Michael S. Tsirkin > Signed-off-by: Michael S. Tsirkin Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261016-vfio= _v1-v3-0-47487cb5a8e5@virtuozzo.com?part=3D10