From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a1455e6c5c-5d23601e-58e5-4226-9733-146f10e4ab90-000000@eu-central-1.amazonses.com> Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11022128.outbound.protection.outlook.com [52.101.66.128]) by lore.virtuozzo.com (Postfix) with ESMTPS id 71B0E802A5 for ; Fri, 16 Oct 2026 15:39:43 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dh1nueVybc7KkiltS9hEr6l+zi4RKfBakfKQMwPr4+9KDe7KrB0jff3H4tJPP1JEPXUMw9h8vl7ahHqRsKATqSrvoxWK/EO+k47qZfb9b6UiI2GRc+z5fpxP2A0+yEnBey22Slp9qpNclOHkF3pE8FEd6bAgI0EG7gexzXut+IKG1ZeBiuo3LMZfRUOApauwY5/2hxdMXOK9BmglIZgRbpcWHfhz3uG4zyti50u4ecdKAUh1t3I2+nXq9xUIHHklf2NBofosvTgev50zmgeThEcSlfLUQ1kavDbktlEFjdHaPYV6r36oJTFquJ70XH20CyxV+0ageFHY9ez4SY+M0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9XhbErwLgzb/WrJTBbDgXbRcm/cSZ6unD3qOIqBUhcw=; b=ZbOnjtpgYv2tQKK4a83jdQZ3HeWVP6krruCRDhISDEHFggFTN7QK5h0ASqlWvoyINXKO3xme8tecsAe2Gkbot1qSGFROZ1G9sZxwqlG0Vonhs5Q7IBeUEHsXi4gSguoC+Fnr5je+tPyMyEBHjV3+HZd3uNWs7kiWxZVt5RmGyVMo06rAsSQ+FapjQgKtwk+Qnhtuicu7pM3htna8w1sMISI2cAG4rCqaqrLN22femg0E2rWalo+2qtOtUI4ow3ugIxytkQe+1mpucGKAFR/ns4awtZvxedwL5ZPMbaTI1nFVgiB8K9uQUT+KCUsGRcVdDEN28DLIQrZTw8TihiP/IA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.5) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9XhbErwLgzb/WrJTBbDgXbRcm/cSZ6unD3qOIqBUhcw=; b=UkcL1l55Xz2xofucCoYsgAND2oue3I2wTDdvdNtMT8/7DARPvKYqYLjJOeazKGJlcADDeYBgjQ6N9yi2dZi4oMk72J62KPEtkVJ38+I4ItUY1pcQhmmFMNJws6Ctwz6AuYTiCH3mkO8aB1ibaEAG3v193MTfYTrl5xgaygLZXaY= Received: from AS9PR06CA0540.eurprd06.prod.outlook.com (2603:10a6:20b:49d::32) by PAWPR08MB10897.eurprd08.prod.outlook.com (2603:10a6:102:46a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.7; Fri, 16 Oct 2026 15:39:39 +0000 Received: from AMS0EPF0000056A.eurprd02.prod.outlook.com (2603:10a6:20b:49d:cafe::96) by AS9PR06CA0540.outlook.office365.com (2603:10a6:20b:49d::32) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.4 via Frontend Transport; Fri, 16 Oct 2026 15:39:39 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.5) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.5 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.5; helo=b224-5.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-5.smtp-out.eu-central-1.amazonses.com (69.169.224.5) by AMS0EPF0000056A.mail.protection.outlook.com (10.167.242.120) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.6 via Frontend Transport; Fri, 16 Oct 2026 15:39:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792165178; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=s4tFdu/duF2WFThGPpEQORHYREYMaeIeKATU0vzRZY4=; b=w63AVH/O088od9TW87HJQWx3rzN2WzQQsNcmqayeNt/44yVbPiK11gz9BeF94ae/ fd2VA19c6zQSjqNVzA1QJYKrS88+um0T6RgKOhNPW3Z2xO0pfaX0F1iAGJk4UO7W5aU l/Uzer1QKog25wwQ2wx8qXqp596p+CfGmM3oUgNLP3JTF8OaIEEjvzQ6I4+3UioOyzC UxbmuS64b/gdeYxhYxEFNQeuJVspUtm0OB9YPBsJ25Ktkb8sckaYNI3rONw6NS9N/Zb 9BhrDPma4roi4hAZsgty8ZPi0c+XNfaHKM0YowAJ+FiOidEiVWzUAhWA2jj+EMaiHX3 wTBMww4Cfg== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792165178; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=s4tFdu/duF2WFThGPpEQORHYREYMaeIeKATU0vzRZY4=; b=iNAbz7GK8K0+nspOlqaXwRyIrbL071oaQ1fEPKrtytakEFrCa3qfoh7rF8SxuucH NGMFsGfFwEsl0p06PfhTePnt7olQ/nqwZhOOEQAMwKhpcJ8oTiQnGaFx29qEvLHbgtp LjquRJSn6knXB+/nJN+GZ5DIMoVWzu7ftuVJ8mz4= Message-ID: <010701a1455e6c5c-5d23601e-58e5-4226-9733-146f10e4ab90-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v3 15/28] migration: Free cpr-transfer MigrationAddress along with gsource To: Andrey Drobyshev , svt-core@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261016-vfio_v1-v3-15-47487cb5a8e5@virtuozzo.com> References: <20261016-vfio_v1-v3-0-47487cb5a8e5@virtuozzo.com> <20261016-vfio_v1-v3-15-47487cb5a8e5@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 16 Oct 2026 15:39:38 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.16-69.169.224.5 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS0EPF0000056A:EE_|PAWPR08MB10897:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 66d51282-1618-4b90-4f15-08df2b9bb066 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|32142699015|9140799003|376014|48200799018|61400799027|5063699009|56012099006|4143699003|261009223027099003|22082099003|18002099003|10067099003|55112099003|16102099003|4113699003|5113699003|13003099007; X-Microsoft-Antispam-Message-Info: +Uj+RfBMFDPAIdLh9gsXzjR+BdI5j7n9TiN2q2sNsbURawzkSVZnGOyFN6lIzX9snuAUBRXxwt5LSnWdHguKdErRbcw7zomzGcaQWhL2gmtQH71Ig0iCHxGblVqlb21bTQgA61lsU+Rb075tcxbUSP0X4hkaj1NAHAwt+0pMIpttqm1hk9dYLjKYXQIIvY7vxnB95YCsuNy3qFfG0wIbmTIW3ubvkviRnZz5YiKvE/kKdAWp8edBsQuDxRbNTSieBYXFXCU6+PwuHpdRGEqvMYa97tPnzKoB/DGQvMKN2QnWg9gFq2y0mV01HPQfgF7JfBBSpaVaCFukpX0RU5oKAEO5dfI4FUZIisefP+VWbS4ITvSOP9txITb+Id0O13+xRFk8xAM5yN6veqEv72kEwWk7zB4CPSL7zbwQx4EDvQwBQZB4wcOpraog7gbjg97cJ2MZ8AvfR1CU6nGV6RQI7XEScw/Kzhj6Wr4Z8l48raZESF31quq/Dm5emQzo8fSF8K8O3GgzPhjvfNp9JK1HXnc3GLdPTfsRKv65mVC8k/jQc2b+A15mvApB+qDHJB0Fogg7qYehZTkQ/ixmG0mw/hwyUvfCNm9qI5q0GEaggQTJoVRR2HU/dR6F0PaiH1jNVM8vK3gfCPdBqfS56MOZEGyjOMFhd69PhWIu4igYEyU+ur0M5NnOWj/lOn7D2svcvJrlWuRQystPYM2RpGpmvnu82Pua77VNqNe4VxYySM1nluUuTmql933v9ITBNgV7PdqGbH9cF+FLU3R1Gyjqxtl4iCV0lDcdR28iP5R2OEtyjliFc8XIeVI50ZwFXpuiqEQCB0DQlqldoWh4ceXNtiY/Y/ZzmTjhp3zjdWkjZFSjFUnXUu3DGhrrlTC17qCIM1Id/vtoVuIHSoPzpiS+A3dPOnF07dzofh62bC1n7E9ss5x9T18/hjosYU48hH4M X-Forefront-Antispam-Report: CIP:69.169.224.5;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-5.smtp-out.eu-central-1.amazonses.com;PTR:b224-5.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(32142699015)(9140799003)(376014)(48200799018)(61400799027)(5063699009)(56012099006)(4143699003)(261009223027099003)(22082099003)(18002099003)(10067099003)(55112099003)(16102099003)(4113699003)(5113699003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: cf0vMPuz2J6Qd3oFZ20r2h8dn766HR3DOiQKkQkjkG4gx56UKRNi0E9e1oI217kr1+lArA2tG2upSLCShFhwGVbjONUupTABtg8wszONxNJN3izhzc+wBQ9VgvAQDsQYFzeM4WbMnrwRuTx+Z5It51AlNmZWN078ZUW9ojB8gr+PVorUc8/A5r0WSR3kD4vkko5ol2KZ/KUGFr1UZkZIvk8crhI1pPvE2i7FQep/U2WZarlWbc4WP8yvjTdOPxnZFnaaeGyVVoCsj1imlBnGwzjv5P96+n/8Nufm4KgGxsTp3hjkjl8pTfDCaOqX8s6JpMzaXBbjw5fxQbYrrp3zfJU7UAvdLxwR4fR53gyyFOo1lNOEE3hsTJdxvHEIUCDbHaPWbGYoMJuawBpl8MfY9v+sq3ywYQvVD80WxPvD2VBg7VCrImf6Eo6pDncNs5Wo X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 15:39:38.8676 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 66d51282-1618-4b90-4f15-08df2b9bb066 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF0000056A.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB10897 > From: Fabiano Rosas >=20 > When setting a callback on a Glib source and giving it a data pointer, > it's natural to also provide the destructor for the data in question. >=20 > Since migrate_hup_add() already needs to clone the MigrationAddress > when setting the qmp_migrate_finish_cb callback, also pass the > qapi_free_MigrationAddress as the GDestroyNotify callback. >=20 > With this the address doesn't need to be freed at the callback body, > making the management of that memory slightly simpler. >=20 > andrey.drobyshev: > This commit was cherry-picked from the upstream commit 6a887119ce18, > adapted for the hci-dev base: qmp_migrate_finish_cb() here still > closes the cpr state and deletes the HUP source itself (upstream had > already moved that into migration_cleanup()), so only the explicit > qapi_free_MigrationAddress() call goes away from it. >=20 > Cc: Mark Kanda > Cc: Ben Chaney > Reviewed-by: Peter Xu > Reviewed-by: Prasad Pandit > Link: https://lore.kernel.org/qemu-devel/20260123141656.6765-23-farosas@s= use.de > Signed-off-by: Fabiano Rosas Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261016-vfio= _v1-v3-0-47487cb5a8e5@virtuozzo.com?part=3D15