From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazon11021083.outbound.protection.outlook.com [40.107.130.83]) by lore.virtuozzo.com (Postfix) with ESMTPS id 6EC908017D for ; Fri, 16 Oct 2026 15:55:13 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eCidPAUqZ7l2hjzVkl3IKWIa2caWV6PnTqd8ogCkQQE67ZGZQvq44AL3w834cqF6+QKp55TuBhqgvBOtzCPDtp8PpxoKfoj4MLe09V6xpvFXgi+xcc/tRIdOaPpd74MI6VSn3HhyDABWbpXYgW+s9BhPryvGG+XC0HOuscZpQf0io+z1TscMdxi4hTiPKXY2VSWomID1N9w0RcIyuAsrPXGv0QjMCmle3lcS76aWJYGjkdjsaXBMYitkVYg8y0KzJTYcBV82lXIz/D/AscM5K87HfPlmdMn6wIgrJZHtJJnj3pWvIbD/EaAiYKF1j6saUD+COPc27QKhr4YJfPR9NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6rPcF3bfnubkGpwm1tmgvvRrJyJGtsvZyg5Aa3S3g0o=; b=jpROPOiSbQR6obJM1AGgqlkMhmmJ9pAsiQLHKD69BOb6biC7wUDMQUfJvm0iyT60guzj3B5mt58zsJGrONNwlRVJzVd0//SQ7bbm6ztZUPdcwAQ9UzT7dYCxhpxt9LUrTPL47hPaJY5bzR2EteX53opyKbWJxtAmnpoidGUiQT96BDusnC/oTJBe71PLQEPYyb02G3+VEJRjvydBr2Aph5zR+dp3WtqtKxYVwLpGSJGD+M0KEbK3zoHTDOZzNgiZ/8DpT03J0ITm7aHoFJ+aVOM49lMwjo1nX/WNAo6aHQDgoyUgT0c6uFW871DzmzS+0K6nGAF3W9jmPyAKHWu7sQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.1) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6rPcF3bfnubkGpwm1tmgvvRrJyJGtsvZyg5Aa3S3g0o=; b=Iv6LJknKgign7ReVLdGmt6n2pJ7/JoleUrHn2eeHtPpSGBU/cYHG4ROel/BR38EEzjgTHaTB95pWwYync5DkaWlrsCJJkB5mYqP56/x+iWKJXyZRtso4TjD48pnYM9ZeERdFmaGkpJ5Zgn+PjueW35fObuxbF6LhVZnMU+B/7wY= Received: from AS4P191CA0007.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:5d5::7) by BR0PR08MB851968.eurprd08.prod.outlook.com (2603:10a6:2c8:4d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.11; Fri, 16 Oct 2026 15:55:10 +0000 Received: from CPH1EPF00000530.eurprd05.prod.outlook.com (2603:10a6:20b:5d5:cafe::47) by AS4P191CA0007.outlook.office365.com (2603:10a6:20b:5d5::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.472.20 via Frontend Transport; Fri, 16 Oct 2026 15:55:10 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.1) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.1 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.1; helo=b224-1.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-1.smtp-out.eu-central-1.amazonses.com (69.169.224.1) by CPH1EPF00000530.mail.protection.outlook.com (10.167.241.171) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.522.6 via Frontend Transport; Fri, 16 Oct 2026 15:55:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792166109; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=ziRjXM7qbKMtB38qItxhdTbvAQ0IaAET2ou0LN7WqJc=; b=qp9k4PrDTzT6dna6cZ7ZZjzwatkeNui+QC2MyzflFLu5tyyLGFjzCaLAg/6cE2YI GefPKvISWFo8a4IZgdAvuAKQLOX8bTfGtMQaF/bUdJYpN4N4ltXU42GaVEWrgdk8m4M aJWMdhq1gs2sIJPaIwaqonTwD+bKWMZQCG6FDj65IXV+cIUsN3bL+5ugz06twMMjeHe 92IIBST4ktA1IQ9QYguHcs9gxj7iIz1EfF+1EHmPXCisUVOUVgHigeReQHYzXMIQcre 4FtZPltBsti5xVslTT+ietU0QG08VYL/8F/JJr63gPqb5D55YGguY5ucGHzNWQWju3F 7VhyWjpSQQ== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792166109; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=ziRjXM7qbKMtB38qItxhdTbvAQ0IaAET2ou0LN7WqJc=; b=PAIPfndeL0CKiJ3IRNq5uCB7fQM4VonLTt50YsuQNdKaVjBG1dsVzcGyT9Pii5ZU 7CP++f+FOTVVwb0eBhRsVr4PFNbfqFYNHp4vEJplUGNA31wngc7m96+um4chpbWf184 F07tB34BpiapsUOuhMdYKElgFS6bpX4UHu5z6c6s= Message-ID: <010701a1456ca208-a75e4f2f-70c6-4415-8766-ff96e40e407d-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v3 24/28] VZ: migration/cpr-exec: abort cpr-exec if memory can't be preserved To: svt-core@virtuozzo.com, Andrey Drobyshev Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261016-vfio_v1-v3-24-47487cb5a8e5@virtuozzo.com> References: <20261016-vfio_v1-v3-0-47487cb5a8e5@virtuozzo.com> <20261016-vfio_v1-v3-24-47487cb5a8e5@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 16 Oct 2026 15:55:09 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.16-69.169.224.1 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CPH1EPF00000530:EE_|BR0PR08MB851968:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 8bc00565-fec0-4b2d-2797-08df2b9ddb8b X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|48200799018|9140799003|376014|32142699015|61400799027|5063699009|56012099006|4143699003|261009223027099003|10067099003|22082099003|18002099003|16102099003|4113699003|5113699003|55112099003; X-Microsoft-Antispam-Message-Info: KvoHa5313jOp/aVacNfUbb9xT/OBHeRAbP/D1hUIcPpdDDvnPQ7uQvoMNEzhUwQFkP0RJeAum231B7AImRHI8aWQJNuGXMTHlszlW45kRWpfKn/zS1D+j7k/8E38U2BYsco4MsCuDGthCPbdbSqGLlZaac0Z3WQ72alp6RnZFtlLY+rAARhEcI/p/5fgADMQns9MqZchFlItXF6pxZkxX/BELp2c15i/7nTod7KUMU8KBSamZUxGbNS43m5uwY4GB/UMFcu7ATaPzoK5ZPPgD+Px5wX8V1dbOhSxIypGcLa/zMo/U5ziQcQcw7T2lDJ7uSNihml+u9h8cbP0PMaQszoT5cX7CpSEQC/gfwr/0SnQXzkV1BvxNW4wbq62YYaFPc72mGZXOYtX1VNkbidyUZiUJLiUA+bsU91K0L25g+TLBWMHvpiSyzdc85qo4IK2uch8J0nQcalt9QU5/AJ/Y944O1AtOugtCClv1o/WKk5g6irrKkvOQjWG9khGu6upGPLQiI7qp6H95SCW9ri5/hgeOessdS7DjBto3mqbIGbiRxXpE9ejb71hod+WDtKIHcxLXpRn91U6qyv6sbz/vIl7SsVPhqFW3B4lZ0fteve7CN0QgZitdW1AuA4hSH7b2gTUPWQufhdGEIw3/F6920be3JA70ZzC83pRT5XzpeUT/jEdt2x9kPjQdJYLw9R1fvuFU/zDeTHTdcsapQ0Pnu7Pqlj8G33iv+S7sznuX95qJEp70ndyLotnFf03eE/tpwkmaaCk1FiNqprfRh2Wr2lRm5J2CyJmrZlsfb63+QadLQon0HBJsqI8nd2zPgH1UD0oia3t8vTBms5RqIGKfcUxjbpvkGING8WaWjoZij9DmYBIF4xlp76C4c8UaScFaPvma/i/r1CtHmh2ceYd2G7qeo3Kr/jLx1k8UOHHwp2lfOfGG+6MO22t2X/eJ0Mx X-Forefront-Antispam-Report: CIP:69.169.224.1;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-1.smtp-out.eu-central-1.amazonses.com;PTR:b224-1.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(48200799018)(9140799003)(376014)(32142699015)(61400799027)(5063699009)(56012099006)(4143699003)(261009223027099003)(10067099003)(22082099003)(18002099003)(16102099003)(4113699003)(5113699003)(55112099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: sns7NsPovi+TUOYG4DUarvdQOxYwNlPaxoILnj9pQa2bWXT9QWhwCqXg3pi2x9TayhZLC6pa8ckHA/WG1O4jKQoiZE+SdqXPYUrFF1GzWFVMlMtKBryY8s62YBn3KYRMazzVWQJoRdccAmGxIPFnrTwYsIQafmsKDrSeii6FZRjeTMuBJkw8d1TyRnRMXNpoycNoF52kdi6yFFTMaKOCxhLQG1An70Cy5ANMpvnxiwRzDLcqsIHOAgxolhIZ77Bem8pPOivGX1ESt97lqAY9V6comx4XWxvBEgZjBfu4PsL7l42qynVRoiIunUnloZgb9Y7aDx4jQya7tpltAIr6XJCAo3BfL9fCjEpWnY6mDvY1cnJ1U+vfY613S6aS4B/61U+tv0GLCregJINUynRdiQaJqjK5EH33QlBh8TKXbDrFAW8b/smUPh0GyIhdiCwz X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 15:55:10.1631 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8bc00565-fec0-4b2d-2797-08df2b9ddb8b X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: CPH1EPF00000530.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: BR0PR08MB851968 > cpr_exec_cb() marks all saved ramblocks with MADV_DOEXEC before exec, but > ignores the result. If madvise() fails for some block, the walk stops > there and the remaining blocks are not marked, yet execvp() still runs. > The new QEMU then reuses addresses of guest RAM that wasn't preserved, > and the guest is lost. >=20 > Treat that as a failed cpr-exec: go to the same failure path as when > execvp() fails, so the VM keeps running in the old QEMU. >=20 > On that path also clear MADV_DOEXEC from all saved ramblocks again, just > like the preserved fds get close-on-exec back. >=20 > Signed-off-by: Andrey Drobyshev Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261016-vfio= _v1-v3-0-47487cb5a8e5@virtuozzo.com?part=3D24