From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020093.outbound.protection.outlook.com [52.101.69.93]) by lore.virtuozzo.com (Postfix) with ESMTPS id 2546E8017D for ; Fri, 23 Oct 2026 17:00:31 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MKbcc22stGhjyv1M493BOzxBqgtRqdDQ3re5AIj54tP7eM3RmELCBjKpY+pB9wK38fWIV4zLHJ/bqhPIW2WpLeq/ftuvprqhTMqwNX8wbtV8GFH0F2cNpS6YbcUve76MqBWtBe2YuCByTLMfHjexpUlV+liW8uSuiZ3usA/UPVEUyph9GerCGMjOplLtYTFqJJcjYBVMbhuO1nvMrH3KxJwgkPElEpweGuOk2MSvSRomvswXNbAS66EdtMwmS3NPArxm1Adn+Ma2gTHL7NVsTjQerzbusCTdNM06RZbcwHkpvJBQXBkNI2M8L2JsTgSZ1HS/ua2pxsCvECXZE+aK0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XIGhe6w1pRbhAUascsf0AaU11x6XU6959MAGr89Nrys=; b=W9kliTZBePA8MC1/Iocyu4LZPXuQD5XgtApupEnfK+/O+49/uAptNmPgTaR5pIw3jCmFcjWwyQXOQC7+hHMT+oBiW+NRzuGtdciUo4S8zusoS/5tWnucyM6ctgMUcbcYqea5id4wK6/QC2yVafAnI5t0I9eJKUsrpi8ujhlmVdXGk7PsMX4OaGTcamKRf6Lppomscj5JgUrCkek8f4zwXISvHDcr+eQpJa9tfdblxi0fS/YkaXQnkALpbVhJpPoJ57D7CEKiP/n1a3KITxNnBHdQgHR2xQIAOtX2KWt3CERTNY1RgAI2j2bQryucj82YpvypHX6dIKNQ8fNRO1VggA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.2) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XIGhe6w1pRbhAUascsf0AaU11x6XU6959MAGr89Nrys=; b=Kfpn/kcxMaRnZAZ25vHVPcsCAJPdDRS6ZdCkzm0wqutbEyJ2qdIpT6adL0vXYZVG8D0sUVQ85FQdY/dZmJLaGDo40c4sIXJJpjaPkz3P4O7lYjwFu9dT0fCMM9/hCv/C+v6p8xCgHWcZf/55GdkNH/o97yb5H0JDVcQdex5VaGo= Received: from DU2PR04CA0188.eurprd04.prod.outlook.com (2603:10a6:10:28d::13) by MA9PR08MB515959.eurprd08.prod.outlook.com (2603:10a6:250:100::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.18; Fri, 23 Oct 2026 17:00:28 +0000 Received: from MAD0EPF000008B5.eurprd04.prod.outlook.com (2603:10a6:10:28d:cafe::5a) by DU2PR04CA0188.outlook.office365.com (2603:10a6:10:28d::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.19 via Frontend Transport; Fri, 23 Oct 2026 17:00:28 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.2) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.2 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.2; helo=b224-2.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-2.smtp-out.eu-central-1.amazonses.com (69.169.224.2) by MAD0EPF000008B5.mail.protection.outlook.com (10.167.241.137) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.4 via Frontend Transport; Fri, 23 Oct 2026 17:00:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792774827; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=JUkskdG7/9DdeZgqMIfilS2gwv/4BPZbQJfuo4UMSDM=; b=ZGrOCtHgkPufseUxM3ug4fMp/Mjm7iRjavB9OJMrubHIoczN/1Lu8QuI0K2UW1Ys mC0wraOHZ3rv/r9c715Z89mhgwgUgCfOOWKrgD1ohU1Y2ETPiRl/GjdRQR2K1naKYH6 lECU5DOoHB2Jp98p3jc2qmOmtG3KmjB84DpOhqEilZ4ILzl+gJgqzaIHICGGHVUFuc7 gKSnKze9GTOTDYKsoqhduw79h5gutZnfQ7iT4Y5gQiCxQUejgPQ46fkVtGFEfyhj8t6 pGG4YOFf6OKYJZZsaAt0nKEpKV6C+rc0Es9wT10qm/ND/TZ0VcooCku+QgfSS40zf1o bytw2UTUiw== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792774827; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=JUkskdG7/9DdeZgqMIfilS2gwv/4BPZbQJfuo4UMSDM=; b=GZ6wAR7YYgvdB4StxEC29yK7Y82p02UtoQp+eo+P9uH/cdd/ezegcSPco4bW4k42 J9A7/hCPmOJd6RmfT1fLCeOoyEk4phwzpec020gTEceEiAbU1CZ5swjCztbsRcchqQ2 hAWCzEXxqLMhqvPt01eK5gKKX6tI6AT9W88rbMOs= Message-ID: <010701a169b4ecb8-7595e72f-1cc8-4dd6-8512-c0b9a8ef132d-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v5 04/36] migration/cpr-exec: require a file or exec migration URI To: svt-core@virtuozzo.com, Andrey Drobyshev In-Reply-To: <20261023-vfio_v1-v5-4-ba0bf3c6d122@virtuozzo.com> References: <20261023-vfio_v1-v5-0-ba0bf3c6d122@virtuozzo.com> <20261023-vfio_v1-v5-4-ba0bf3c6d122@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 23 Oct 2026 17:00:27 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.23-69.169.224.2 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MAD0EPF000008B5:EE_|MA9PR08MB515959:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 13e27599-fc16-4829-4a05-08df31272372 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|48200799018|9140799003|61400799027|32142699015|4143699003|5023799004|56012099006|5063699009|261021121427099003|261022105027099003|261009223027099003|10067099003|16102099003|22082099003|18002099003|55112099003|5113699003|4113699003|13003099007; X-Microsoft-Antispam-Message-Info: dBualp94h8flhfQSyEfgHcQMVWv2z5JxZOlClfRdxEkxbV9MnhxAR89v0H5nQmkF5N42pi3+/5jk/HVwzVpAGjHDBSJyNS3ZN0zpdN9KQ3+2t6JuakhOBU7PcOoShvsudcjmIgcihLCLac53et7TgpGHhinxQl9I3tWyLAXlJvz5wpspxNbY9z3yGJh+Q/Nh43Ft/SJoxgZlvVPJZMZnfhnit/QrMMhix5BBwO+8wdO6Q2KLZkYjPrTDwGaVaBMIFuSeche982+x7K/B/V4bU+dXAxYcbYO3egEbvj97Ccu/A0zIo+KtR3BV3/335SWodVXm4cJoew3lXWvna6zU+2Uswk5MMkffrxLi3U1Xh0AGs8ai4zG36qWvXDPJun7pG6MJY9PKQ/QaG343E90zU8zLsvQ4eN35Q6X9ntrDL7LvvtOFxP9GCAN9FLALBkS43jMRV7asXiRAE3ob9NnCp7xu1pZxkH4T3/yhqPSLLMAwLkBRDYz2QTzok+z1o9rir0Lb+hivEQvwK+bYPgGINn7nnwqj/Pn/bQelDLH4yTyT39ZkwEDLh+Y2aIKPWG/PSzoE7TfVJYRajVCdf7CH3cuBARrYCZYonLUiuf/oNg0vLRSeeQHMKVZiYgLl+znM2KT5hkcZcWtr7p889o3FpqMQ4nOjs41a1oy32nrjt9spv1F0rYIgiMgWdwxfb0QCTIQ+Cv4FUt3MgJLQwqxjQEqNWEGJA/5CPlRJimSAmd5HzOmaMO1mMEsGcUCMmb6oFw2VGxzw7rcTr/aizrOGikFEH0quZjz9sQ4pJbA8BscYQpDef7uEqdecGGevmG8M8mAo262mXvk+LL3w/FBKeC8Y8UUUrnwbT6KmZ7JQCRoaT93NBqm9Ohz0FNIZkRtvIsZ/rZmRF+0/gEUa1blNXS2LG9hN1/Qa+Ie9NtPfdYQ= X-Forefront-Antispam-Report: CIP:69.169.224.2;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-2.smtp-out.eu-central-1.amazonses.com;PTR:b224-2.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(376014)(48200799018)(9140799003)(61400799027)(32142699015)(4143699003)(5023799004)(56012099006)(5063699009)(261021121427099003)(261022105027099003)(261009223027099003)(10067099003)(16102099003)(22082099003)(18002099003)(55112099003)(5113699003)(4113699003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: j+45xro9LSfcoXK4l9PB/weLJyozS6LACxEa0kbIGzQuEYlXqf3kvrDKniqe6vy6LriE2bv6hjOBUYWRpGehAdlTKOBMmoqKx/q1AIZYZ3E34tT2+AzXXf38YMGYwxfnLPo0f5weOVY+vRJboZb/rkmKxvSAaPZWnPh/p8/Q2yfDDizYmqZUsrLE6rDINhOPKosUp26Lhy9v3FH00h6zYwTd5a+lKxCrx3K79pBeqNvkI1Gi0YmFNTMhkmTR09d7tSaPC+PpXhCnqAJis66bajk3nODHVYcm7PF+xrsDuYRq2JW/DofEQ7CV64g+flQPDZtxefpoliYG4xhiWmWRXqbU37oz1V6oPi2Qu8lPnzkmE49R1M2OkOS8WV9CCIfbx20xL3Tj6nB1WD4Xt/IzKnXHhNwioBMuNRjaBjMHWAbnkyrODuEqbjI9wtAaZsmT X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2026 17:00:27.7114 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 13e27599-fc16-4829-4a05-08df31272372 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: MAD0EPF000008B5.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: MA9PR08MB515959 > cpr-exec writes the device state to the migration URI and new QEMU > reads it back after the exec, so the URI must capture the data: a > file, or an exec command that stores it. Nothing checks that. With a > socket URI, e.g. a save or a live migration issued while the 'mode' > parameter is left at cpr-exec after a failed qemu-update, QEMU sends a > stream without the guest RAM to the peer, execs the stale cpr-exec > command, and the VM is lost. >=20 > Refuse cpr-exec with anything but a file or exec URI, the two types > the CPR documentation allows. >=20 > Fixes: a3eae205c601 ("migration: cpr-exec mode") > Signed-off-by: Andrey Drobyshev Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261023-vfio= _v1-v5-0-ba0bf3c6d122@virtuozzo.com?part=3D4