From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a169b627f4-33bda172-cc29-4af8-945f-b4552d882996-000000@eu-central-1.amazonses.com> Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11022117.outbound.protection.outlook.com [52.101.66.117]) by lore.virtuozzo.com (Postfix) with ESMTPS id 5C72280474 for ; Fri, 23 Oct 2026 17:01:53 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IgYAgLp+QWO2SHDhmnA6rLULGKez9FyNubXyQbnZdMYYBSLqgi1v8nzGn2fkP184gl+rPzuhME7LIaEkYANDMoBg7zG6b2JCaED+fVarkeXCby0vkqnkmbmOXtkgK7qVhVILZvEEJJVVqWU/e1lSluIDhAVT0WCpS4W6l7C3eZZ/9C//lMHalAQ8aNddh9t5i7R7dFgoz6GUQKPE297C/fOgfhv0n9UTO5zRfQv3n6EPendphkcWge6vLvL/SNVYxpUXg5gv74IyrAnZR49ISzuuAezsj9c60HE2hWq0DHQ8DxeHxLLG1aC0WTBWLuEozV31jW1lxzmx7V5+oDEBoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5GwqmrzsLb4D1OVQdvhvFXz6NA7Lr4aq8rWuaAZJy4E=; b=PDNUJdayQljrRkEVES7+Na3w2xt6sKk4A79vmmyGT1S0Dc/SDQgxYC9klfPqGua/xrZVTLo2+q615UGZ7UtWaKhG8WJyUELpeRTgo+eXuBfyIJ5X0go9fAEGtLNfXwCbiX4Ckqk1ge7X87ODAiYSNLTwyCJeNGNB9ZbltRoaD6OQydrUJAe5eH4laB1B2q7ebmHPQCNfeXzVDsoZhxjG1YEVEk/eLGhxtPYE6wyTn6ZpI9IWnvTIjlgD7oLElmjti8Mym3RruCyfpWfjJ8wHMeTUIRHOjWjG5Mp6r1Y24iCK8sgU4lqLDuC8grA/LVpAekNszzqF0P2FgTWC23fz0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.2) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5GwqmrzsLb4D1OVQdvhvFXz6NA7Lr4aq8rWuaAZJy4E=; b=lPuQeghwtxwYOrCxuH0b6dSZM+O2eQYTu3sCmOuafbFfC6+lTgwXGwnPDnc8D9VsiPPbP6GPYFCfvqWVpKQN7FvldUZ7+e+FdTZqDAAYYbaER9eVf9SnRdw2hJAxdmzawTVtWaeWb7sYsWW90oizWzOQY6n66O/nylfSHZNF+yo= Received: from DUZP191CA0037.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:4f8::9) by AM0PR08MB5490.eurprd08.prod.outlook.com (2603:10a6:208:184::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.19; Fri, 23 Oct 2026 17:01:48 +0000 Received: from DU6PEPF0000A7DF.eurprd02.prod.outlook.com (2603:10a6:10:4f8:cafe::8d) by DUZP191CA0037.outlook.office365.com (2603:10a6:10:4f8::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.19 via Frontend Transport; Fri, 23 Oct 2026 17:01:48 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.2) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.2 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.2; helo=b224-2.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-2.smtp-out.eu-central-1.amazonses.com (69.169.224.2) by DU6PEPF0000A7DF.mail.protection.outlook.com (10.167.8.36) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.4 via Frontend Transport; Fri, 23 Oct 2026 17:01:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792774908; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=n1nb50GSqqxkgHeDdhQU8o47V+f79kP6o+UaX5ZLoDw=; b=G6/5Bp6WO8woqG6PCODV6Aoo2pRs/T/aXWqBqi+OQf/buKkMaHgD0d7IBhNI+F+j wR7PYt3v6GtSo81JdzzDSweaLNjtXtZq48GagY0CyOefyu37bCGOKdLfu8V+1oZzXyC Gyme2fOHQSdtDXfZKch/WBrv9n6VSxqZ51iPCt3/pgRnjDtJ94IirrSkYBy+7W1tkIN LSjQeFhi55XnAiVEtq97nd1k+peMxhIWFBFjfO6dxSmGpimw7CHoFhh5Iri5Fw0LNuO K9qrch0pKeN4WgMQnn308UR3V9kc4gC7z+rzdwgiMQyMV1NnTBicGhtrZae2bcakMve w6SI7cZIGQ== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792774908; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=n1nb50GSqqxkgHeDdhQU8o47V+f79kP6o+UaX5ZLoDw=; b=elz+Q2TvPuoUhTbtwJ0tskq/MH4dK9rd8GQEGQki8zjTkzdY9rS8e8XD7QD3UJXM 8VQReqiG1p63NQEZwvTocVo2ps4k23eUH15/AXO9lNfd2dLuLEsXp7+STJrc2QMr4b6 5hGVVgcFr7USXtgu2+3/IjEN4K++jmdwz1gQRGQY= Message-ID: <010701a169b627f4-33bda172-cc29-4af8-945f-b4552d882996-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v5 05/36] migration: close the CPR state if the outgoing channel fails to open To: svt-core@virtuozzo.com, Andrey Drobyshev In-Reply-To: <20261023-vfio_v1-v5-5-ba0bf3c6d122@virtuozzo.com> References: <20261023-vfio_v1-v5-0-ba0bf3c6d122@virtuozzo.com> <20261023-vfio_v1-v5-5-ba0bf3c6d122@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 23 Oct 2026 17:01:47 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.23-69.169.224.2 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU6PEPF0000A7DF:EE_|AM0PR08MB5490:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: eee81790-a195-4f13-0717-08df3127538b X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|32142699015|61400799027|9140799003|48200799018|376014|4143699003|56012099006|5063699009|261022105027099003|261009223027099003|10067099003|16102099003|22082099003|18002099003|55112099003|5113699003|4113699003|13003099007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZS9JVmlaR09LazZIcEY3am51TVYycjhxeWNzL0pJb1pYZFE4UGJFSEdVV0Zr?= =?utf-8?B?U3Q4elFFTUpMc1FwV2xiLzJkVG9JMGdKR2pHMWZYdk5NZnhsQVo0NWViL0JL?= =?utf-8?B?dFB6SDM3bkdmQ2lQSXZoMGd2UmlIOG9JTVlydTF1bDhhd2xtbkZpK2dTcEdE?= =?utf-8?B?WDRjaFBNUFJwSm9ETUthak9JSnI3MldXKzl3b2ltSTZTRStabUdoWkV6R0x4?= =?utf-8?B?RGZkdDg4WkMrR3JsaDJ0YUdUbkdxa09NTmZmRGRrUElIZzhBZitrMmRNQjRV?= =?utf-8?B?MlJZbW1odXdwVEw4ak1hSVNJQllmY2tLMlF5Y0hiQnJVU2YxOTllRSt4Z3d0?= =?utf-8?B?VjhjYXVnUUhxUnFoTjlWbUtNRW5DaFVEWE5NblhkMVNhdTFhUVQydzNJUDFj?= =?utf-8?B?YW9TaHdXQ0VlV3grb2hYOWxQRHE4aHZKcjUvNmVyeUJwUnhhRGU2NHlmYi8z?= =?utf-8?B?a1RoSVlZVStRbmI1c1JKT3lLaTV5RDM3Ui84dU1xMWI3d0lXTmdTSDlkWWVu?= =?utf-8?B?ZG5jYXhsTTFhRklJa1lHcFgwY2l0Qys4SDlrSUZpdmp3RnQ0M2FpbmFRM0cy?= =?utf-8?B?bmNIQjgrcTFGVGtpM1VGaDh4Z0NPUG15M2trTm9xWVZoYzZVUEhMQzNpeFFk?= =?utf-8?B?OHFhUjY4ejFoOWpOKzdOYXh0dnU3TU1YSlpqRW1NTGh0eGdYaFlGNlM0SHNn?= =?utf-8?B?YzloVlRvcUFKMG5vT3U4SFgzdk40RjVJeHZwbnhjQm5Nc3dha2d2T2R4NCto?= =?utf-8?B?TjlURDZsMzJWR3BTUzlmMjB2SVJJaCtJTWUyOU9IZlRGQnZQejRjY3E5UGF5?= =?utf-8?B?K3FBank0TmR6L08vckM0ZUVXanZZN0hURDRMamZkV051TUs0NTZ0TzNXRzZi?= =?utf-8?B?TC9xR1BFWE81cFgvUUsyL3FyY3Zhb0EzQ3pReWEwcUN3SlJ4bVJPUVQrQU1q?= =?utf-8?B?aFhiRzBzM3k3ZFFiai8rWm02MjVKdFZaWTlXVE9jR3ZNeCtVNEZCZGF4T2JD?= =?utf-8?B?U1pXdzVGa2FLMDlPRk9kb2tmRWZ1NVo4VlJqNURmVlhhc3R5eGVVU0p1QU5R?= =?utf-8?B?aTBWUitvRldreXJCa1FqOUhRaTllMVVRa1VVWFhrRWV1VXlVT2tmblMxbXNC?= =?utf-8?B?OXZ6Q092bmhJWVlucVdNTGRweFlOKzhXWGZibWl2V0RqMmtFTmc5WTI2T3ll?= =?utf-8?B?OWloQ1g2R1NKU1pnNWZLUEtmc3NjakptUFNWcytqRHY5cXJ1WHRNNE54eHd0?= =?utf-8?B?cGdwS29KdXZJRmlVREdXUU5RaUdFakw1N3I3bjZMUWdRdUttaElobk5IblV4?= =?utf-8?Q?JEjmMrKR54EZ8=3D?= X-Forefront-Antispam-Report: CIP:69.169.224.2;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-2.smtp-out.eu-central-1.amazonses.com;PTR:b224-2.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(32142699015)(61400799027)(9140799003)(48200799018)(376014)(4143699003)(56012099006)(5063699009)(261022105027099003)(261009223027099003)(10067099003)(16102099003)(22082099003)(18002099003)(55112099003)(5113699003)(4113699003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: O74+yabfPpPpLe7Tp37YM5LIroN/Z7FLEMIJbQhspO7CBz6g4O83ZFZNDfwO8nK/5tNLowMmhBLw6Ihd/HTfRl+tWe7g+Dik3Qwwi6lDdrCibs4U045+niPFp/AJ7d6mV0xBGMczKmu4deAAf840jXH1Iz1aV8zsIcde09RxxHAajgwK6Ry28aDNJK7MGtJekPMs71qBXAmYq52Pp6U/sGob3cqNGtBOyqvDzkwa0b2Ea/FrXCt81Mm3qbl8Z7acAVQrXnTEmnQHYj54nRQ0seDxL5Nrd3vfRmlrYslM5GJLobYuLrdt5lK4EtiSESlX6jNOcGdsXSQInPkNqsPuWvi7Al+R+1S26nNpkhkAr1Ou8Uey0iGUO2TINjTqo2SeasjKtOzMx6JwSYzqUzwq+ISyxf+Mr7DiJuxVPSAuo0XfQupW0ScdOQwsC1LLJBYk X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2026 17:01:48.4119 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eee81790-a195-4f13-0717-08df3127538b X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: DU6PEPF0000A7DF.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5490 > qmp_migrate() saves the CPR state before it opens the migration > channel. If the channel is a file or an exec command and it can't be > opened, qmp_migrate_finish() returns right away and migration_cleanup() > never runs, so the CPR state file stays open. >=20 > Close it there, next to the yank instance, which has the same problem. >=20 > Fixes: 624e6e654e11 ("migration: cpr-transfer mode") > Signed-off-by: Andrey Drobyshev Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261023-vfio= _v1-v5-0-ba0bf3c6d122@virtuozzo.com?part=3D5