From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazon11021106.outbound.protection.outlook.com [40.107.130.106]) by lore.virtuozzo.com (Postfix) with ESMTPS id D13F88045D for ; Fri, 23 Oct 2026 17:02:06 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gTNYW2/IQtDaKsVFG93mqr+7p8RZw342hbjq5TpEnsqeBnEsJgd/Au3FTjTiVy0+Nnq3vbKM8zlIA/Jp6//l/FP3ZZ9pUx/EAeOVJK4ayHpL/SmEyxgCDrvutQykmmOJ/+lvrtXx2qFwZ/Fb6BN2YpB5e9mccyFU6o2BsUS4wldleBDzkjhVOHXwGi6oyCgSVmEISrEtr2QnVFnzFSXwsSYf0LB4rTEHfmSebbXRmR5QdPw1VaA8AhOo9AwMF7jnyx3K9VLGJ7qJLZIOw90o1bWyYEWDBvRRQXrtsyhVPDL5bJtzZKev/EGwWAqPjQIHgAdAzoEBPxwkWaMcvGdTeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fxFVkMEZW6qFqxKOSsciycAEzFRDDOtMwny9vrJUTPw=; b=T02UybVMYvQLE0qmanXRo6HwTzCDNWit7L9JH9hJiOcSLhLrQNbqbe1fKf9pazd64NMmQRuQsKEi/PQc7tMXz+ebYvcBU59qGLOylxIcYhcN+7vMyDuzzNoqe0P1sT6Yxmu4q7rlDrjUuwTHS6XQ0VoIWfWWxG9sZ735ixngpVlmqCvjwg4Wu0LsavDdVZgjwdFF3CqmvOYQ6KzMF1ms9KYVuGcHlXbva9ucBPUyFLc97J4QpfEi5/wPm6/eFr6WTlEF7SEerkaSCMH2KKa9B3domOBjtML9kLPLx71arZDmxvC3TOW7pEyQ88gq3/CsCwMgoNN59R3U5lvbnTCIFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.1) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fxFVkMEZW6qFqxKOSsciycAEzFRDDOtMwny9vrJUTPw=; b=ekOR9Rp0rB2V8JA8z8khYLKR3D6ObrEsSqREoweu/zh1FPWtxEwMvh9xx37tvxUSMGgpihrlyyoZUJBPiehFiqdlJv/wgVDIX2+p9raECyiKUie2Ut6g6sEB/RnZXrBVXU/rrE6Cpw/nT8A9gBA1yIfEqhyAvNFgO6/q7/i5y4A= Received: from DB9PR05CA0006.eurprd05.prod.outlook.com (2603:10a6:10:1da::11) by GVXPR08MB10812.eurprd08.prod.outlook.com (2603:10a6:150:153::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.15; Fri, 23 Oct 2026 17:02:00 +0000 Received: from DB1PEPF000509E4.eurprd03.prod.outlook.com (2603:10a6:10:1da:cafe::56) by DB9PR05CA0006.outlook.office365.com (2603:10a6:10:1da::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.19 via Frontend Transport; Fri, 23 Oct 2026 17:01:59 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.1) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.1 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.1; helo=b224-1.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-1.smtp-out.eu-central-1.amazonses.com (69.169.224.1) by DB1PEPF000509E4.mail.protection.outlook.com (10.167.242.54) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.4 via Frontend Transport; Fri, 23 Oct 2026 17:01:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792774918; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=7wbtJsHeit/4ZNYJtnOpcOtgbghQlSYseoJk1uJWy+4=; b=T/kkNWyZB/JevtOKpcSQjBzhMW2pTe96hMsoqkktSSuJ3mIAEk5CxVD03J39/oPN W543+rDHdHrjqlQzTY/xcHd+11zA1AtIRnP+AIETxNHgPqxuOxLe7fQlWamStJwuF+w XG/LV29NtVQ5W4wyTOuhjv5xDzTsyHmfDEKVkBfVMU3VSzTUnKKvOJfDbpL3Oenoxu8 ICqZJaepkwe8HddaONfA8kqRRwazRx3/nqDN7fcTgZzMFacASdt61KhWQ//W36qnJWu GaBAHC+mpd5K2ieAAHja8L1TcydxsMGoQBBWwITpkLOEsNTF/pEJsAfPtfMtTdmAKvm sxs1MD78tQ== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792774918; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=7wbtJsHeit/4ZNYJtnOpcOtgbghQlSYseoJk1uJWy+4=; b=kpGlErJANezFinqQSX7f/qKyGVmoMUr3x3nfSvvwHAe0jcojICqGPwCOK5NZLX51 WgVNFuQD4QT744wFPhFudMXU7OPCM+ili+mYpVfmclzJ60rp2rOiM046z6fmyqNsAF+ RKDf7WenDug942t5IvSOrFe+njzqvEEkfxUS+HRE= Message-ID: <010701a169b651ce-14e7ecce-557c-461a-b78d-cc46bb642ec0-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v5 06/36] migration/cpr-exec: close the persisted state if the channel fails to open To: svt-core@virtuozzo.com, Andrey Drobyshev In-Reply-To: <20261023-vfio_v1-v5-6-ba0bf3c6d122@virtuozzo.com> References: <20261023-vfio_v1-v5-0-ba0bf3c6d122@virtuozzo.com> <20261023-vfio_v1-v5-6-ba0bf3c6d122@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 23 Oct 2026 17:01:58 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.23-69.169.224.1 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB1PEPF000509E4:EE_|GVXPR08MB10812:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 279d651e-11ee-4639-7f2b-08df31275a2b X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|48200799018|9140799003|376014|61400799027|32142699015|261021121427099003|55112099003|4113699003|5113699003|18002099003|22082099003|10067099003|16102099003|13003099007|5023799004|261009223027099003|4143699003|261022105027099003|56012099006|261022075727099003|5063699009; X-Microsoft-Antispam-Message-Info: NskNgEd3XIsh9PrUvPxeUEy3rKP0HFS9QQEoqm/NDc4PbnCJHwcwzcm8Od+UlceipgCbWnJNQHOh4tsHkQwWe5m0mx1jts+jLSZcI19SzJd0tnwdozMnXvCN6pNEx+BNm8+hdU5wz3g16SUATMSMMLyRb+H3URKGsyGM9C8nJuwDVI6W7FvHg/AjO1+rLFNmvBN63oUYZaO2DbiPOV/T/8R6Jrq6Wqsh3C+DIPNRASfgnBk1g3hfmVgzpWDa3KdMmhJuw4sX3OJHGm1za8RmvfmWqJw4D1FoESvxmM/P2D7YJyBe8OrYVvowX/ZFtfZcWvw4/IJp+NxrwgYW7agxogGUQzoq8ZwHd7VEYlT2iCz29ACOZGeJUBAKe5n5+rZKac7HAZvG5BsBfUtG7Aiql90bStKr2xMV4Shca2rCNGMDvsOO45wT0gsVztpsTiPQ/sxlZkGzwtifS6McwGiUSMF2LnJ0XSDnBbGpHfbAIB/4Ofz51pR0kDDmVhnuYY16tXvw8z780dJtzlRggc9Aq0c2nwfPZKahhtne18woDpbvopd007Pq77BLrgjpEp6Dp8oSCzCyQlAbpez3ZIlSCd1kfC5xmmKE/gBxqM6e2t19VUON+5IVPKnFHKe9aawLzUDQiNSX1Q0DaFVP61rQaVNjJCuLm2kLG6aMpneU962YvGGSxhM9a4RltLcJEjJa+jOcpgRYxSSHxCc6lg7Xi5Fvdxh/8xUS+YTJOFq/f22rCGO94gTMcw27HaxH0/p64MtXLKVZQDzuQPKFtpW9BmbI//qMQx8BeSOcerYz/oXxXJoHji/AWEwvEt8t1/NbERygtynWRMkitXFGeP4Bt5TyXOo/wBvFhx6jceZ+1IDX8JE2Fmh00Pqj0beS7Bbl1pvUXzvT3lWdR9Vor3lAzg== X-Forefront-Antispam-Report: CIP:69.169.224.1;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-1.smtp-out.eu-central-1.amazonses.com;PTR:b224-1.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(48200799018)(9140799003)(376014)(61400799027)(32142699015)(261021121427099003)(55112099003)(4113699003)(5113699003)(18002099003)(22082099003)(10067099003)(16102099003)(13003099007)(5023799004)(261009223027099003)(4143699003)(261022105027099003)(56012099006)(261022075727099003)(5063699009);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: iGBlTvLqwKyWEeOQy+OH1NU1F6fDcpKboPxOjFKgfgBseqVAoaAQWxWwFk8SLA8j3ksOlZeHrYbcQmRgtzCA7I5PbDRrETpwk7i9jQWhF3pA2kxactoxw/nKUsj91Jzb9XKZW7QEntf+Qos8BG7bzzQWZeKMOChmw+SlV3Z5BBUqWJH6CFf83VGCE9734+Tp+O8q6ufvPbufQReJ1dXht+bPl3D0/PW/vhK6YayGYNlMBaOnqZuHg/LrZI9Y/lL67vElaCkNj210FfcmYZzo/Fqpl1NvDfN5DriXcgWzq0Dr53h2y2GvYaQ5OxNPys3mri8fUIAHTd4OpGiqEi6WjVsPQAuccrRr/7omjlnUoHH2AdM0tXQFv+nR3c+/rYdr3BfmcrYRCTXCUvmB6CvTY14gj/SEOXa3NwoPCVo7/qkCr36spY4kcwUSZMV1QFLy X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2026 17:01:59.4875 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 279d651e-11ee-4639-7f2b-08df31275a2b X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF000509E4.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB10812 > cpr_exec_persist_state() dups the memfd holding the CPR state so that > the dup survives exec(), and remembers it in the environment. Both > are released by cpr_exec_unpersist_state() alone, which runs only on > MIG_EVENT_PRECOPY_FAILED. The migration channel failing to open > doesn't raise it, so the dup is leaked and the stale environment > variable is left behind, once per attempt. >=20 > Release them there, next to the CPR state. That path runs in any > migration mode, so make cpr_exec_unpersist_state() a no-op if there's > nothing to release. >=20 > Fixes: a3eae205c60 ("migration: cpr-exec mode") > Signed-off-by: Andrey Drobyshev Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261023-vfio= _v1-v5-0-ba0bf3c6d122@virtuozzo.com?part=3D6