From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11021123.outbound.protection.outlook.com [52.101.70.123]) by lore.virtuozzo.com (Postfix) with ESMTPS id 29C0C8017D for ; Fri, 23 Oct 2026 17:04:40 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YxHMGrvej57lEQXHO9COf7Wxuu4AggeAKVR2/8KYea0BYEToLaA4UDocGC+WCAwvtgt2QxWV9D4f4Q14SX9JKvEvtAEE5BrOS9eMlvkiQq3PQX2vZvkOsJhV9Ms76NjAPkIg8Bh/qtgkVWuSaFmFlwRk2vxQ6vEOUMNAVhZIf7uWChgx68zaY+VXGSDOFES4yp4sK485ivqBNSVoEvfReaKjRHok8xKTtk/66H6KN/TaA86d9Q8eiIXMkKTPqabj4aI0Z7utHaEBIkTsaZ0HzLE0oc4bFlrjyK9ygRdy59lDJ9U+RIiTf9C9vYCtf/B+lf/n6lNTU2kGgQAOxR4Zkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w5J+Pw3N7LtVPTZEjfNf+OWP0cVCeT6s+VEqB/b2vLI=; b=dG4aTKmgV7a6UEQwa+VOKE4d/EeL277NAkAabvO8Xj6+DiMyASO7nRnSdaLvKMztOwj5/yJlR7qe7ur8KIoc//LYtCP+D7yxr6avS7DOO9asbvqWTC15ZaBWsbPoEiuAAdWUvAopCH2fvC6qN8MKxnPf4SoLZGi1bAhDgn5dqnmXcJY9IBpwNfdvcWxEqXg4gRjdJmHGwsZUtVSqBszectPfsNLpeG3+IZ0UCG7hypAGqlr5w8W8pxaQgpyW6u7UB3n/yMWDpn7u4IS/fZj/7KbdZTVbsmW4L+qeBehiFCkqN0HFHCiLxpyow0tdxdKm85oF/M3GxqLOX31hgL/ZcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.6) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w5J+Pw3N7LtVPTZEjfNf+OWP0cVCeT6s+VEqB/b2vLI=; b=arXAyrMXRyAbWWpKWheyGs/6UlYn85oL+RxCD7KuvSs2Wu51Ilwj5dQBEmoydlDxuASTn1FjLVMU9b9wt27lEcSc7+jNaKI0e3K00IWxEHZ0keoevLLVY8qvZI2WDsNdDGXd+/29duq1N8yX+yLIGc88RCrJN1xmc86+HeheEk4= Received: from AS4P192CA0006.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:5da::7) by PA6PR08MB10830.eurprd08.prod.outlook.com (2603:10a6:102:3d3::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.19; Fri, 23 Oct 2026 17:04:32 +0000 Received: from AM1PEPF000C1AD9.eurprd02.prod.outlook.com (2603:10a6:20b:5da:cafe::31) by AS4P192CA0006.outlook.office365.com (2603:10a6:20b:5da::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.19 via Frontend Transport; Fri, 23 Oct 2026 17:04:32 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.6) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.6 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.6; helo=b224-6.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-6.smtp-out.eu-central-1.amazonses.com (69.169.224.6) by AM1PEPF000C1AD9.mail.protection.outlook.com (10.167.242.104) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.15 via Frontend Transport; Fri, 23 Oct 2026 17:04:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792775072; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=5RXYieeRYszYc8eBzSaA/NH2/l/aVWvaYlpJL38EL7w=; b=JdfJmM/vSKqqliXnFMJrAlR67dnc6NNGBd7yQJfSpnC/9GyK39DRRTyZ2zP6LNkT 9Z96oVkGCraIULkjIl16EbqRPVbZ/XXSoctsxj5tUDFMSC8RK7Z5EI2v7n5CaCv9avR ZQwTSorlDX4i9SxwjBzRyGo4aMmzu2A7c5GnEDf+JQYDPKnp+rEZ7IHNTQpWZjOuT9X 3knXA0a2rSnn/7ef9TBacV/RC4Ze88CNoHIcQxgUqLQxkFUV3Qi4aNJ26kYlVupAL6V L/selBpqO1RCfsTAP3ciuD8SDWIU/RNUdXd7/8pxIZxcehK4RW1W87GN44JjlILzbM9 EhOcu0bSrw== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792775072; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=5RXYieeRYszYc8eBzSaA/NH2/l/aVWvaYlpJL38EL7w=; b=NX2SAGXi69707AlvMESxyLgEcrOfUAM4E3Nx83i7OSVdr1d19jTRduxNez6iVCAB +TqJeUdKmgGlpgZvZCPO+Z2TYspRPzOreMRb33cfT0+k9TpElStwjwUIYEvtYxYXPkP L3M+gsJliuO5QTmYTi8s1YIT/TSqowEXCjf1sX2E= Message-ID: <010701a169b8a963-34523792-7a04-4df2-9b2f-c0054dd338e0-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v5 11/36] vfio/pci: Fix information leak in vfio_rom_read() To: svt-core@virtuozzo.com, Andrey Drobyshev In-Reply-To: <20261023-vfio_v1-v5-11-ba0bf3c6d122@virtuozzo.com> References: <20261023-vfio_v1-v5-0-ba0bf3c6d122@virtuozzo.com> <20261023-vfio_v1-v5-11-ba0bf3c6d122@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 23 Oct 2026 17:04:32 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.23-69.169.224.6 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM1PEPF000C1AD9:EE_|PA6PR08MB10830:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: c543e8e4-9b1d-43ab-b9bf-08df3127b557 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|704160211799003|376014|48200799018|61400799027|9140799003|32142699015|55112099003|6133799003|5113699003|4113699003|10067099003|22082099003|16102099003|18002099003|13003099007|56012099006|5063699009|4143699003|261009223027099003|261022105027099003|261021121427099003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Rnh6N1U3ckxEV25oQmtZTE9ERm4yOTVVWkpJT1NweUYvNzk4QU4xWDhXalhr?= =?utf-8?B?OW40UktFb3Y5NWNTR2JxTnNrN1I5cnFORVc3U0hqUkYyNndUMXFNN1ZBOElD?= =?utf-8?B?SHVhRXVsZE1TaFprMU15SGRtU2FZNitnN3Vzc2NuaHNmV3JicWJBUjdTYVpW?= =?utf-8?B?aXNMLzlTWEg5RnVVWG9qSUlGaU5reENKWlZPUUJtQ0x1TkpiLzMzUW5UNXAz?= =?utf-8?B?VG9MMjZIMkNWbnRXYWN1YXBqb1JBS2QzSy8rWm1ZbWxSd0c2emJ3VzBTRWhZ?= =?utf-8?B?bXNKZTBHbm5jSkd2dGlVYVVWelFHOEFVdXYzU0IzQjJCNFRqaFR6M2lzV0Jx?= =?utf-8?B?OFhFaGpjclJFN0NHeFRVZkZPUjUrWXdHak9wWmhpaHpPZUZhWmYrK01GKzgx?= =?utf-8?B?eEF5M2ovdFJPWkpJeHlUWE9GMmdueXZzblExZTVVMmxFOEgwSkVhRXBGaUFD?= =?utf-8?B?eS9pTHNDYjFyVm9XNi9CUEg5TGVYVEI2bi9jdzV1QUloLytXUlR1RzR3U3Rm?= =?utf-8?B?MHNXYUNQd1YrVS9uR0FQbS9tZzNsVW1pb1ZBYiszUXZVZHhoU2tSUUZoblVT?= =?utf-8?B?YngwaUtJUUFVWER2d3E3R05IR05GODNjQ0hVOENhOS9HTkl4OHFDSGd6c2FQ?= =?utf-8?B?R0RDUDFpK0Q0Ty9LcjI2ajUxZHlFZzlVY0dJeWwxeFIyNFZZTmdoUjEzMm5r?= =?utf-8?B?YlRIb3h5SmtIUy9OT0ZTVUdWdmRBM1d2cGJCbEpiS2didnZDL0xWWFAxWWNj?= =?utf-8?B?TGpTckQzdFVwejNrZFZuUkswNDRLZWZxSHljdTdFZkdtVG5JWEJUYkJYMFNu?= =?utf-8?B?aldLUHBCWTYrV2FJY2QwSlZ3eUFsM3ZmRW9vMVZ1bXpWa0tQa3kzVDdKNm5s?= =?utf-8?B?UG15VzNsdno2RzhvcnA2TlZtNzdGcmg3SCs2akVvNUZIZjdudWRudzNFRXh5?= =?utf-8?B?TGdrR2lPTEVlWkN6S2VTQnB0Nlh5WENoZXZjN001V1ppOGo4MEIzZGYzem50?= =?utf-8?B?anVXUFB0V2FuMk9ORGtBSWpRRGZ4WmZqTVpDSUxRQTZyellBSG0wQzg4T2hY?= =?utf-8?B?Qm1EeXpuaXZSZUFkYzhwTG9USWVtMlhIUGdOY2Z6dDQwOXJ3SjNvNU11ZXB4?= =?utf-8?B?dmZyYUtyenc4QmROV3h6cFd6dDJsaHpldGx0dEZLRVNLazNMdWY4QTQwSUI1?= =?utf-8?B?dUVvTHNmdmZYRW5pV2dzZzFwRzg2MnE3YXNMeGpCZjhpL1BtdkxPdGhpdGE4?= =?utf-8?B?dCs5dzRIaEh0eXhpL09aQm9GVGVUZ0wyZWF6WDJ3V0FVUDBsNzdhRURxMzcw?= =?utf-8?Q?P3uJfxqQQ3b+g=3D?= X-Forefront-Antispam-Report: CIP:69.169.224.6;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-6.smtp-out.eu-central-1.amazonses.com;PTR:b224-6.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(704160211799003)(376014)(48200799018)(61400799027)(9140799003)(32142699015)(55112099003)(6133799003)(5113699003)(4113699003)(10067099003)(22082099003)(16102099003)(18002099003)(13003099007)(56012099006)(5063699009)(4143699003)(261009223027099003)(261022105027099003)(261021121427099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: svJL48T36XShr6NlecVKZBzbETKYEtykbuK6b3KJpZf+V25ZsM01tYPUBvPiaooNgLxAn9ugxWz7fOwcvJ+1WQsYdz2YBl/B4/Z4drTCBSjM4WdGHs6su6gDLyLq2/Q2iv3/nE2huHMl2ix3arG6eet3T6nlfqEi2pFg22BsHwY6qEW2iu+2Q4LFwL7rPxwTQRmVgoVXl9o/d9/afObWG+g3bDqXFakGGELbgebla2eChUGNyAZrlE6QDTznyAIukzLuPQ11V4JwvnrHaBwPzDzYV/q4Hbp6eJsjW4Lr9GnLCQZEdvOUCBqEzEOXToX9cWb7zGOx3k/Uq4bEmr8V679ZJKPXDgRFylEsB/LrB9jMI8lFuPyNj2Q377tKBpxGeOoglMhUSqfO9y30eHcGV4knxdwWNXd6iI+tnnvZp60uqXbH4OvnlNj/Who64iky X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2026 17:04:32.5164 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c543e8e4-9b1d-43ab-b9bf-08df3127b557 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: AM1PEPF000C1AD9.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA6PR08MB10830 > From: C=C3=A9dric Le Goater >=20 > vfio_rom_read() can leak uninitialized stack data to the guest when a > read occurs at the end boundary of the ROM BAR. >=20 > Fix this by initializing the val union to 0xff, matching the ROM > initialization pattern used in vfio_pci_load_rom(). >=20 > andrey.drobyshev: > This commit is cherry-picked as-is, with no modifications, from the > upstream commit 402fd5a75659. >=20 > Reviewed-by: Philippe Mathieu-Daud=C3=A9 > Reviewed-by: Mario Casquero > Link: https://lore.kernel.org/qemu-devel/20260602074446.1206892-1-clg@red= hat.com > Signed-off-by: C=C3=A9dric Le Goater Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261023-vfio= _v1-v5-0-ba0bf3c6d122@virtuozzo.com?part=3D11