From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11021116.outbound.protection.outlook.com [52.101.70.116]) by lore.virtuozzo.com (Postfix) with ESMTPS id C176A80C1B for ; Fri, 23 Oct 2026 17:07:13 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wp1p1oM1vfc4+aJp+AHB/eEvDhJxA9Ce3vDnU0gnoZDy9M7CjvmUNWQ4IziY6/iERiOq1HNnyTBLxQjaaGu+oKkKN5QCVt4TNHKuD4+Z/FanAgXY0IIEzj4c1Dwvas+l54aIudQi+IS4R9CA//OW+Rc8mEAWtaKys5ztDhH8/CkNNUx8npjVtvYlKwCh66p3j5XSOdWnLtbZkVBbBlNFRtTGueAku0HNp5zXppx04dmDv5QgQOnIVL2D7aON57jGAq2oMvto6VPJCCsF0VtgzTH40bFuTmPhfK5QWh1EuS0VTGPBLw+qh9arZjIF9ZOBKVkeb5gbob8xPcW45K7juQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hmCR9evAOej1ysNN+CslulHJ3vZlJFvCIPMbUyIIP1A=; b=It3YkirZclxdPVHuGyjTdLMi5JXItovoQDFLRs+cTl8FMbloO8Sp6yuoEyqUML2FcuJcSZLoMLa1dHbUPHSkemP5JOj7IktckdeY3bGA8biacx1nOA4IshfYqBHkOcXZQC7Dm7cWJdyTm09oYO6+Rk9OzKTwbAsOR0nva3O0XKsvpvKU3MA5e4dAO3StpFrL3rdsADLcH4Rta2uw2YIgCOs11vfcENQDLJCqxLmPlAdOo9mHG318G8T/kRw9vjHbkfhJDknOpvP2Bg+sj30CjAaLBLsy0vMTl4fW9WvYCIeC6nnEDE6V2JUN9obt2gKb1OvsEgmvTFzoBzCPjT1ACw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.2) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hmCR9evAOej1ysNN+CslulHJ3vZlJFvCIPMbUyIIP1A=; b=iVPYfXVzrvVqZFLV0NNy2kpFapvtYHXra50QxTEN1dIpwxZwSxgKcjCCpouGSk42lyTjBbtOA7ohvswRhkhzf/a9CMsMNw0pyhXQOZdDV0tpkwd1NTMIPoiCppRUDfSGlUSlUTGIXCztRV3l/cPQPJCRkwBdS8ZuRSY3VNurFt8= Received: from PR1P264CA0171.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:347::17) by MMZPR08MB101989.eurprd08.prod.outlook.com (2603:10a6:190:3e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.15; Fri, 23 Oct 2026 17:07:10 +0000 Received: from MI3PEPF0000855B.eurprd05.prod.outlook.com (2603:10a6:102:347:cafe::59) by PR1P264CA0171.outlook.office365.com (2603:10a6:102:347::17) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.19 via Frontend Transport; Fri, 23 Oct 2026 17:07:10 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.2) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.2 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.2; helo=b224-2.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-2.smtp-out.eu-central-1.amazonses.com (69.169.224.2) by MI3PEPF0000855B.mail.protection.outlook.com (10.167.240.23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.15 via Frontend Transport; Fri, 23 Oct 2026 17:07:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792775229; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=vll5iuW/C0AK8wZpVQIJtYJz9A7rNw17HoNyj0FpFoY=; b=XKsuNMg8wYXTmd7zXfbi5/rcILFMjW+/hrZhgnEOqpHoUQw7CidA0F23d0+e+HPh T88rSnbiIkCfEYahyrZm0HX6E0vwNvNdGSWnqW6MNwbdkFSHcX6+0xxT7SQhgzDwOXu 3yeMXHtc8oTxRrLe1CGOIE8KAPtmirzPDr53LIKHsXqLJ2WJ1eGqEmsqEiGqtkVG/nG 6vxGocmxY8VFWqaOURV4NFVRipNok0U7ANKGDBjE0ZLub3HCeFIVlYncSnsDpUNRoHB nKbu0LREsPpci+DRkvd7nG2tSou+biYr6I8eJ4924L4p2sTlId8/kYmB06m1wofSPKv TRJ6DcosNg== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792775229; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=vll5iuW/C0AK8wZpVQIJtYJz9A7rNw17HoNyj0FpFoY=; b=h4FxHj4JzCAmNCl855ilFrFhY2X4dRRoF95x/UcSPhhSMd3ToQ/apWAe552DsawO RmvPwZypWoOe6fSxq0Rzc7LunykxRpofXlT3KFuzt32z6ul2pwNnRJ/36E380/X8n57 FSG7Re/M4355yAElYy6Cv7xnzIBaBmWLkFLmusKA= Message-ID: <010701a169bb10ab-a415d7b6-8d9b-4aed-9675-1eb87a9527c4-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v5 14/36] q35: Fix migration of SMRAM state To: Andrey Drobyshev , svt-core@virtuozzo.com In-Reply-To: <20261023-vfio_v1-v5-14-ba0bf3c6d122@virtuozzo.com> References: <20261023-vfio_v1-v5-0-ba0bf3c6d122@virtuozzo.com> <20261023-vfio_v1-v5-14-ba0bf3c6d122@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 23 Oct 2026 17:07:09 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.23-69.169.224.2 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI3PEPF0000855B:EE_|MMZPR08MB101989:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: c97e74ce-ae85-44b3-99cf-08df3128133f X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|48200799018|61400799027|9140799003|32142699015|56012099006|5063699009|4143699003|261009223027099003|10067099003|22082099003|18002099003|16102099003|4113699003|5113699003|55112099003|261022105027099003|13003099007; X-Microsoft-Antispam-Message-Info: 641U+uZRMXGsl8R8mcDF+C+/QvOH+mPfTjb3cARARMGplK9OV0tVimkzkkDI36dv0nvMUYwQzG5ZklBx9wpg7/Gwbm/+ncEnScaSyGOAa+V9XYtcVZEuXGsCVgKOtRya3AXV5JnFwijVUDqljcBDQMhbrY1L2UtM5jrNkFlmvGXQ70ybrFwdzVm4Jh4HjM+tkvUNnX605C2AYZ2VTtYKvkGdB+Xn6iakHVQQoT7LPfqR8dcogh+LO+jtKbTdjpdQXk3IaRLBdIml4vQwPpbsDN4wyeyZlA7UaKKhDjT9jvO1LsmHnQ6lep0Rn7KNrenIvhWMPx6pRH1ciXGNT+4GxplgZzVNLG24X66sj9O5B2NQGZKtiRTgBzcTSV9dUMITOj/d8WuKZtg+KV7A3BPW/umengAJX+S02sBUsjjj/qzIgMs74/QqATiVrGaYJsdLgpW5CNfznj3adMPXNMY1XHgEwHVgDfxF152laa74PsJdUlcabcjMm8EqZroeVXuZYEoPeuBCdktDrxjpLuZMSq5BVCH6Kks2CrgImxIe1wQvjsUTqJ3qSHsvWxh861IGSNV//bP8K+arFxRY+PZ/G9g6l61bReabeC+465UHvyovRjUc3Z3eUYat9a+DSxMKQOWY3Aa7h77hOxxOwLz7BCI123E1pWV+y9baBBdKICXW05tOEAKdhE/al1kE6IRjyu2oG0VUp9GR7NgnZf/RRiZNVBT7Rpa0eO0WicUzGRu3zS5Mk1ZLMDl24cGHbsJCGFr+D34DhJ5hwU6I5A+xGsc59RqWxqKkjms4pRafgIUTkHOpN940af0/oQm8O10/Ib5P5sQ8QojnF3xfw0yx4f4YR0xpjKQ/2Eg9N2fZuhU+mTtSKXNCNviMt/XXtE2sGAtl5+4luh9foeOS1JSftA== X-Forefront-Antispam-Report: CIP:69.169.224.2;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-2.smtp-out.eu-central-1.amazonses.com;PTR:b224-2.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(376014)(48200799018)(61400799027)(9140799003)(32142699015)(56012099006)(5063699009)(4143699003)(261009223027099003)(10067099003)(22082099003)(18002099003)(16102099003)(4113699003)(5113699003)(55112099003)(261022105027099003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: HLJgjCOtSJKF1QXJi/FMrVNdAySBNouoA67KXK/8cHoaxoARUFvIOyv0idrRy/LY/ApG6gdtPiLoXW1orNqmObq6ajyWvskqoKaVpb4EsTTEZxgsbbX/KVclKMY8HZnjliK90YnTl/FFjuRj4CU/NjP2T5LI5rm83zjl5FBZ1imvqqwmWY3nVTcZscouIFkUEcATTlv0TWHx7JoFrUN6K54CLJhPdLJbwNu4h6aBzvYt6DupRvv1zR+l3PyTYOuaboFnDNZryN0956TX947Zgls6UVbj0dT6OuipS7sMvSCujYhwIdXQQ8MtweVpAM6uJwDgMnQEsKlFt3s1CUGnB79f3BBbA3TMlNOB1fVF1hwaidfT16HuOlplgh0CnKj0SI67JmpvM66xQNnQDaukGPo/IQSr4egPXPFYuQq+rMrm52IXArgRK+0TRqJNS1J5 X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2026 17:07:10.0594 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c97e74ce-ae85-44b3-99cf-08df3128133f X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: MI3PEPF0000855B.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: MMZPR08MB101989 > From: Igor Mammedov >=20 > When migrating, dst QEMU by default has SMRAM unlocked, > and since wmask is not migrated, the migrated value of > MCH_HOST_BRIDGE_F_SMBASE in config space fall to prey of >=20 > mch_update_smbase_smram() > ... > if (pd->wmask[MCH_HOST_BRIDGE_F_SMBASE] =3D=3D 0xff) { > *reg =3D 0x00; >=20 > and is getting cleared and leads to unlocked smram > on dst even if on source it's been locked. >=20 > As Andrey has pointed out [1], we should derive wmask > [ ... ] > Reported-by: Andrey Ryabinin > Signed-off-by: Igor Mammedov > Reviewed-by: Andrey Ryabinin > Reviewed-by: Michael S. Tsirkin > Signed-off-by: Michael S. Tsirkin Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261023-vfio= _v1-v5-0-ba0bf3c6d122@virtuozzo.com?part=3D14