From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a169cf300b-4acf409a-6231-4a3a-b8fc-149da4c572e8-000000@eu-central-1.amazonses.com> Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020128.outbound.protection.outlook.com [52.101.69.128]) by lore.virtuozzo.com (Postfix) with ESMTPS id 440148045D for ; Fri, 23 Oct 2026 17:29:12 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=t7gbXArAZAwHBpsABdpOo7cliltla31k6QY797J7OzjUNHpQmLN++2BMQ7Y4LU1bz9PWcwzibIMf0RieNsoUzJxDsW0w4omE8KAQ5uGko9aTUCQWpse58Z5EW3JEfwfX4oGxAxNUltZB8/pRfGt2ac/ALqN1mLnAhfZ7zSyXKeBLKeKmYUgp0HwEWfK80VAkUUOaC+qlGm5b/fyhdkxtdsQg1ZDLS9tFZ+vICMFAxz81c/WGZ8+l/vGw02poMibcF82OrEp22sawJYrbY9JXNAG16GuzX8666nOe/mf90f5F8QOBJVXb9yX3ZAJN18EYdo91xErKgSGW38Or6laTDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hNLxJcYEPWHGcspn2RmVQMCJGv0gawvLTT/+IlnNgB4=; b=FC1W9xz9CoMo5CbGmRTcpZwmuK//mCBmYUUGvG7T5G4NwjSDrEQeV4sy9lkRK/0EaSxm+2MvEbU3qJTPIlkKrvD+IhSyt5WoZ/rWWMIhq9j+2f0xDFk9KU9WofGgQ4fwtpunGEJ0Q7pppi68HlwHxCjVfMJEX4n7CC3cdNGFIcOUbOqWGhE02oBTh8sa3d5csEdjl3xNQfbmJW65d3jWuJ0T5x+TbFePV8rRfvmAylKoOqmSIee8w6hl6iUl0lZVLYTOotpL0dFXlJnds+7aWyaenEcaRkQ0aMQF8KTAUjRi6detoq4aEUz5W1e8reBS+MrS2FAHaPfKxRwlmxLvqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.2) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hNLxJcYEPWHGcspn2RmVQMCJGv0gawvLTT/+IlnNgB4=; b=TkaBIukhoZ0a7uJJL1+KxQoPo6mCGVXpgPngMA0hV39CDPB2ZFtWKpbrX82dHq48r/Onz4FvVLqgrVYGyrRUGT6yHdEXvM6ybN9djWES/ZKZdCnS+S3BquQ1nu8wzgMg6cA6upieZ1eHqoRbhxeRUh1vxha8AQsnbCKDCzQUXkg= Received: from PA7P264CA0060.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:34a::9) by AS8PR08MB9597.eurprd08.prod.outlook.com (2603:10a6:20b:61b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.18; Fri, 23 Oct 2026 17:29:09 +0000 Received: from MI3PEPF00008555.eurprd05.prod.outlook.com (2603:10a6:102:34a:cafe::68) by PA7P264CA0060.outlook.office365.com (2603:10a6:102:34a::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.19 via Frontend Transport; Fri, 23 Oct 2026 17:29:09 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.2) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.2 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.2; helo=b224-2.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-2.smtp-out.eu-central-1.amazonses.com (69.169.224.2) by MI3PEPF00008555.mail.protection.outlook.com (10.167.240.9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.15 via Frontend Transport; Fri, 23 Oct 2026 17:29:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792776548; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=aA7PAimn0RCxXDLNUfjFSRSOcQvyMfnssX+0xRKIND4=; b=GSCXBvic7bjgzfnAK6uVN0RaTU5tn1qVBQPGh8aDabzDsnwF2G0vvCQsrL23E/1p vAmKXTyU0NOr3/jDTjQ2DfqOza4gO3F61zs96/0r/PSPt7nSRNiZ/o9q6ZZikdckDsQ wv3Gin82wLQqBzzvYiYiOgKZLh9Hw91QKFFP6Eg4o3yCcTVAdnX+MVbJ91ko5jnm6hd rTvvsRlgkHLTEVkXgbLsvRhRCZsXcUltxSCKLpnsA+JrCATRRyvr3n6PHkKQEJq6ibH 0TuIlRUH42QxFJnpmQD343PjP6PtDzpGIfIbma4tN8dP1QMfxD8sArlhgdnecUYn6BZ ikJPufcQVw== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792776548; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=aA7PAimn0RCxXDLNUfjFSRSOcQvyMfnssX+0xRKIND4=; b=EzyCag2KXruQG9qE74aEXx1pH4JpRv/L0JJAvjXvej4N+rQlAHih5gCbt6/mgffQ RG47x3cbGk3MTkQIYKzRezWDri31j5zbzhWpRTqnZHArNuJOIYzE5oUVrGpwJlyiQRz xj5HnEuIwQLCtxmnzf6nUymErBrpdvwx6vPrGlhc= Message-ID: <010701a169cf300b-4acf409a-6231-4a3a-b8fc-149da4c572e8-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v5 28/36] VZ: vfio/cpr: don't close KVM on cpr-exec To: svt-core@virtuozzo.com, Andrey Drobyshev In-Reply-To: <20261023-vfio_v1-v5-28-ba0bf3c6d122@virtuozzo.com> References: <20261023-vfio_v1-v5-0-ba0bf3c6d122@virtuozzo.com> <20261023-vfio_v1-v5-28-ba0bf3c6d122@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 23 Oct 2026 17:29:08 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.23-69.169.224.2 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI3PEPF00008555:EE_|AS8PR08MB9597:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: ad4f8cda-57a6-409f-af8d-08df312b2547 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|704161411799003|32142699015|9140799003|61400799027|376014|48200799018|4143699003|56012099006|5063699009|261022105027099003|261022075727099003|261009223027099003|261021121427099003|10067099003|16102099003|22082099003|18002099003|55112099003|4113699003|5113699003|13003099007; X-Microsoft-Antispam-Message-Info: jaIsB7mWg36KiyPIo25xvCaqGm5dGi3W+MR3hpQ2WEe4Z4lKzfYOwww89G+8WqyVR2EDhsgZLQsTLQJjGu/8rdE8dOZLA3MkFhiJ4/8IbleT+CVO+r8DvlVx+7DJcV8kvuXeic9LH4tVaoEdiauBdhcYxi3TEN5S/0VOVaxn4Qsg2AWSSX77rxqhNjZq6bpXVCRRh/qJg7cf/Cq9zh2foQkiaKWQij0WNR8N9w2n9X12OV/f0Cb1zobLyo2u4bzrx9PtJ0sk8JqE8SKUoZVguW+4aGZL5fbJ5jeAGCZhoce4hRMkSwlwTGtTrfOjrF4AqTiOHTjSJ8u8DMgwUBIKSk2fm0y66F8DHaYOm51TYZfrlFquPv8Ut5f/luNxu4+UbLjEhdPN9KubKVu3Rr0SnhKl+1LFjykpXW8mLmt8BcmCeUYsKZ29ajj6miNhl9ogwiLxmvdqahwaNjCSXhVhsJs2R2J8O+QBP+VYbT0EhBhvpZY7HSRxy5Rdwq/g0E7uxdZQX/MGzVEisGhTJH7mXsF4KCy4EgjHMsQagRVeI8js3At+8HS6bdLXSLTaoqY5E79/HWGkYsO3lGdykmuIsJS9W9y7eiYKmTeyCja70kWps4UamrhsWSEfVohxQ3lUl5SXzzudeyx+ZrtH4MeLRXLiTDxuz0XdgALD9rcQ+u46RypEhdEndHg1KclUAA4UBK02hUFZgE+eXjmcpKR1lnX+RtSkYDLdoC4jo5mua1G3NcHUbjLIb5dcaMJNwQ1d5iIBN52xV1qm3lwYGseTGjbzMYwb+ML/01TrKgGBN+YUqq3onwz+O8K7lxx7RPpmJWdwLcYHWi9M4eX2D2kvHvEH4LwBYI+o1zAAZkPl41eIB2jxDldSGSw9mJQBdmeJKHik7YDJUDOSazy3oVIFXQ== X-Forefront-Antispam-Report: CIP:69.169.224.2;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-2.smtp-out.eu-central-1.amazonses.com;PTR:b224-2.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(704161411799003)(32142699015)(9140799003)(61400799027)(376014)(48200799018)(4143699003)(56012099006)(5063699009)(261022105027099003)(261022075727099003)(261009223027099003)(261021121427099003)(10067099003)(16102099003)(22082099003)(18002099003)(55112099003)(4113699003)(5113699003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 2AN14eEc7E+rP/tz9ETLE8iHkoDpQ3hTYqCa+ZKbucIMb6O72DRsSHzdsMHa/qUNBTfivAuCYfPKweBNvVJPEE1SCEpUwO6J/wGw8XO0DSbKGkW+CpIXzAATS/PA3ncVhMq0EjuFH8Cpiut/kxzyzQfTHWcKAx5dh0dc/AtbpWnqCURqxvlGvLF4cVc1ohqox1lkV4XvzhDzyIAyCqxGxt8JTQlLrZ48tnEvRShnpBZ3D8t/JRNbQWbjZEpE5WqHqFvtW3ykAJ/QbHtthclS6Ao+2UJAhVcVysv4evEbcsMl9mYVM43y6EBLd9LNhGHUc+q4lFaZhzLvVz6sKcUJil+2Ew7TuRJdNWl9eMAc16WM0hJbpGhwuBDy4tu0X5nd9+fn/uKAsR1/Isi6MpWBvH2igREke8oKpIecFfR2w0wCe+TQQ2en9M9M106aD8Uz X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2026 17:29:08.8013 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ad4f8cda-57a6-409f-af8d-08df312b2547 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: MI3PEPF00008555.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9597 > With VFIO devices, KVM is closed on the source when the migration > completes, so that the new QEMU can create its own KVM VM with the same > devices. That is done from a migration notifier, which for cpr-exec > runs before cpr_exec_cb(). But cpr_exec_cb() may still give up, when > the memory can't be preserved or execve() fails, and resume the VM in > the old QEMU. A VM without KVM can't resume: kvm_close() removes the > vCPU threads, and the first KVM ioctl of vm_start() aborts QEMU > (KVM_SET_CLOCK in kvmclock_vm_state_change()). >=20 > cpr-exec doesn't need it anyway: the KVM fds are close-on-exec, so the > kernel closes them during execve(), before the new QEMU runs, and > kvm_vm_release() tears down the irqfds then. Keep the notifier for > cpr-transfer only, where the source process lives on. >=20 > Tested on the vfio-net rig: cpr-exec 5/5; a cpr-exec aborted in > preserve_ram() and one with a bogus cpr-exec-command both left the VM > running with no lost pings, and a later cpr-exec completed. >=20 > Signed-off-by: Andrey Drobyshev Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261023-vfio= _v1-v5-0-ba0bf3c6d122@virtuozzo.com?part=3D28