From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a169cf9455-b5dbf23d-2922-46b2-8a86-e367aba9c80b-000000@eu-central-1.amazonses.com> Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11022105.outbound.protection.outlook.com [52.101.66.105]) by lore.virtuozzo.com (Postfix) with ESMTPS id 8EA498017D for ; Fri, 23 Oct 2026 17:29:40 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=zLwpiZ539nW6F2UXfgzF1b6gkbpdPB3y2xY7fyOLuEH3zHwy95zuTlpJtKaFs5UbAZqHQHbEKBj+3isGdxZ1WPIFS0LKjIcygaTFoAy7QnCEVnqr/1Kj2QUXb4V+a4LQQnZhf0jcG7VOeWehlrgKooqiwTmjQsVLhxkx8tL6zkGQ3UuC77fWzjkPb5hNIqeeWTfJTx6MheAzS9djjkFes1PCiVnUNBozhutE+1bFhGerDiRblHis2NCSWyXSr/zIXCy885bPdqROaUelLhXQxvhuBWGuKzgoSSFkvWXuxE4LdcnNNwilbPRABdVPu4H6xf5+ZyWTtDzIx5sjUW6kSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TB0qh88ass84k6eh1g5MIOXLhUlLgdoQGPEAnnjRGlU=; b=r0snVqFw0K7X0TJ1izavhgWVC7SsaWCNzQkmWQB5/70xoNVMaq2wH/7h691inhA/4tHKIddUqc6B49sLC5UzCCPEIzQGGhK9t5S+fhO6Wz27VkGCU8UMC6CS4rptnH/HbfD7aoLhwreSHJ9nzfJT26KNcc8icIAB1CcvYWibc/8R4wc2D78vrprSsuFvUelAdqGcWEOG6f1e8pbEOhK+/TgFTrQkPSE6IqVcrXg8PhwWXTsfJwZKNG7nCF1cCXY5HPGj+81ASqAPU1N9HGVvovxgrMrCXdoyqIPu2w7aTyj0y9vBQWtj0XXXeKpCup2zEsRU4zWRKdGYTnZ3OiMY6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.2) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TB0qh88ass84k6eh1g5MIOXLhUlLgdoQGPEAnnjRGlU=; b=QGu0tZdTSnrD1s3DIhAt3SKDzm71S6xzDsagj/c7ljCrHc/Ai78QIRN8ZpGWXBGAwzBSlbUo/cBqSfOr+sD9wiQH3fTwcXXWozgQWXW687vBotc3wLovSgsDj48p8gZsM1dW7vjmUzerzCO9kXrMTgCTy+unFUyO5tbwwfQNdag= Received: from GVX0EPF0005F6C9.SWEP280.PROD.OUTLOOK.COM (2603:10a6:158:401::659) by GV2PR08MB576087.eurprd08.prod.outlook.com (2603:10a6:150:37a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.19; Fri, 23 Oct 2026 17:29:35 +0000 Received: from WA1PEPF00009B3B.eurprd05.prod.outlook.com (2603:10a6:1d8::119) by GVX0EPF0005F6C9.outlook.office365.com (2603:10a6:158:401::659) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.382.15 via Frontend Transport; Fri, 23 Oct 2026 17:29:35 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.2) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.2 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.2; helo=b224-2.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-2.smtp-out.eu-central-1.amazonses.com (69.169.224.2) by WA1PEPF00009B3B.mail.protection.outlook.com (10.167.242.41) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.4 via Frontend Transport; Fri, 23 Oct 2026 17:29:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1792776574; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=RTtQS9xjdR5j27Qi0ySh34tvzjXajUYJhRcHByzPh1k=; b=Ip4ViyUisRr8iCftf8Ywgt8dj/bngpimYfxfsV3wr32rMcH1GDZTHiiKBFbDkZQh +ptOWnIDdVl8Ust3sHAanRuCoaxf0q6F8qq0S92eMBhN4M99qIJhro0v6VOHpui8PPM FXMrpGG/iRoeiI+sysvEbrEMcee0v1siuJw1eggtRCB/TLOGVXDx7DKJkXwLAnTEaeI Vw5cnj9Q8HXNcE2yGdQ3AuGuE/VWYVuAel4THH+63s5uxrS+JH0ea0JT9uRQo1VCnzx B2vkNbIJbdci3wNNz4EUvixXFDnN8s5cjHmgOIkv0F8S6FIfQmJq/tncUDz3RcMEIRB VlNByyNe1Q== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1792776574; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=RTtQS9xjdR5j27Qi0ySh34tvzjXajUYJhRcHByzPh1k=; b=DZEZ/cD7+UeVt+oukfwXUgmpyPRWgpT7XNY3PsaW5W8WS2bzFBpqCOmJ2rvBeeFj O6h24EcBKo9vFcLofG4HeFXIgaZqEGmy/4RD8juQ9s5ZNM/w51YB9bNPPy4byDvkmOB QMN3sAe7WV6MCPYRxLQ3j/DZxMiWr96T5QGmkQTc= Message-ID: <010701a169cf9455-b5dbf23d-2922-46b2-8a86-e367aba9c80b-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v5 29/36] VZ: migration/cpr-exec: abort cpr-exec if memory can't be preserved To: svt-core@virtuozzo.com, Andrey Drobyshev In-Reply-To: <20261023-vfio_v1-v5-29-ba0bf3c6d122@virtuozzo.com> References: <20261023-vfio_v1-v5-0-ba0bf3c6d122@virtuozzo.com> <20261023-vfio_v1-v5-29-ba0bf3c6d122@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 23 Oct 2026 17:29:34 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.23-69.169.224.2 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: WA1PEPF00009B3B:EE_|GV2PR08MB576087:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 8a82254d-7f24-4ec0-5812-08df312b34af X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|48200799018|32142699015|9140799003|61400799027|55112099003|4113699003|5113699003|10067099003|16102099003|22082099003|18002099003|5063699009|56012099006|4143699003|261022105027099003|261009223027099003; X-Microsoft-Antispam-Message-Info: NCIe+rU7hTo11bM7hAUipGbakdvNR9F9rO50XU91+6RDTuzXjmVa0ySC+z4gzqCwyIUpgd30oSSJbRZiHt81v4NwQfsP6NyVjDl+Dpd9hOwPDXB9a4sHs5wPEQWrZ2Qbe6SkkQyyWv5s6ZZdKD2JMVateHkNylpHyQjkH1SD10b+od7zMp7DPRiGInJyUR2fszLCxZKX4Ncq5FDi0L8SOTvU2esq6hPzadsirxZ99n0sl3RUHfb7DRnxs/dqHYyMpIBI83n78fMqzPDelCN4IkQ8F3Fvqd6VgPNa8L5aOIFHvbby/zblIgEz5fqEBs7NGRcsZ3S96UzV8Rx4FwK+g1ePE6u9OcH+SDcy8mNHs65IBgsVeCQ6iyuYEdXrmCPYg+j4oGgX7SMwwq+n5mB/mlbHoCH/nEn5Z34KLZGkZ2hHFiUDTRzlv43TYcd5og2BN2QIjWpWx7uqxT9aL1bhfGTA4xI99HqMUiZ0ML/nIbCRAFy3cXcjPZSBjAaQlJ1Zl99HtFrBmyLmuGvACcUKrzK8/iES3yJBflX6fdbxF2TQ6V/ANKjon1rELpcjqgnYIBoKIOPZJw5D8skqNUMZejaiPyvnWpgp+fb95BQOAMzHe52Y9HO0Jj7RbOr2VGGo9a/fGJLIYYzfn6Fkxm+7M07ybs5tbBnUNDu6KFUNjah+hmpvPu6sPQyuW+MeRL0H1EYGNyUvqgh4KW7F0VmpiTJkfVV0xnH1GzY5xAPTqP828n0I+sIn+Rus0kj42L30dAFs4ZUGSkMjro1fWpGinIPIh1Yr208362U5KYKxFdiWUJABoVnuIyU+VflDAXnfo7lQuJqtJr/jkWYoXEL43IIOk6xPVdXkAJhtYTvfHEGRSCUzwNfP9NXmra8OYKz6Y+QhAcd6SJ2rfM1Ce989zI2CWXlbu7xVa/QeGSpIJdXkXEyvGXtlDiBVmf8ssw3I X-Forefront-Antispam-Report: CIP:69.169.224.2;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-2.smtp-out.eu-central-1.amazonses.com;PTR:b224-2.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(376014)(48200799018)(32142699015)(9140799003)(61400799027)(55112099003)(4113699003)(5113699003)(10067099003)(16102099003)(22082099003)(18002099003)(5063699009)(56012099006)(4143699003)(261022105027099003)(261009223027099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: aXuxpxEdYjCLj6H4n5bzPDDJgJEfp/SvAW1xU/SlDz/R3hmEbCFURsGxx/6PMH5aBMRQ2EmqvvT0odIzoxLoalHHn/2DSa6qR+zGI8BCPtXzxnHHd4rmh7N22iuUVRVcB1DVLXftdNV4Sak+B34MzRZoEB74D2gL31wzy4g4NZCr3uyEUT+kGrWTYVNEUR+WPZpG+Gbc8Tf4F1k0zBRJMjcvdYH23M5mNcwAWuHJSRc8URxZSJDXLn534VH2Ar0vJUQJnZGHsFJuC3/4JGUnQ6+drUA7S8Y7xRvzES+matKz9eN9at6jq5uqZ+b5mHA+/I7Sdifg6Lq6wZ8oQrCffq6bkvdmzoXInLkdLeVFH6uiT9fMUr2DWImYVgNFjSBvwwyR013aGpXZu2+ehsPFzuf+eDi42qVRv5qq3vLmRrUr0GnDGM0aPFsqiOFBiu33 X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2026 17:29:34.6012 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8a82254d-7f24-4ec0-5812-08df312b34af X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: WA1PEPF00009B3B.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB576087 > cpr_exec_cb() marks all saved ramblocks with MADV_DOEXEC before exec, but > ignores the result. If madvise() fails for some block, the walk stops > there and the remaining blocks are not marked, yet execvp() still runs. > The new QEMU then reuses addresses of guest RAM that wasn't preserved, > and the guest is lost. >=20 > Treat that as a failed cpr-exec: go to the same failure path as when > execvp() fails, so the VM keeps running in the old QEMU. >=20 > On that path also clear MADV_DOEXEC from all saved ramblocks again, just > like the preserved fds get close-on-exec back. >=20 > Signed-off-by: Andrey Drobyshev Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261023-vfio= _v1-v5-0-ba0bf3c6d122@virtuozzo.com?part=3D29