From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11023120.outbound.protection.outlook.com [40.107.162.120]) by lore.virtuozzo.com (Postfix) with ESMTPS id 4189480CB2 for ; Mon, 26 Oct 2026 11:14:20 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=X/b6zNdqSnlJPYic36r6whWWVHMqhDypdweJcUgGv9tG0SEBVzgHzC4++myiwnVJMXNZffPWL9CT60IPfhWt+e26scqitAoy/sohW3ow5dLzL1b4egOTEZJjPp365WVmaZq3lEQoUfyljmwFsJMwihE2sCxqi21AHs+HPULmYXmd6XSp9mFgEWgbLr1jwOH18sUvxasWzIgzNa4pOgtNGW6sraHIi6CBHW6c6shnzPHc/fdVfhkpE3rZxoKrcnG22o6sKx8Ko5ISAx38/DogK0ZwxMqmovILMm61f4SziPsGGOdTgVDs069nezDeD44UsxvrU0MMHsDmlM0ODjNFEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1T4T/LpoaNI3tLDIV6riUA2Bov0/x4d/yvo9Fc577cA=; b=ONoOCr3du7fAlGsmbSjmOod5IXLSQVsFiE5vwoTkxeQJNWacR3pIrSyiIs7GArfbtNiRLuFc+B0tl+kMR7yVAHqPbhWY0apkPH2wcMrATJ+Knf0Q6ogSpb42jtykaMvgPhDGQtRb++0ds4iQgIbpvLwsXwHojNMYHDtXF1I18KAE3BZKdLtQ7NkxJCUq61+6ygYULOOQ8WcR5m+ZCAUXam3ONiEI88kCijXtRYT8PCcUT92NkFbjk4CkDFJ+Ni9Su/52MfOpelZUPCSmmcPYKAqIBVoUSUqeNHWLFcKCIZITPEgfosZRA3KdxClqr3f0Nv1Hi/GtFmm13+v82D9L7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.2) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1T4T/LpoaNI3tLDIV6riUA2Bov0/x4d/yvo9Fc577cA=; b=bZczbvDec9HqKbEGKRDAH5V9cuD876Ic/uBs05yjgbrrQ+HXZo115+pzu86b3wwfqilPqmhCfAJytuCWEZ2/P5AJQ0XeGmmfcjTgcby/17bZdDp4Jpj/zU7vXHO/u6rRJN4wbmuF1qKMRm2blAphMpL6x21OXxtv1U4cJ7yi3us= Received: from DU7P191CA0018.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:54e::11) by AS2PR08MB8309.eurprd08.prod.outlook.com (2603:10a6:20b:554::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.22; Mon, 26 Oct 2026 11:14:17 +0000 Received: from DB1PEPF000509E4.eurprd03.prod.outlook.com (2603:10a6:10:54e:cafe::f) by DU7P191CA0018.outlook.office365.com (2603:10a6:10:54e::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.22 via Frontend Transport; Mon, 26 Oct 2026 11:14:17 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.2) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.2 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.2; helo=b224-2.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-2.smtp-out.eu-central-1.amazonses.com (69.169.224.2) by DB1PEPF000509E4.mail.protection.outlook.com (10.167.242.54) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.4 via Frontend Transport; Mon, 26 Oct 2026 11:14:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793013257; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=dICq2zgUhssogB45unO6bspUpQMR1IHXxliYQT9GG4s=; b=H3vciFbgEc7kk1ZIIDSwsqTIDBRoMs1m/xnI/lwk5vOciB9YYHZBVJyXbANqnTYA +3DmbnObJ82pjW6thjCAZAALXYCoUaIzMjvh29MPH+eK0QUf4fp60lpiESuX4wn0LzO ksXcqpiqFdB4hNxu015ERuNIEx3D2Dyboa7JlkOgZ8jvxrgCL8uSnMbaBxWs8VPWpX/ OpwLt2kS8R2undzmV1Hg7hyAo+FgrAv/8cHHtYhcMh0G0Z1oGb3SXtOqguqrKOaDxnO WTlDhjNzy1pQBffjOdSNObq/VhPXY/nm0oBOJswnxzgLK8P6DCcepzFPDsf4Y0GJSmS +tD7pN79mw== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793013257; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=dICq2zgUhssogB45unO6bspUpQMR1IHXxliYQT9GG4s=; b=DO2bZ94iUfIhPaRnsbSOYxzpLM5SxlBRiN+cK1nyRuiVEN7nySxlaSMpGv0ysL1k 4GFgxRxStc1DiUrL2ncLh+81hFIKWJwaXWoAkKnPNmojahuBZFCU7WmZrm3R1XYHU3A cmHipBt6NJmDz9jSaKkkShK9WW8hDCNgZOdryBUQ= Message-ID: <010701a177eb13a7-dba38707-7ebf-4ae9-ba24-075ac65bad48-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH hci-8.1 1/1] virtio-scsi: fix hot-plug event racing device realize #VSTOR-151351 To: "Denis V. Lunev" , andrey.drobyshev@virtuozzo.com Cc: den@openvz.org, svt-core@virtuozzo.com In-Reply-To: <20261026111134.145823-2-den@openvz.org> References: <20261026111134.145823-1-den@openvz.org> <20261026111134.145823-2-den@openvz.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 26 Oct 2026 11:14:17 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.26-69.169.224.2 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB1PEPF000509E4:EE_|AS2PR08MB8309:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 7fe2dec0-ce82-4873-d21a-08df335246cb X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|9140799003|32142699015|48200799018|61400799027|376014|22082099003|18002099003|16102099003|4113699003|5113699003|55112099003|10067099003|56012099006|5063699009|4143699003|261021121427099003|261009223027099003|261022075727099003|261022105027099003; X-Microsoft-Antispam-Message-Info: FsLSbCEIaFHW8ynf/7qY1bL8/4QIAA/YFmhPTx0gXfDIEycsGZXapOB8Xd+mtVVLacFLu77S4ZByRUdk3a/FXZQ/ySwRZNFT93qh+9MisSRd9H8MQY0vnZWgm/9ntzMtOYus2riOK6EIFtiFbZzlmllDt5c2glN2I/Axy2RvU3f6bWMle31/ZUijJ+JAVr6uv6UauwYeU2/6Y/fukFyhv1oraXeOAyg24VVB44bB3uTMr6rLe/DVdpusYhTsDCqLggkYxLgJLFi2/KLvYYnizbDQRGxr1UjnmYjNQHmwEa1rxFCnokS87U/5d6llees4GvxLIqC9luJfihfWRK+y8rSdIzS4bMVogihlbahkVP3z/qTSddOWMsN0nTxjK/yXRlPAiXCS0V1AkDCYqsRJRNjcz6mKqY7T7vM+nS/2RVFVCdt5LqGOOynIGf7D4/N15HlptyvTvFsPyN8h03YCPgZGN0ECSomeaJIUc7GG9PK+//2UVZOzkifKjamSymHxKipEqPl1hQIUGxhpaIxQzHt1/PdNoN5R6iTm8RgvPIfOzQR0aOpDnGxWD9NXfj8PTG07zYVRKIRp2ayLcSkKRy6yaujWgEDYdHN9xjm1gpWzL/NnYV4ZFgfwncPwp0y2ZSqCs+BuX6fSYGMzJ7S4JUFYHynO3CpeYMdzRRHezOFPx5bwXoyBYL/1x4AZ6MhixgAS+XMBlxZvTh7blW5S5SkmR+AT393bq4iC6l9ZkXk2kgsPoGmG2kXa+tCh3dG6j3kND//ilL9XWp/+b0vom/mw28IXerlQDMCvLZrBMNMivR79SgAJyt192b+ahvCbz4OywE3or+4+d3mf8vvAlGTOZbd8erlumAwJshkhe7mefORzrtJgOpyn/v/Nwgr/ZJjsIbGM+6G/zfmooBVppQ== X-Forefront-Antispam-Report: CIP:69.169.224.2;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-2.smtp-out.eu-central-1.amazonses.com;PTR:b224-2.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(9140799003)(32142699015)(48200799018)(61400799027)(376014)(22082099003)(18002099003)(16102099003)(4113699003)(5113699003)(55112099003)(10067099003)(56012099006)(5063699009)(4143699003)(261021121427099003)(261009223027099003)(261022075727099003)(261022105027099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: lh+iEtBtinYM/JoPMe6/FzArXCUNJIsKzoCc0Lik/8h9CGbX/19ww9vxHzwWAfYbHKzpNSUGzmV+sfEep9+qn+OZ4lIFBdqJnKYaFR9wdOomMSXnDT0LmHQ9h1NZwHq1PiVI3vdwxXUk/A0Y+qwzfu6QiJWX9uCEeEEoO9KTKkGk/2BSU5fY27X83orjSDo/dcY6GPyTwKEuEhzwvfEZkbMGPfVhp8VPoIY7cqLjXRSEzs9kIKUPYDDamDKmWpIULOrkw5AcM/HijWUKF/qaz5Da4ABjZ5XOeoiEF5ObnbZUfO+7AF1lccFtq5HpS/7dlZeWrfiR7U79MHKsLFJKCP+lfvRlJxl0RLkXB472nhh+dvpIIw140eEMveAnmUGF0a+xp+gFkvQLraJbRdOPWHjucw8FM3W0eT/4z1gWFTITrv5RiX64MSoIII2dBoLG X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2026 11:14:17.7059 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7fe2dec0-ce82-4873-d21a-08df335246cb X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF000509E4.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8309 Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] virtio-scsi: commit subject carries downstream tracker tag #VSTOR-1= 51351 -- commit 6ce8922336ce923544c647be9bf402727f9af695 Author: Denis V. Lunev virtio-scsi: fix hot-plug event racing device realize #VSTOR-151351 This commit moves the TRANSPORT_RESET/RESCAN event and the REPORTED LUNS CHANGED unit attention out of virtio_scsi_hotplug() and into a main-loop bottom half. The bottom half runs after the device is realized, so the guest can reach the device when it scans. The bottom half takes a reference on the SCSIDevice and re-checks that the device is still realized before pushing the event. > virtio-scsi: fix hot-plug event racing device realize #VSTOR-151351 [Severity: Low] This isn't a bug, but the subject line carries a downstream tracker tag, "#VSTOR-151351". It is a Virtuozzo bug-tracker ID and doesn't follow the usual "subsystem: summary" subject form. The patch is Cc'd to qemu-stable, so the tag would also be carried into stable trees. Could the tag be dropped from the subject, or moved into the body or a trailer? > diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c > --- a/hw/scsi/virtio-scsi.c > +++ b/hw/scsi/virtio-scsi.c [ ... ] > @@ -1163,17 +1186,10 @@ static void virtio_scsi_hotplug(HotplugHandler *h= otplug_dev, DeviceState *dev, > } > =20 > if (virtio_vdev_has_feature(vdev, VIRTIO_SCSI_F_HOTPLUG)) { > - VirtIOSCSIEventInfo info =3D { [ ... ] > + /* The request path ignores @sd until it is realized, so notify = after */ > + object_ref(OBJECT(sd)); > + aio_bh_schedule_oneshot(qemu_get_aio_context(), > + virtio_scsi_hotplug_notify_bh, sd); > } > } --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/2026102611111= 3.145378-1-den@openvz.org?part=3D1