From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a186fa185c-0055b5f5-c6e0-4cb3-bc54-2a6214472c27-000000@eu-central-1.amazonses.com> Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazon11021090.outbound.protection.outlook.com [40.107.130.90]) by lore.virtuozzo.com (Postfix) with ESMTPS id 5142B80E7E for ; Thu, 29 Oct 2026 09:25:03 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EtZMfZATJThAvy+fmJmQfNQT1IErjscOJfFjDIGabPLmwSXPLeH2zYdcYPa08z9i3DDmUDCo4dXW9E5e0rytQtm8metjwtuQjICvhTAEoxAKZqnQq4J973DAAmJDXlhGmgvNjoNY4ORcsUaJCNx5umvhIJsTQJOMN6leXqxgo2CBI35qBlHKFGHuTjV9Fant7tuzGos6JJYmAN1YnM7ZRP9rH8CJjNNz7d2jee+rEy3DTeTg83nWNdLkeDeHgx09vmmkITxcBZOhDg6TqSpCkUwlWU3pJ0t/PVfd8MiN5TZ3JaGqBw2oM7ECB8V9qQR3uDMJHc8CpJdBSJ+b1d1cTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=csmQ1FmlPJ8auelnmIORVNnSMIbNQ8jwLqTCbzYMvR0=; b=PSFLvD3+coh3Rnk8FdZF9ddCqudnLjyd2op6I6foom4MUpLTweJUHp5pKV4y2rZlunYeLmrWcmy+EI8kxBfO/+CKo9YoAO9N21xoLP6a33xAGHc18hxrOm2ocX4EUFBzaWHCM2VQTmuuWUSaUIAw6jfdmo+/GXmcGxzAtSvXZcEk5bhOGvk444iF3XfpdcKSpz30jvycdhOX0etMYXh1lqzPfNlK1qo90KzQwnV9UuuLxzLXTo2PWx3s8l9dR0K6aJc+XVIdyHcxsMhtl/xN8mYv0hb8mLeltuEnb/OHqNRySP/cONGGUf3QRIu52rSGFO3DFwdtH6ys5NCtD/bWLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.1) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=csmQ1FmlPJ8auelnmIORVNnSMIbNQ8jwLqTCbzYMvR0=; b=CJFvW5BvLo71alN8Z58yi9bvJMEMmk3lEDqGDWyIRDQfmH6ANwtd6w6tFNiaS0O7g5S1Od6PvW6Zfz1r3sIgv+ydaMHmw+nl6E+dQZEHyRWphI0s52FJpqvTqUl1QeoZGy3/B86whWr6YFrysVkYI8XICDnOnfcX8zI2v6BVfrs= Received: from DU7P250CA0002.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:54f::15) by PA4PR08MB6031.eurprd08.prod.outlook.com (2603:10a6:102:f1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.8; Thu, 29 Oct 2026 09:25:00 +0000 Received: from DU2PEPF00028D02.eurprd03.prod.outlook.com (2603:10a6:10:54f:cafe::68) by DU7P250CA0002.outlook.office365.com (2603:10a6:10:54f::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.22 via Frontend Transport; Thu, 29 Oct 2026 09:25:00 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.1) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.1 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.1; helo=b224-1.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-1.smtp-out.eu-central-1.amazonses.com (69.169.224.1) by DU2PEPF00028D02.mail.protection.outlook.com (10.167.242.186) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.4 via Frontend Transport; Thu, 29 Oct 2026 09:25:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793265899; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=yEsVHH3693TbcBo99HBBOzOrFBKt57KDFV/i0XMfONA=; b=sSZcspb3fdrQeMJd9UOzAZYKOBlSLGn5Nf6CKWRS9pN4ZtfE6zK2FhIO4XhnmDx7 C9dN0EbN7B0J6hsr+8l0GtaSuhGCZ/uZwetKSOId/HAvVxfhsYnZ8BXAX+XVu9XZdGo ez+10f91vvUwdQNwPzAMvN3kzgRhQRVx6fLw8sZ9CK8rFcb8sVRRXjAOp1poL1hjl16 CRseIViflhnGEB4oXQXSm3ChIcexw6FQO4c8WLP2dEEpq4DdmV9MuZ81S5ORaCWlKuf 36IknjURisTyRc4HTiomJtrKmMQOyzqnCD4nG3NRf2UYjMGN7ACK1zZUky63etLZ/J7 O1jF2gW3Zg== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793265899; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=yEsVHH3693TbcBo99HBBOzOrFBKt57KDFV/i0XMfONA=; b=E086Ks4sZt4TFUnrEnVYwL2AsYwM3+5uXA0diyQFiYEihZdH4k5OpS1eZ1XFiGT4 WmVD8vtZT0RMSRlbpXwWBKRSD9nyDjACNFIQlqHxY6w/W3FIVuWH1lyB7qeDfrhcewn bxd09hL50Cx/po3C91lEidgx9sec+6sgS1EIh9mE= Message-ID: <010701a186fa185c-0055b5f5-c6e0-4cb3-bc54-2a6214472c27-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH hci-8.1 v4 3/5] vhost-blk: use a local vhost_dev pointer in start and stop To: Alexander Ivanov , andrey.zhadchenko@virtuozzo.com Cc: svt-core@virtuozzo.com, andrey.drobyshev@virtuozzo.com In-Reply-To: <20261029092301.3286535-4-alexander.ivanov@virtuozzo.com> References: <20261029092301.3286535-1-alexander.ivanov@virtuozzo.com> <20261029092301.3286535-4-alexander.ivanov@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 29 Oct 2026 09:24:59 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.29-69.169.224.1 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PEPF00028D02:EE_|PA4PR08MB6031:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 3ddd1cc9-799b-4eee-028f-08df359e8168 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|704161411799003|61400799027|32142699015|376014|48200799018|9140799003|261028144727099003|4143699003|5063699009|56012099006|5023799004|261009223027099003|261021121427099003|261026140227099003|261022105027099003|10067099003|55112099003|22082099003|18002099003|16102099003|4113699003|5113699003|13003099007; X-Microsoft-Antispam-Message-Info: X2sRPH4tPnAzbqg85L954qSQ2xDngkyw89XDWh6l7pRMO3Z7/ZIQ7OhzN3XqCQmw/JBhtwYE0fTWYfYnUq5A4toQ2LwDewAUP5JA+5jhqmscHRsEa2GiZXSJ4w+YC0vB3oJoZmKdmheurjZt6XKMRuqmk1MPFIRK55AY1hJGZ6/ENg5m3Kv1X9ZBWShX7fs5yq/JwYNElkKwaQBTtuXKoeo38GJ50GEY04ZJPcW5c3WUIQtKTO8H5z/GS8mxNFXzXr2N4CCNo/0fuTWzeKqc4eHDSclN8nJ2EKqgw2D7IY52gx1BX37/g0EvpG0pBnP3V62Ow5tXZ0EOI6sy7PAwm7YSPa9lJnrjGG5uRw7UX6jsG6/T+UKDPsRYI5Tj+iGUqnB46b6VaiQ9fa0W2mnFo756wn0SBFHYvFhzz4Xv4xqYVHQ3GPKFV6PBn5hbNiOCnJ3f4J16RT7xN4+IISch+II20sEQqmZ2EgVpaqrfwjjjW5LARP2EegxDNVe3ZXrN77KNunLkf0rkxKT1LjMS/4WFvD2W2jQnX6IlfwYTo4VNYgSwO7Gb6Mw/iMaFoTepwdtXUzLH7JUvZELZhXMMrM8mqUqZaRTTS7/8DyoXvxPHycdTko4hzU3tUfg/jpdFqHurnuAqcl2rlI0cvHbCe5NAsV8sqj+9RHY5W1VDWgBKG6zeOoQh/AY0xx+ebRYj7FA68qBI35lVJBwTOjF0gBuhLmfZSVNHWPnVzqqj5qLJ2PuqanakXhv6O8yBkdRgjYfWvMtwJykZs5Hn6Wg4/uwE+gsVWBqY4JxeUsuapB3oTfg1TxLnVYQAGApqWH/aMlAwi/b2ygKozl7VkD/K9oK6OpOj+kSc8NXjlB30ry0= X-Forefront-Antispam-Report: CIP:69.169.224.1;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-1.smtp-out.eu-central-1.amazonses.com;PTR:b224-1.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(704161411799003)(61400799027)(32142699015)(376014)(48200799018)(9140799003)(261028144727099003)(4143699003)(5063699009)(56012099006)(5023799004)(261009223027099003)(261021121427099003)(261026140227099003)(261022105027099003)(10067099003)(55112099003)(22082099003)(18002099003)(16102099003)(4113699003)(5113699003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: OVRJKk4kjjyRmMwdGk1IGy3xpDgKrBV325WJb1KB/L/U7P6QediAQVktSgjbtk0akNZj4CQAx0NYd/Zy2n6vH7OdhWrmSmoPAXHdzbLso+KgXZYq6h+pBJhFvfuUKObxoqT/OSyPELzvNqrH0RakkglGmeqsvMUstW3Cqyjzh+u1LQdIwKV5OCxLaohPljQuEZhhmDKELV1PAOOOdLvs237BxMN/jxj2mg3dmQt+RWPQytkfpPCl16qEEXnxHlUrJl70vzVSnbszASyTmh/oyqhBjzzQRiZwYzUSFZPqKhwqLDoFYE3rFnAGvOv4W+MvBsPEKT0cCjaCUx2KZSb7W2/aB2YxSggTDy/G78w1DqVaMR3nafNgoAkyr6eRBbg4M4TPgaqviA3j8z0sXjxWy9mbHWtSiFJzVbizRvjFnz+zPX8KpPzz7pUrsoPC6ju2 X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2026 09:25:00.1187 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3ddd1cc9-799b-4eee-028f-08df359e8168 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: DU2PEPF00028D02.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6031 Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] vhost-blk: Fixes tag on a no-functional-change refactor -- commit e32c7620df63e11379f613aefad8997664c58582 Author: Alexander Ivanov vhost-blk: use a local vhost_dev pointer in start and stop This patch adds a local struct vhost_dev pointer, hdev, in vhost_blk_start() and vhost_blk_stop(). It replaces each use of &s->dev with hdev. The commit message says there is no functional change. Link: https://virtuozzo.atlassian.net/browse/VSTOR-107537 This isn't a bug in the code, but the commit message has a problem. > vhost-blk: use a local vhost_dev pointer in start and stop > > Take &s->dev once into hdev in vhost_blk_start() and vhost_blk_stop() > instead of spelling it out at every use. No functional change. > > https://virtuozzo.atlassian.net/browse/VSTOR-107537 > > Fixes: 0ff3cb5ff28f ("block: add vhost-blk backend") > Signed-off-by: Alexander Ivanov [Severity: Low] The message says "No functional change", yet it carries a Fixes: tag pointing at 0ff3cb5ff28f ("block: add vhost-blk backend"). The only edits are the new local alias in vhost_blk_start() and vhost_blk_stop(): struct vhost_dev *hdev =3D &s->dev; and the replacement of &s->dev with hdev at each use. Nothing in the diff fixes a bug. Could the Fixes: tag be dropped? Stable-backport tooling may otherwise pick up this cosmetic cleanup. If a real bug is being fixed, could the commit message describe it? --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/2026102909230= 1.3286535-1-alexander.ivanov@virtuozzo.com?part=3D3