From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11020081.outbound.protection.outlook.com [52.101.84.81]) by lore.virtuozzo.com (Postfix) with ESMTPS id F2AA58017D for ; Fri, 30 Oct 2026 14:50:13 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PrVieWXPcx7StwLT2GvJnsEgNCRXY1iJv18P+QhN1VVFeqyUuCyeUZV6yMPX5wDWzvCpr0qPhDsexPPYjI7wZL3XI0DgFgSKO3HvZ9kV2gnvdZFgFRXAFksAjaniukq0iDRot+FkyLjuxcfZks14SiJHD0/OJKxeWjWbMHWBGcoSeweS+5hJSOj/qFWVMht6xM79FHC2ytfby6QWoHSXWUB1aawZIEtlBmwmvj3j4OafKBbyr2nd5Ukqcr77ZH0IiXQeMLKoyUJyhfejij1PW3c4Oip7OZonRin+HhlKhFoXbocBar5G2GjWWNiso20a2YdXJ2zvjky1g1ek9Gz8tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZtcFV6RndBNw9SSHJP8JgZKSVBpXJT1nWSfAc+RVJ4A=; b=gYVKe9fjQyCni5ac+MaP1vqZO5bU350P++RxLwOESNFaP1h9ahrwjTRz3eHVq1HlEekWgTQKEr8h0S7qPMmlDnLR27IQoZW5pJQ0zmyh5lHZe8BH6t/FFMveH3lbbW6tjQpbUufHKUVhwf/x+q1SrYde12g+TmA+8INKemgLStv1ahn++1I4KpqKULcV1b+DWJ0z5FNGlTRFFwj09XSlUcBCZ5vgHDgdP9qYPKte1cPbOMYwcivnDO6zYLxOhqjJQQI2n4ZBvxPoKkuoFLUQAwheyJm+f3w09oHeC0lPzN3QqTFqycA5t62Ex3q31MCLCl1aDyzCpgg8ddaI7YPyBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.5) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZtcFV6RndBNw9SSHJP8JgZKSVBpXJT1nWSfAc+RVJ4A=; b=Y7XIG+45Wh1lTji1lV9UbFPVKNVqVKNEBuu3AydKLRwtrAa+EcH8v4iCJUGu/XmOpWW4TOcEtdGYEKzMPLmniLCk/6/JCNf+aoziJp5SARoV4IznhecLRunZ7RBMTuQ1i9lnyLHSOOVanK28+LIYUqsxWkrx2bM1+m9sPWv6NRE= Received: from OS6P279CA0076.NORP279.PROD.OUTLOOK.COM (2603:10a6:e10:3e::20) by PAVPR08MB9353.eurprd08.prod.outlook.com (2603:10a6:102:302::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.21; Fri, 30 Oct 2026 14:50:09 +0000 Received: from WA1PEPF00009B39.eurprd05.prod.outlook.com (2603:10a6:e10:3e:cafe::7f) by OS6P279CA0076.outlook.office365.com (2603:10a6:e10:3e::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.8 via Frontend Transport; Fri, 30 Oct 2026 14:50:08 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.5) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.5 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.5; helo=b224-5.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-5.smtp-out.eu-central-1.amazonses.com (69.169.224.5) by WA1PEPF00009B39.mail.protection.outlook.com (10.167.242.38) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.5 via Frontend Transport; Fri, 30 Oct 2026 14:50:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793371807; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=+HcR2w1FRyigBe9p6Bixy90QhN7FCQvuthpu80quWEk=; b=jaYEblvEpc1D/rnbiLBo2NxCjtbcTnqX4+8NNZnK2DyGNpVqboOhHvBbW+frekje XH5VQLsMaUdb7sijAe3LaC/AxnKijjSsNS3G+fuT97T8v5+vn4PJJRkxq0fiW6xx0RC ixqlULabhfe4+cLs9eMDGIPlK083c3fQJ59Rpp6Dy4TuREu2kRmlRL7TlFKjwWhirMY GSBBKT4icGDhUPLZmCGjzwdO/816D2MCbNgCfFy+JCkGbDVNNItcBd35P4+v8A7Yyjs K61w7WG26laoLovhz+RqULTK+P8Ws22x/SKc8csWwzgnF8r1ejQlN4ZcZiyidu4aPdT OEhX1k/ceA== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793371807; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=+HcR2w1FRyigBe9p6Bixy90QhN7FCQvuthpu80quWEk=; b=hadNtYRdsn6S8xx0sJ9yLU9kSvd9qydQc9oFarYBADipUrq7TWRuWH+ppujud0fK +MDVN/v+HC+ZPTYfZfmhL3iRdNa/OH6XznqoaHhoDqzWKxJq4l52S1F+h1K2Kdf8FMS 1rau2LNvSkrvAgKhBlfSuXP1lKRASuYA0rIZInzA= Message-ID: <010701a18d4a1f4a-6815a432-25d6-4b4a-841a-9e6b74fcf940-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v6 04/34] migration/cpr-exec: require a file or exec migration URI To: svt-core@virtuozzo.com, Andrey Drobyshev Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261030-vfio_v1-v6-4-45de246bc92e@virtuozzo.com> References: <20261030-vfio_v1-v6-0-45de246bc92e@virtuozzo.com> <20261030-vfio_v1-v6-4-45de246bc92e@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 30 Oct 2026 14:50:07 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.30-69.169.224.5 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: WA1PEPF00009B39:EE_|PAVPR08MB9353:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 472cd920-fdf0-4df7-baad-08df36951774 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|9140799003|376014|48200799018|32142699015|61400799027|18002099003|4113699003|5113699003|22082099003|55112099003|261026121527099003|16102099003|10067099003|5063699009|261022105027099003|4143699003|56012099006|261021121427099003|5023799004|261009223027099003|261028144727099003|261026140227099003; X-Microsoft-Antispam-Message-Info: 7cYXLenpGSuO2dl/UjJSKADWv3PyuRbDCaNOeDwMmP+qWFflcT9t9SK/aKl46z764oUSmWymby363H6zQH9LeGYk66AKYutzY9qAZqcjxpcyFud0VvC2dmsDn3ZxKslo96BB5TvGU/wBPLLQUtMltNDh/2znMztvrmgJDUQO5s+DWQG1tBjUmJR35sXpjr/UtQ+mki5tY/ZaMRdo8NVtxXg1odgQSpbYNgbnjBPl22rtTyFx6UIMy14d91v7/J8PGZHFkID4biUf9gy3ARg8dZhTnZLHOeRBy5eSyjfobFrfo29OYM0AqJcOlUWEGdBIEPi7XbQltIQQfSyUpFmz/Y1SQwDiS/+FEuLSnYaaGXdpR2eRSH5SJzFai/c4xvIpSXU9TIDFrTJ1mGrU2CG5t+dYqJIehRTEB1SZJTrzv5UAw8EodGvDxCjGXF9Da/zkOPNxLx9D3hdPGwy9Y/u07Y5vEJlUYRGRWroAWNv8oEbB6aYyv+yJcYCRd6f/hjEa9NN3S5UtWn2atJzIWe/ec6JGfLxG9o1M07l6AdDbrk3xD7/aBjlEbCGwWiZcxgk3Ed3CkX1qWEXBka2sNJnuj+pUyOTNsvN1Zi/7voXDyHRY/IOX4yIsNxtTniczfpLwMGpI7eM9QAaA+nXUs+bCqx5oTf2Nqdp975a/afhYth0m38QO0r5S9CP0bKzle8nVa2JZ1w/PvXzkNtm198+Vlh6cdTAN8qG9PPGJWr20Sw9XiZ4Achcg6uYBIpQ8cMC3/x8sj4n3MESiyDOZg+Kz6JHObxfjViremWxxxhWqA9DEv/u9XBxeXfZC25D5qmuHJbvHyEWx+MM3OxoEi65Dzyd81M3ZMIXupfoKdxrU7CF0B5hsrxGIZTXpWAPZo6ab552eCO4NWkL1yKBg84GijDQdueq7SbHzjx1V4xiVHI0= X-Forefront-Antispam-Report: CIP:69.169.224.5;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-5.smtp-out.eu-central-1.amazonses.com;PTR:b224-5.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(9140799003)(376014)(48200799018)(32142699015)(61400799027)(18002099003)(4113699003)(5113699003)(22082099003)(55112099003)(261026121527099003)(16102099003)(10067099003)(5063699009)(261022105027099003)(4143699003)(56012099006)(261021121427099003)(5023799004)(261009223027099003)(261028144727099003)(261026140227099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: paaXjYVqRDow/CVQF29lErjFM1DD7vDKUjLgE7IF2dKC2UKuJVmuotweadULazaV6Hg2ZZ+SVImp5Udc0EICCEZVyE6Np7XMT8MUzLCQQe1ai9D/0w6H6aDMUOmjfwi7V/qpr2xs+/g/XZoCU6UwOKydSwjrROE+nKyfzDumGZP/8/b3csKNuI2VRHfdO4ahfoSiHvzAc18iM6Z5wo5+AWrQrrb+x5tbl9u0IRX0QClqtggx3vjB236145hY7WJVJhq1eW/DyXuSMEJSIYWoNifiVkYYjL8SEymoJPg0jq5e1D31M13vDYaNaILvT4t3YF9wM3R2tu6675e0hbBQQpU6HLZsvokoq91gJnesnKN/tpMc9g/jUQIjJ8HZuNmzmhLRDSlGMOVm7ZSBb83u8WRO0dPVhD4PKIvU+P70oqBMEg/THjZ/i6NNWVq7RfBu X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2026 14:50:08.0634 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 472cd920-fdf0-4df7-baad-08df36951774 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: WA1PEPF00009B39.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9353 > cpr-exec writes the device state to the migration URI and new QEMU > reads it back after the exec, so the URI must capture the data: a > file, or an exec command that stores it. Nothing checks that. With a > socket URI, e.g. a save or a live migration issued while the 'mode' > parameter is left at cpr-exec after a failed qemu-update, QEMU sends a > stream without the guest RAM to the peer, execs the stale cpr-exec > command, and the VM is lost. >=20 > Refuse cpr-exec with anything but a file or exec URI, the two types > the CPR documentation allows. >=20 > Fixes: a3eae205c601 ("migration: cpr-exec mode") > Signed-off-by: Andrey Drobyshev Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261030-vfio= _v1-v6-0-45de246bc92e@virtuozzo.com?part=3D4