From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11023112.outbound.protection.outlook.com [40.107.159.112]) by lore.virtuozzo.com (Postfix) with ESMTPS id D4F5081065 for ; Fri, 30 Oct 2026 14:51:13 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=d9AFoNvGFB5yKjkv5+NzLDgqB1mbp+wU4JRn8qCayLpdkUOJMjj0nzQ3u8O0lKO5k+z/bcB0wn/Tc2Cf231iEL1WmeHa8WzXXNMo/X5TyFfp7TOTr6e+dXErTwBEnFO35qRD+hVL73sVng4TAG7XoTmZGF3ykH3xdik+ViSFjNugh5C6eGATlEANd+04KiCf6c4pYv9feGgxnEnH6/+Inkpai8CAOjyEhMle+B0yjve6EdNqE5cjOtV389NjBxwdDwYsxh0JI17SbD4C66n71Hbkfc+SxBqysCs1YyvL/r1T/mMpHvpxOHxw8yZC5JCwpaEjmfxLDTFospvFt51tmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XyYWEjVvKvFjNXU209arh/dsdlubItx/FbcCCsau+aA=; b=RfZiSjc18+Uy7yMK5Z/L0kyosaF8tiqQy1bww1JkMp20xL4nWc6iqYYBqb/UrHldjsxoqwNyiBdeiYcqCVIGurgfLIPZw170Ryd7Yd60IlMevLfLweSZtWSUaYpgzMXvjChJv2fCANEpk6zYdOIEwYC6fRwgUbMr7ZAky6K4U6cbXYpJ5mGasakqOsLBeQQZbhl2GOiFzs3CGzrV2gfiPTa4ZdN6uVhyVIalhDQH9t6gh56qgW8iOjgjPGHZturRyTGyPQ+nSPQOg5mhI5ZBCM55dIMsbdR9XEiOXuZGW2ABHck9yEVdat6g6V/4Y0NbvYLxlddtH+uCtPS9XJ0WsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.2) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XyYWEjVvKvFjNXU209arh/dsdlubItx/FbcCCsau+aA=; b=M+Xw/Zf3tI9vNjY7DRbB0JbHTQaOzrQxxgUXMz822dUoFqADlGK25JOvrQPBJXsj5m7rp/15yA7oMlKtqU8e6CkDkAFWayuyTS6tuoTjkJ9I9IOL3KRNGU9FQ9IGs/5BID3SorLRM1yTGsgZ4RkjXe3jUDwQal4B+KgwhH5KoVo= Received: from AM0PR10CA0028.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:17c::38) by PA6PR08MB10622.eurprd08.prod.outlook.com (2603:10a6:102:3cd::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.22; Fri, 30 Oct 2026 14:51:09 +0000 Received: from AMS1EPF0000009D.eurprd02.prod.outlook.com (2603:10a6:208:17c:cafe::6b) by AM0PR10CA0028.outlook.office365.com (2603:10a6:208:17c::38) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.9 via Frontend Transport; Fri, 30 Oct 2026 14:51:09 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.2) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.2 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.2; helo=b224-2.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-2.smtp-out.eu-central-1.amazonses.com (69.169.224.2) by AMS1EPF0000009D.mail.protection.outlook.com (10.167.242.74) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.4 via Frontend Transport; Fri, 30 Oct 2026 14:51:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793371869; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=MrCFZnNXikIIIgZKH7YusonyzoZwSh26pAHuWXpiHG0=; b=Y9xgSUKcoth9RuM3dZ2i1S8JeYIUKRBSBkD0aziZv934zPNEBZpLmKts/KG3G7f1 tb/YnB2fdL2GSXEOi5MkI1/6We2rvsISGpUxO8bcNxkGeZugc7c+r/0dFyVnzhIAEWk zC4Haj3Wg23go8zn9+fuVim9MugHkboB4jxyJYum+pYjevH0JUhpXjC+VpvG0/e2d7t HquPDNf5QLTfiOStn2MHgJTi22XvvHHhCmVTZzgLxi9gT3/xb9xDmqp8EuN+RR0y7Fw EtCnXhDIF90GKLt0YkgTbaEFagQzi+67d3LrAELQJszxZRIlP6zQFm1AzG6MS5S1/qW H1ZMCjeVIQ== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793371869; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=MrCFZnNXikIIIgZKH7YusonyzoZwSh26pAHuWXpiHG0=; b=m6sSPGCZp37WNU+AxQNINy2FOOuAijAyGmB8Sj+lqmZICeUC7ONEM/OrT8tKto7/ bTZVPw6HPqlfSolBJm5u803tGQfDPBIMB7OfWm76UBbd5515gHEn/xeO62dQvixtr3v hxXSd74sXxl7PMSvECcLToS+H5RHXOC/3pvtFNL0= Message-ID: <010701a18d4b0f75-e35f8672-50f2-4f3c-8fa3-587db0bc3b8e-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v6 05/34] migration: close the CPR state if the outgoing channel fails to open To: Andrey Drobyshev , svt-core@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261030-vfio_v1-v6-5-45de246bc92e@virtuozzo.com> References: <20261030-vfio_v1-v6-0-45de246bc92e@virtuozzo.com> <20261030-vfio_v1-v6-5-45de246bc92e@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 30 Oct 2026 14:51:09 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.30-69.169.224.2 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS1EPF0000009D:EE_|PA6PR08MB10622:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: a078c1c3-bc41-49bd-3bdb-08df36953c0c X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|61400799027|32142699015|376014|48200799018|9140799003|4143699003|261022105027099003|56012099006|5063699009|261009223027099003|10067099003|4113699003|18002099003|55112099003|22082099003|16102099003|5113699003|261026140227099003|13003099007|261028144727099003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?S2pEOUZXL0J0QUI1a3lBajFCWXNEVklDdmhwV1h6MTdrUWtsYnBRemFqcWJv?= =?utf-8?B?WGFHVEZHNldyNmoycXpudXZ2bEhtVWlwSzJnanM1L2h5bk5ucFJYUzNycHJY?= =?utf-8?B?RnA4d3JqSjBxMDhlZkVJaktuSmdERmxJMWQybjR2YkZ3VWdicFd4Z2FBQmQ1?= =?utf-8?B?YVRta3JYb09wcjNySWV4UlJET1owTFZiK2pJWTgxVlhHM0VEdnRHNCt1K295?= =?utf-8?B?cHJHS2FvZ3duMmphcVh1Q3lhNkVoMjB1UFd2eEpTcU1DL0lxVzNTRWs2MWtO?= =?utf-8?B?L0RjZGtHaDBKdmlxMlFCMTBlc2NTeVMzV1h0QmNYR2lHTEVhNnFQTkh2b29w?= =?utf-8?B?ZDI3cVlXSS84ejE0WjBSYXZQanhzTlJUajE4cDZUajB5VDdWS21FODFGQ00r?= =?utf-8?B?OStoSXkwQU5hU2VhbTVGZmhKQjRUTUE5Ym8vZlFYM2lkaVB4RENVd2cyQytL?= =?utf-8?B?Q2I1c2xYOFY4eEgvNFAzcklQQjlZckMvQUZTaWdaTm5xRC9ReG00dE8zY1pH?= =?utf-8?B?MzBVRFpjekpHc1lxa3hCd1N4WEtrSW5udG9HKzNFRXg1TmxJUnJRVE1KaXU4?= =?utf-8?B?dytNcTMvTmJVcWlCaGlsMW9KZk42M2NaTGxTVUJYMXRVaWJ4dWl5aTYvcTZu?= =?utf-8?B?UFYvQlJuemFxS2pNRUJqNmRaUEhWNGRST0V1UGtTM2pYYW1seldFY3Q0UGNR?= =?utf-8?B?WWZuTmczOFlmWDY1Ylp1M2lGTW1PcWxienZpWmVKbnRQdWc0Y09UcHluUVk0?= =?utf-8?B?ZUJTQi8xc2FOVXloSys3dEJWZm11dW1jdVh4Z1ZnWC8wamRqOEdtbG9weEti?= =?utf-8?B?Sm9pSVVGQVlNQkQyYlBvRGgvRFpZcDkrRkRiMWN4ZWNEWHBGN2ZnTEduaU9h?= =?utf-8?B?dWVZL29VbXpPVU93eHByc3JaaFl4Y0xaU2YwVlM3YmpscU9ncVo5K3dVdTlZ?= =?utf-8?B?bVNaUW0zQitWeXZwZzYrQ1p1UFVuZFY2azZkVis1cndOUlB0YS95OFhnZTlZ?= =?utf-8?B?WXZuTTJLZERORUFqWjB6VkdjN1Q5TS9wR2o1cXRNb3BKdEtTaUJGM0Z1QTFx?= =?utf-8?B?aFUwM0VRNW94SUJUcUhzVy95WTZBc2gvSkRhOTF2Z01UeFQybmNYYVVPblln?= =?utf-8?B?L29Ic0dTOHhkU0RzdkVsbHRjMCtBUEM5aWw2RFdYQnV6Q0x6MU10aHl4RER0?= =?utf-8?B?bXFUVTNPc0dNZkRGUjJpVXhYNldWY0dRZ1o0YXA2Zlg0WkRJYW5RSFZkYmdv?= =?utf-8?B?TjNjVUFaSTlFbHBVb3NKNlRaOHE2amllMXVWUzJySVlxSGJZQitqYlVkdzZv?= =?utf-8?Q?iF2Q5s9JM+1B8=3D?= X-Forefront-Antispam-Report: CIP:69.169.224.2;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-2.smtp-out.eu-central-1.amazonses.com;PTR:b224-2.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(61400799027)(32142699015)(376014)(48200799018)(9140799003)(4143699003)(261022105027099003)(56012099006)(5063699009)(261009223027099003)(10067099003)(4113699003)(18002099003)(55112099003)(22082099003)(16102099003)(5113699003)(261026140227099003)(13003099007)(261028144727099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: HgVVgMjIovjN3lPgrBqXZoI/O6/zVNegoCrPdRGxPGg10RAjNJwva7ttS6cAMaWNq9YtPX6iIn2+RdcyA3tIErnaQ+S815c6Ov+KxvO4Qeo5cpgen8H/H93ox2O9TuHaP0zShllk30CMg9OvNliX3p22u5eEejgO2uVcWB9JG3nIqwJmOZoWXdbbOfuFiAAJmVog7BpfVd6SEHc/MDpYBNV35dJUMdbW7J5y1WRnYXixvxm1ZHlehreHnuNES/slS1+xwTcdGAr3No2sQXj3fbk51dA2KLAT8/PHnnJe+3CQZifvR+01jdOHZ5K/mlx85GlR+7JuLzW4mBu6i/V3IzdvBeU5axARASV7lUdJqUIAAwgxEdPewiu4ivvvyVVoGLNfoAC5gXxjWvA4Tba/07qvDJZdzkYUUxrGkscGcu/iSiUdoJOhRQWlD+S5vlHy X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2026 14:51:09.4618 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a078c1c3-bc41-49bd-3bdb-08df36953c0c X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: AMS1EPF0000009D.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA6PR08MB10622 > qmp_migrate() saves the CPR state before it opens the migration > channel. If the channel is a file or an exec command and it can't be > opened, qmp_migrate_finish() returns right away and migration_cleanup() > never runs, so the CPR state file stays open. >=20 > Close it there, next to the yank instance, which has the same problem. >=20 > Fixes: 624e6e654e11 ("migration: cpr-transfer mode") > Signed-off-by: Andrey Drobyshev Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261030-vfio= _v1-v6-0-45de246bc92e@virtuozzo.com?part=3D5