From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11023083.outbound.protection.outlook.com [52.101.72.83]) by lore.virtuozzo.com (Postfix) with ESMTPS id 8A98180E7E for ; Fri, 30 Oct 2026 14:55:01 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SazAc0LFEgc3o/DbjA8n/jrRZTXR0fXBnvQwFfynWJULVg7CIgauZn32XTM5QN/JDD7BKOxJYwDi+5fSMDyqMBYnP0qkCClMD3Z+P8tVPYz1h7K/87ZebE7twO55YVS1Yw2SWp5ktOxqzhZeYq82wt5yUTm9Fxmgp5HDWnRi3zS379x393i91WpgOKoFBmwRWBUXMHrFHSCVN3Ppa8EN+fZ6s5kRZ3YNYvBbpfPlMHEOv14YTKfJLdR6y8DHuJyKVFhws5FfjbND1JoJ5vO2vC13W4aklr2hRHssO0SkWaUz6D6Vzt3RZWSXaHEsHDAtVNjNT4o+8AlQW/auf18x7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9rOW3BYuBYIy/fhT+xH2rv+YGKWLrlWc305PJpGBrgE=; b=fs/Vt9UvsGspJ2vUDJzHU+NqXzokC6w2SMbwp6oJoofo4ghxg8G8V6ukxu4MP/u7G/JtO/GzQ1ztBVTY1MVb0miKuTFqdAg8WzZeNkLRIj27aolVFRvzI9HT1i/LUx4wLUSrZYbxgl+uT1i8gdijPE+9qbuk61WwP7ui/XBsWEq7lN/Jf/qbX90P6P2v9TcBDUTcy9xaxJyrXrDLXQwFA1NFvDW93y5rJB5TtcmC9+vGwwtRoPVg2IXlTEWbp6zeEkZ5++agAVrQIUy6tN7o4BGdPhf2UHrJ6imzWBet4mBZNgvM2+mvXLrUf1RYpqJN9agpK4fce4ktBqj9m7RY+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.6) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9rOW3BYuBYIy/fhT+xH2rv+YGKWLrlWc305PJpGBrgE=; b=gWnYpr9d/cYGSzuGGa7LDVb6PSIlkpokGehB3e5HGsdZ9l5IYvH7BjDlnZpQduQ40KBMZdeWgpA21JVczKLSUTcbZj7qn3t7kIoe/bITI6ZhxY6AZzocIquJN5AGUdpKfS4zqz4+9w4E7GdsX67ZYbWRZa66/R9zl0vvf9TmZyE= Received: from OL1P279CA0059.NORP279.PROD.OUTLOOK.COM (2603:10a6:e10:15::10) by GV4PR08MB11250.eurprd08.prod.outlook.com (2603:10a6:150:2e9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.22; Fri, 30 Oct 2026 14:54:57 +0000 Received: from CPH1EPF00000528.eurprd05.prod.outlook.com (2603:10a6:e10:15:cafe::a2) by OL1P279CA0059.outlook.office365.com (2603:10a6:e10:15::10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.8 via Frontend Transport; Fri, 30 Oct 2026 14:54:57 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.6) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.6 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.6; helo=b224-6.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-6.smtp-out.eu-central-1.amazonses.com (69.169.224.6) by CPH1EPF00000528.mail.protection.outlook.com (10.167.241.139) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.5 via Frontend Transport; Fri, 30 Oct 2026 14:54:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793372096; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=XaLLF++LDlkUiEiuiKLt42Q6flvOwea1hBsi4YX9xM8=; b=VGIBV6ZFvKBimCgfmzpbY1nyhbjTv6kkNiIUPwSMUwzzl/z4CpyVxOzmCRV+sn+f fCPG6BrnXEY8YJuqW4cFXN66jLAek0hrVC4/9PcR6Uck3JJ5TWUwOCxcArJjYkC+kF5 uvattWwcbHA8m/3S0f4rYTNpXzhCc2bP2yK58cM2tw/lLFIWVKCUOxKC8v/1ZrUzbZp DOiwDbwtbhhvxthTTU1eOFydN+3oMe9G9vULUJWnDJr05OpuDLTLTle392ZIUPf+ZYh yKeS0/7L0/I7p2a508o+c8y6kcFdPDFsakdvNbQ/Ckx2KFP87VPhMhtHoNGRQbEQq33 B0dO6WvNzg== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793372096; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=XaLLF++LDlkUiEiuiKLt42Q6flvOwea1hBsi4YX9xM8=; b=Q/0JPQa0uyWee7Tda2+Fwd1ZZCh0RCKwukLuTgztY3Q34HtYL1wiXb0gbze4ctke oPenqh1kiJGroo2Fv/WFi5SEi4ihz/GogLwqC0tFeI8n1rCv5/vxL34I7VPW0Yj+Kg8 HQyyH9oHExFKDBFz93ZkfFYSz1l3rQ4Mf6clBW8M= Message-ID: <010701a18d4e86c5-ddd8ae52-0785-4028-b997-0968f663fff3-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v6 12/34] vfio/pci: Initialize rom_read_failed in vfio_pci_load_rom() To: Andrey Drobyshev , svt-core@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261030-vfio_v1-v6-12-45de246bc92e@virtuozzo.com> References: <20261030-vfio_v1-v6-0-45de246bc92e@virtuozzo.com> <20261030-vfio_v1-v6-12-45de246bc92e@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 30 Oct 2026 14:54:56 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.30-69.169.224.6 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CPH1EPF00000528:EE_|GV4PR08MB11250:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: d149fe45-5f53-4044-d219-08df3695c37a X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|48200799018|9140799003|61400799027|32142699015|261021121427099003|5063699009|56012099006|10067099003|261009223027099003|261022105027099003|4143699003|4113699003|22082099003|16102099003|55112099003|261026140227099003|5113699003|18002099003|261028144727099003|13003099007; X-Microsoft-Antispam-Message-Info: m6ix50RjmzHaVHzM1zFZOdGV7JOTuc2VaIcmD1Wtvz5jV4jf3OYuBbuuASmozunR7ZiCStxzkA0AD6PWKmpQwyv0N1kZQyNiQWv2tz/m07wuzf9MamADHBXJV+15ODgxNXLvXWZIPTeuqdHte6d9RdRKU7OwyxSJxeYnEGOMQWJJ81KWvisSiIoKZ8sAKrBtWI5KYDwKomMLncm5qB4i+3Fvo8whCdGK/eq2SHh+k9DvznRlqRNvLHQzhnzNsk+gL5lKy2AP4fJgXqBkJaeJImsfVAJh88bU/3aLxamhmPkfpOuuBoh90ZvCq9iYJhcpYtED51jOhkoQLb3LXGdGkNXmJk9qZ6UOh1Iy2KD3MZ3NX/KEb6a1KrNhDCWOkQc6L+RVB3CrApwSU8Q7emKGP6Tag0BcWlRJ+iFqUnmkQVrCKrUj2IyFXtrDMf0/ePTN/peZHj/68xX+XBcH8UfY+SEBg2jypRbx+GywgidOaq8tCg4yD3uiJkorbinCnrlMGlub17GML7eftd49xRsYC6m36e2YhybpD0nAY+T1BWBTznf4mA7mwc4KTJB5NtPoaQNRcu75OIaLCsQelWGv85TqUXHAJn7VoqMAXjvzR4rKgbZ60xk55UQ+6mny315GnQ+HY0OLee9ygCnhXmILKTHAu5ZZkw4RBluclY7KnubmFQ9rgd8kkGCoAz15tmg/XiWB7HdEYhqs6OSNOas5SgJ6U+YX6xwKVaeeM1WLvXlPQbO5TJnEyy5543OoLPBYGr8SpoZd+Rawc00aXcMpwgSckAuUnfVLcgWRFsDLixLBw0Aq/zk141Vx6XaXhve5lquLy2B+mNU/MqQhT/IA89HxOWZCcuP7Jew2Svq0OVtERmZFFMg9TOedklyA1BlH X-Forefront-Antispam-Report: CIP:69.169.224.6;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-6.smtp-out.eu-central-1.amazonses.com;PTR:b224-6.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(376014)(48200799018)(9140799003)(61400799027)(32142699015)(261021121427099003)(5063699009)(56012099006)(10067099003)(261009223027099003)(261022105027099003)(4143699003)(4113699003)(22082099003)(16102099003)(55112099003)(261026140227099003)(5113699003)(18002099003)(261028144727099003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ONdQyygTiv+QqDVLBUEM+0cUTz+kO9ghF3uhampTwpwuo2rY9t/GeVuPN5y6otFMxHIBSM34ndj0oQ2t6AMGQis+EqMFJw81nk1XNQRWGHE4VL7tjNWvb/5dzVDxfk21aFtqmA8StryWkyiLHi8WM6rANLNL/CsQMj/sHPoFAoQzwArhzsV9Cqbo4Jn5o/6vBc65PLFjw2fsTI6KTxpVwEi0d3AhvZRnjFjHzy+u51vz70v95W9yiwrUunfil/5mhV9Psrytx1R8QnLBTPU8+sgSpbk/IiiRpOwcQAJ/9lu2rePg3wsirKsRlsxYuhJs8hx/kYG/0WvPl/1xcqhPGW5NZtqKviCyAPl7+DNZuWtiL1OZzzvFdketNDO0hIk6sefl5IBU171o5Ih34XaFMvBexQY5Vh4YvVeomRQmJlH4B/Sxw1GCM/HwmaZVg+RS X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2026 14:54:56.6667 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d149fe45-5f53-4044-d219-08df3695c37a X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: CPH1EPF00000528.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV4PR08MB11250 > From: Mario Casquero >=20 > When vfio_device_get_region_info() fails in vfio_pci_load_rom(), > the function returns without setting vdev->rom_read_failed to true, > and without allocating vdev->rom. This leaves vdev->rom as NULL. >=20 > andrey.drobyshev: > This commit is cherry-picked as-is, with no modifications, from the > upstream commit c822ecd80661. >=20 > Signed-off-by: Mario Casquero > Reviewed-by: C=C3=A9dric Le Goater > Link: https://lore.kernel.org/qemu-devel/20260602070857.356526-1-mcasquer= @redhat.com > Signed-off-by: C=C3=A9dric Le Goater Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261030-vfio= _v1-v6-0-45de246bc92e@virtuozzo.com?part=3D12