From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a18d549b8a-4bca1d6d-b124-4e92-83a2-2b9a8d7f7a35-000000@eu-central-1.amazonses.com> Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11023120.outbound.protection.outlook.com [40.107.162.120]) by lore.virtuozzo.com (Postfix) with ESMTPS id C4F4F80F25 for ; Fri, 30 Oct 2026 15:01:41 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bjfjmDo+1nF0Fs6kkNuSAaV5u/9FfhLRP5xd/bsfBdr7duAwQqjek5NiV0vZgyv+c0X8qeU0rEa7AR1Ja0vD/c9rnidDM35g5PUimBCPSS54/8zRVj7Mmg9mifMCQMoP3zDDoD+39TbmqmjItTYrDrc384f9/qMNWQBPqTy0+4M+SFhmkXqrO4iQF73b/HF5S8YC9V4XEiw4JD0mTW5Pyv0X00ISXGoZqPI6NBtGMaBnRu2gzBxluN8E5VFx1F7jeAX3Qi3FJvgpoOEYVq7cXjQA8vsNCfKnzSWdSRa3K0XLnrs/r3glrXGbYi74KCwlTD/6gasfpgF6o2l9pnh/zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VYFg8syxAzFCzDAOCW4bAlV7lMCFzoNPeiZ9JrKtEzQ=; b=GhTviX1kI81gM3ObU/5LMrRVHIBn1tuw/fq6QTcRo5izt0hj1rYOr/W5kli/gqlTuv7Aj5LinBV7biU3n2V8Q/IZqX+iD0rKeDl/mGL96oAE18S1Su6w6TR6UqnZV0hZdGfq6OWrE2GaPkco8Ook0J2dKCwplpQRMc3K28hGuhAA7qJFdHa+/Uo0537q6kaLT1rB/NkE+dwFmC+KYg3ddjAcqQkJcMXC/lTaqM6KQGM5JbPl+0LucCRGWHUYWZwdHqw375XYqsPlLRvfujzPnSWKeSyvr2yXKh8xxmFzndS4p4ZN1vYCA09dhC0m8t3tgjMHvT61GerzuVvh3YvlMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.5) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VYFg8syxAzFCzDAOCW4bAlV7lMCFzoNPeiZ9JrKtEzQ=; b=A+PwrxhXYBfyidq9NBELbtCUfJpHHFhhODbGICjyCA2orUwRF2aeoQnhnK5XIIo59h1iuu9UuzzfAGfZvHPn1GhGVinMsrFLOXVTEWty2WzyCmQ6QFRJTAkXW8U3o9SQ5ufBViOkXz2T5/pRUKj3DcT+LbKWrEflYIgGiv4PFRM= Received: from DU2PR04CA0234.eurprd04.prod.outlook.com (2603:10a6:10:2b1::29) by DB9PR08MB7471.eurprd08.prod.outlook.com (2603:10a6:10:36d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.9; Fri, 30 Oct 2026 15:01:35 +0000 Received: from DU2PEPF00028D08.eurprd03.prod.outlook.com (2603:10a6:10:2b1:cafe::12) by DU2PR04CA0234.outlook.office365.com (2603:10a6:10:2b1::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.8 via Frontend Transport; Fri, 30 Oct 2026 15:01:35 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.5) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.5 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.5; helo=b224-5.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-5.smtp-out.eu-central-1.amazonses.com (69.169.224.5) by DU2PEPF00028D08.mail.protection.outlook.com (10.167.242.168) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.15 via Frontend Transport; Fri, 30 Oct 2026 15:01:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793372494; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=u0rcLg9LYZX6nTg1qU04pCBLNi/wxDLXb8MI1vSGDUM=; b=epdjOl3KyhsNnYY75mvcwAeUZMFkKCXiofsq+6VeeAE/9iloLWiNxXBw7Fb9HrY4 +bUXplmxuVO6zO/lXeQZ4g50DpnMUUOhjbL6XbokI2E1GpnwqaV81uH+f0v1wpLzBJk Z0gcmzTFc7dafbnpUwt9s8wwBXLQ/WImfOjFdsiuIMA7SfEsaepOhpZBXjgAmJjlBft iqptTYqpeIRUi9Jy9BXNyy8d8gJyVEGemhYQmOYlg58PQGfVonr8puUQh+q98oJAlgE msoMW/Yvlvvfjybfp2e3qlD+Nqhew+rsJV3o8mDelOooBnBCHwX8S4M97uqco2XalUB 8ujljhiZ9A== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793372494; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=u0rcLg9LYZX6nTg1qU04pCBLNi/wxDLXb8MI1vSGDUM=; b=mtow92y7DmMT1I0/lM33zwj5uE/e6yMjB/8jUPRSoEmmd+mWeoxDu4NT1VKt+Fo8 oKZecLIqVO1mHU5AE0YZgPoASefEfCvdm/XWLIPL/2Kgg28uEyQmd23Bju27Fs+fj29 ocOuDbX63oAavqQr6oi2HOMMi/OhGEmNDzsQWfA0= Message-ID: <010701a18d549b8a-4bca1d6d-b124-4e92-83a2-2b9a8d7f7a35-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v6 19/34] migration: Free cpr-transfer MigrationAddress along with gsource To: svt-core@virtuozzo.com, Andrey Drobyshev Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261030-vfio_v1-v6-19-45de246bc92e@virtuozzo.com> References: <20261030-vfio_v1-v6-0-45de246bc92e@virtuozzo.com> <20261030-vfio_v1-v6-19-45de246bc92e@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 30 Oct 2026 15:01:34 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.30-69.169.224.5 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PEPF00028D08:EE_|DB9PR08MB7471:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 5eacfcf3-b65f-4fa1-e21d-08df3696b10d X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|48200799018|61400799027|9140799003|32142699015|4143699003|5063699009|56012099006|261009223027099003|261026140227099003|261026121527099003|261028144727099003|261021123027099003|261021121427099003|261022105027099003|10067099003|55112099003|16102099003|22082099003|18002099003|5113699003|4113699003|13003099007; X-Microsoft-Antispam-Message-Info: Rnmx15GhdaZAROuY6Ma6ADjtcQyFOmwHJkjhnGdZkZuRsSAHkVKVJR4ms4lfMkKa0wod/r4aXFNl/i6Qv4wqgYipODZNBI20p427Dvp2ybVlWbDvdMlZafjmqFJP1dZn7e0lYxZutinaOl8Nuzu24lsMfzH85ydBp2sr5TNynyUfDdN3ZQC0xEARnlAtHBYvzsJbKEATgYIqd02+qEYr4IrId3CWulNeSxtxLUPkKV6T4lSG9rn7QvlefG43XJ13KcjHY+bU0FZ8dCoBhFrXbnn8ZlwtcTxD3hKDe2hcCk2WbCP57Ivl3cjg7+R776y6ipE6UnYlE6hXn+BMYIc9k0oiDdl9+nmicuySUPOMRcPpNgx3M6i++gbwnEhWEnkSRF2+DcpnlDstukEroy7bdzEa5Mf7huwZG/rPOM8elgt0G93xdDUgItOMjtQrg4nzezpYhxYsoGYATAociiNZmTtWvgMOXzkglEi2OiMKAyP0MepmdZTijB9br7I5/nIbAqWfTChonW0t48bOW+UUFiRkPpyx5pJI+spZN03cIwcUhPDJXieURpe77QPHPkaUK5mZ6e1BYGCK/q9IO6uNj60TgO7SIX15U99aLRSi5wVfulB7bWBPO4hRe8SW6UtkSIcZlMMQIyVH657rh8HhSrC3YQmNNFm9GA2QPQADZSqr+5aH4ZLDYPrDEdnJ0Vv9dCcUz0y26wGdas0uJWyfAv0aiGKt3DQLozVmQPLrjHS9gpaY7PvRsf/JXTgW9cW9Tqv00zNIKJPRgjn8MMXFJeC85xuhdb+hp9oTp2DO14sOJNr1JO5Zp2NmgdLzEJ/qiIhj4aJOqSJ7b10QLvzOar9uYj+3xDodWV8CDMRTwSDvll2AbfaKqS0J/8ADjgxG4Vbs2KwAzV2YgN5y8scKe27X0kHi3CBFlCkm5OAWnTeManB27tsUGVwo54fwKNe8 X-Forefront-Antispam-Report: CIP:69.169.224.5;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-5.smtp-out.eu-central-1.amazonses.com;PTR:b224-5.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(376014)(48200799018)(61400799027)(9140799003)(32142699015)(4143699003)(5063699009)(56012099006)(261009223027099003)(261026140227099003)(261026121527099003)(261028144727099003)(261021123027099003)(261021121427099003)(261022105027099003)(10067099003)(55112099003)(16102099003)(22082099003)(18002099003)(5113699003)(4113699003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: LHyqDD5MnzCi6Jx0O4+zx/RhXy1AbGYdIXpNEni5o/07vivdEvkB/avmN48RcmuiNbmFmmCXqWcg9Jb1rDCURduwUUnD76LhZab7mjmbMQWVUisZbD4oEYqjnICf8o7+FBQt7LfbRbo/wHMcb7qTib9CGW7pPvhgJH0unAYWmYIjP9zfyRxSgZ9zyo9H0oCIKOPMWRtzoHlkwcdy8cMl0aAErJL8illAXGO+997BctLaK/asCCsXVh7ID8O305sqqTtm/ayTJBV3/iFHz198oBLT8qfxHcQZwGpGR1v2vXKlexGySVeb2Zz35WcV9pLKbxLvsd/wdOOQGFKK7LxoaXbwqLjKaJCiRS3OUjAOjEOeOpbAhQ5bC4wRElhsMsgP4iuv3K+3gQKWkHZFmgo6TGOvFqlRnVbIJrBVWtN0Av3hTloxSQrxN3J1auc2xVYR X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2026 15:01:35.2505 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5eacfcf3-b65f-4fa1-e21d-08df3696b10d X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: DU2PEPF00028D08.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7471 > From: Fabiano Rosas >=20 > When setting a callback on a Glib source and giving it a data pointer, > it's natural to also provide the destructor for the data in question. >=20 > Since migrate_hup_add() already needs to clone the MigrationAddress > when setting the qmp_migrate_finish_cb callback, also pass the > qapi_free_MigrationAddress as the GDestroyNotify callback. >=20 > With this the address doesn't need to be freed at the callback body, > making the management of that memory slightly simpler. >=20 > andrey.drobyshev: > This commit was cherry-picked from the upstream commit 6a887119ce18, > adapted for the hci-dev base: qmp_migrate_finish_cb() here still > closes the cpr state and deletes the HUP source itself (upstream had > already moved that into migration_cleanup()), so only the explicit > qapi_free_MigrationAddress() call goes away from it. >=20 > Cc: Mark Kanda > Cc: Ben Chaney > Reviewed-by: Peter Xu > Reviewed-by: Prasad Pandit > Link: https://lore.kernel.org/qemu-devel/20260123141656.6765-23-farosas@s= use.de > Signed-off-by: Fabiano Rosas Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261030-vfio= _v1-v6-0-45de246bc92e@virtuozzo.com?part=3D19