From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11023109.outbound.protection.outlook.com [40.107.159.109]) by lore.virtuozzo.com (Postfix) with ESMTPS id 1976C80E7E for ; Fri, 30 Oct 2026 15:02:04 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lHeiUq45eMkcB/SH116hDJFfXjQhbLGnBNMKN8yHyoSnPoiFlK/55Gx2KwaFDcjwV5RpMd/Ksw4Bn+2c5RpwbEZVXi3wicX+71WTeKIFY80spAsNIM4KFxwy8LZG4AMjg6Hru5r+W4qbfPNlGu+H8wFkUXGsfgrWNPySI5FTB1nVM0uooUtBoPQqFSVOW8TEvtnAgJybgnwdNvtH93E4rGgC5IieJ4BswsCMyXbj+UdErevWqwKAN7H9ltjYwfTTMDdN3xoh0hDJRqx0Ord4e4ZltIg9g51hOKFbE1pouNdmKjDA4drEaNwoDHOajL9nulnnltaIa3AdK2bB6Lrq7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JwBcYiwmChrBvULKwLSf5ARtqMj3GW005rHy7yx2Hi0=; b=MKmK5s0AJv6RZYR5n5uQ60gX3xtnL7hWUNJArc1IPI4A1HxrSZbh+8YD5z3H0A6F5eXqpA8Fqp/w3/GUUKzYhBqsJyRZLqDHXE7R4/g/Giu6LqVgoGSb9Lu44JhGWmaKxYt1F1wieu4d6uIC+tlaaZaxDIYpH5rKpT2ITPKiya4T+kM4XmFiL1HdL4p3PT7H3DDQzHUpTf4W1v5FNwl4auqoD/coEy+RfL2kVO5qDoaBSkL7HDKQPu31nG7MSXP8YiWq/DKvX6TniR1ebXqUiuY1/A2EoZlpB/IW1v2rGYU2W2mJ6EHObnsOv7+bpnvtoL7GWLRw+o70+ieFhIbrQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.1) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JwBcYiwmChrBvULKwLSf5ARtqMj3GW005rHy7yx2Hi0=; b=HQSYBO9a9mRFpyD1jLKmSOEjLaZeEY7Dr0JJmE8VX0BsvmvTOmL04/PJ0um5tMDCJVFhkQBhshvSnK3x9Upm/PG73hmolgLww+xr4khzmfRyeB3LklvJFeccMagQP0U+jah81wdgqwr2VGzxKJ0AY8pXfE3HvhLwQq6nQJoT3A4= Received: from VIVP296CA0109.AUTP296.PROD.OUTLOOK.COM (2603:10a6:800:355::12) by BR2PPF72BF2E8AF.eurprd08.prod.outlook.com (2603:10a6:2d0::20b) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.546.22; Fri, 30 Oct 2026 15:02:01 +0000 Received: from MI3PEPF0000848F.eurprd03.prod.outlook.com (2603:10a6:800:355:cafe::97) by VIVP296CA0109.outlook.office365.com (2603:10a6:800:355::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.10 via Frontend Transport; Fri, 30 Oct 2026 15:02:01 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.1) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.1 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.1; helo=b224-1.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-1.smtp-out.eu-central-1.amazonses.com (69.169.224.1) by MI3PEPF0000848F.mail.protection.outlook.com (10.167.240.150) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.15 via Frontend Transport; Fri, 30 Oct 2026 15:02:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793372520; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=s0wbAI7vtg/swQKf6WjlxxgyiVLWWjGDFiiVSgjqPBM=; b=gMXgpVMI5Rrv1c9BZT3m/schJIKVu78Krm0kKn6R+w0jXT9FT7mMvMQgjvEaKEhb +wHMjt/6Lx3YI6CUaZwbXWgJuUsBLmuKuLPaNUjQn4f/89WRmps0W9ELBR7rZtr7WPE k5tjTBjKRLD+WfzipzTDN0W90/PfnkddpaUU5cmplhSuq9rIHZAdMlmds0giPQHJY6L +NJpZtL0yHK4sIqCW0MzELlus9pX32JQE0GFqKYZ3RMATmYOAFBL3znOuM/eUI+SzcE 7rUM1qvYxiJrEd/C+XpI8hYNP1R7DnJJK+j8i+ECANFV1hAf6cH1eUz5cOH36uG89RK qhidepTTKg== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793372520; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=s0wbAI7vtg/swQKf6WjlxxgyiVLWWjGDFiiVSgjqPBM=; b=gUIO8hjB8ex7wzAymBxdccriVWZR3mvCT63hcisu68pbe8Gy7NApnJ9tGBg/ku+Y MHBojtt94fCzZjhwCvWASAcNk6YEm2w7fSrxOg/H/mY5Dw8erXq3HFVH6DIYecO1YZN lzZEFx+DN92IfbvPzMteHaUqJJZpMjEgTX4vpCDE= Message-ID: <010701a18d550004-d3bbe477-98c8-4ffb-89a8-05a87d0dc803-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v6 20/34] migration: Move CPR HUP watch to cpr-transfer.c To: Andrey Drobyshev , svt-core@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261030-vfio_v1-v6-20-45de246bc92e@virtuozzo.com> References: <20261030-vfio_v1-v6-0-45de246bc92e@virtuozzo.com> <20261030-vfio_v1-v6-20-45de246bc92e@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 30 Oct 2026 15:02:00 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.30-69.169.224.1 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI3PEPF0000848F:EE_|BR2PPF72BF2E8AF:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: fff81424-7999-4af9-cf37-08df3696c054 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|32142699015|9140799003|61400799027|376014|48200799018|18002099003|5113699003|22082099003|16102099003|261026121527099003|4113699003|55112099003|6133799003|10067099003|261022105027099003|5063699009|56012099006|4143699003|261021121427099003|261028144727099003|261026140227099003|261009223027099003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?NEZ1KzJvUFJxMEVDUzlWWDY4Y0RZNjdQYjBtUTFYcWdjbE1sbExpSnBsK0xF?= =?utf-8?B?ZFFTVVlKS05CTS9VVzdLd1pGdzBhSTdXVFdlRzBkRXYvUmFwWGUyWXEzOUFR?= =?utf-8?B?QVJCM0FCY3RWcXRoOUFUNG9sQ1hheEVmVjJhR1RZNkRyQVNQS0gvenp3cU90?= =?utf-8?B?VkpJaVBNMFVVOU1TZDNyc0EvT2VidGNGdE1WbkRDNnlGRlJmSmFSbGV4OVR2?= =?utf-8?B?VVlUMFdVdUJ5cnRuNXNmYzdVTnhJdVdHd2hQakFMM3l5MTl3RzdRT2FqVE5j?= =?utf-8?B?OUh1ZllvTEtRMWdrMTJmZ3dKSURsVTRKWHEwbFY1M0ZiUE1sS3N1OStJNHJV?= =?utf-8?B?bWF2RDRDSGZDbGNPRXIyUElXbnAvZ0x0eU1hY29vSG9FVDJ0bHArTkdoTXlM?= =?utf-8?B?TUJUeXArQmFHOUVXWmFTNFJTMG8vb3g4clJ5YlpzZFB3QlNhY3F2MkxlYlZU?= =?utf-8?B?dHQzT3RjMkFsU1hzclVrU3VBUjR2NGVBSkVOaFY1SG1CSEtPU3lzc29EeExt?= =?utf-8?B?Sm1UeDI4cGJtQWhFbldzd3lpOXhIREVVTktvV3VoMmlmUWxIWnFhZ0duWTlr?= =?utf-8?B?ZWZJczkxYXNxTmRvZzRSa0s3anJyL2VSWDVqeGU0T3JoMlFXOWpsdkY4S2hF?= =?utf-8?B?RitSbFBvQ3g0UHo1R1dXa1ViekxtNWhQeUFrS2Y1R3lmYm1Rak12dlZFcXkv?= =?utf-8?B?MktTQ0hjeWZvbHQ1QXZNaE1MWllCVDNxcjVuTXp0UXhhNXdCYmdkZWZkVENK?= =?utf-8?B?VWs3ajVYM09iOGlsRWlEd1VrRHVXM3Fialhoc1BLQjNQREhIVGs0UktUVTdx?= =?utf-8?B?UkNOVVdHMmlXUm1zRklwS2lNN2l2QUhocnRDNExSc3pXZDRKM1owNm02bDhj?= =?utf-8?B?aUhJWWVmUXpxc2k1Ky9zbVJFMXhtOHpnRFdSUlMzZ3pwZ2FiTUN2TlZkU3RO?= =?utf-8?B?NnBPMzA2cDNBN2JwWHB0NEVpUmpQTGJub2llZEpYZGppam9MMTJQUWthL1FX?= =?utf-8?B?R2hpVWFvQ3pPNVJvTERlTU9jK3VWY3NmM0hpR1dhLzVSRVhKcnUxd3FJMEdy?= =?utf-8?B?SjRVYnErb2NjcDdZZUFNSGhUMU5oNk1FS0phZEx5eEgzbzNPeHlGZXBDL0lK?= =?utf-8?B?MFRlSDVURmxUYlIzUE5xM2UxSGZEaTFHWVZBeUozUzFNVURid21tbUFUbGVq?= =?utf-8?B?RFFjWWh0bXg1QVpOZlhwaEJpak0xNFJuY2wzekdUM3hydlVkRlp0dithY2xs?= =?utf-8?B?Z0JxblZYQytZOWFEQkZIcE5STjQzT0dGdGJkdlJJZXpLVFBxQmtyRU43bXNa?= =?utf-8?Q?7VoZW+H4x/xW4=3D?= X-Forefront-Antispam-Report: CIP:69.169.224.1;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-1.smtp-out.eu-central-1.amazonses.com;PTR:b224-1.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(32142699015)(9140799003)(61400799027)(376014)(48200799018)(18002099003)(5113699003)(22082099003)(16102099003)(261026121527099003)(4113699003)(55112099003)(6133799003)(10067099003)(261022105027099003)(5063699009)(56012099006)(4143699003)(261021121427099003)(261028144727099003)(261026140227099003)(261009223027099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: EViUpxj7x+UfRz+pETkI9qb+RqvsCI90JOSKh7Sb3AA+eGLQ/voBhWNyRsJebq3kkNk9yOwNnFViGdf4ZXYkWH0zeDzc69/1tQ4Gm/QhphQiEDbA5VuWJWC+TykEfUUBN6+QJUqKcA7X+FTdUysEsYBIsiFRW+GJq27Bu9P50BbYUTfpgrpF5gMtSYoXv2Xo3U1mlD3jiBP9uS3qRdUyXcPtWs+ejlcHTtgWcj/nWBgZYafE5/m+Rd4Bk+3hvVxAnj0spVmhTBSPN0QEv+IVwH+ao5vBIcdd3o891eY84W4k4kDrRD8nIlZYlF4oxJWTTUyX6ZeUs9IsTd/DzHEf7gpgM508wELvDo9+vFHyQ05EDJM8YIzsHAim6duB9ATwkqkmt+SXi54+E0CRM3s3DeUUdx6Nqug8zIVa63OvHxXp7URS1RN9TdyKgf90dLzn X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2026 15:02:00.8914 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fff81424-7999-4af9-cf37-08df3696c054 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: MI3PEPF0000848F.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: BR2PPF72BF2E8AF > From: Fabiano Rosas >=20 > Move this CPR-specific code into a cpr file. While here, give the > functions more significant names. >=20 > This makes the new idea (after cpr-transfer) of having two parts to > qmp_migrate slightly more obvious: either wait for the hangup or > continue directly. >=20 > andrey.drobyshev: > This commit was cherry-picked from the upstream commit f523e5aa5f56, > adapted for the hci-dev base, which predates the upstream qmp_migrate= () > rework around MigrationChannel: the watch is still armed with the > plain MigrationAddress from qmp_migrate() rather than main_ch->addr, > and qmp_migrate_finish_cb() keeps closing the cpr state and destroying > the HUP source itself. >=20 > Reviewed-by: Peter Xu > Reviewed-by: Prasad Pandit > Link: https://lore.kernel.org/qemu-devel/20260123141656.6765-24-farosas@s= use.de > Signed-off-by: Fabiano Rosas Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261030-vfio= _v1-v6-0-45de246bc92e@virtuozzo.com?part=3D20