From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a18d571242-a5a4f5fe-1e20-4956-aaa0-1f02345aff4c-000000@eu-central-1.amazonses.com> Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020132.outbound.protection.outlook.com [52.101.69.132]) by lore.virtuozzo.com (Postfix) with ESMTPS id 570298017D for ; Fri, 30 Oct 2026 15:04:21 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=J5YfsqmixEAO+V72RgNaIHrnXFHH1gekhwMn/SDHRnp72Fuuw6RvEqFFXBn5j9TQYUK0VqkMYGYuQybul7SCcTVhZt3CF1v3zbFqDWKdBiXR6f0oaDDK8Ad976Qzw0i+J1wUa+8qRlUWKgBE1uQWErHP9JeV79aMSeixl0G6mSOrxWy15r616wp3OBmeUUZOd42kLkcBrw+xaDB9DfjavSztQB+51qENU7TiGW2sC6nKjRjja/nmQB5lXBpM0pewbnuLV5ZUJgQSkbo9HucgIypT/qHGOeUst5VQV3AnG2pPyknkuU5puo2XIQAhqz4R6L8d5HSST1DvyMrDNtA0bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SNIPKML8NBqc2O9bOtz80BSZsgCeh8MlzdtqVjuvfwo=; b=XIiPt5pq7yVrGcDlMa8kbK81E/EW4dMJrd8+/1aXj42AeQLlgfhQ0v1npgBNVC2sWRGRjJ4W7iifebM4V+wqE9eAt5ustTcAbFltOiuNNC+sq+xkoQJzsymNP709CgGBdSDqmylGxU0YOesznq8pNi8AArF4KBXrtE8b090dMLMcJ+coSPWITR3+qHHO9IQL0THyuC7lp9dg/3Sse3f1DrN8kfFvkmzuK3e5sZQECsLMXmvrAKJTmv3yVfaNMPVKzwZI0LGnD/prr/2smGokj8kGwBC7fcc8oRINaBoR9WEDc2Su39e3NMqr6eQDO+Swxgn9tiY3wjmNCsMfBp+7Qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.1) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SNIPKML8NBqc2O9bOtz80BSZsgCeh8MlzdtqVjuvfwo=; b=LMW/vwnPCALhoXylrR6p4o5YkD94OuXVPM7g7UMC/uC/UCJnjN+5IBlYt9wuSO7s1CkwVXSqaWVVTC4jiI9qKFfGe6gYC5ReOaqnehw6rsudqc4dfTqnZAe0VgPcsn9L1QNt7v+CzeJzDB8dF+1Y0W6EVsz/tJpJvAVC7L/MgmQ= Received: from DUZPR01CA0017.eurprd01.prod.exchangelabs.com (2603:10a6:10:46b::8) by AS8PR08MB6072.eurprd08.prod.outlook.com (2603:10a6:20b:296::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.10; Fri, 30 Oct 2026 15:04:18 +0000 Received: from DB1PEPF000509EF.eurprd03.prod.outlook.com (2603:10a6:10:46b:cafe::41) by DUZPR01CA0017.outlook.office365.com (2603:10a6:10:46b::8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.22 via Frontend Transport; Fri, 30 Oct 2026 15:04:17 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.1) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.1 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.1; helo=b224-1.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-1.smtp-out.eu-central-1.amazonses.com (69.169.224.1) by DB1PEPF000509EF.mail.protection.outlook.com (10.167.242.73) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.4 via Frontend Transport; Fri, 30 Oct 2026 15:04:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793372656; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=SNIPKML8NBqc2O9bOtz80BSZsgCeh8MlzdtqVjuvfwo=; b=jAmnG22dm0jxKYVrkOe6rSIW98PTAspw+VAhAOJwFCGzIwJBk/ucVdVUyVZfekO6 ie/mx3EAn64WYJGGLQoqH4QP06owJAXwSONgtv3s69pWUyDAdSVeNQPAv1dOPuSLkxK vCC5iQlhdr16DGXvecLPLmQaboHZYDV8UXPYh0vdL+JEyHRhbxsiP6fUWNCMCJRX8eX tuuVmFD55UtY6Un9vGxrUK/klVB8oKIoTOXHH+AQBxHoeQap7+9scL4zYFA3zfS35sC RXLQKpfSKIhtmE4GiSA0t0RNmFlkKaijPhAaOg+OSolR50QsuGg0ltYZXw6RDO3sKcj po1uURPSEQ== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793372656; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=SNIPKML8NBqc2O9bOtz80BSZsgCeh8MlzdtqVjuvfwo=; b=HflUU8bv3DSOSQtaHF7edRtP1b9XgRczkblrd8cilDH0foudamSQ3P2S2+3UdhUN +ZScIHpVxVlhtnqcooudiYiKLfmkXp8O14nz7amoUbpuuqr3a66BD3pCF3I9XeV8JGC HtAJlrSZfJ28bly3OZIWlupTmHI1qEEYgpImH90s= Message-ID: <010701a18d571242-a5a4f5fe-1e20-4956-aaa0-1f02345aff4c-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v6 21/34] migration: Fix crash on second migration when cancel early To: svt-core@virtuozzo.com, Andrey Drobyshev Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261030-vfio_v1-v6-21-45de246bc92e@virtuozzo.com> References: <20261030-vfio_v1-v6-0-45de246bc92e@virtuozzo.com> <20261030-vfio_v1-v6-21-45de246bc92e@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 30 Oct 2026 15:04:16 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.10.30-69.169.224.1 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB1PEPF000509EF:EE_|AS8PR08MB6072:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 8e69f694-d490-4fac-d667-08df36971148 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|704161411799003|376014|48200799018|61400799027|9140799003|32142699015|4143699003|5063699009|56012099006|261009223027099003|261026121527099003|261028144727099003|261026140227099003|261022075727099003|261022105027099003|10067099003|55112099003|16102099003|18002099003|22082099003|5113699003|4113699003|13003099007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WUFHeko5a2puS0I0TkVuVTlHY3EyMTJkaUJlSkFCeWlkU1E5SUN6N1FsRFVU?= =?utf-8?B?TlJ5aHUvL3RXcTZ5c3RqbWdiam5jR3BHK2NwTzZkTzJVZms2WlJpa0l5TDJ3?= =?utf-8?B?TE56amtBMFNrbU5UQ2NkalhlUWw3MnhNMjRpaTVrZ0VUenZxV3JCNmRJMUpW?= =?utf-8?B?ZEVqanprSTRVZDVBSlRIMFhUMCtvZmR3Z2x4eGpHWlRtc2tvNWtFcFc3TEFY?= =?utf-8?B?T3h3YVJMdmE3UFFFMTZDdUdsNENvN3hKMTV0dmk5d25KT2lQTVVGTm9zTDZP?= =?utf-8?B?NUI1UVpPVU1RaTBtd21PcndiQU9xckgwTEYxbm9Lc3pKYTN6Mk0zYzQrbmsw?= =?utf-8?B?R3R1d2JBWXR3eHRTR0FhSUs2OENpaFY5WnJlR2NVWFVlQVltbkFHakNkRlhY?= =?utf-8?B?SGJKNVgyOHhaVFM3M3dpUVBnOXJHSzZDSXhqbnIrS0YyU3FGcll1Y0p3OHlT?= =?utf-8?B?NWVxR0FBeFpRVlU5VjQ4OGVicFFoNmV0ZUdCV1NERjZuQzk3ZDlFOVJPS1di?= =?utf-8?B?UVlOTmNTVi9LZGhmNGdVK1FoM24vSS9YRFZ4OE5YMkNnbW9qZjQ5OW51MFEr?= =?utf-8?B?dHQxWXVEaGxBMGJ0VU1wVmxuZVJtZWdTYUpZWUJRNUVibUE0Z0JTK0xGdTJh?= =?utf-8?B?OVArQTMvMFFNTWJiVUlaOGdod20xa0poUE03b2xwL0FvM0VKbHMzZ2NRMWp3?= =?utf-8?B?YUdMU0VQVXE5UlFMVmZqR0JrZ29ncFpRSFZhZDNFTU5reElkZ3ZoSXczNVNz?= =?utf-8?B?ejBlbmNmM1VKMmk3blJuQ3krYXpGRmlEV2NkeVZPd0dQNkw3WmxXVUZsQU5O?= =?utf-8?B?bHVQTVdUOTA4N3FrbFJlT1JtZFl0OGdCV00rK3BnTng1OFh5MHBYRjNZaFNY?= =?utf-8?B?djN1RWR4MWRmSE9HaWkrQXFIOTZTLzcwb1RneFBXaTE0RHp2Zlhqeis4L0Fw?= =?utf-8?B?SCt4eEZvTDBndXpWK1BqQ0NiRmJmdmdLak8rR0FJd1VUT3Y5UUJBZmI3VElQ?= =?utf-8?B?VkV6S3hCcXI2RDZwSlQxS2psMlZCS0lIc3pUb05EV283cWYrOW5Bejc3ZjQ4?= =?utf-8?B?V21QNSt2VisxRlZnb2tHNWI3MzRvamtFZUx0cjFRSUlkYitOcEdvVjJaQ3pX?= =?utf-8?B?QU5CdnpybEFQOEkxS29wYTByL0RHUWdYdk9jbFhXTUVqeUZrUW5QUVFhanl5?= =?utf-8?B?UUt0eDhiQmU4dGVqbDh5TjlvcjZyay9naDRraDc1UHJCcnpCeS9CSEd0NVA5?= =?utf-8?B?ajVITjNUWXp2TXdqTEVFajdOVkIwZ2xQYm5TSitOZzVndDBEdz09?= X-Forefront-Antispam-Report: CIP:69.169.224.1;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-1.smtp-out.eu-central-1.amazonses.com;PTR:b224-1.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(704161411799003)(376014)(48200799018)(61400799027)(9140799003)(32142699015)(4143699003)(5063699009)(56012099006)(261009223027099003)(261026121527099003)(261028144727099003)(261026140227099003)(261022075727099003)(261022105027099003)(10067099003)(55112099003)(16102099003)(18002099003)(22082099003)(5113699003)(4113699003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 8b5XWf0J71EhIN2AkNRZJxS102VFhNqLlHwau1wkMsTV0EoU/Um0w/OqIxGm6d0TVosuxlK7M3qxsl1iMFPnPHhnrLXaOYqxpsE1wNvS8oukR4Xgb1t27IrvilyelteLPR4F+vZCSdEgCVX8s/gp56hvnvUG8pTiRwOLaiACRW/RVhFhyBPND1Kq5erCDzCC0PPrSnlKfAd6ypX+hRrs/jyYJcbpIwn67BQC+EvNzpLCo7h157Bkx2Xt7LyMuu7KP6m1AGkxXqsGsAusq08dsQwUIBKZErlbtvQz1RPYHyv+UNrDMOLph5ssrmWm1UAxPZIfoipWUBZeyYeh4RrWwFVeKC5stVFyJWpE7spGEVEc31wiJC450O9QfW5OvYOBxzgrl+IkTuVUMovhTv3g2J0bGq7u+9GgpJ5Q7nSt6fWAIS2VL5gT6+uevmyoV0No X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2026 15:04:16.6962 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8e69f694-d490-4fac-d667-08df36971148 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF000509EF.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6072 > From: Peter Xu >=20 > Marc-Andr=C3=A9 reported an issue on QEMU crash when retrying a cancelled > migration during early setup phase, see "Link:" for more information, and > also easy way to reproduce. >=20 > This patch is a replacement of the prior fix proposed by not only switchi= ng > to migration_cleanup(), but also fixing it from CPR side, so that we track > hup_source properly to know if src QEMU is waiting or the HUP signal. >=20 > To put it simple: this chunk of special casing in migration_cancel() shou= ld > not affect normal migration, but only cpr-transfer migration to cover the > small window when the src QEMU is waiting for a HUP signal on cpr > channel (so that src QEMU can continue the migration on the main channel). >=20 > [ ... ] > Reported-by: Marc-Andr=C3=A9 Lureau > Tested-by: Fabiano Rosas > Reviewed-by: Fabiano Rosas > Link: https://lore.kernel.org/r/20260421175820.302795-1-peterx@redhat.com > Signed-off-by: Peter Xu Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261030-vfio= _v1-v6-0-45de246bc92e@virtuozzo.com?part=3D21