From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11022076.outbound.protection.outlook.com [52.101.66.76]) by lore.virtuozzo.com (Postfix) with ESMTPS id 59E6480E7E for ; Mon, 2 Nov 2026 10:39:29 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tT4DOfoAPy/Zhzt3IXf7oGYD9ucMmoMZkX4nK1s0FXMlA+3QMr9UKDhAjWU5XPezt5RRHscSc0PBtXcgaiAjRrp2QOaPGvS7tyOfnlinqMYzC+oDQUH2uc8gc1WSlNk7+vRg9sFg7a/VK78y857uWyU7l/OFO13n6n7SgkRyAiUan2ltGCrvB+eN7zNCvk9D+bP3iwZpiWDLXDucXVWcGG4QRxO3Mpmnn5FU0h6wRv2KZYvx0Ur7LCZZKnquCikNyIew3gZC70KMeI44BW6EGXJiTKsdjaiUhvO9o5BLdJFJdE0iZaxNcEY74/mMx8IXSayj3vpj9bOQciv6J4Pn3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tm3hwYVMrSE7hTPEic7MOJl+UPPvT0xgMk7AyRAhqgc=; b=RAv2bezsOOBWjz51Rh+USFuZdh5YTIeuvrI9ikrGEuqDpy94CZrzjs4U/r9MngcQekFG1qVuXTTJRe3M/DJ2EaTJmuPf92p6mtkkXTqMB1RpDWq/O8LA/zWkjbg3s/BolKtQjlq32W1faJJAIjWFCfkUmsQFo95nDo0jBS19Sx0roHRNu0ZJewK/ztSvfKVooOFKvO/hE8NcHTb0MnQTWJFyWbLsGkd1ID73JZQk6f1iXsx4yghuoFlR5cpgO/n+LYQFvJTI53zOApVg0RTU9B81JrxN/ywiURxuiyK+4X7zoQrsY4gPTXATyiNTe0Y76fkUb2jpdbk04lpqzEeKbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.2) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tm3hwYVMrSE7hTPEic7MOJl+UPPvT0xgMk7AyRAhqgc=; b=d9O+9wed/fAI2TeOS8Ssfmu9rAE48RnXG+ydkgudy5wM9w3IPg91m9zeXzN+OOMwK5DXq1Nc0zOTuXcByw1w6KsIWHOsA6qe2HnBN9S+umWuaQQjrR6SaR0XH//rp7AyxhDyHUYixsuYwwgOD5gRNWI2Y7sUKrsZBw8jrdfRVFM= Received: from DUZP191CA0026.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:4f8::7) by PAXPR08MB7489.eurprd08.prod.outlook.com (2603:10a6:102:2b8::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.12; Mon, 2 Nov 2026 10:39:25 +0000 Received: from DU2PEPF00028D07.eurprd03.prod.outlook.com (2603:10a6:10:4f8:cafe::8) by DUZP191CA0026.outlook.office365.com (2603:10a6:10:4f8::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.22 via Frontend Transport; Mon, 2 Nov 2026 10:39:25 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.2) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.2 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.2; helo=b224-2.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-2.smtp-out.eu-central-1.amazonses.com (69.169.224.2) by DU2PEPF00028D07.mail.protection.outlook.com (10.167.242.167) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.4 via Frontend Transport; Mon, 2 Nov 2026 10:39:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793615965; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=tm3hwYVMrSE7hTPEic7MOJl+UPPvT0xgMk7AyRAhqgc=; b=YLkjreALlSwrrt4vNrCsgaYvjfodyHCJZCTqbThj7ZQ7cEvNOcTigMKd3ENEwlW2 j4/AYybQ3xe1aoBq+HET8k7VS3dE7UzNjkagPiynuXdDcMTnkIfrfcX7EBdT7EMzBkK 5CyxETXQ6RC6VEbJJwXGuuW854flot6lOVIGg78BZQqkgiN6SE2WWr8QEtC/DW9rANb DYbstJxBf3gXIqFUvNxh6w1fBG71f0woNJ0uyFRQ/29vlGfjGZN0b4/Zt1Mud/FQVNz xxlRrnsJi3mR+wAvucSQqVJRumF4bIn/WKN5WKVq49NfcXATGaBJcd8xImVShdREZwn EB4ML1Sfug== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793615965; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=tm3hwYVMrSE7hTPEic7MOJl+UPPvT0xgMk7AyRAhqgc=; b=QlRiFZc2D/Wuu8UiKvNnRcEf2yff6Q/TFU+CgGL1bgHXUKpTo483UEKFCUYYF1X9 sXP5jpXVzyXM9WqhBGFpdIhWgJSQO2WPBkRgpBVFv3YlStXkyqJGobnBhpQYdiD+TVn TjXmsdiU0pIquVtHwEmKKEfbPz6IWaINm+C2KNII= Message-ID: <010701a19bd7ab3e-c6a522c0-6dab-4de6-9bc5-a9c42f85f9f4-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v6 01/34] VZ: migration/cpr-exec: fix Error leak in preserve_ram() To: Andrey Drobyshev , svt-core@virtuozzo.com In-Reply-To: <20261102-vfio_v1-v6-1-9bc7cabc850d@virtuozzo.com> References: <20261102-vfio_v1-v6-0-9bc7cabc850d@virtuozzo.com> <20261102-vfio_v1-v6-1-9bc7cabc850d@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 2 Nov 2026 10:39:25 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.11.02-69.169.224.2 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PEPF00028D07:EE_|PAXPR08MB7489:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: bc3d8fe5-3bd3-4cf6-5819-08df38cd90a6 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|32142699015|61400799027|48200799018|376014|9140799003|4143699003|56012099006|5063699009|261009223027099003|261028144727099003|261026121527099003|261026140227099003|261022105027099003|10067099003|16102099003|55112099003|18002099003|22082099003|4113699003|5113699003|13003099007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?eEUvVFpPcVNHME90T3M3L2RpWUxoNlUzendlQ0VaNkVwMXp3OXhKZEtRWXd6?= =?utf-8?B?Qmx2TEpVY25scndza2Z4VG5mbE16Y2xzYS9BbDFDSEZCK1RZbzBoV0psTUd4?= =?utf-8?B?WjFqSkQ2bXdCMnpRN1RJeWFHNGc3bFQycWpqTGZMVmh3dkpSclAvdmRLK0FS?= =?utf-8?B?bXIwbFZVVys1TEJYQno0VFI2TnhBOW1CN1BJT29FblZOWmw5VVQ0WFVrWFBJ?= =?utf-8?B?cVdNYkxEQVlhejFmenVDUGkrVG91NC9NUkJ5Mno3djliVlNVQ2ZmM2trdG9t?= =?utf-8?B?RE5iZTVXTXdOZWxDSVY2ai96NmpzdWRhQThjd08xQWMrY1FFMHB2Z2JWd1BT?= =?utf-8?B?VmM0SjFNeUl2MWErRWNBN3VzOTZrbW5vaTgvbTJubDRQUXZSTUk4M2dhazg3?= =?utf-8?B?TnFyelFiYlF2d0JWTVBlNWd5bEZEZEs3YkZ6RHlZNWF1bC9lOWtEbENCTGh6?= =?utf-8?B?cFVDU010OHo5K0MzMVBVWjRsKzgyNnh6SDFtRzVrNERRRnBIV284NjJLS3VO?= =?utf-8?B?UnFPaWs1VTFiWk8rSXVKNlo0aGdueDA5MTVSa3Y1TlNiWGNXdWFJOTZXNWxz?= =?utf-8?B?d3IxTDA2aFgyM2dDRUZlR1VJOUVxM2IxM1VZT0NuRStSQmhGRnEyM3hFYkxH?= =?utf-8?B?a3NlSlQwVVJkMWtEVkh2Q3c0NDN0dHplVUZCbW5KcWppZ1kzemRLLzlzRk4r?= =?utf-8?B?Yk1iR1NzRnlMdGNXQXFnVDNOdHE4L1dlTU1tT3N0cUpzOEVsbGpYT0NKdnhE?= =?utf-8?B?SXlsaEd3YmZhelBGelhoZ21HVk11SXQwMXdweGZjOTVPVDM4TFRnb3VrT0dj?= =?utf-8?B?OXo0Wm42UUtnMUhyaGEzY29ZV3F6MkdFVkpLN01HMzVjUmJzQmtUWVg2cVZQ?= =?utf-8?B?bVJsTFZqNnFxSUpBSHRZZlQzSVl5SG9vMVpUYTNBT2c1cWN2SWM1Y1ZKdjFn?= =?utf-8?B?enRDWWVrZkU5U3FjVmViR2FHTGxxbm9yOWgrMXFUYjhCYzFQVnI2VExqcjVN?= =?utf-8?B?NTBtRkxZS1pmVWNHZFBlMGVFRzRJLzZ0OVR0TmpqcThnV1lWVjJQNmVPRDdE?= =?utf-8?B?aGI2Q0h2dExmRDN2ZXpTR1RsUU5ZTnQwQ2dJMXZMR040dnpBQjFMT1ozNzJL?= =?utf-8?B?UkFYb1dtK0pIL05oeUl0Zkl4eUxrZUhDa2pXVmlTWkhHUTAxNVVndHptUG4r?= =?utf-8?B?aHlidzlIbkdmWENnOFI0OWNMWHlPNEFoWTBWTzZDV292TzhjaklkQzQ3NGl1?= =?utf-8?B?a3RvSnZwaDl4SmRxazJjc0p1M3EvbStiRHVqSnQyMmFXaldtUEJaTS8zOG5V?= =?utf-8?Q?E+vRP2fyrSXtu0EU7iSO7+GcYCpqY/jpS3?= X-Forefront-Antispam-Report: CIP:69.169.224.2;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-2.smtp-out.eu-central-1.amazonses.com;PTR:b224-2.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(32142699015)(61400799027)(48200799018)(376014)(9140799003)(4143699003)(56012099006)(5063699009)(261009223027099003)(261028144727099003)(261026121527099003)(261026140227099003)(261022105027099003)(10067099003)(16102099003)(55112099003)(18002099003)(22082099003)(4113699003)(5113699003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: uElzP+qB3k+oB/D76PVLlpONFzeNWVchQTonBjgd6FEO5FHjdVWLppMvT9mqy1IYzew0x7z9uLKlyoBGWnH/iEy7YeSajZI2SUTZ5GIknxFicg/s4VWC0GPaVS550Q0NRUhdbvPioSwqQXh/8OkJQdFzphn/VWRsz/lS2A5qNsEewEURSG/4aFHr+EX3rCWKOBygoXqjWWt7LvE2CaTOJszHWEQeIKWyC/jHuI2Id7rpfMaGftY3uAQZsIUiGSlUegs46rZLsYi4wzIYbPdIYTobM6MNiBZFaugOoKlgd6oBJKAxXd4EbOGj1YVHDlmesi85v7QqIk5hdBGDwYDSVB0G4ImjuUFMzeOVSeajbCTXwQDNWVQSik6uhSDg+gLmnmmxHdswS2dLQqLLVSCbuscfoGUx6pir61GNBy2exWfIKe+0rdbZh6RQBIsJ05Gq X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2026 10:39:25.5287 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bc3d8fe5-3bd3-4cf6-5819-08df38cd90a6 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: DU2PEPF00028D07.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7489 > migrate_set_error() stores its own copy of the error, so free ours. >=20 > Fixes: a3745506daf9 ("VZ: migration/cpr-exec: mark saved RAM blocks with = MADV_DOEXEC before execve") > Signed-off-by: Andrey Drobyshev Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261102-vfio= _v1-v6-0-9bc7cabc850d@virtuozzo.com?part=3D1