From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a19bde1086-63546913-c592-4098-abd5-392478e5e99e-000000@eu-central-1.amazonses.com> Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazon11021086.outbound.protection.outlook.com [40.107.130.86]) by lore.virtuozzo.com (Postfix) with ESMTPS id B52598017D for ; Mon, 2 Nov 2026 10:46:32 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Y/8p/Egbp2qfbQ6lxDPySskWrk1/70HO7S1LuknwPqFDvvRqTqWQvoIr7obZITKTFy9vJTPGQTB0ght9uB+Y6/iC+Q83eTDrhFUz3QKAaSckH3C6Hhe3MfwuNgxtOZPO3B/pdFGvNPgt+u/1nTrcKhmIX4jf/ymEz1qDecv5JG8GqAs7xwBcHlJGHsGsEKJPZ9nwfXNIShJfA+pzVg64pCO+5+pJrNjaNCmAmA5xBalhG8iPSMyI3YiA+zzWGDXANv22ZzHyr6ozkU066omdTpHllKhDV4RGYan3RPeeSM1yH8XAd4jM2VmDL4h8+c1TEyHc6UiyE4n6hp/w5cj9kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SSblyx7VFktzr1Lu9DaVez/yBwALRnnTJd3CrVJ+gaY=; b=OiaIx90mbgXiT4mk1nK2GHeRYh3rc6Wdqw9Y50OAxDIsdYR0BORVUcildQqGsgEZiYX3U5Lu1buhZknlk6Xkh+7nQ9EjX6ytgugCG4LDxSlIbpos7vwlbTT8GWuPB99MhSgQPaG+n280ZfdmIEPW/LNvOApPZHAvXO1jy1Wo6oWli2VgDPssdvZfvn3s2QMaBcXp0Ax8PYF4kXqEWpi3jqj4uViTUqxIB/OciV+U56rDUuLcI1hCqjmNW4N7Hh32pFKc5NVWRrVyzdFSKHgSKL8Rk5WVdNZFsGyQk9C/J2pvUH1K7fLkfDhxZ0AjBI5Skvxzl9kLyWmop7eRspLOmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.2) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SSblyx7VFktzr1Lu9DaVez/yBwALRnnTJd3CrVJ+gaY=; b=NbAJRQ/FoOQz/RVUNEacAIHYoUScla3Y7DFM2Ig27ScTabDVmkoIQq8O8hEvlDBDDLtbSaWeXSct1G0sY8d9H/s1ry7aFjWbH5pOKIoGo17IS1QVnzoXXbc/7tM9kBaBrxRHRsO3yLT8xPccNpNUap4vltzzuML4euHPKPFtOtQ= Received: from AS4PR09CA0025.eurprd09.prod.outlook.com (2603:10a6:20b:5d4::15) by GV1PR08MB11028.eurprd08.prod.outlook.com (2603:10a6:150:1ee::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.11; Mon, 2 Nov 2026 10:46:25 +0000 Received: from CPH1EPF00000523.eurprd05.prod.outlook.com (2603:10a6:20b:5d4:cafe::91) by AS4PR09CA0025.outlook.office365.com (2603:10a6:20b:5d4::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.12 via Frontend Transport; Mon, 2 Nov 2026 10:46:25 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.2) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.2 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.2; helo=b224-2.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-2.smtp-out.eu-central-1.amazonses.com (69.169.224.2) by CPH1EPF00000523.mail.protection.outlook.com (10.167.241.134) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.5 via Frontend Transport; Mon, 2 Nov 2026 10:46:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793616384; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=Aw0uKsY9EDBcgJubWHpxJpL7HiJQlbuFwTdQpp0LtRw=; b=m0g7E+LwhVNqxKHKpJ4modG7kDjrusqPGTVQtPbZ7/iVgL7yTwzxaaKPjFvv+gih S7BCdS/0lLocp22vrsY9q7G/9E+1rJu7aHakWaf7AFgfmW2MQtdl2A9lDctoS+PrQv9 wHs8LIivjjqt8JGI+LaR2Vdi58ASflOUiOYaeQ1YAVoRiWa/kMZQqpmttlRhplTGNaQ DyT1ozQrTSQ14cCOtBdaHDGzSCFn3fhk82DUwsC38CBXgUjE9isMSQm2JQi5See2euI /I4y/4j/QMQsArVBuxdjnOZrbo86Ph3EflR+mCF9o4sGQct4875HtF2Z5nvEM07DezC gNaDHwp+xA== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793616384; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=Aw0uKsY9EDBcgJubWHpxJpL7HiJQlbuFwTdQpp0LtRw=; b=j2QPf0ueGdQ0LfgBJEg9QC2QTxG5OujQoxfg+7zaPVc2zf0gyzx5EdpBb2RZwkOo ufh2wikXnnocNOz7dO7iMq9thZtot0DJtpUHtBGwziqINLPM6u+JUmTdPQqOfVBKT9r 4IxzX7oxMiBItLZj7/8VETNRL33jK5dQ73K+eqxY= Message-ID: <010701a19bde1086-63546913-c592-4098-abd5-392478e5e99e-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v6 12/34] vfio/pci: Initialize rom_read_failed in vfio_pci_load_rom() To: svt-core@virtuozzo.com, Andrey Drobyshev In-Reply-To: <20261102-vfio_v1-v6-12-9bc7cabc850d@virtuozzo.com> References: <20261102-vfio_v1-v6-0-9bc7cabc850d@virtuozzo.com> <20261102-vfio_v1-v6-12-9bc7cabc850d@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 2 Nov 2026 10:46:24 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.11.02-69.169.224.2 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CPH1EPF00000523:EE_|GV1PR08MB11028:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 61313cd5-0059-43bd-95a0-08df38ce8a89 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|9140799003|32142699015|61400799027|48200799018|5113699003|4113699003|10067099003|55112099003|16102099003|22082099003|18002099003|13003099007|4143699003|261026140227099003|261022105027099003|261009223027099003|261028144727099003|261021121427099003|5063699009|56012099006; X-Microsoft-Antispam-Message-Info: 6C2ghDzXsqBgSOtYuibgZ4tBmHh9bWZ2G4e/bhWbw/02+tfg+GESOgdWAG43JYan6/DN0Uo1TSZqsMlVOAYExW4c9NAx8okpM5U0kO5TY5cz14YWBWb+qpKy56pjni6Pa+a7h4owfh2lUPgbTT35FcSHnwvHybmlcdsLfU7sQoMCq/+nSETtmHdolgJRy52Hn1h1x4zCa6f/Rc8K44Hn0L3sCwDUMjWeOIt+O7qxYy1HfxSVjxkdWjtCEyaO5KeDnJsen2+ra5QMfvj4DCfqAi712jnTtxlsbXR1JMZAZrLsCc9T/CfLo+BAFK+vGfr6InlYCE7Az66OkWj3R4D1+WQofPLRdoUAKlPELqAGlqqFA8iW0ZoaHmMPlJv7F+FirJluVHdXy2qXj6nwuhSNeZW/2YSyORu7FGJX4BvYgvyjQiESNyCSN3oZMKqj0ffyYBz3itUNA3w6TeH53gGciGYEYjE16OCpTnFVGErOIn0XvUgXpWlXLlQvNBBAR27+yiT1O5vCdCiRlrCWxLFegScSGUvKu0bOdEjwpwS6zHeaVp4IKEaS0GAYik6b10YlALwpfDa/eYrj3QlFxWn02aUlXMwfF2+PfmhXWdYGT8hUVstUHYARLmmhG4fHciFgKh1KK2iRmy8b5ur5+AfILCTpApMBcu0ofZO24VuvX9mF4e2wgnl+lgD7vPRKWkkOZVYGcxfJBaRH81zvre1xpXC2HcQpyUoiZaj6aLxAN0FRn/oBz45GqG7FSKtCwphd7XPhbYCjvx9YWa2Ln2xctYrWXRZw1ffDd8ZBOqT2TSDWFGPgUYedttn9vGBc0n3mrVr/m5z9Cl2yzOg7XAVAoRxniVt8tqYGFB4cEsxkV6njHHFTMANcuZMKYM7mKwOX X-Forefront-Antispam-Report: CIP:69.169.224.2;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-2.smtp-out.eu-central-1.amazonses.com;PTR:b224-2.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(376014)(9140799003)(32142699015)(61400799027)(48200799018)(5113699003)(4113699003)(10067099003)(55112099003)(16102099003)(22082099003)(18002099003)(13003099007)(4143699003)(261026140227099003)(261022105027099003)(261009223027099003)(261028144727099003)(261021121427099003)(5063699009)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: +z0fBBTf5+y4OP2YO6wYBpNsutLlIrTTVYzIXaCgbwURVjNxSGnJ8Zp3I8AzP8hklKIGnmkrdw0ZYvGbTtC1Flf3YZrv4IK2Kz4i5FVVRjsVJVK3rZSdsP+18lv9V8lkIZoFyCR8Fvlj1zeX8y8Ek8lBmvTnMSvtkgO1djvdXwifCCphI34TesDWVmHL6vdY4vzGfqhR/eHkgpgkLiAC7TrY6oFImu13T0GjkwxOWdiAvB+TVNNF0oVgEO6khU0eRQq3uw1CzK8pgv4qUEzXnvaVGjYal515DKUF30BCna4tsoom5iNxhDqhrFvSM02NwRYazQlx7JeWs7jABl9Au+59nox4L9DvXwwAO6lQ32FS+3u+G5GRNQlc8mTzexUWnoMe+hNSDL1sBnYIQbid11Fsu9CuHmY3ZyPDlAFqKhIn3QmuCWegLVVPBtq+s91p X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2026 10:46:24.7597 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 61313cd5-0059-43bd-95a0-08df38ce8a89 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: CPH1EPF00000523.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB11028 > From: Mario Casquero >=20 > When vfio_device_get_region_info() fails in vfio_pci_load_rom(), > the function returns without setting vdev->rom_read_failed to true, > and without allocating vdev->rom. This leaves vdev->rom as NULL. >=20 > andrey.drobyshev: > This commit is cherry-picked as-is, with no modifications, from the > upstream commit c822ecd80661. >=20 > Signed-off-by: Mario Casquero > Reviewed-by: C=C3=A9dric Le Goater > Link: https://lore.kernel.org/qemu-devel/20260602070857.356526-1-mcasquer= @redhat.com > Signed-off-by: C=C3=A9dric Le Goater Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261102-vfio= _v1-v6-0-9bc7cabc850d@virtuozzo.com?part=3D12