From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11023111.outbound.protection.outlook.com [52.101.72.111]) by lore.virtuozzo.com (Postfix) with ESMTPS id 8F25380E7E for ; Mon, 2 Nov 2026 10:54:17 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XU9IjD9wcZUUfQZLffl5jbm+uM+ezJIHvznkiu4lJfBmsZegHy+ag+mIQHcfxCW9MsMF12dNoLCK12cUwxi/5wrrYLIV7qJw9rqi34P55cONwMCmt7EhtMZnZCLPV6CuMEwWTwhVTWtLk4Id550t23vR/xthlVxff6kOK0Dmns9RzJ616Npo1PtsO/ST7NooHsQj/QsbcRi7g4BDbxK+JQIl8AoP7l4XHICXzGdIDPC2NADdx9ikp0YWhofFeE/kHf7lj1zKFWF3ZUJd61DBXN7IbAUCBAD2ZRj8muCemacxaxKyk8YoXStyZ3XH51ceg2VO+X02jsoaqRHGIpjcIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QbNye9gwRN9kAve37HOh0P38JgBZjTaxg5rcdtWjKkI=; b=yiz6TZNDTzLv6OSLLAwqfRxEMBe3XlAOqVg7cmvUR0OMYziIoWmD8W7JGL6pg2VUCIuLEyYS5Wd1C4NFTP4PR8ZpZlyqMdrwtAeFtXDkIL9HZmW7x+5UdH9Elxsq1I+WL+g0+V36SOFKqQzMVVN0NmMlflZASZv22FFR08RudQyu1BT0tL/ZaDSV+WxJmB7rz32m5XboOzBUd/f8FsZ+C+UD6i5OEaqY7rvPLnIPLHUwHe4jQn/MZDMIEPmeh4ZPE6w+33hmy7YXYw53/yPCfBO9ts4cC0368l0GUC5dZODuUpChLwqOgjy0ncLURBsEightK7pg1ks/BfdU0YjVJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.6) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QbNye9gwRN9kAve37HOh0P38JgBZjTaxg5rcdtWjKkI=; b=atxo0nddbAUBlHylkap8UqtSuGQy1KbLELN2NcvYyOY4a60mYgNuUqIY/HmQs+EndB1LdHstZmf3JvS1HPKltlQNA3nH2DGL584wEjk7pm4fVa5cxENnEPTkaHkje4atuBqxHkklS2p5EsX9fuul51j8UYkeik3Oe/kpXvqzDqo= Received: from DU2P251CA0019.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::26) by VI0PR08MB11552.eurprd08.prod.outlook.com (2603:10a6:800:2fd::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.12; Mon, 2 Nov 2026 10:54:14 +0000 Received: from DB1PEPF00050A01.eurprd03.prod.outlook.com (2603:10a6:10:230:cafe::7d) by DU2P251CA0019.outlook.office365.com (2603:10a6:10:230::26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.12 via Frontend Transport; Mon, 2 Nov 2026 10:54:14 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.6) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.6 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.6; helo=b224-6.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-6.smtp-out.eu-central-1.amazonses.com (69.169.224.6) by DB1PEPF00050A01.mail.protection.outlook.com (10.167.242.43) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.4 via Frontend Transport; Mon, 2 Nov 2026 10:54:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793616853; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=CVh+Jedk93xqse1zVNnglxLynrL2p1assW9xq1s3L6s=; b=b1PxaDqpYaOFeB7erp1/baAkt0k7lxOo6mZ8yk/G0XFBE1XD/n+l9r66fNHwzaNA gYs1OFFTN1bpRZoAnVN/ByjNQi5IrpNkIOnvgC69AlbUGTtzXc3yqb7Lf6Tg86jggtC nFf2t2lF4MhPXBU8nnwc2cInqg3HOhuEL6FbkAcULl+/+VDQDt+zYcqfnhPec+dt01v yt2vNKnN3UPyK+ZcbMddFRwnHrCqKCV3xLIM85NyE/4yq4MEuOUiH2fnGfx7bhmxlMh 2Kj2Tzeu2GZAJcMPilsAmLtK0z7NmOopC9Kfksjp36C+0MPBmtMX7rAfDD1EstFqNOC ZIm+ghf47Q== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793616853; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=CVh+Jedk93xqse1zVNnglxLynrL2p1assW9xq1s3L6s=; b=KQY8jMD7TfPOeaUZedWvwOl5vECeOh+nT19nohIvXrzupRCp47Yg27JFaYse15w+ YOFtHqAAPUHle79a5q4ydJU+0ndsx8BTM3axSt42sgJxyzWJ3q+bY6x1Ssmn+fR2nS1 cxBuzruPXEkAQ9pSLkC8pjLYCKxV8TB/ffm2xaEE= Message-ID: <010701a19be53862-6de7373b-4bdd-4b7d-98b8-76d4341ef18c-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v6 20/34] migration: Move CPR HUP watch to cpr-transfer.c To: Andrey Drobyshev , svt-core@virtuozzo.com In-Reply-To: <20261102-vfio_v1-v6-20-9bc7cabc850d@virtuozzo.com> References: <20261102-vfio_v1-v6-0-9bc7cabc850d@virtuozzo.com> <20261102-vfio_v1-v6-20-9bc7cabc850d@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 2 Nov 2026 10:54:13 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.11.02-69.169.224.6 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB1PEPF00050A01:EE_|VI0PR08MB11552:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: d156717e-bf70-49ff-7a37-08df38cfa1f7 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|61400799027|48200799018|9140799003|32142699015|4143699003|5063699009|56012099006|261009223027099003|261028144727099003|261021121427099003|261026121527099003|261022105027099003|261026140227099003|10067099003|18002099003|55112099003|22082099003|16102099003|5113699003|4113699003|6133799003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SmVFbkdpVjZnWWZIeG1RUUZtTWVzVUV1U0NRRU5EeHdHekRPQ3gvbzh0TkpK?= =?utf-8?B?KzRIdmVXcmY3T1lLak9Vd2YzbmVUbDlTMmtYWVJrTDUzQWF1YkcyeE1BTmx5?= =?utf-8?B?ZmJzTEYyQ0VFNWIyT25tMjZxSjFpZVF4NHpoeGNYYUlhc1ZlL04vRnlRZjN4?= =?utf-8?B?RmlxQ2ErK3hYUTllV0ZhVnZGb2dCWWpaazRFTDNtUFVjT0VqcHE1V082WWlL?= =?utf-8?B?QTNPWnNsOVZpY3FWbC9nR2NMWDdCSVY1VHk4ODJ0Y0gvZjNrT2oraFZ5RWNt?= =?utf-8?B?VHc5VmdSdnF2aHpwUlMvRjU5SytTUHhQT1FEWkJYeWh1aVRWL0Exbnl5QWFK?= =?utf-8?B?OGoyTWxrQkVUSVVYWm14RmxPZDBHY1VTUmNnL3ppSm5GbmV1TTFiSnQ5Qyti?= =?utf-8?B?SHNuUHY3M0JkWmQxS3NNRDNlSCtucVRsakJveE5sTGxQOFZrUytPQkx1Y1J3?= =?utf-8?B?aHVvTXB5WUh0M0l2ZTA5MFFQQWU0RnhtMXhBQ3g3TjlpRndENW02ZFY1SFRG?= =?utf-8?B?K3BCdTFHVytOVWd1NEhTV1g3emx6Qkd2eHB2aTNoUzFUSHpMR2lWUUV5Q0Zm?= =?utf-8?B?cW1CbzVqSWtzZ1h1ZituUitRQUpSdlhDZDFUVDZ0YjNqNDc2T1JmZk1ab2lR?= =?utf-8?B?Zkd1elI5L1lzcERQR2Q3RUVzeXFMWUVOUWNuUEJIZnc5cVNJaVBlUWRjVGpR?= =?utf-8?B?eWx1c0w0TnB1NUZvb3grY0loU3VONGk0TDZJV2ZjYjJLRU0xK1p6SFZnWU56?= =?utf-8?B?ZGJKK1BVK2x0Rk9nejZwWVFLVGNlVS9tODR5UXlSYjFJZ3kzM3B4bjBFa2RX?= =?utf-8?B?S1YzNGNNQlVGeGpQTHdlUERjTzBxcC95RTUzSkVvSWpUaW1iRkdNdjdnUGxw?= =?utf-8?B?elVLUTZtODdHMFBaaExDb1lJSzJMQVZzREhod21xSHRXZ0FGb1l1RlVBTS9n?= =?utf-8?B?U0tPbFp0endnNCtVRkNwNllXbG8wL1gwQjUyeFZ0aXRvSFVWSGJlbTdYbXdY?= =?utf-8?B?YUd0WDd2dytJRVU5WHhXUjAzTkFZOTUzQ2Fjci9RaGJoT1BzdUE3ZUgySjB4?= =?utf-8?B?MUlQRlNqeUY1UlE5R2lUU2ZVcnRpcDJwYzJhcThGMlBWNDRVbnFtMEV2U3I3?= =?utf-8?B?R25YcFlzdS94bGVJWkJVVW8yYjg1Tk5UYUFENkliNm5Gelpvbm9xZTdhRDZs?= =?utf-8?B?R0NzNnI1aXJFeXE2bHlCNlJPQmUzaEg5eDg0SGhVd0pTYm1aWnFzRktpNkdX?= =?utf-8?B?UWc1MmZjdzd3T0NDZ0JTdEFySzdPTVVlcHk2YlR5VU0wV0lnUHhSUXpzSWVK?= =?utf-8?Q?sEkAaYtKsUAg0=3D?= X-Forefront-Antispam-Report: CIP:69.169.224.6;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-6.smtp-out.eu-central-1.amazonses.com;PTR:b224-6.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(376014)(61400799027)(48200799018)(9140799003)(32142699015)(4143699003)(5063699009)(56012099006)(261009223027099003)(261028144727099003)(261021121427099003)(261026121527099003)(261022105027099003)(261026140227099003)(10067099003)(18002099003)(55112099003)(22082099003)(16102099003)(5113699003)(4113699003)(6133799003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: BUI40BUzrm60YGnu4bCYsataMpU+5Kc/NLBPIIpihY226GEuH3+NP1xf42v/ta//vI6OR72V2qWkq2LIP/YnuiYk1Dr3KK8XvPy8s7dI+T5QQbNxRvFaNv69EbcGYXQIrFFkJvaQOEONnsPrKNjL9H59pfCl9l/bYg28bCDNz0WRLDPJoABLvO3OYYTpyl8V4ONcjx9MLlUorkZ2wY1kCKlvpzlr1GMTK9K7QQMeeHuwBkBBBOmXofNjYVPQ0TsWvCDGV1rSF3RoyBK92X3gdqfdvBjEJN1y8agfvKR5Tux3fwNhtDizS8C3U03DcaHeIIoeZNBGzadrTCLRxXulL4FkFXCE2A8SuBdDvXQhZJH22zGm6jEjZYSuTV+RsaUVVemOwCsALxlv0j/h+Z/w2Cu3OcRqtzMbPbTJoOkqDDEDdwuerydOUdIGG6xJ+qdE X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2026 10:54:13.5773 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d156717e-bf70-49ff-7a37-08df38cfa1f7 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF00050A01.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR08MB11552 > From: Fabiano Rosas >=20 > Move this CPR-specific code into a cpr file. While here, give the > functions more significant names. >=20 > This makes the new idea (after cpr-transfer) of having two parts to > qmp_migrate slightly more obvious: either wait for the hangup or > continue directly. >=20 > andrey.drobyshev: > This commit was cherry-picked from the upstream commit f523e5aa5f56, > adapted for the hci-dev base, which predates the upstream qmp_migrate= () > rework around MigrationChannel: the watch is still armed with the > plain MigrationAddress from qmp_migrate() rather than main_ch->addr, > and qmp_migrate_finish_cb() keeps closing the cpr state and destroying > the HUP source itself. >=20 > Reviewed-by: Peter Xu > Reviewed-by: Prasad Pandit > Link: https://lore.kernel.org/qemu-devel/20260123141656.6765-24-farosas@s= use.de > Signed-off-by: Fabiano Rosas Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261102-vfio= _v1-v6-0-9bc7cabc850d@virtuozzo.com?part=3D20