From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a19bf4fc01-c1a05205-1a3a-431b-b800-c5cc02535cbb-000000@eu-central-1.amazonses.com> Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11023096.outbound.protection.outlook.com [40.107.162.96]) by lore.virtuozzo.com (Postfix) with ESMTPS id 5FC4480E7E for ; Mon, 2 Nov 2026 11:11:29 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XpMEYAguCXy9mq75P3P1gwX7I3/SovMKfKdc0SGxaHVR3MSIMY/037R4mxCZKGd/onB7MXin5zu1nAhhkip9RKjqotIN4wGkojHCCwuKF/oSxgl725H4K9XHnKjUlbVKFbKprU0RMEjoeEtK4F+ky5qnq2kqGfUJll3GPUBz6H2M3b2dswnkhK7NJlCfpoalzmGMxMuK8QVLrDkAZK5mB9i3LE//QaF9Z+Sxfw0EGclCZ9x+FOCg1RgDlC5PMYJAjDi0Tj4BOpZRPZ+BQ92k4l/fIFkcJ3c8i5A7+Xn6cB84CplCnBX6an9oJ4YD9Gnrf53CVZJI1lA9ODKRM6W2wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OHa1EhAEQlYt+A3JcRlxCPdzSrcSx5iCNaUsCJ+d0vs=; b=wPe2pQhtFI4pa4nu5zx25iBNxDXnuprtWlGVGqpwM7QoXxI7lvCLClPBWOllb1yTSJvz1Of21BwRGKygeqzfUiucSm0PU4kzjKg4jKvJfG8LlecesAxMV50AI39deeDCXgcDJbnZvMMIFEUXMt6Umi4M16Hv/9UpX3Jmf0ao+5JRwFcYgUQPnxuKoVFxkTAWhK8jD39C00ajDehVzNMyG0SRnXWqsAO3ahKU2G/G5pj5kGdFqydz67XI3ZiEdKUG+w48vQhmjntnhRbvRG4U8bY55t3Xm7/NGLq78ep2m2mb9MObQyw2WKg0zlEMjqhS7hUxEktr8oVBe0cM9tzLDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.1) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OHa1EhAEQlYt+A3JcRlxCPdzSrcSx5iCNaUsCJ+d0vs=; b=d2osJMid2l9/q0VaIOhbRqCzBkR6jP8FFa6NAtQtrYV0FhpatIos1uMO9ZBVahjxh5d1J4KF4/1BoscTo0G+w6WnKY2I7qynSX4zHspF5rn7TZ8+FRBHQKfn78JeGqsoKhdV02ADXCSqwE9gHREkd9xZcnlXMsoUvXTfykHueN4= Received: from AS4P191CA0028.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:5d9::20) by BESPR08MB999874.eurprd08.prod.outlook.com (2603:10a6:b10:10a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.12; Mon, 2 Nov 2026 11:11:26 +0000 Received: from AM1PEPF000C1ADC.eurprd02.prod.outlook.com (2603:10a6:20b:5d9:cafe::85) by AS4P191CA0028.outlook.office365.com (2603:10a6:20b:5d9::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.546.22 via Frontend Transport; Mon, 2 Nov 2026 11:11:26 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.1) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.1 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.1; helo=b224-1.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-1.smtp-out.eu-central-1.amazonses.com (69.169.224.1) by AM1PEPF000C1ADC.mail.protection.outlook.com (10.167.242.107) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.5 via Frontend Transport; Mon, 2 Nov 2026 11:11:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793617886; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=pUFQiq4u1mud5KScIXPA7i6SQl5ehnGHW9sVJE8YvKM=; b=2KjlDucDXn2qP1UPfF6AgcAXv8VnCTyodBPLo44lpy9lmH/w+pZojYPnOXhtGlM6 tGX1Q/QexQp539yH6NqSHbAsP+HvfT3RT8qugQ9M5N74Na0czEoi4U6OQ5btrvW/t3n qDj0r5i4BUDi/nes9jlOPtubB4LkbcSUt4C1cN9pYKxEWM4UaYEvbKe3nqvHOpIHk9/ 7AsWyGxpS6KLBoh6Oez93BXYBCgw60HkzyqHjmnTVKKLE/bgb24nsE/XMiujPz6buUH dbi//NY52XZhfgh8FRGHPMMEWoxOj786V5WnbdD44xpBEPGvmiyI0oJbK2tn1NolAYD XjLvoSohvQ== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793617886; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=pUFQiq4u1mud5KScIXPA7i6SQl5ehnGHW9sVJE8YvKM=; b=J9lQBlDHsZLLd7HJP+ZA+7DuNgxxIbnDrSillLTrcN24MSqnK8UTNJnRfDmjefjf Du//GtUIAzKOotFbgtMrmQ2gQvlf04RPGjOWg/dNX7P6M5RNOSM9lUfy65DAyltJeB+ TatR+OmYXH3WuVPuQi77GcF0R2hju3InwBnsVA/0= Message-ID: <010701a19bf4fc01-c1a05205-1a3a-431b-b800-c5cc02535cbb-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v6 30/34] VZ: migration/cpr-exec: take the vhost-net devices back if exec fails To: Andrey Drobyshev , svt-core@virtuozzo.com In-Reply-To: <20261102-vfio_v1-v6-30-9bc7cabc850d@virtuozzo.com> References: <20261102-vfio_v1-v6-0-9bc7cabc850d@virtuozzo.com> <20261102-vfio_v1-v6-30-9bc7cabc850d@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 2 Nov 2026 11:11:26 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.11.02-69.169.224.1 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM1PEPF000C1ADC:EE_|BESPR08MB999874:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 244b3fdf-bbe0-42b2-ee78-08df38d209b6 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|61400799027|48200799018|9140799003|32142699015|4143699003|5063699009|56012099006|261009223027099003|261028144727099003|261021121427099003|261026121527099003|261022105027099003|261026140227099003|10067099003|18002099003|55112099003|22082099003|16102099003|5113699003|4113699003; X-Microsoft-Antispam-Message-Info: Qlpp+p/3vKIuNjialan53N26EqBegjnCFYfBWnWpC/77MHklUMdw7YGvx4WvNsoZnb4Wle8z+y1TBFSd+tQIASMIK+/JFuANlJo1XFJR2Id/Q3fl/L7Ic5oiUJR9qPNufXBeptan1Rplbo5QJMsGzIb6xAesZWEyzg6T0/A8S99loa77tLTM0RBv8PSGRZTfxsVwbQzYKSl0trGg+PYHGHlpmDep5rlE0tNf9HR259JFfeWSF42/CR10Y7B443fN6vUMpxrarf5jFmW2D9EgYn/ZIpEDjyAa87M0GZHQ//r2p5Jd+YCTjmJEtAgX8VkOB6HWFb+yt9Y0gaT7hwheXEzdhRFf4j+sTN2RW8WXJrNfMWLlwfL4ml3U3psPVdVmAP3Hdvoe9c6LcDQLzW/dkxyo4WHG5OLg5/9KH7koejUaFKMAgeDAPjDpKw9q0tvcWPU4hySUNPKZQ4EPcxceKUM2N+xoVGvJeHF+yEfyC5ixNL8gTHt39x69gpYdbF5ZZDlDTGpMeV59fQyOuE+sbNDiSl/OUoAPtgDpKjpH1W2i349ogaMk4vBjiwIhthIXOMhl6E8DE/zBTRWgq086gj0xAyaAC/Uk/t3ZEgSI9itOplv3f16KouvJdgQtboScpk3huBZatBOh72t3cDTShNBB4IubL7gdoNu0xNMbbTnrssFtwxPn0x5Iaa41nWjJyP3AVhHCwe72I9DFU0K6bSl31CtG/s61zQGiX6fAwHhX/Ua7/eCjiUrV8sEobBnNf+eMDJrdjnQDOvOzKuzYl4TV1u/eKlR6EjsE3unXX2XiysbStl9eC48XUcwZbxN2ySZ7bxrDpR2MEl01M0uDXg391oOehBZiSy2cgtVMhIsnH5Uvx8qMJIRiYnVVmNf3BLP+Hr6/MLXRPpwZ6Qvnog== X-Forefront-Antispam-Report: CIP:69.169.224.1;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-1.smtp-out.eu-central-1.amazonses.com;PTR:b224-1.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(376014)(61400799027)(48200799018)(9140799003)(32142699015)(4143699003)(5063699009)(56012099006)(261009223027099003)(261028144727099003)(261021121427099003)(261026121527099003)(261022105027099003)(261026140227099003)(10067099003)(18002099003)(55112099003)(22082099003)(16102099003)(5113699003)(4113699003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: dh+UfY1ghPp+MoCCqNytjE97Bw7Uhc5P4uZBhlbDZIt8CKz1us1CB8bWM+N9Y3X0ZYXORrkvSm8GWWVWaPb96JjPBqwMhr+Ym2CjVcnlEi7nsEeakKKXUxAiQ3LgKRYVps+VBiWb/b9Dk4X2P3rLmiW1BYeUTqcE6ZXtMqiSc/yv2lONQAWQ8TcNIsEpdm2Airvzhi11RfuaDCjqALzoELexQ71IipRXUeMdjcMBD64u+ZM+7XuFFeStT1B5lGUR8yR+tHgAXj3puo2hpMN3f+Lmk6YnjV2IZ4B07+33ihKl0/nXhYPn1nFT3YMh76NBW7jRHtCN1E9XPkE+62yamj7dC3RirN/FCECCqUdiHkp7gbQSY70qHHlVdy6zF0DwvrWxTOu2/uqSlhQ9flXMbu3faFbxP7Cnr+9RApda6L3XQskYLBvfrROEtssCXKFa X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2026 11:11:26.6426 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 244b3fdf-bbe0-42b2-ee78-08df38d209b6 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: AM1PEPF000C1ADC.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: BESPR08MB999874 > Right before execve(), cpr_exec_cb() releases the kernel vhost-net > devices with VHOST_RESET_OWNER, so that the new QEMU can take them. If > execve() fails, the VM goes on in the old QEMU, but nobody takes the > devices back: the kernel refuses the ioctls of the next > vhost_net_start(), and the guest is left without network. >=20 > Take them back with VHOST_SET_OWNER when the exec fails, and set the > vring call and err fds again: VHOST_RESET_OWNER dropped them too, and > vhost_dev_init() registers them only once. The devices are stopped at > that point, and vhost_net_start() sets up the rest again when the VM > resumes. Only the devices that were actually released are taken back: > vhost_net_cpr_reset_owners() marks them. vhost-vsock does the same in > its CPR notifier. >=20 > Signed-off-by: Andrey Drobyshev Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261102-vfio= _v1-v6-0-9bc7cabc850d@virtuozzo.com?part=3D30