From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a1a1b7f90a-6d3cbf8b-2a8b-4384-b0e1-f91edecb5a31-000000@eu-central-1.amazonses.com> Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11023122.outbound.protection.outlook.com [40.107.162.122]) by lore.virtuozzo.com (Postfix) with ESMTPS id CC57F8045D for ; Tue, 3 Nov 2026 14:02:36 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NTc4k3VFsyNwGk3sZeNvUFbDXWjs8zAvdYuXT6TwjDrIFPdhGNnJxffwkb1ONE5RhRpxMOfaqxBrdTk4a4cXJg7jxPCgPCWxopoc4v3WnMjKdjiKIc/oZeQq8VJ8DBr65iXLxjZvbcWkVJsTUuEEjWNa7ZU9kDUEQPirN+DCNPa1TTRno1Gl+NyJF8sZDyWZ2aa9FG/4X6xuR2Ws35AGpSs8TLaa6tM2PCzaUNZx7MoffHm582VRWe4cqn82ivEmWhFhTcX7seT2tlg9JSXg+ypQEog2yrZMotoc0DCiaGw/RVSkk1BOESVhOPhH+6d8V/naurE8/C5cjyAfx4G5jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S7pkNsJpSOufVELu3kmo3lfyU2BKJQMDEgqtXVzRq7Y=; b=TdjJZfKgGuIZimG1VUCFVU0VQEclCQAZNaklb6bAY3pkVkCeoG13vDzVBynUygLT7Qgh4ZkGrAuLdkqqa16nyXYFYBaRu1Ga23atXW5dW0sB3VndR+yS3EorJIJ6gtEn9vw70f9LxyIeb6TSMQ0fIFU6R8hTwShNyWNd4BBP8IZ1Ap8YgiqgpCkFjnLUa7sMZqFfXofMNnQdX1SnP3fNZbe0Dk96ePZiKWxrbBXs4TT0wAda2ZldunVbZqlgfGdwg1UNEFl6CIBcceAKZhYH8fuOZIsKXCBwVfMhSN67Y2QPeLbozOjm3BB+t2+ty7nqiJ2ZhmAaTqEq6KGzAmsidQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.2) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S7pkNsJpSOufVELu3kmo3lfyU2BKJQMDEgqtXVzRq7Y=; b=h1dmIYIyAqqDB3iBbuGNtREnh7y2WiAfoed9OeBDEW5GAAkUrum+9l5Uhp+PLBTzRSwUlVe0V/ZFcGKsMB47M2g1qAqohdnSHl6ozBVOw/Yxd/8tysw1iV1AhM7xkFFURbA8yZPZxsCLv/iuio1pOAwNLmBKIolXqw4b1MUu1sA= Received: from PA7P264CA0295.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:370::16) by PA6PR08MB10548.eurprd08.prod.outlook.com (2603:10a6:102:3d9::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.12; Tue, 3 Nov 2026 14:02:31 +0000 Received: from AM7PEPF00000053.EURPRD83.prod.outlook.com (2603:10a6:102:370:cafe::51) by PA7P264CA0295.outlook.office365.com (2603:10a6:102:370::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.8 via Frontend Transport; Tue, 3 Nov 2026 14:02:31 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.2) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.2 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.2; helo=b224-2.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-2.smtp-out.eu-central-1.amazonses.com (69.169.224.2) by AM7PEPF00000053.mail.protection.outlook.com (10.167.242.39) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.0 via Frontend Transport; Tue, 3 Nov 2026 14:02:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793714551; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=I/ReTU1wIHYRya7kzMjZAyWlHdy6mENbjGUT/bHhIXs=; b=x4oO7qCxOyZa3JYarXt7oUaWX9YP+vTHz69stML7WJBfkZ9/Rks0RMKE91rEuucg n+0aQfHhokkA6AFoULCzUTdWPWlxQP6uHBuBleBglQaG3eU9nykz+rxf19sG8W4IXvY QQwEjuRrIPx3sn/8YoUSINN/ueEui9m7XaToHiRis3QpI0FnuY5ZT0IJoGLGe23gDSL NKu3mFAM/7/QTbVQk3Mj+rxzDD/V/ncPc9txu1pQrDQNHZb8yBuE997ky+BOoT45PHC PH0iDL649aVXy4hy5oZo3sZ4F9k7r1S5dBHjVpYt/xIcFVktnYTn5PXc8C/7Is5gmAj DA/WH9a0eA== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793714551; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=I/ReTU1wIHYRya7kzMjZAyWlHdy6mENbjGUT/bHhIXs=; b=OOZkiUeHxfZHOzanpAP85iseiAqXkhD1r0D+SjPEP28Ozuil01Ko4cGQaG7vVU3n BaK21piaCwQrkA2vhUcjVIgxm5rkHMSYPZkKfRodRb6q5evneY+cfrfI64aPEercHQW N8BKi5dsoTgD8YeRtRGXBeFpEgA3Qu3Rzicm8KC4= Message-ID: <010701a1a1b7f90a-6d3cbf8b-2a8b-4384-b0e1-f91edecb5a31-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v7 03/35] vfio/region: create BAR dma-bufs with O_CLOEXEC To: Andrey Drobyshev , svt-core@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261103-vfio_v1-v7-3-4467fdccbbe6@virtuozzo.com> References: <20261103-vfio_v1-v7-0-4467fdccbbe6@virtuozzo.com> <20261103-vfio_v1-v7-3-4467fdccbbe6@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 3 Nov 2026 14:02:31 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.11.03-69.169.224.2 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM7PEPF00000053:EE_|PA6PR08MB10548:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: f7b4afe5-ac21-4383-0313-08df39b31a74 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|704160211799003|61400799027|48200799018|32142699015|376014|9140799003|56012099006|4143699003|5063699009|261009223027099003|261028144727099003|261022105027099003|261026140227099003|10067099003|22082099003|16102099003|18002099003|55112099003|4113699003|5113699003|13003099007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cUo4cFRXY3hOMjVteUdyTWQvRVlQZkpONEFsS2V6aCszdm16Zzk2Y081QThS?= =?utf-8?B?RTJERFpxbWZndytka0JOenpEY1hKYlpPOWhlRW5kNGVoUGZxZHpVbnE5OVY3?= =?utf-8?B?RkpPcTE3VTlYejdmSVdqT3RsSGZzV25vdEVNRWhhUjUrZEswdEVzb0FHYVVL?= =?utf-8?B?dGhycGxZRHdydjdOcGtMa293OGcyenl4M2pKbnRWR2I0bGV1SUUvSGYrWlpW?= =?utf-8?B?dFprWURMK2JDYU1DTDF2VFl2eFozTkhFMFdtZnBHa2hTV0JybXg5RjF4SVJ4?= =?utf-8?B?akUxTC94ZEd0SkJJWVNBbzJjUUJwcnlxcGp2VFJ4NjVTejJkNmpkeU1pNUZO?= =?utf-8?B?MURTN1llUjkxQUdGU2R6UVQ4bkxNZHJRK0FoS3AwUWxEVDRVTFpwY202TktV?= =?utf-8?B?dzlWUVNpNm5EeXUzL1FUZlVSMmJlQ2dlOEh1YlZHWUdTazdtdzdHcXFQaHFT?= =?utf-8?B?Uk9LMGtRMURxS2FUVUJSQW53VFRkbUVHSmNMUzhPNExJc0Jmcm03K0JpY1BZ?= =?utf-8?B?eHU0S2ZmNm1wdEp6TW96cm40RTlZMkpqelVBYTZja3FCVjllemNPSDlrVEFF?= =?utf-8?B?eDBXKzdad1UweWg5dDVZZUI4NlN0YUZ5d1VSL1BWbjNGVUlESjFiRXNEczU4?= =?utf-8?B?WU5QV3VKLzY0ZjZvT25TRVZPWUJsUVJEZXM1b1pWalpyVUlRcjZlNmdyeVZ4?= =?utf-8?B?WTA5dzl4QmVaZXhaR3RxSFF4RUNUaHJNRDFQUjhMTDFBVCtwY3BhdmJQb3Fn?= =?utf-8?B?T2VkVCtOTnQ0dm5DNFBDdlAyZ3d3bys5NWM1VnE2OGNjZ25paFNRQ3ZEZUpO?= =?utf-8?B?RW9wcldwOXczUzRESHpyWER0OHJVNnFWTUpVaG1pd3NTUGIvQUMvVXBESng3?= =?utf-8?B?Y1hsbFY0RnowN01nakdDb1JlcVhVNkZHNGJPNmdYNCtJblcyT1BpQk5PZWNG?= =?utf-8?B?WWlLMzZlVTFlK0xQaTlBQ0lSUFFCenhKZkxqblRFR0VsanE4R0ZPOWZPR2xk?= =?utf-8?B?NHhxczF0U054WTZVdXZsUXVNMVE0blpBcGMzTDA2ZnhFUzM5S01iNHJDUE5k?= =?utf-8?B?SGNBTDdPNDAzejZkV2tNT2VtdjFlT1MxTDJpcnV3enEzTVFPUmp6aktjdDBZ?= =?utf-8?B?QUFCVGoxLzUwenpHbEcwRmhKQ1NnOThDSHcwNnNMMTlJdFhpc1pWSDVNNHJV?= =?utf-8?B?QnI4SFpRNk5RcjJ1ZGxMZU5IeDJralkvMEVuakNXMGhWZWJhcUhvL29jYVRt?= =?utf-8?B?R1o3QkNjdVFTVUVFVlZUS2l5ams3TEJ2V1dMTU9aZG9QMUVTbkgxK1FwRkxL?= =?utf-8?Q?NZQFpcKIHj7JPUEPf1jBb2lMgoUdq2QoUC?= X-Forefront-Antispam-Report: CIP:69.169.224.2;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-2.smtp-out.eu-central-1.amazonses.com;PTR:b224-2.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(704160211799003)(61400799027)(48200799018)(32142699015)(376014)(9140799003)(56012099006)(4143699003)(5063699009)(261009223027099003)(261028144727099003)(261022105027099003)(261026140227099003)(10067099003)(22082099003)(16102099003)(18002099003)(55112099003)(4113699003)(5113699003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: u/TNX1vca3FLPz8gsgL7j2oXOBLpRDnv2IplUtEVa7H4PwSBZUEp2iE8TzK3GTHoT4HlI5HuOGEroz5JL63UsMxm92is+tqdYRT2Izlg49mK6Lbp0oImW1aVyaXxl44ObceV8bA/La53caFlTO62/cDx9Pm7/eBZbqLCQCtKUUS5M5+f137jKBrH3/chHlmJSm3ftA0++W18AWl4i5D8PYEvCJm+Jz/B+bADMMQnpx2hAn7ZE9/x+GT/1GpFFrd9cbJ5NwnPRJXXaY9TOQj1ezpAFGFRpYM8c2SeBDNJYJ+wxY5zMpvgSkVaVinl4QA0oeXiD754jg8JsnZ2roxSuAYiyOqk3SkOkR0w8WcghtWtIXElq8qY/HUy+HYzyNVYHxP5rAZm+vdgLZTVXF9ig4hgFc0/+/fG0c8K1z0qmWBRiS29HEXmfg27iYup/+k8 X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2026 14:02:31.5005 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f7b4afe5-ac21-4383-0313-08df39b31a74 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: AM7PEPF00000053.EURPRD83.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA6PR08MB10548 > The dma-buf fds are created without O_CLOEXEC, so they leak into any > exec'ed program. With cpr-exec, every update leaks one fd per mmapped > BAR, as new QEMU creates its own. >=20 > Fixes: 96163e0dbcb4 ("hw/vfio/region: Create dmabuf for PCI BAR per regio= n") > Signed-off-by: Andrey Drobyshev Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261103-vfio= _v1-v7-0-4467fdccbbe6@virtuozzo.com?part=3D3