From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11022122.outbound.protection.outlook.com [52.101.66.122]) by lore.virtuozzo.com (Postfix) with ESMTPS id E5B0C8017D for ; Tue, 3 Nov 2026 14:03:44 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eMOj0i0hu9RnEGK0h6fcVAqmv3UAtcjInVRLECUKd0khEmaZIEkOQFXbimaZcIzYRkalRj5WJ6AO8xzMpGP9yOqg6ko6AE/BhiNi48cUiLs5mD4txXD90ZEj0apZ/BEmPcQrNV4cmZFFDcgUuqsvpdOe2DM5lHeUJOyjJzo4r3DXqkrweRGVSE4/QGAE6g0MvZKNMLROaQII1FNIvDvN/S6QW9mbLXheev8viK9NSeuIc5JbzOAzKWZgMMI6/nhT8b/RCuptUIc14GS+Jt4AJpm+7V6fvCuBU8X+vOGtvU2h2wWhLY5NjACcDg8lr9kN/DhKD8kgWZRxJ0kizXvNSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lE9QWQ7UCrIrfyAheRCPItUhWCu7v/8BdHtRq22fGEc=; b=BQVQF9G6FaAACJIaj7pqeB6zy6YvNqJP2ahQQLrX9B879qmMh3ilTisg0ihpIE+1pScrPUYbwyWKIbBqVftx7GV3fS81g5Ye4b60aFs4uE9N4njMGoTzW32qOi5KuKEtGuU8oD7ctLKEySnOZhU3VK0vcX2hPwEkoSKXalAdJBJMIhkoJi2S87dJCuyzkqTmdKGgHs0t06GR7eXo4rVpk5YJIGp0wsakpF0npB2yWCTWCOGi0ujvtOJEW31QOacAfbJRlYHdFy7p8f1gLTgAS/c7Va1bWbDi64LtjdUKuEvvzPuGjCz1ajLhcSxX7eLiIcROozrKwGYuD8OoBCtgOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.5) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lE9QWQ7UCrIrfyAheRCPItUhWCu7v/8BdHtRq22fGEc=; b=h88Rbq5LLRQ3RRbR+As+o7lmKIKCzhbPg+yGiz4ncOQROhAqN4Bnei98rCjI5/T3aIhHLpyt0WV3CpDYpPswySkS0f8ivJ2RXU9/D1QkHxeFOp8KEdbdIdUORR8ZjKefoyYfgfVnyFo7lbIYJBAAcYoYJ9rGjr754VB7tn0PJ5U= Received: from PA7P264CA0387.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:399::29) by AM8PR08MB5697.eurprd08.prod.outlook.com (2603:10a6:20b:1d7::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.569.9; Tue, 3 Nov 2026 14:03:43 +0000 Received: from MI3PEPF00008486.eurprd02.prod.outlook.com (2603:10a6:102:399:cafe::44) by PA7P264CA0387.outlook.office365.com (2603:10a6:102:399::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.8 via Frontend Transport; Tue, 3 Nov 2026 14:03:42 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.5) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.5 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.5; helo=b224-5.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-5.smtp-out.eu-central-1.amazonses.com (69.169.224.5) by MI3PEPF00008486.mail.protection.outlook.com (10.167.240.133) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.5 via Frontend Transport; Tue, 3 Nov 2026 14:03:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793714621; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=cq4t5XlCHxP/CW/dX7nIHFDzMngpBPps/XgjEYiCysY=; b=rIGuf13abRAIO57bLmzMpFxDVjnrGxeeol4LSw4oHzCqfinD8iQAIvMaxKQFpt9U 90LSOoyzZVScjeQMKcOeeTzIhwBmHOSxdfvjE6acQE8xTejQNcjhfWEnmGsTlKQL+yc zNiIwvjsGEhLPPcq0V9zv17LhDMu+5cdom5LAYqA/VKZ8BgpjTJpWap5PNZh8bCJr9I DNUePD+sbCWcBW2n6CnBw8oo+NUc7VrBEK6BRddg27Py3AMUGf4DPr+EhoxnUcInObZ FeAJbT9SsYT22x9KNfFzb4nEf0EkLmtF9A6MTDxM+zwUynNAvv/YcV2T3TkfrChq12N KzScEJAWpA== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793714621; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=cq4t5XlCHxP/CW/dX7nIHFDzMngpBPps/XgjEYiCysY=; b=MstmFVmLpBEVV72L2mcL/izdddNIrFt0D1Z+9wuDb6xFm/I0crH2Lte+iIi9wd4A mbavI5L/dkyiQzUxtnzGMXeCg6JDUctTrrD4PuUUVHlx75y+aYU3vlzgDWwlO0cvKpL FF7ZLSEnYADh6k/iQUliHE2W4ex+HcJLDENtxzPk= Message-ID: <010701a1a1b90d5a-b93fadce-1393-4acf-a280-12a803677d81-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v7 05/35] migration: close the CPR state if the outgoing channel fails to open To: Andrey Drobyshev , svt-core@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261103-vfio_v1-v7-5-4467fdccbbe6@virtuozzo.com> References: <20261103-vfio_v1-v7-0-4467fdccbbe6@virtuozzo.com> <20261103-vfio_v1-v7-5-4467fdccbbe6@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 3 Nov 2026 14:03:41 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.11.03-69.169.224.5 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MI3PEPF00008486:EE_|AM8PR08MB5697:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 47fff55d-8357-4ecf-7184-08df39b344c0 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|32142699015|61400799027|9140799003|376014|48200799018|4113699003|5113699003|22082099003|55112099003|18002099003|16102099003|10067099003|5063699009|56012099006|261022105027099003|261028144727099003|261026140227099003|261009223027099003|4143699003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZHQwUHlOVjBsZGtESEY0L0s0YXZNQlZsL09xZzczTC9TSW00RDlCNnFIZU4x?= =?utf-8?B?TXNrMllzbUN6dCsvcW1kUklHOGdKLzZmZWwyL1k3UWo3TXVpNHB1clZkM3Ba?= =?utf-8?B?RUlzWXpiRFJtS1Y2K1NoUDhuQzdHSEtobElhS1M3bitBNlJONmR5VGxVMURH?= =?utf-8?B?bTRKbDc2VHFiMEw4RUhlZXM5S3E5SjZhMVFmUnZPSlVJVE5pci9YeWQyZWlJ?= =?utf-8?B?NzNZd2ZkZ2FVZnZFZDdwamUzaXdMRURxbkl4WUQ0cFNFS1pXbHhmL2kyVnNq?= =?utf-8?B?MVdXellhbzBiMjloaHprTkgrMVZUaU9DTUsyV2w4dU1MZ0NneStNQmxhb2RC?= =?utf-8?B?bWpRZ3JwWlJGYW5EMFRLZW5OaTdSMXVsRW5CaE54UzVBMjl0UE9GcUtVeUNn?= =?utf-8?B?M094bDZISWtlRGhXaFZvR1I0VmlCSnVqUGNBL3lydkxTdityZXVLdGo5bUl3?= =?utf-8?B?eVc1L2RGcS9FWEFyeGloTC91Mzlyc0hXSGF2U2NNeFVxWXpvRU5aQmh2V0RR?= =?utf-8?B?bXNXM2s5bWhWTkxSUnFXRVBwbW1ObGJZT3hKUmdWbVgzNUIxdE9yd1YwYlM0?= =?utf-8?B?NUVpZ2QzcERnTkRyaHF3YjRwTkhtZEJDcUdsMXk2L2o1OHRvM1gvRkNqVzJQ?= =?utf-8?B?WGtqMkJ4RVl4aWZZWmxpNVhaa2Q4MWRWM1RaMERmcjhuT0U5UDdpeVQxenVZ?= =?utf-8?B?Tlh0b3VycWQrSGZ2S294d3UxV09KVmpaYUp1L3RHVlNucXZIT3hDcTYyZ0ty?= =?utf-8?B?aGNzbWhjUWxwQTEwOXJlQmw2UW1ZaUVoVm5nN1o4amRHSTBnUWhIcUY3WUtm?= =?utf-8?B?WG1OYmI2RTlueEVXbGF6dTNBNFZRbzVPNjdiRXhYeUZyVGVLZDNLa2cwSXov?= =?utf-8?B?d0s1WWlmY0VUMU8xSkNTS2F4djBSVllxTzlkeHdSeWVBM1NZWW92QW5YZGlk?= =?utf-8?B?QmN2c0p4RUFMQm53aExyNG1tR1R5NzZYcTRJMUpxRTlFdFBucXdORlVKNmk5?= =?utf-8?B?WmdrdmFsWGY3Vkp3cG9EZGFxRERlVGxDWVU1U25qeEZkMWh4OFI2eDRpdFI5?= =?utf-8?B?QzlrcVZTRXNuRjJCQ2x3aFFnYlM5azZqVGU1NE9yWDNxMHFhVVd0VHZmRDZI?= =?utf-8?B?TjN3c09qeG1WTFRqT2lqeUpTQUxvS1NpK3VGelBxRENWcFl3TTFNSHJsMHIz?= =?utf-8?B?djNld21kR1Y1aGRpVkg2YkVkSHd2RGN3T2hoalhHM2h3QU9OSm1DTGpzY2l2?= =?utf-8?B?bkIzMEo2ZDArYnNnSmI3VSt4VXZzOTVXQmpXWktTU1hrREo3aE4zaEZLTGYz?= =?utf-8?Q?vn9BBEUiUU9sE=3D?= X-Forefront-Antispam-Report: CIP:69.169.224.5;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-5.smtp-out.eu-central-1.amazonses.com;PTR:b224-5.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(32142699015)(61400799027)(9140799003)(376014)(48200799018)(4113699003)(5113699003)(22082099003)(55112099003)(18002099003)(16102099003)(10067099003)(5063699009)(56012099006)(261022105027099003)(261028144727099003)(261026140227099003)(261009223027099003)(4143699003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 7c2Gc8JCjQXWK/Rs3j2/JxxwUcJEKcQ0bgAY6ffQxyFanhlLs5t27XPfOaemxL22uxCwyuf7qJrMZrfqU0FVX3UBy+8oiE7CYihVDH7zYPRVMHuwlWNxNpff17LLGkq1KTlsns0bPx4N9LQ5Q5yQ6la1jWuFhG1xv5X862D6bni9Uxc1i15vTDAap8znXigf5q/9ij/1XvrSxmFlxmphBRO5+a+7S+nu9HTjHX7/liDbj02XZtH7D4x8u13Re+H5ZhI/sMAM7jCpHfQS0f9NDA9kuP3vO1/f61cSn8ezaJ2Bc+S5FvyQhkhYhSVtUWAJt/7ccPVKWnXLFmjbzYkRaLCfm9omOJ9dFnv/f80Fa064tCHgpiz8NUZj6Zqfjcu3Dixp1ew1iOV9YmvKRf59I/LpJBZaVf2aHjyQtneXS43mkLz+uc+khjt5cJBwzsg/ X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-Auto-Response-Suppress: DR, OOF, AutoReply X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2026 14:03:42.4524 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 47fff55d-8357-4ecf-7184-08df39b344c0 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: MI3PEPF00008486.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5697 > qmp_migrate() saves the CPR state before it opens the migration > channel. If the channel is a file or an exec command and it can't be > opened, qmp_migrate_finish() returns right away and migration_cleanup() > never runs, so the CPR state file stays open. >=20 > Close it there, next to the yank instance, which has the same problem. >=20 > Fixes: 624e6e654e11 ("migration: cpr-transfer mode") > Signed-off-by: Andrey Drobyshev Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261103-vfio= _v1-v7-0-4467fdccbbe6@virtuozzo.com?part=3D5