From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a1a1ba8b6b-71368582-7d8f-4452-ba9a-311d74266003-000000@eu-central-1.amazonses.com> Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020123.outbound.protection.outlook.com [52.101.69.123]) by lore.virtuozzo.com (Postfix) with ESMTPS id 497338017D for ; Tue, 3 Nov 2026 14:05:22 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PwcGSAbFwrvCj2t22HwEzmoEksWI+qWw5gCJT4NiGHppmnkHGwv6Gip9bNPC9nBddTf5FE1YzmeKoCqtrAyhUb3i7pz1Yj+v/W9SyhFVeZb9WghafPRJUjtZYlXRX4Lx9XQ2YosHlRFEh/6Z3otK1wsuvFbEgJGgEgc7xqiXb/tBm3reuAgiPxMk3I4SYPKUuEkz3OHVJpraPl0imBVaYlNYogTwus5QwcKokHZEkV1oaodN+Itc6xRRvCMgN372hmhJDbFFA2jbMMxdeMHQoBzSzLAGZbiNoSrVKU/zsMk/lgG/ssOp9xlFAsL8cxTX2JvJ3paC7NbpyAr+YlRszA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eOgI1MP/Mb0muNuhLTLJK8oyX4yk9yDLFAfv+XQZxIE=; b=gRpNdW8JOFVC5+m5UqGIWoFUXjEGEPpr7gBzAaivEgw+qxghl08f5HUcEYewg3hEeYzOUM5N7m/FHiW5VfL58g7Q87f/9gFFhwSr+87GxmHdlTlqtM7st1ZN26diOUjyHkC6ul4pxfFsaA2KLdDYsosQXpXhHwaJXb8lGn9mRzwAL4Lhp/WYk8ifQDNKZp0eV10jV+1JmOciPGv/M6EtJ4rBP6TSBhzi9AgIj9H0l6ot6Zo32Wa+XKAUhJ2mryZTO2rB5LtPRV5a6j4/x1krCmn9Ew92ktQ45oFgaRZI81n2fZXTIJLu8KTz7n8oQ/iGgTMPGLMTO59dbYBCX4bUAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.6) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eOgI1MP/Mb0muNuhLTLJK8oyX4yk9yDLFAfv+XQZxIE=; b=JIQ5uYjDIxludlCODKHAYvWtCUiFwsdNaVvW6OjiMe9x/g+01M/KB8I2qAO+tw8SSK1HUZ4CH1DpkstOBilLFqiDNh4Bsz2LIVQIBADgmOEXJ3VnMmNQUIjtLHOrn+0gRjcuK+f9i0TkZPnJd0sW0IVC+1ZiRA7ds5faKZioeHs= Received: from AS9PR06CA0456.eurprd06.prod.outlook.com (2603:10a6:20b:49a::11) by MI7PR08MB766481.eurprd08.prod.outlook.com (2603:10a6:290:112::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.592.8; Tue, 3 Nov 2026 14:05:20 +0000 Received: from AMS1EPF0000008F.eurprd05.prod.outlook.com (2603:10a6:20b:49a:cafe::1a) by AS9PR06CA0456.outlook.office365.com (2603:10a6:20b:49a::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.8 via Frontend Transport; Tue, 3 Nov 2026 14:05:20 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.6) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.6 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.6; helo=b224-6.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-6.smtp-out.eu-central-1.amazonses.com (69.169.224.6) by AMS1EPF0000008F.mail.protection.outlook.com (10.167.242.86) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.5 via Frontend Transport; Tue, 3 Nov 2026 14:05:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793714719; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=61cxN12LuvXMvlKx9/8wDLI8Hn8VgKze0XWnHiYUGSY=; b=iJYOMI69H5h6tNBLh960/e2uNAEfH29dydpFjUFVN8Z3xTN87L4FZOsc9RXGX3ZV 3qDzPUrdtZN+jD7KPhpnEQEdM6SRPwRyDG+IthFKCOTSTk3fsQ/OQ0valKMS4Wn9Rx4 2NqjGLHNZh0giS21awFSIT+NhhulkDbx5VBijnd0b+Z4N88/IdyqJRcjGPCOWEdcdM9 sTYpZ91WUeEFFV7SQnFDgoh1vl11SI5xNjP1uJ0eXkdHts4w/GOy98Z8svDpO4V8Ltz zyoNKIFPJGy9r49D29lfMA3UIyhZ52dCRnM+fOsO/TQFgOi7Gae9HBmpvSgS5rQpFDp if+jEcBu5Q== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793714719; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=61cxN12LuvXMvlKx9/8wDLI8Hn8VgKze0XWnHiYUGSY=; b=e2gXcoziL6iU/asTj2zwaUZdMH6GxvfUsikjaaH+DNsARHd71TorUPthsI6hDMtp ZkQecslsM7JQ+cgFE83kJGzkOmMhZ1U2dZbBat2F+hHm1l7YHt657L+cKMuvhuY+P3d fA+bRFFuKr2YgLYIbtyEPyLhVQZHa0ZyaDA4O9Sc= Message-ID: <010701a1a1ba8b6b-71368582-7d8f-4452-ba9a-311d74266003-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v7 09/35] migration: Plug memory leaks after migrate_set_error() To: svt-core@virtuozzo.com, Andrey Drobyshev Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261103-vfio_v1-v7-9-4467fdccbbe6@virtuozzo.com> References: <20261103-vfio_v1-v7-0-4467fdccbbe6@virtuozzo.com> <20261103-vfio_v1-v7-9-4467fdccbbe6@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 3 Nov 2026 14:05:19 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.11.03-69.169.224.6 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS1EPF0000008F:EE_|MI7PR08MB766481:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: c03c574a-f24d-4d7b-0e89-08df39b37ee8 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|32142699015|376014|48200799018|9140799003|61400799027|4113699003|5113699003|10067099003|22082099003|18002099003|16102099003|55112099003|5063699009|56012099006|4143699003|261022105027099003|261021121427099003|261102123227099003|261026140227099003|261028144727099003|261009223027099003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bVhXRkFLbGplYUp2akg2OElENmkvZnByRlZTczF3UUhidzlhMVdPWm1iMkwr?= =?utf-8?B?YWlNYlhBZnpZeHNJZU4zV2xDcTh5enp6d2NSRUF5T0JZSmZUWFdvUFNLSXVo?= =?utf-8?B?MXlIS0ZNMnhxYUoyc2pWTTRvc0J3QjdMNk9EZytwNEQ3RlQzRld5QVJlUjg2?= =?utf-8?B?dm8zNEpIZ3VHZ1h1ZVZjcmFZa2sybHZKT1NwS3RQRFJYRmRtUkRkdXNVbVRG?= =?utf-8?B?OFowc2hyOXFnWCtrenFvbkU0dGVRRHFyUmtHZnk5Zm9tTnRDcUFRMW9aOXZa?= =?utf-8?B?b1NXY0FBSHJzRU52L2Fqd3pVaU4yTG1yQ3FubXN2ODkwRXZ0Nmw4ZUllSXBU?= =?utf-8?B?RzFhQUVIRnpQSElPdkhvZGdIa05lS1FhUWptSDVURHlhUFV2UEt2NXd1L3JJ?= =?utf-8?B?V1JZZ05aRlFGUzM3am9OaHE5eDh6T3RmcnFpUkY2WGJKRnFuRG9pVEx4NUVU?= =?utf-8?B?YW1pMkZ3a01sc0VYOFVhUUtkRXdwTXAvZ25XL3dydjJBUzRacXN4K3RJYnJz?= =?utf-8?B?SHNDRGRtbFBROUhERXZ4M3o4ZnZDc3RQOVpqNjF1cjB0ZG8waGFPdWVZYXBE?= =?utf-8?B?SEZqbnpLbFpMS09rYjJLODBYUndacThwWWhidGQvMXE5RWhQT2RmVFc3U25l?= =?utf-8?B?dmZkaEwzbHpVNUpubEdaUFNXc1k5UmFzZ2wzYUU2dU1vNXNkUlRLem16Z0pJ?= =?utf-8?B?T3E0MGJmdUJGT1U0S2NtZ05PdEptbnkzK1RsY2JWcmZ3eE1vdDRPdDNOZTBj?= =?utf-8?B?UU5qZWt0VGZKdDdEazJsUnNQRGZqRUVaanNyWS9jS0g1YXJpVUdNZ3NDUlgw?= =?utf-8?B?VWZQTjFudnpseFJZMno2TE4vR0gyb1ZlN1I0WDY2NWZNTFkySEYyYnF5RW9J?= =?utf-8?B?dTF2RHVTbkRCcVYyOThXZnNzbkxYUm0zWTFPRWJ3Sm9tb2Y5TGFWNFAzdlFa?= =?utf-8?B?NW15MFpoQWE5RnI2T1RtU202QlNIZ0FrRm5SZFZrWGd2MlEwYXowc2xENVQ4?= =?utf-8?B?Uk5uOURtRjZGWEJiaWZITEZxclg0NkZNbktnUkpKMVlPb0pwRktiWXp3VnV3?= =?utf-8?B?VDhvVGxrV0dXaDNuc1JZcTdvSTQ4aUVORHNYT3ZMZU9xckNzdmxCVTBEMDk3?= =?utf-8?B?SG9MZFhDYUtkWkNFdjhHZm12M2x4RWgyRXRaVzFvSjhFTFpaK2lOWnA2a2Ez?= =?utf-8?B?VStxME5nQkx6dE1qa0JDaitlU3JGdFhMWG1HK21iOEVzejBYNS96RXY4TXFs?= =?utf-8?B?Q24xT0RzVUFYN2UzaFdvTmpEaG1GZ3FYMSs5UmJJOUNod2tqR1VycmNRZEpk?= =?utf-8?Q?q0KWGaw5SCswnW9CFM6YJ2jfFXSaTL+EJ0?= X-Forefront-Antispam-Report: CIP:69.169.224.6;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-6.smtp-out.eu-central-1.amazonses.com;PTR:b224-6.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(32142699015)(376014)(48200799018)(9140799003)(61400799027)(4113699003)(5113699003)(10067099003)(22082099003)(18002099003)(16102099003)(55112099003)(5063699009)(56012099006)(4143699003)(261022105027099003)(261021121427099003)(261102123227099003)(261026140227099003)(261028144727099003)(261009223027099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 5zCqlqqu050cqI0FPs9OPAix6AzAwmgL6KijyUrJDgrB0M1WcI+inKz6Ft4LbFZPATvtmTSvjpUiqfq/YvpyPWLmjEBSi99SeyJB0lApt1c32cHIzyOLJtrKHC7FBBdQ7ofwr4VzqFnFs6uxwlbJRYCTiYVg8ChU1Dq5S3USDn93aX1HE6BmBfv0dHy14Wfi/4rUw9U9yZiqA7jsaW++8h93TxtjKO7u+/JpHpvz37TOCEY+oKz96zkU0goZQ0IIxFFa9MMgtaFg3EYkxul6hnjDiBRcvbCCRnxQcyhSsYBusYQPKW1FGhvEHhpSUE3WdW8ZBLan0n1FCaRZU8/u09xJeczksI2S0r/HFKuH+0xcPB/MDYrSWthW9iB4GuagwWlqc+1wPMpHIRwF9g0t2RFzlU1wOKy26GvNoPrLLyeGHyo7xgfROoUKf8KP5+ol X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2026 14:05:20.0326 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c03c574a-f24d-4d7b-0e89-08df39b37ee8 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: AMS1EPF0000008F.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: MI7PR08MB766481 > From: Markus Armbruster >=20 > migrate_set_error(s, err) stores a copy of @err in @s. The original > @err is not freed. Most callers free it immediately. Some callers > free it later, or pass it on. And some leak it. Fix those. >=20 > Perhaps migrate_set_error(s, err) should take ownership of @err. The > callers that free it immediately would become simpler, and avoid a > copy and a deallocation. The others would have to pass > error_copy(err). >=20 > andrey.drobyshev: > This commit is cherry-picked as-is, with no modifications, from the > upstream commit 93817ec39656. >=20 > Signed-off-by: Markus Armbruster > Link: https://lore.kernel.org/r/20251115083500.2753895-2-armbru@redhat.com > Signed-off-by: Peter Xu Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261103-vfio= _v1-v7-0-4467fdccbbe6@virtuozzo.com?part=3D9