From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <010701a1a1c2d35c-ed3a6dc5-310a-45a1-a489-f1a6ee8f7c4f-000000@eu-central-1.amazonses.com> Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11023136.outbound.protection.outlook.com [40.107.162.136]) by lore.virtuozzo.com (Postfix) with ESMTPS id 387F68017D for ; Tue, 3 Nov 2026 14:14:27 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Oh0zeODj7SitnrC3G5/tcFHD/0uGf0amzt+cOSGBpJMPYoUs+1LAR+S+h6jvZqbm/5ki3sdQezq8xkKYCfz30LmDIPYlJTUQF8MbbBfqbYIR+3SsYny7LAZAl7zab7UquOq+DSIomkrAlO4F5TtiN0+/8s0ni71QzwoIrZ2FqdriVXGJS8xyS0wK3uPLCHNPYglxqlffF4qrxqLcB/lALkSzn/9s7uUcujVCuJgvvi4m8ZCoaFntbmC0fOS8vPhDonJwPhE+oclj/9E8y1R9RysfYkPOXuuVi+Lpgba+ECDeOFYBPmlKb/FNFjE7+POvVwMKBxUIO0yBS7NhVAmd5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IOjmq2fpp4/qRaHoXIKLcjjkXsY5I0YBc6loSf3Eq/w=; b=eq0LMKN8LYYr/ZBsX4E1GVLN9G2jiszrWslZN3rKljqa/NvzM4FWJ/ItYseY4CBqlj/SkUIk3odnv3cfYjUN2o351CSrrkY25o/Wdf3tnTOgddi5vMPvn5dM6slR1Z5f8AYIQvSHE8f1PDvhe5a/vJR6ulFa4WFysaktpbaYPHJEMVe3Ec51c26cQqixBXK3sSsYGQ4IRCWh3xMr+/md2rWH/2lj3Fbsy9hW+9h6IgqPZrT1A6LNjZ+X7yBHUX2cHNEwIba+N+XTJiQWiM0QnI5VoyXfcBHe4IBNOYUC3u1Va3fUowiKtmr81el0cGFfAUN01yKU/17r69MgrkFxDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 69.169.224.1) smtp.rcpttodomain=virtuozzo.com smtp.mailfrom=eu-central-1.amazonses.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com; dkim=pass (signature was verified) header.d=amazonses.com; arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.onmicrosoft.com; s=selector2-virtuozzo-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IOjmq2fpp4/qRaHoXIKLcjjkXsY5I0YBc6loSf3Eq/w=; b=WG+OgH5vBV7vQdCGzRIFxRANHaN5qRL18MtsdQn9chaTl3FUTRzawEPzhmB+Q1IIv/SFCcakY4FiYaUJ/LNf8jVDr2Afv042tb84iRYR6MRNdPh/DocWDv2RdSQSWX/jkyy7Hz07oiKtd4zkDc4DX+ApFMGzdiPC6lOkf/FWpEM= Received: from LO4P123CA0591.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:295::13) by VI1PR08MB5485.eurprd08.prod.outlook.com (2603:10a6:803:138::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.592.8; Tue, 3 Nov 2026 14:14:23 +0000 Received: from MA3PEPF00000409.eurprd04.prod.outlook.com (2603:10a6:600:295:cafe::a6) by LO4P123CA0591.outlook.office365.com (2603:10a6:600:295::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.12 via Frontend Transport; Tue, 3 Nov 2026 14:14:23 +0000 Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 69.169.224.1) smtp.mailfrom=eu-central-1.amazonses.com; dkim=pass (signature was verified) header.d=sashiko.virtuozzo.com;dkim=pass (signature was verified) header.d=amazonses.com;dmarc=pass action=none header.from=sashiko.virtuozzo.com; Received-SPF: Pass (protection.outlook.com: domain of eu-central-1.amazonses.com designates 69.169.224.1 as permitted sender) receiver=protection.outlook.com; client-ip=69.169.224.1; helo=b224-1.smtp-out.eu-central-1.amazonses.com; pr=C Received: from b224-1.smtp-out.eu-central-1.amazonses.com (69.169.224.1) by MA3PEPF00000409.mail.protection.outlook.com (10.167.241.154) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.592.5 via Frontend Transport; Tue, 3 Nov 2026 14:14:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=23yjbh4k34hwzfubhuiim7m4inbd3ick; d=sashiko.virtuozzo.com; t=1793715262; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=VdY0MHpa+1pG/Ch+21XAR4HsFfwC+k3s2KCDB46hS5w=; b=Dd/60fL2WN0fMeFDDFva0xh8K1Wnv1hQHLLaXomqElxyZ1nz55In7zRrjVxET20Z A9Ca4GJ/DMtxNyRcG8hAH0z9XZAtOUI1mPpEZLrF4bzXP5osEXnLezk3GrrBVzp36fc hvf6yXocuW/xzsiBBtZJV+bOxJqtU3c+0ZFcDSkuHziZhJLfXy9IyU9OS3E9fMJoK3A m7SL1FAAACa/GePdj2x6vsNKpVI2XatupVexAT+NLUqraSZ2mbeu6iHabnOsUVQZqFS ZcqkqD+BCNOGBQM31wsheTcYk3f5TbcyB+EVtM2KZFV7FM3k1W0Mo+6rQQPlruClPRN 6LZivvIC+g== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=qftdzk2dqsatjnlrq4r5brjbihpfcrsh; d=amazonses.com; t=1793715262; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date:Feedback-ID; bh=VdY0MHpa+1pG/Ch+21XAR4HsFfwC+k3s2KCDB46hS5w=; b=BgXMIKdGkS7ydK9BtYls44tJcRxfvlEbobyvZwVvSz7f0H8FYY/xJalgDcp7yYLL zEcUAe9M+0OAU9cDuNvFwsUXtBcREY2QS6E2+7OBydq4kf/++z6J5dwMlh982ylCwTv D4CXyEeGgP1nT/WqjeFQta4/cYWU1av16L80h1H8= Message-ID: <010701a1a1c2d35c-ed3a6dc5-310a-45a1-a489-f1a6ee8f7c4f-000000@eu-central-1.amazonses.com> From: no-reply@sashiko.virtuozzo.com Subject: Re: [PATCH QEMU HCI-8.1 v7 21/35] migration: Move CPR HUP watch to cpr-transfer.c To: Andrey Drobyshev , svt-core@virtuozzo.com Cc: andrey.drobyshev@virtuozzo.com In-Reply-To: <20261103-vfio_v1-v7-21-4467fdccbbe6@virtuozzo.com> References: <20261103-vfio_v1-v7-0-4467fdccbbe6@virtuozzo.com> <20261103-vfio_v1-v7-21-4467fdccbbe6@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 3 Nov 2026 14:14:22 +0000 Feedback-ID: ::1.eu-central-1.2wRQJBpg9g1fGRYexx3dUuYGS25Bux+2TEOx72/m6U4=:AmazonSES X-SES-Outgoing: 2026.11.03-69.169.224.1 X-EOPAttributedMessage: 0 X-EOPTenantAttributedMessage: 0bc7f26d-0264-416e-a6fc-8352af79c58f:0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MA3PEPF00000409:EE_|VI1PR08MB5485:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 81dcea07-a528-4f51-1103-08df39b4c273 X-LD-Processed: 0bc7f26d-0264-416e-a6fc-8352af79c58f,ExtAddr X-MS-Exchange-AtpMessageProperties: SA List-Id: svt-core@virtuozzo.com X-MS-Exchange-Transport-Rules-Loop: 1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|48200799018|376014|9140799003|61400799027|32142699015|261022105027099003|4143699003|56012099006|5063699009|261009223027099003|261102123227099003|261021121427099003|261026140227099003|261026121527099003|261028144727099003|10067099003|55112099003|18002099003|22082099003|16102099003|5113699003|4113699003|6133799003|13003099007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZWIxdWtXTjVEam9OdGRkbTlheFNIVDNXRndvYTNzR25BaDFWWmR3TU0va1Fn?= =?utf-8?B?bW1ncmhOcEF3SlUzZ0VxMWg1SkU1K1FwTVhtRE9zWm1INDBjaTQyVmlvUDk2?= =?utf-8?B?SzNQa25pWjdJUE9FaStRK3NnU1Jra1VDZXlSd0FWYVVoRFV6ajFqVmtoL2Yr?= =?utf-8?B?eE1WZnplcnRNOXEwSDlaVFdidDRwYjFIaHlEWFJJVlFMTzQrSWxEeGIzOEJw?= =?utf-8?B?MXdSWktYSzZ0cHBZMWxJY2lPcDg5cFMwTkI5RWdMYTg4RVhTTUdncDQ5S3JE?= =?utf-8?B?ZTZFZ25VaFdOSFNVemlwRmRPZVpxd29DZk9VTHRYaXY2cmhueXFYTmFJMnEz?= =?utf-8?B?QVNvdjlPb3FHQXNTbmZpNU5LVlhuY3pweFQ1djhZV3IzS3EreUpvcVY5bVlv?= =?utf-8?B?TFFoQ1Z1VTc2REdKYzlNb2c4YnByNkY3MnU2KzNvSEVYeUt0VnVlOTRWNEJF?= =?utf-8?B?aGlmUXovUURXOVRSalNuZm1sUUtJZVViemtBQjN5L2JUekhDRTNiSUpxaVh4?= =?utf-8?B?aUxQTUsvdFBkeEdmTVFybHN1YzFLN2RVSVA3WXgvRkFEY3o0UWJpYi9rT3o3?= =?utf-8?B?OUl2bjI0ZDJuMmh3QTNKaW9SSFdUZWJVTURmWkVsSDFYRkxiN2YvdWNuM05G?= =?utf-8?B?WEQ5dDlJaUtzTlNzMVQ0OFlPdnRNMzk5dVdvUnlmZDExVVZKU1htR0w3U2dV?= =?utf-8?B?WGxvcnZKb1hPR3NZWU1KZk44VDhGNDZGaktyVVRyN3VWVGRNdS9PWmpBajJX?= =?utf-8?B?VXZDRWkxOGZhcmNYV2dVcHkzMzNxUFAwWm9TR0RKR0tjcXZrSm5LQmR1UmVq?= =?utf-8?B?dG9VK0lreDR2NlR1RHA4MDJYY3dZSVpJby9LMTVZbC9kSFMxR0lDZmJhQUkx?= =?utf-8?B?VjdRUnlRRFV5ZCtBS3pkKzdUb3NJOCtxc1FmU2M4WWU1Y1B0a3ZPRGZKeE5w?= =?utf-8?B?UU43d1FRSjBzSEl4dWVaTVp3SVRCMHpueXlJSEVyS3ZwTlE4dlVtMktDUDZ3?= =?utf-8?B?V0FiMWRLWGZqaFordWd5bXFPdm5NVnFpMjlHUmppYzRSNGtySzdEWjdvaXhr?= =?utf-8?B?WDlpOU1oVmxDSHlwaHZHcUkrS0toSEpuTW4rK1g4QTMxNkJMMHpXbU5GYXY1?= =?utf-8?B?N3A0R1lpV1hsY2lBMThERWlKL29qd1pQdmdvWGwxT3o1Smg3TVVRWmU1aStP?= =?utf-8?B?TkNBQnMyUDBUdlRnZHE4MGtVeXV3K2xTRG9hWnRHeWpoYjhwNGgwSFZJNzhy?= =?utf-8?B?b0t5M0I3OXg1bWxEVnVUYWdYZVFtNnZPY0Y2eFJUTG1EL0dYNlVIdXpmclgz?= =?utf-8?Q?80Cn9XVvjZCR4=3D?= X-Forefront-Antispam-Report: CIP:69.169.224.1;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:b224-1.smtp-out.eu-central-1.amazonses.com;PTR:b224-1.smtp-out.eu-central-1.amazonses.com;CAT:NONE;SFS:(13230040)(48200799018)(376014)(9140799003)(61400799027)(32142699015)(261022105027099003)(4143699003)(56012099006)(5063699009)(261009223027099003)(261102123227099003)(261021121427099003)(261026140227099003)(261026121527099003)(261028144727099003)(10067099003)(55112099003)(18002099003)(22082099003)(16102099003)(5113699003)(4113699003)(6133799003)(13003099007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: +i2GdsLVZY3UTWIacU4RrjdNfAVMIOsbdaQeZ+2Ba36PXUcuuPDHgMfFWLu2R/P4x1c4WKJAIJoe0ZQWGSBbfeJv22UHpehF7Tttv2s6kcuCuQonkloh7cy44H0PgoVQ/eoCrYJ10mEQqN5CmD+pW8976vpRgjW1K1JlhTtREf6As/vGvyk9qdLgrU+aES+vpaY2O0N6A8PkU3fpQdkFl8uCt46x88krlAnKmdWYdGVpofLnqb129Ol2dI5Pu1g1eSDIf3fh1eW+FNymOQzJpGA5uXZVaMSqbtDtCkWJpDpt5pKZeWGeroI8AGA/v99cnOwflgzd4u060unV7tj6ym0lWpT20mP8ZygGwdGuW/VES8N0LdJXckYQAf2f8iL3tZo0WzgeUqxkuN9G0NU26wx63r0KTCPrwZNcza8OYX1N9CDY8+iK/srSXTYvcoun X-ExternalRecipientOutboundConnectors: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2026 14:14:22.8192 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 81dcea07-a528-4f51-1103-08df39b4c273 X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-AuthSource: MA3PEPF00000409.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5485 > From: Fabiano Rosas >=20 > Move this CPR-specific code into a cpr file. While here, give the > functions more significant names. >=20 > This makes the new idea (after cpr-transfer) of having two parts to > qmp_migrate slightly more obvious: either wait for the hangup or > continue directly. >=20 > andrey.drobyshev: > This commit was cherry-picked from the upstream commit f523e5aa5f56, > adapted for the hci-dev base, which predates the upstream qmp_migrate= () > rework around MigrationChannel: the watch is still armed with the > plain MigrationAddress from qmp_migrate() rather than main_ch->addr, > and qmp_migrate_finish_cb() keeps closing the cpr state and destroying > the HUP source itself. >=20 > Reviewed-by: Peter Xu > Reviewed-by: Prasad Pandit > Link: https://lore.kernel.org/qemu-devel/20260123141656.6765-24-farosas@s= use.de > Signed-off-by: Fabiano Rosas Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.vzint.dev/#/patchset/20261103-vfio= _v1-v7-0-4467fdccbbe6@virtuozzo.com?part=3D21